I guess I can add a sentence "This will allow us to keep an edit history, with edit notes, so that we can see info and reasonings about genre editing later on"
2022-06-14 16531, 2022
reosarevok
Huh. But genre addition is only used by me :D I guess I can list "This will add the Add Genre, Edit Genre and Delete Genre edit types", if that seems useful?
2022-06-14 16548, 2022
reosarevok
I mean, I thought "it has edits now" was pretty much obvious
2022-06-14 16551, 2022
reosarevok
But I can do that
2022-06-14 16522, 2022
reosarevok
(like, I'm not trying to be annoying, I just don't see how it helps anyone to say "there's some changes to the edit genre page" if they can't test it anyway)
2022-06-14 16528, 2022
rdswift has quit
2022-06-14 16513, 2022
reosarevok
yvanzo: Added a sentence to MBS-10165 and two tests
(we don't seem to have any Controller::Delete tests at the moment, so I didn't add one here either, we should think what'd be a good way to test that if any)
reosarevok: Thanks! It’s not useful to beta testers indeed. Your added sentence is clear and useful to “figure out the reasoning behind changing” MBS “in the future”.
2022-06-14 16522, 2022
alastairp
Pratha-fish: ^
2022-06-14 16535, 2022
yvanzo
It also informs editors interested in genres which edits they will be able to search for, even though you’ll be the only one to enter these.
2022-06-14 16540, 2022
chinmay
lucifer: questions about SoC - How should we keep a track of the project? And say you want to test changes made by me locally how do we do that?
I'll release a new beta after we check the regression with annotations
2022-06-14 16544, 2022
lucifer
chinmay: for testing the changes, you can push the changes to a branch on your fork. i can pull those and run locally on my side. for keeping track of the project, we can maybe break down the full page into some subtasks like the card component, api calls, timeline ui component etc and maintain a checklist.
2022-06-14 16517, 2022
lucifer
but if you prefer to do it some other way that should be fine as well.
2022-06-14 16537, 2022
yvanzo
reosarevok: #2492 needs to be rebased after that merge.
2022-06-14 16537, 2022
v6lur joined the channel
2022-06-14 16555, 2022
reosarevok
yvanzo: why change MBS-12456 to beta only? It was showing to me as well in prod, or did I check wrong?
It's trivial to just fix it to "work" like before, maybe I should just do that, even though it's stupid, but you only get there if you type it by hand, so
2022-06-14 16555, 2022
reosarevok
(that's just when the entity has never had an annotation, so there's no latest annotation to show)
2022-06-14 16512, 2022
reosarevok
Think I'll just submit that for now as an ISE fix, we can improve further later if desired
2022-06-14 16543, 2022
yvanzo
But this band never had any annotation anyway.
2022-06-14 16535, 2022
yvanzo
“you only get there if you type it by hand” - exactly
2022-06-14 16509, 2022
reosarevok
I mean, ideally it would probably say "This artist has no latest annotation", but it doesn't seem problematic, so yeah, I'll just fix the ISE
reosarevok: I'm about to eat but I had a quick look earlier and it looked fine, so feel free to merge if you want to deploy it now (otherwise I can check in like an hour :))
2022-06-14 16545, 2022
reosarevok
Ok! :) I'll do that because I would like to release before bed :)
