alastairp: morning, is there anything preventing us to retire frank after yesterday's ftp.ab changes? There are still AB-related containers running on it
2022-07-06 18718, 2022
yellowhatpro
akshaaatt: Current PR just initialised few UI changes, bunch more to come in upcoming ones..
2022-07-06 18718, 2022
yellowhatpro
Also do tell how is the backdrop implementation for BrainzPlayer ヾ(≧▽≦*)o
and I have a zigbee stick and use zigbee2mqtt for translating switch signals into mqtt messages.
2022-07-06 18728, 2022
mayhem
and now I have a python script that maps zigbee events to hue light commands. the hue app is no longer controlling the home automation, only my python script does that.
2022-07-06 18735, 2022
mayhem
and it does *exactly* what I want.
2022-07-06 18741, 2022
zas
interesting, I'll have a look at your setup when I'll come for the annual MeB meeting, I was thinking of setting up something like this
2022-07-06 18752, 2022
zas
getting rid of the hue app is a good idea, I started using a python script too, pressing F12 on my pc to light on/off my office lamp is ... satisfying ;)
2022-07-06 18755, 2022
mayhem
sure. it is more reliable than anything else I've used. now I use hue bulbs (because they are very good), but most of the logic is really under my control.
2022-07-06 18720, 2022
zas
yes, the app have a lot of stupid limitations
2022-07-06 18732, 2022
mayhem
yeah, exactly. I am using motion sensors to have low intensity red lights light up automatically at night.
2022-07-06 18752, 2022
mayhem
a night mode for my flat where nice and non intrusive lights come on automatically.
2022-07-06 18719, 2022
mayhem
the back portion of my flat doesn't get a lot of light, so getting the light right has been a big focus so far.
mayhem: that sucks. Unfortunately it seems to have become the "standard" platform for open home automation now. I recently migrated from OpenHab which had similar problems and was much less user friendly.
ansh: Hello! That looks pretty good! I have two main comments:
2022-07-06 18734, 2022
monkey
1. the placement isn't right, I don't think we want to put reviews before the crucial information about the entity. Lower in the page would work better, but we might need to move some other sections a bit. Here's a dumb mockup suggestion:
2. There's a bit too much whitespace in between those reviews; we can make it a bit more compact and fit another review per row, or just have a bit less padding/margin in between and around the elements
2022-07-06 18703, 2022
ansh
Regarding the spacing: Yes even I felt that the spacing is odd. I'll fix it.
2022-07-06 18715, 2022
ansh
Should I display the reviews like I have now or should I display them as a column similar to what you have done?
2022-07-06 18702, 2022
ansh
Or we can have the review cards in a scrolling div ?
2022-07-06 18737, 2022
monkey
I'm so-so on scrolling div personally.
2022-07-06 18737, 2022
monkey
Depending on where we find space for them on the page the answer will vary. I think in your mockup they might be taking a bit too much space, and in mine not enough (not enough space to show more than 2-3 reviews)
2022-07-06 18712, 2022
monkey
But perhaps if you condense them and place them lower on the page the 3*2 grid layout you did will work well
2022-07-06 18731, 2022
monkey
I think we can save some space on the review cards: we can get rid of "review by", the date doesn't need to be in that format, we can place author and date and the bottom right. I think that' would be a start to make them more compact
2022-07-06 18748, 2022
monkey
Do you have the HTML for the cards in your mockup at hand? I could try to mockup what I'm describing above
yellowhatpro: thanks for the PR. Looks good, will leave a review soon.
2022-07-06 18725, 2022
q3lont has quit
2022-07-06 18705, 2022
akshaaatt
monkey: I like the review placement on the side. Will the reviews section be visible at all times in a vertical list or will we show only 4-5 of the latest reviews?
2022-07-06 18747, 2022
monkey
Only the X most recent ones (X depending on how it fits visually I guess)
2022-07-06 18754, 2022
monkey
Then a link to go to the CB page
2022-07-06 18757, 2022
akshaaatt
Noice
2022-07-06 18730, 2022
akshaaatt
Do you think this UX should be followed in LB also then?
When I use this module, first query is run flawlessly, but the 2nd one just says "this connection is closed". Even though I make new connections for each query with a "with statement"
nvm I figured it out. It was due to the fact that my library returned old variable everytime instead of making a new one when the conn function was called :D
2022-07-06 18713, 2022
akshaaatt
I think a hyperlink to CB with text like “View more reviews here” should be below the reviews
