11:41 AM
monkey
Yeah, not the best :p
2022-07-08 18910, 2022
11:42 AM
monkey
Do you have that mockup handy? I can't remember what it looked like
2022-07-08 18938, 2022
11:42 AM
monkey
But `show_entity_type` is an `h4`so it should already have some margin at least
2022-07-08 18928, 2022
11:43 AM
alastairp
2022-07-08 18928, 2022
11:43 AM
BrainzBot
CB-442: Improve layout of CB entity page
2022-07-08 18929, 2022
11:43 AM
alastairp
monkey:
2022-07-08 18951, 2022
11:43 AM
monkey
Oh wow that's already being implemented? Great :)
2022-07-08 18953, 2022
11:43 AM
ansh
I was planning for implementing oauth login for CB. So if we have plans for linking other oauth services also later on, I can design the code in a similar way
2022-07-08 18908, 2022
11:44 AM
alastairp
monkey: just the location of the rating buttons I think
2022-07-08 18918, 2022
11:44 AM
alastairp
ansh: thanks for making this additional change to the macro in CB#440
2022-07-08 18918, 2022
11:44 AM
BrainzBot
2022-07-08 18957, 2022
11:44 AM
monkey
ansh: Yes I think that could happen in the future. If you can easily make it reusable then please do, but don't lose sleep over it :)
2022-07-08 18915, 2022
11:45 AM
monkey
I could see a use-case of "I want to import my collections from ServiceX"
2022-07-08 18914, 2022
11:47 AM
ansh
definitely :) I'll try to make the design easy to expand in the future
2022-07-08 18914, 2022
11:50 AM
ansh
So, after I am done with displaying the reviews, I'll begin with creating tables and making changes in the ORM to support that
2022-07-08 18925, 2022
11:50 AM
monkey
Awesome
2022-07-08 18908, 2022
11:57 AM
ansh
alastairp: since we are also using the download-import script for tests, we should keep both of them at the same place
2022-07-08 18906, 2022
11:58 AM
alastairp
ansh: which both are you referring to?
2022-07-08 18923, 2022
11:58 AM
ansh
the download-import bb database and the test data script
2022-07-08 18924, 2022
11:59 AM
alastairp
in the ./scripts directory?
2022-07-08 18930, 2022
11:59 AM
ansh
yes
2022-07-08 18952, 2022
11:59 AM
alastairp
right, that's OK. I was referring to moving the bb-test-data.sql file out of the root directory
2022-07-08 18909, 2022
12:00 PM
alastairp
(I think, unless you are talking about another one of my comments)
2022-07-08 18952, 2022
12:00 PM
CatQuest
I thought cb alrady had oauth from mb..
2022-07-08 18947, 2022
12:01 PM
monkey
CatQuest: This is for BB to allow writing CB reviews straight from BB
2022-07-08 18958, 2022
12:01 PM
CatQuest
oh ho
2022-07-08 18928, 2022
12:02 PM
CatQuest
well evetually MeB will be the hub though.. so keep that in mind maybe 🤔
2022-07-08 18935, 2022
12:18 PM
monkey
2022-07-08 18917, 2022
12:19 PM
monkey
I think that should probably be reverted as it is proper punctuation (and also making a snapshots test fail)
2022-07-08 18903, 2022
12:21 PM
ansh
2022-07-08 18901, 2022
12:22 PM
monkey
But the space you removed is the one between the entity name and the parens, I think
2022-07-08 18905, 2022
12:26 PM
monkey
I commented on the PR; sometimes JSX isn't the best language…
2022-07-08 18940, 2022
12:28 PM
ansh
oh :(
2022-07-08 18907, 2022
12:33 PM
ansh
I've committed your suggestion
2022-07-08 18955, 2022
12:33 PM
ansh
alastairp: all the tests are passing now
2022-07-08 18954, 2022
12:34 PM
yuzie joined the channel
2022-07-08 18958, 2022
12:38 PM
yuzie has quit
2022-07-08 18925, 2022
12:59 PM
q3lont
is the first released label of a release group denormalized in the database? Something like release_group_meta.first_release_year but for labels?
2022-07-08 18934, 2022
12:59 PM
q3lont
or would I have to fetch the first release, and get its label?
2022-07-08 18912, 2022
13:00 PM
q3lont
(e.g. something like release_group_meta.first_release_label)
2022-07-08 18917, 2022
13:03 PM
monkey
ansh: last bit on LB#2053 is to update the snapshots (because you did fix the extra space in front of the entity type :) ). You can run `./test.sh fe -u` to run front-end tests and update the snapshots.
2022-07-08 18918, 2022
13:03 PM
monkey
Then commit and push the snapshot changes.
2022-07-08 18918, 2022
13:03 PM
BrainzBot
2022-07-08 18933, 2022
13:03 PM
monkey
Thanks for fixing the extra space, it was bugging me
2022-07-08 18952, 2022
13:40 PM
zas
postgresql turns 26 today, happy birthday!
2022-07-08 18919, 2022
13:49 PM
BrainzGit
2022-07-08 18945, 2022
13:49 PM
BrainzGit
2022-07-08 18919, 2022
13:50 PM
BrainzGit
2022-07-08 18914, 2022
13:52 PM
alastairp
CB still running node 12, I think we should upgrade this soon
2022-07-08 18950, 2022
14:03 PM
riksucks
hi lucifer, I had a question for you, do you think the index is not working because `recommendee_id` key doesn't exist in every metadata.
2022-07-08 18911, 2022
14:04 PM
riksucks
for the index to work at all, is it necessary that all metadata should have that?
2022-07-08 18928, 2022
14:05 PM
lucifer
riksucks: afaik, that shouldn't be the case. i'll need to look into deeper to find out what going on. will do that in 1-2 days.
2022-07-08 18911, 2022
14:06 PM
alastairp
monkey: hi, finished for the day?
2022-07-08 18924, 2022
14:07 PM
monkey
Yes, but I'm around
2022-07-08 18951, 2022
14:07 PM
alastairp
monkey: OK, perhaps we need to leave it until next week then. I've deployed CB on beta, but we need the new views
2022-07-08 18957, 2022
14:07 PM
riksucks
thanks :)
2022-07-08 18915, 2022
14:08 PM
alastairp
because at the moment our queries are failing
2022-07-08 18917, 2022
14:08 PM
monkey
I can run the views script
2022-07-08 18930, 2022
14:08 PM
monkey
Let me try on test quickly
2022-07-08 18940, 2022
14:08 PM
alastairp
if you're happy that's not going to cause BB issues on the weekend, that'd be great thanks
2022-07-08 18900, 2022
14:09 PM
monkey
I already checked everything when doing the PR
2022-07-08 18917, 2022
14:14 PM
monkey
Well alastairp we'll have to wait, something doesn't look right with search indexing with the views updated, I'll have to have a closer look
2022-07-08 18943, 2022
14:14 PM
alastairp
monkey: ok, no problem then
2022-07-08 18924, 2022
14:17 PM
alastairp
ansh: I've released your work to beta, but we're going to have to wait to fix this issue with the BB views before continuing
2022-07-08 18940, 2022
14:18 PM
ansh
thanks for approving my work :)
2022-07-08 18956, 2022
14:18 PM
alastairp
another option is that we update the queries temporarily to perform this join/query, if you are interested in trying to get it running today
2022-07-08 18943, 2022
14:19 PM
lucifer
riksucks: not sure if you saw the message but like other SoC students, you can also contact mayhem for an IRC cloud account.
2022-07-08 18903, 2022
14:20 PM
ansh
umm I think we should wait for the updated views
2022-07-08 18911, 2022
14:20 PM
alastairp
sure, no problem!
2022-07-08 18931, 2022
14:33 PM
Sophist_UK joined the channel
2022-07-08 18924, 2022
14:34 PM
yuzie joined the channel
2022-07-08 18947, 2022
14:36 PM
q3lont has quit
2022-07-08 18950, 2022
14:36 PM
Sophist-UK has quit
2022-07-08 18902, 2022
14:37 PM
q3lont joined the channel
2022-07-08 18934, 2022
14:37 PM
Sophist_UK has quit
2022-07-08 18904, 2022
14:38 PM
Sophist-UK joined the channel
2022-07-08 18906, 2022
14:39 PM
yuzie has quit
2022-07-08 18908, 2022
14:40 PM
Sophist_UK joined the channel
2022-07-08 18935, 2022
14:42 PM
Sophist-UK has quit
2022-07-08 18922, 2022
14:52 PM
BrainzGit
2022-07-08 18929, 2022
14:53 PM
BrainzGit
2022-07-08 18939, 2022
14:53 PM
Sophist_UK has quit
2022-07-08 18954, 2022
15:17 PM
Rotab joined the channel
2022-07-08 18908, 2022
15:38 PM
yuzie joined the channel
2022-07-08 18950, 2022
16:01 PM
yuzie has quit
2022-07-08 18915, 2022
16:06 PM
yuzie joined the channel
2022-07-08 18910, 2022
16:07 PM
BrainzGit
2022-07-08 18909, 2022
16:26 PM
BrainzGit
2022-07-08 18932, 2022
16:48 PM
alastairp
sorry monkey, I don't understand this PR enough to be able to give you feedback on it :(
2022-07-08 18912, 2022
16:49 PM
monkey
No worries, I'll deploy that to test on monday for further testing
2022-07-08 18913, 2022
16:50 PM
alastairp
great
2022-07-08 18920, 2022
17:14 PM
CatQuest
2022-07-08 18902, 2022
17:40 PM
yuzie has quit
2022-07-08 18904, 2022
17:48 PM
yuzie joined the channel
2022-07-08 18921, 2022
17:48 PM
Pratha-Fish
CatQuest: damn this one looks..... Smart?
2022-07-08 18946, 2022
17:48 PM
CatQuest
tuna watermelon is a thing apparently
2022-07-08 18915, 2022
17:53 PM
yuzie has quit
2022-07-08 18941, 2022
18:08 PM
yuzie joined the channel
2022-07-08 18945, 2022
18:08 PM
yuzie has quit
2022-07-08 18925, 2022
18:41 PM
Pratha-Fish
CatQuest: I am glad that's a thing lol
2022-07-08 18941, 2022
18:41 PM
CatQuest
:D
2022-07-08 18924, 2022
20:46 PM
yuzie joined the channel
2022-07-08 18910, 2022
21:28 PM
yuzie has quit
2022-07-08 18935, 2022
21:49 PM
yuzie joined the channel
2022-07-08 18941, 2022
22:10 PM
yuzie has quit
2022-07-08 18924, 2022
22:15 PM
yuzie joined the channel
2022-07-08 18928, 2022
22:34 PM
yuzie has quit
2022-07-08 18906, 2022
22:37 PM
yuzie joined the channel
2022-07-08 18904, 2022
23:44 PM
yuzie has quit
2022-07-08 18920, 2022
23:44 PM
yuzie joined the channel
2022-07-08 18902, 2022
23:48 PM
yuzie has quit
2022-07-08 18902, 2022
23:56 PM
yuzie joined the channel
2022-07-08 18907, 2022
23:56 PM
yuzie has quit
