(People still up: atj, skelly37, yuzie – anyone else who wish to give review, let me know ASAP!)
2022-07-25 20634, 2022
yvanzo
Nearly completed diagrams, continued writing docs, looked into MBS dependencies.
2022-07-25 20649, 2022
yvanzo
Also reviewed a few PRs, and made a bit of maintenance of Jira/Tickets.
2022-07-25 20607, 2022
yvanzo
Fin. Go atj?
2022-07-25 20622, 2022
yvanzo
Or skelly37?
2022-07-25 20635, 2022
yvanzo
Or yuzie?
2022-07-25 20641, 2022
skelly37
hello
2022-07-25 20643, 2022
Freso
atj, skelly37, yuzie: Any of you around? :D
2022-07-25 20647, 2022
Freso
Ayy.
2022-07-25 20653, 2022
yvanzo
Go skelly! :)
2022-07-25 20645, 2022
skelly37
Last week I've been improving the single instance mode for Picard. Very annoying bug got removed, URLs support is almost ready. Passing commands to the existing instance was discussed
2022-07-25 20648, 2022
skelly37
quite a productive week
2022-07-25 20608, 2022
skelly37
Also I was trying to move imp -> importlib but got stuck for now
2022-07-25 20635, 2022
skelly37
When it comes to personal life: well,finally got my first job (with some help of the gsoc experience, thanks y'all!) :D
2022-07-25 20645, 2022
skelly37
fin, go atj
2022-07-25 20645, 2022
alastairp
\o/
2022-07-25 20602, 2022
skelly37
or yuzie
2022-07-25 20607, 2022
yuzie
Hi!
2022-07-25 20615, 2022
yuzie
Last week I add backend API for resetting user timezone and also modified the corresponding frontend UI a bit.
2022-07-25 20622, 2022
yuzie
But I’m stuck with problem related to CORS policy.
2022-07-25 20628, 2022
yuzie
That’s for me.
2022-07-25 20646, 2022
Freso
I guess atj is not around, so I’ll wrap up after yuzie. If atj or anyone else are around and want to give review, let me know now!
2022-07-25 20603, 2022
Freso
Well, let’s wrap up then.
2022-07-25 20626, 2022
Freso
Thank you all for your reviews, and thank you all all for your time!
2022-07-25 20639, 2022
Freso
Stay hydrated, masked, and take care of yourselves!
can you share what you see in network and console logs?
2022-07-25 20640, 2022
yvanzo
Thanks
2022-07-25 20654, 2022
yuzie
Sure. Please wait a minute.
2022-07-25 20654, 2022
alastairp
thanks everyone
2022-07-25 20616, 2022
skelly37
Just a reminder for all the GSoC folks that midterm evaluation should be open in 15 minutes :)
2022-07-25 20645, 2022
Pratha-Fish 👀
2022-07-25 20625, 2022
alastairp
Pratha-Fish: hi, do you want to get LB running?
2022-07-25 20642, 2022
Pratha-Fish
alastairp: Sure, if you don't mind
2022-07-25 20655, 2022
Pratha-Fish
I hope it isn't too late for you tho
2022-07-25 20604, 2022
alastairp
nah, it's fine
2022-07-25 20640, 2022
Pratha-Fish
Alright, then let's get on to it :)
2022-07-25 20636, 2022
alastairp
OK, so the idea is to clone the LB repo, configure it so that you don't run over anyone else's version on the same server, and then connect it to the main MB mirror database so that you can run the necessary apps
I looked into this, it was the same thing we ended up with a few weeks back - the service was trying to restart but failed to bind() to the port, causing an error and a restart
2022-07-25 20636, 2022
alastairp
there are a _lot_ of error messages for it. I stopped and restarted the container
2022-07-25 20659, 2022
alastairp
I can't remember what container we had this issue on last time. but it seems like our restarter script isn't sleeping between executes
2022-07-25 20622, 2022
alastairp
Pratha-Fish: ok, go ahead and clone LB into wolf (I'm following along to make sure we make the correct changes)
2022-07-25 20634, 2022
lucifer
i think it was the labs api container last time as wel
*need to set API_URL to localhost:8100 in your config.py
2022-07-25 20618, 2022
Pratha-Fish
alastairp: done cloning
2022-07-25 20627, 2022
yuzie
OH, I see. I set it to API_URL = 'https://api.listenbrainz.org'
2022-07-25 20605, 2022
alastairp
ansh: I don't think so. I just wanted to take another look at the database query to understand what information the endpoint is returning
2022-07-25 20608, 2022
alastairp
Pratha-Fish: great. first change - edit devlop.sh, line 13 in function invoke_docker_compose, change the argument after -p to `listenbrainz_prathfish` or something similar
2022-07-25 20623, 2022
alastairp
doesn't matter what it is, just something different to the normal. your login name, or your name, or something
2022-07-25 20652, 2022
lucifer
yuzie: setting it to api.listenbrainz.org will send the api request to LB production servers where this endpoint doesn't exist thus giving you a 404 error
2022-07-25 20615, 2022
lucifer
when you change it to localhost:8100, it will go to your local container.
2022-07-25 20639, 2022
Pratha-Fish
alastairp: done
2022-07-25 20600, 2022
reosarevok
bitmap, yvanzo: not sure there's enough ready to merge for a beta yet?
2022-07-25 20606, 2022
ansh
alastairp: Okay :) If there are any changes, can I make them tomorrow?
2022-07-25 20618, 2022
yvanzo
Probably not
2022-07-25 20619, 2022
alastairp
ansh: yes, of course. sorry for the delay
2022-07-25 20634, 2022
ansh
Thanks :D
2022-07-25 20641, 2022
alastairp
Pratha-Fish: cool, now you can run `./devlop.sh build` to build your listenbrainz containers
did we ever set you up with docker access? perhaps not, as you were just using jupyter
2022-07-25 20615, 2022
alastairp
one sec
2022-07-25 20633, 2022
Pratha-Fish
yep
2022-07-25 20650, 2022
alastairp
OK, I added you to the group
2022-07-25 20657, 2022
alastairp
are you doing this through a terminal in vscode, or separate ssh?
2022-07-25 20614, 2022
Pratha-Fish
vscode terminal
2022-07-25 20625, 2022
alastairp
ok, we need to convince vscode to restart itself and log in again
2022-07-25 20638, 2022
Pratha-Fish
alrighty
2022-07-25 20602, 2022
alastairp
is there a command (control-shift-p) called "Remote-SSH: kill VS Code Server on Host" ?
2022-07-25 20634, 2022
Pratha-Fish
alastairp: yes, there is :D
2022-07-25 20642, 2022
alastairp
ok, let's try that
2022-07-25 20633, 2022
Pratha-Fish
Too late, VScode's restarting :D
2022-07-25 20646, 2022
alastairp
the problem is that restarting vscode locally won't fix it
2022-07-25 20658, 2022
alastairp
because when it reconnects, it'll connect to an existing long-running process on the server
2022-07-25 20604, 2022
alastairp
we need to shut down and restart those ones
2022-07-25 20618, 2022
alastairp
lucifer: hi, it doesn't look like we have a local dev setup for labs api, right?
2022-07-25 20635, 2022
lucifer
alastairp: yup don't have it.
2022-07-25 20637, 2022
alastairp
ah, but there _is_ a `docker/docker-compose-labs-api.yml`
2022-07-25 20641, 2022
alastairp
did I make that?
2022-07-25 20653, 2022
alastairp
yes, looks like I did. it's a local only file :)
2022-07-25 20613, 2022
lucifer
ah no, i see it here as well
2022-07-25 20624, 2022
alastairp
huh
2022-07-25 20646, 2022
lucifer
its docker/docker-compose.labs.api.yml here
2022-07-25 20654, 2022
lucifer
. vs -
2022-07-25 20614, 2022
alastairp
yep
2022-07-25 20624, 2022
alastairp
good, lots of fixes for Pratha-Fish to put in his PR ;)
2022-07-25 20624, 2022
lucifer
however, its local as in you need a mb db and typesense server also available.
2022-07-25 20605, 2022
alastairp
yeah, but the typesense server on wolf is connected to the musicbrainz network
2022-07-25 20609, 2022
alastairp
so that should be perfect
2022-07-25 20618, 2022
lucifer
yup makes sense
2022-07-25 20645, 2022
alastairp
Pratha-Fish: any luck? I see a few new vs code services started (though I also see some old ones running)
2022-07-25 20616, 2022
Pratha-Fish
I've restarted it for the second time, apparently it's still not working
2022-07-25 20627, 2022
Pratha-Fish
The kill SSH command didnt do much either TBH
2022-07-25 20631, 2022
alastairp
docker commands still fail?
2022-07-25 20650, 2022
alastairp
yeah. I remember looking into this when ansh tried it. it seems like there's no great solution
2022-07-25 20603, 2022
alastairp
Pratha-Fish: anyway, perhaps you could just ssh in with a separate terminal?
2022-07-25 20609, 2022
Pratha-Fish
sure
2022-07-25 20612, 2022
alastairp
I'll kill all of your servers on wolf meanwhile
2022-07-25 20605, 2022
Pratha-Fish
alastairp: should I port forward while connecting? (just in case)
2022-07-25 20605, 2022
alastairp
they should all be shut down and restarted, maybe your terminal there works too now
2022-07-25 20612, 2022
alastairp
not yet
2022-07-25 20619, 2022
alastairp
we need to decide what to do about ports
2022-07-25 20629, 2022
Pratha-Fish
hm
2022-07-25 20620, 2022
Pratha-Fish
alastairp: Alright, I reconnected on vscode, and ran the command there. It worked :D
2022-07-25 20648, 2022
alastairp
great. has it finished?
2022-07-25 20651, 2022
Pratha-Fish
yep
2022-07-25 20654, 2022
alastairp
great
2022-07-25 20602, 2022
alastairp
so actually, this part of LB is still a bit developer-unfriendly
2022-07-25 20611, 2022
alastairp
do you know about docker and docker-compose?
2022-07-25 20621, 2022
Pratha-Fish
Not really
2022-07-25 20627, 2022
alastairp
ok
2022-07-25 20642, 2022
alastairp
we have this helper script, develop.sh. in the background it uses `docker-compose`
2022-07-25 20606, 2022
alastairp
if you look at the file `docker/docker-compose.yml`, you'll see that it defines a bunch of services
2022-07-25 20629, 2022
alastairp
these are all of the programs that LB needs to run. the flask webserver, a database server, redis, some other stuff
2022-07-25 20632, 2022
Pratha-Fish
I see it in the docker folder
2022-07-25 20649, 2022
alastairp
and when you run `./develop.sh up` it starts all of these services and makes them available on a port
2022-07-25 20607, 2022
alastairp
however, the mapper, which we're looking at is separate from this infrastructure at the moment
2022-07-25 20627, 2022
alastairp
take a look, we have a config file `docker/docker-compose.labs.api.yml`
2022-07-25 20643, 2022
Pratha-Fish
I see it
2022-07-25 20604, 2022
alastairp
this says "run a service called labs_api", the `build` section tells us how to set up the code, the `command` tells us what to run to start it, and `ports` tells us which ports it should be available on in the server
2022-07-25 20623, 2022
alastairp
the `networks` section tells us that we want to be able to connect to the musicbrainz database which is running on wolf
2022-07-25 20620, 2022
bitmap
reosarevok: not atm but I'll try to review stuff tonight so we have more to look at tomorrow
2022-07-25 20639, 2022
Pratha-Fish
I see
2022-07-25 20649, 2022
reosarevok
Okay, sounds good
2022-07-25 20619, 2022
alastairp
so, we can do 2 things: either run all of LB, or just run the mapper
2022-07-25 20632, 2022
alastairp
as we just need to fix the mapper, let's do that instead
2022-07-25 20652, 2022
alastairp
we have another little helper script which allows us to run the mapper, it's `./docker/start-labs-api.sh`
2022-07-25 20600, 2022
alastairp
which works like the develop.sh script
2022-07-25 20611, 2022
skelly37 has quit
2022-07-25 20624, 2022
alastairp
so let's edit this file, and again change the argument to `-p` to the same that you put in develop.sh
2022-07-25 20657, 2022
Pratha-Fish
Done
2022-07-25 20616, 2022
alastairp
(this is called the docker-compose "project", it's a prefix that docker-compose uses to keep track of its processes. normally it's OK to leave it on "listenbrainz" but because we're on a shared server, it'll cause conflicts if multiple people run it at the same time)
2022-07-25 20618, 2022
alastairp
ok, let's try and run it
2022-07-25 20621, 2022
Pratha-Fish
What does the -p represent here though? I am guessing "profile"
2022-07-25 20624, 2022
alastairp
./docker/start-labs-api.sh build
2022-07-25 20629, 2022
alastairp
^ project :)
2022-07-25 20636, 2022
Pratha-Fish
ah
2022-07-25 20604, 2022
skelly37 joined the channel
2022-07-25 20600, 2022
Pratha-Fish
Looks like the ```./docker/start-labs-api.sh build``` command is throwing an error
