#metabrainz

--skip-editor with derived data allows to import annotations at least.

it will work regardless of that option for mirrors because there are no foreign keys, so it's only an issue for standalones

Thanks, I will check standalone setup again then.

Freso: could I please join today's meeting? And go early if poss

aerozol: 👍

hi lucifer, I am stuck when writing the front end test. When I import SelectTimezones class in the test file, I got: TypeError: Cannot read properties of undefined (reading 'Component')

yuzie: at a first look, that sounds like a missing import. can you push the test code to github (regardless whether complete or not), i'll take a look and try to help.

Yes, I already pushed to the github. Thanks!

cool, i'll take a look

Hi, same issue on recreatedb.sh this time unfortunately.

At this point I'd be happy to just comment out the "RunSQLScript($DB, 'CreateFKConstraints.sql'" lines from InitDB.pl :D  It's been a struggle that always ends at the same place!

<BANG>

It’s Chant at the Moon Monday!

We have a few mailed in reviews, so let’s start off with…

monkey: Go!

monkey says…

"""

Hi everyone!

I’ve got family in town so I’m out and about.

Last week I mainly worked on reviewing ansh’s and Shubh’s GSoC projects.

Both projects are moving along very well, but I’ll let the authors update themselves :)

Also made some beer with alastairp and tried to enjoy the hot summer.

Back to you Freso !

moon!

skelly37: Go!

skelly37 says…

"""

Hello everyone,

sorry for the absence but today is a holiday in my country, so I might not make it to the Monday meeting.

This week I have been working on processing command-line commands (heh) by Picard, e.g. `Picard -e QUIT` will, of course, close Picard. It is almost done now, as I am awaiting final reviews from the team :)

I am also still unsuccessfully trying to replace imp with importlib.

And I think that is all.

Have fun & enjoy the summer!

"""

reosarevok: Go!

reosarevok says…

"""

I'm away today, but last week I mostly did code review, released beta (on Saturday, to give people more time to check it if something broke), quickly rereleased a fixed beta (because something broke), and did some refactoring, plus added genres and instrument images.

"""

aerozol: Go!

(Others up: yvanzo, bitmap, atj, zas, alastairp, mayhem, akshaaatt, lucifer, yuzie, yellowhatpro, Pratha-Fish, ansh, CatQuest, riksucks, Shubh, Freso – anyone else who wish to give review, let me know ASAP!)

:(

Thanks Freso! Mōrena tīmu (morning team)

I did some smaller stuff, brainzplayer mockup, CB mobile mock-up, LB player icon

But a couple of things that I would like everyone to have a peep at

A writing styleguide. This should be a living document and please get stuck in it anything like wrong to you, or should be added

The idea is to give some guidance to people who are writing text for MeB pages, documentation, or comms

The other bigger item is the redesign of the MB artist page. I'm not sure how quick this will move forward with akshaaatt now busier in life but I'm sure there'll be lots of opinions in the meantime!

MBS-12349

MBS-12349: Redesign of Artist page https://tickets.metabrainz.org/browse/MBS-12349

Thanks all. Time for me to go back to sleep :D will catch up on your updates after. Go hero akshaaatt

Hi everyone!

💤 aerozol ! good natt!

I was out exploring cities this weekend

Last week, I looked at great stuff from yellowhatpro. Great progress on that!

Had some discussions with aerozol, with his great work coming ahead

That’s it I think. fin.

Go lucifer!

hi all!

(Still up: yvanzo, bitmap, atj, zas, alastairp, yuzie, yellowhatpro, Pratha-Fish, ansh, CatQuest, riksucks, Shubh, Freso – anyone else who wish to give review, let me know ASAP!)

last week, i worked on fixing a couple of LB bugs, improving test running time, upgrading the spark cluster and writing some migration scripts for migrating MsB data and listens.

that's it for me.

yvanzo: next?

Hi!

aparte, al-bondigas: I recommend you to use an earlier version as I suspect it might be a recent regression: sudo docker-compose stop; git checkout v-2022-07- 18 && sudo docker-compose build && sudo docker-compose run --rm musicbrainz recreatedb.sh

Back to the review :)

Last week I wrote and tested steps to fix genre and tag on mirrors.

Also published a fix release of musicbrainz-docker to use Node LTS.

Updated the list of locales for aliases in MusicBrainz (in beta).

Plus PR reviews, support, and tickets triage.

Fin, go bitmap!

hey

last week I worked on MBS-12525 to fix an issue with certain versions of Node v16 failing

MBS-12525: Pre-LTS versions of Node v16 no longer work with compile_resources.sh https://tickets.metabrainz.org/browse/MBS-12525

submitted a couple PRs for MBS-11758, one to fix more React hydration errors, another for the bug as described

MBS-11758: Reset language displays mixed languages https://tickets.metabrainz.org/browse/MBS-11758

later in the week I started work on MBS-12535 to fix more performance issues related to the digital release event "spam"

MBS-12535: Releases tab on area pages load extremely slow https://tickets.metabrainz.org/browse/MBS-12535

also submitted a couple large refactoring PRs to improve Flow type coverage

other than that I did code review and was updating PRs based on review feedback

fin! go alastairp

hi.

I'm also on holiday this week, other than making beer like monkey mentioned, I also rode my bike a bunch

zas: next?

Forgot to say to the MeB team: there will be more alerts related to aretha this week, don’t worry :)

No zas? atj, go!

atj_mb?

No atj either? yuzie, go!

Hi~

:D

(Still up: yellowhatpro, Pratha-Fish, ansh, CatQuest, riksucks, Shubh, Freso – anyone else who wish to give review, let me know ASAP!)

Last week I mainly worked on writing tests for the settings api and the react frontend.

I’m new to react so I’m still facing some problem when writing the frontend test.

That's for me.

Go yellowhatpro.

Hii everyone

Last week I was busy creating repositories, data classes, DAOs for album, artists, songs and playlists features for mb-android.

Working on the implementation of navigation of these features currently, and almost getting killed by college curriculum ⊙﹏⊙∥

that's it for me. Pratha-Fish next?

Pratha-Fish: Ping?

ansh: Go!

Hi everyone!

(Still up: CatQuest, riksucks, Shubh, Freso – anyone else who wish to give review, let me know ASAP!)

ansh: you there?

Last week I worked on showing BB Series items in CB.

I also worked on showing works on edition group’s page in CB.

and opened some PRs based on things required in BB.

On the BB end, I mainly worked on the changes suggested by monkey.

thats it for me!

Shubh: next ?

Hi everyone!

Last week, I mainly worked on PR changes as suggested by monkey on the frontend PR.

Improved the ISBN field by displaying new ISBN alongside the checkbox and added duplicate check to prevent multiple instances of same ISBN.

Also added badge to display identifiers count in place of plain text.

Displaying more details in summary section for new series.

I also did some code refactoring to improve overall code quality and tried to make to Ui bit more intuitive by adding suitable tooltips and icons.

That's it for me, go CatQuest!

Meow! `😺`

Added a whole bunch of Andean/South-American instruments we didn't have!

Reo and I have added several images.

Have looked into aerozol's artistpage redesign, I'm writing up a proper reply as we speak.

Finally noteing that, after extensive research, nylon guitar and gut guitar will soon be merged into classical guitar. ifr https://tickets.metabrainz.org/browse/MBBE-58 ♋ ΦωΦ

MBBE-58: give gut- and nylon-guitar credits.

♋

fin, go whoever's left. uhm.. freso?

or riksucks

riksucks: You go first. :)

go riksucks !

Final call for anyone else who wish to give review!

If riksucks is here. 🤭

Maybe I’ll just go.

🙋

might as well

o/

Did anyone happen to have any opinions on the thread about the cover art auto-edits I mentioned last week?

Not much to report from my side. It’s been incredibly warm and sunny and I’ve tried to take as much advantage of that as I have been able to, so my time on MeB has been extremely minimal this week. :x

fin.

elomatreb[m]: ops i forgot completely

And that’s all for reviews!