ansh: I'm just looking at this with monkey now, in the office
2022-09-14 25750, 2022
ansh
alastairp: I found some such cases in the database. I'll find them again
2022-09-14 25758, 2022
alastairp
the one thing that we both saw at first is that the 3 sections (list of reviews, list of this entity in the other db, list of related entities) are difficult to visually separate
2022-09-14 25715, 2022
alastairp
I think the best solution here would be to add some more whitespace and open a ticket for aerozol to make it look better
2022-09-14 25707, 2022
ansh
Yes, that would fix the issue for now
2022-09-14 25755, 2022
alastairp
I'm going to open a ticket
2022-09-14 25719, 2022
alastairp
for now let's not overthink it, and just add some more whitespace, and leave it as-is
2022-09-14 25721, 2022
alastairp
so that we can merge it
2022-09-14 25708, 2022
alastairp
yvanzo: hi! I want to do a push for updating translations on CB after all of ansh's work. should we remain with transifex for now?
in this case, the "this entity also appears" is currently in the table, as `<tr><td colspan=3></td></tr>`
2022-09-14 25706, 2022
alastairp
rather than your version which has a separate table per list of reviews
2022-09-14 25714, 2022
alastairp
and it also explicitly says "no reviews" in the case there aren't any, which was one of the things that made the earlier Ann Leckie example a bit confusing as to where each section starts and ends
2022-09-14 25754, 2022
alastairp
one thing we're not sure about is what it will look like if a) the main entity you are viewing has no reviews, but a related one does, or b) none of the main entity or related entities have reviews
2022-09-14 25727, 2022
monkey
^what he said
2022-09-14 25700, 2022
monkey
It turns out we're too smart for our own good and your way of doing is is both simpler and more future-proof (with the CB-442 redesign we will soon lose the table elements)
reosarevok: Your track example was really great. I just discovered that there is an undocumented limit to the size of the query parameter sent to the Spotify API which if reached results in a 404
2022-09-14 25743, 2022
monkey
144 characters max
2022-09-14 25733, 2022
reosarevok
hah!
2022-09-14 25754, 2022
lucifer
mayhem: deployed the album crawler and surprisingly. nothing pending...
2022-09-14 25701, 2022
mayhem
so if i listed to stuff now it should start crawling them?
2022-09-14 25730, 2022
mayhem plays more music
2022-09-14 25724, 2022
mayhem
huh, but listens should come in and start causing items to be downloaded. but that hasn't happened in a few minutes, so something seems off.
2022-09-14 25718, 2022
lucifer
even before i took it off, the artist id crawler only had 1/2 ids in pending
2022-09-14 25734, 2022
lucifer
for approx ~30 mins or so.
2022-09-14 25707, 2022
mayhem
ok, I guess it fetches everything and then goes back to sleep.
2022-09-14 25718, 2022
mayhem
maybe print out how many albums have been fetched since start?
2022-09-14 25745, 2022
lucifer
can see that in redis.
2022-09-14 25755, 2022
lucifer
118 so far in 5 mins
2022-09-14 25742, 2022
mayhem
question: if you find an artist id, do you automatically download all albums for that artist?
this is already getting stored in grafana as well, if you want to graph it
2022-09-14 25701, 2022
lucifer
oh well, the fanout setup is wrong which broke the mapper.
2022-09-14 25710, 2022
lucifer
heyarne[m], thanks for the report. will fix.
2022-09-14 25741, 2022
heyarne[m]
🌄 amazing
2022-09-14 25759, 2022
lucifer
mayhem: my understanding of fanout messages was incomplete. we can reuse the exchange but still need a unique name for this queue to ensure both the mapper and the cache get the listens. "spotify_metadata" for a new queue name?
2022-09-14 25757, 2022
lucifer
heyarne[m]: can you try listening to that song again and see if it gets mapped now?
alastairp: monkey: I think keeping white spaces would be good for now. The prototype looks good, but I am also not fully sure for those two cases. Because if there are no reviews for the main entity, It would be kinda unclear for the users
2022-09-14 25731, 2022
ansh
Should we say 'No reviews' for the related entities btw?
2022-09-14 25746, 2022
heyarne[m]
<lucifer> "heyarne: can you try listening..." <- Yup! That was fast
2022-09-14 25758, 2022
lucifer
awesome!
2022-09-14 25751, 2022
rozlav has quit
2022-09-14 25754, 2022
rozlav joined the channel
2022-09-14 25754, 2022
mayhem
lucifer: that sounds fine to me.
2022-09-14 25728, 2022
mayhem
`Pending IDs in Queue: 211652`
2022-09-14 25736, 2022
mayhem
oy, that is clearly working ok.
2022-09-14 25749, 2022
HorusHorrendus has quit
2022-09-14 25733, 2022
lucifer
mayhem: yeah but something still seems off, 2000 ids in 30 mins is clearly too slow.
2022-09-14 25740, 2022
mayhem
alastairp: do you have a current email for Paul Lamere?
2022-09-14 25714, 2022
mayhem
fetched or discovered ids?
2022-09-14 25747, 2022
lucifer
fetched
2022-09-14 25749, 2022
alastairp
mayhem: the only one I have in my inbox is @echonest.com, which I suspect no longer exists
2022-09-14 25758, 2022
lucifer
discovered is > 200k
2022-09-14 25709, 2022
mayhem
alastairp: ok, I'll dm him on twitter, that should work.
2022-09-14 25732, 2022
mayhem
not sure what the rate limits are lucifer, so not sure.
2022-09-14 25749, 2022
mayhem
are we fetching one album at a time or multiples at a time?
2022-09-14 25759, 2022
lucifer
1 album at a time.
2022-09-14 25719, 2022
mayhem
there is an endpoint for fetching multiples in one call -- lets use that.
mayhem: yes, tracks are cut off after 50. i guess we could detect and do separate queries in that case though.
2022-09-14 25729, 2022
chrisshepherd has quit
2022-09-14 25732, 2022
ssam has quit
2022-09-14 25727, 2022
chrisshepherd joined the channel
2022-09-14 25711, 2022
ssam joined the channel
2022-09-14 25750, 2022
chrisshepherd has quit
2022-09-14 25752, 2022
ssam has quit
2022-09-14 25737, 2022
chrisshepherd joined the channel
2022-09-14 25707, 2022
ssam joined the channel
2022-09-14 25704, 2022
mayhem
Yes, a pita, but bound to be faster.
2022-09-14 25705, 2022
reosarevok
loujine, jesus2099 (and probably most other userscript makers): the new React relationship editors are out in beta. They'll be there for a while (longer than the usual week)
2022-09-14 25741, 2022
reosarevok
They'll almost certainly break several of your scripts - feel free to ask bitmap or me if you need help with something (well, bitmap knows a lot more since it's his code, but I can try to help)
Aheno: thanks! I did see, I'm just recovering from a little collection of injury and illness. But should get onto it today
2022-09-14 25713, 2022
aerozol
Also fair warning - everything here usually moves at a slow pace. So I would get used to playing the loong game. And doing a lot of editing/scanning while you wait!
2022-09-14 25703, 2022
mayhem
lucifer: oh heh, lol. we'll we'll find out soon enough why it is slow.
