lucifer: that seems like dodgy data in Spotify, but it should still be matched I guess
2022-10-11 28433, 2022
bitmap
kellnerd: thanks for the updates, I'm glad things are mostly working! I'm traveling back atm but I've seen your message about the attributes issue, I just might be a bit slow to respond until I get home
2022-10-11 28408, 2022
bitmap
will have plenty of time to look into it on the flight though
2022-10-11 28428, 2022
reosarevok
Have a good flight home!
2022-10-11 28447, 2022
bitmap
thank you!
2022-10-11 28401, 2022
reosarevok
bitmap: the comment under CREATE TABLE artist_release suggests we sort by catnos, but AFAICT we do not? MBS-6796 is still open and find_fast doesn't seem to use them
Wait, no, I'm being an idiot, that's _release, we don't store catnos for _release_group
2022-10-11 28427, 2022
reosarevok
We could consider storing the alphabetical first catno for all releases in the RG, I guess, if we find that's useful, but that'd be a schema change
2022-10-11 28427, 2022
rdswift has quit
2022-10-11 28451, 2022
rdswift joined the channel
2022-10-11 28401, 2022
reosarevok
Marked that ticket schema change at least
2022-10-11 28448, 2022
reosarevok
Oooh, thanks for the knockout flow
2022-10-11 28400, 2022
reosarevok
(that sounds like you're a great battle rapper now)
2022-10-11 28442, 2022
bitmap
lol
2022-10-11 28421, 2022
bitmap
right, we'd need to materialize first_release_catno I guess. dunno how useful that'd be outside of this case
2022-10-11 28405, 2022
darkstardev13 has quit
2022-10-11 28423, 2022
darkstardev13 joined the channel
2022-10-11 28401, 2022
akshaaatt
Thanks yvanzo
2022-10-11 28418, 2022
akshaaatt is back in India
2022-10-11 28434, 2022
darkstardev13 has quit
2022-10-11 28448, 2022
darkstardev13 joined the channel
2022-10-11 28459, 2022
darkstardev13 has quit
2022-10-11 28404, 2022
darkstardev13 joined the channel
2022-10-11 28406, 2022
darkstardev13 has quit
2022-10-11 28440, 2022
darkstardev13 joined the channel
2022-10-11 28423, 2022
darkstardev13 has quit
2022-10-11 28429, 2022
darkstardev13 joined the channel
2022-10-11 28430, 2022
darkstardev13 has quit
2022-10-11 28452, 2022
darkstardev13 joined the channel
2022-10-11 28435, 2022
lucifer
reosarevok: yeah, could be dogdy data or just how they manage data internally. i think we should probably try to match if possible. fwiw, i did some counts and there are 30k such instances (having ft, feat or featuring in name) out of overall 3.3M artists.
"Among other things, it recommends using the Authorization Code flow with the PKCE extension instead of using the Implicit flow."
2022-10-11 28417, 2022
alastairp
well, if that works, I don't see much problem with suggesting that we use it
2022-10-11 28439, 2022
lucifer
yup agreed.
2022-10-11 28445, 2022
tykling
fwiw django-oauth-toolkit most recent release changes authorization code flows to have pkce to be enabled by default, we've had no problems getting various clients to adapt to it
2022-10-11 28411, 2022
tykling
(we = $dayjob, nothing to do with meb)
2022-10-11 28430, 2022
alastairp
tykling: thanks. atj_mb suggested that we make it required, which we're going to do. we're using https://authlib.org/ + their flask library
2022-10-11 28444, 2022
alastairp
it's currently optional in musicbrainz.or
2022-10-11 28443, 2022
tykling
right. it protects against some scenarios that are relevant when the auth server and the resource server are not the same, not relevant everywhere but a good thing to get standardized
2022-10-11 28419, 2022
alastairp
that's great actually, because this will be the case for us (I believe - resouce server: musicbrainz.org, auth server: metabrainz.org)
2022-10-11 28410, 2022
tykling
oh right of course, well great :D
2022-10-11 28420, 2022
alastairp
tykling: it sounds like you might know a bit about oauth ;) do you mind if we run some documentation/plans past you to get your feedback on it?
2022-10-11 28445, 2022
tykling
not at all, though I may take a few days to find time to look at it, my schedule is crazy at the moment
2022-10-11 28451, 2022
tykling
happy to help if I can :)
2022-10-11 28454, 2022
alastairp
great, thanks. we finished most of our planning doc and made a start on a test implementation last week, I'll clean up the doc and send it your way
2022-10-11 28433, 2022
alastairp
I think I caught monkey's sniffles :(
2022-10-11 28450, 2022
tykling
is that like monkeypox lite
2022-10-11 28452, 2022
monkey
Awww, don't call it that !
2022-10-11 28458, 2022
monkey
:p
2022-10-11 28421, 2022
mayhem snickers
2022-10-11 28452, 2022
kellnerd joined the channel
2022-10-11 28403, 2022
zas
gooood moooorniiiing
2022-10-11 28453, 2022
zas
I'm still astonished that cocktail bot is a legal weapon.
2022-10-11 28425, 2022
mayhem
legal or lethal?
2022-10-11 28404, 2022
zas
lethal, yes, that too.
2022-10-11 28457, 2022
mayhem
lucifer: have you started making troi changes yet? if not, I think I will take a stab at those later today, to get into some coding after a week of madness
2022-10-11 28425, 2022
lucifer
mayhem: which changes?
2022-10-11 28436, 2022
mayhem
click and how to load patches
2022-10-11 28453, 2022
mayhem
or should I go check the PR list? heh
2022-10-11 28436, 2022
lucifer
ah yes, i did make small changes but not all. i'll open a PR later today, you can complete the rest if you prefer.
2022-10-11 28456, 2022
mayhem
ok, I'll wait for the PR then see.
2022-10-11 28422, 2022
lucifer
yes getting the spotify cache PRs merged would be nice. currently, the containers are running on custom branches.
2022-10-11 28423, 2022
lucifer
also https://github.com/metabrainz/troi-recommendation… is open, the only missing piece for getting the minimal spotify playlist export feature in LB is adding new permission scopes and frontend changes.
the cache is more or less stable now, should we revert to spotipy main instead of the fork?
2022-10-11 28405, 2022
mayhem
lucifer: what is the purpose of the raw table? why can't we just insert into the normalized tables directly?
2022-10-11 28438, 2022
mayhem
if you think that will work, then by all means, less for us to look after
2022-10-11 28424, 2022
lucifer
mayhem: we insert directly to main tables and as well raw. raw is only there 1) in case we discover some bug in the migration script that ported the initial 13.5M albums data 2) we want to change the normalized schema.
2022-10-11 28410, 2022
mayhem
but we should remove that at some point soonish, yes?
2022-10-11 28458, 2022
lucifer
yes makes sense. once we are satisfied with the normalized schema and seen it work in prod for some time, sounds good to drop raw data table then.
2022-10-11 28410, 2022
mayhem
personally, if you are already resolving playlists correctly, then I think we can nuke this, honestly.
2022-10-11 28430, 2022
mayhem
and the data migration tools too, not need to keep that around, methinks.
2022-10-11 28433, 2022
mayhem
*no
2022-10-11 28453, 2022
lucifer
so the first prototype of schema didn't have a position column in rel_track_artist so when retrieving the artist name, the names got unordered and there were some mismatches. i added the column in the second prototype to improve matches. i wonder if there are more such bugs lurking which only come up after testing on a wider array of recordings.
2022-10-11 28427, 2022
mayhem
ok, if you prefer that
2022-10-11 28457, 2022
lucifer
i'll open a ticket to remove the raw data tables so that we don't forget about it.
2022-10-11 28401, 2022
mayhem
k
2022-10-11 28415, 2022
lucifer
mayhem: oh also, when you have time later, please generate these keys: https://help.apple.com/developer-account/#/devcdf… . i'd like to setup apple music scraper soon so that we can start building the cache which take awhile to become usuable. meantime can work on adding listening history support.
