#metabrainz

yes, except this is pretty much a done deliverable. :)

I see that images are misaligned, let me tinker them into place.

Great! Just the ‘small’ matter of UI hah

So for future features I still think it could be useful to do a digital composite, where people can adjust things more. But I’m getting ahead of myself

Like

(swapping out flooring)

aerozol: UI isn't important just yet. automated covers for stats are killer start!

there is one thing that is bugging me...

on the rightmost vinyl cover, there is a white area that butts right up to the cover art.

it makes the cover art look... bad.

what is that white thing? could it be something else?

mayhem: perhaps the order of images, it seems to me last two images should be swapped

totally plausible. swapped. will be out with next update.

hmmm, there are more issues, when swapped another artifact appears

Are these artifacts on the png layer? might be a me problem

that change is not live yet. at least not on grid.lb.org

aerozol: yes.

The white thing up against the rightmost LP? The inner sleeve?

zoom in and there is a white bit we could do without

likely an inner sleeve, yes.

I can shop it out if you want but will take a little bit

yes, please.

and also, is the leftmost album a true square?

Not seeing the white artifacts:

I'm a true square, but can't speak for the album.

I reckon square, but possibly a bit beat up?

do you see the white strip on the left side of the rightmost album?

Personally I think cutting a bit of the corners off the cover just makes it more realistic but

Yeah I can remove that, that’s the inner sleeve

yes, please. I find it quite distracting.

I think in general, I need to zoom each of these covers out a bit to ensure that there no artifacts.

Looks great guys !

:D

FWIW, I think the artifacts are because of the little bit of perspective deformation tapering the squares

indeed they are.

But they're not very noticeable

lets see if they remain a problem. hang on.

it doesn't look very good: http://136.243.82.226:8000/coverart/cover-art-o...

but that is best I can do. unless we go as far as actually warping the image the same amount as the perspective shift...

3d transforms are not fun.

screw that.

But maybe more doable with inkscape to get the transform values

I’ll adjust the frame a bit more

for now

but making the squares true squares just moves the problem around.

mayhem: I had good results using a clip-path before the rotation (well, it seems to be better)

<image xmlns="http://www.w3.org/2000/svg"; x="386" y="488" xlink:href="https://archive.org/download/mb...; xmlns:xlink="http://www.w3.org/1999/xlink"; width="202" height="202" transform="rotate(2.2)" clip-path="polygon(0 0, 202 0, 202 202, 0 202)"/>

Also I slightly increased the size of the image to ensure it covers borders

^ black liner

without clip-path, rotation will let artifacts

zas: post an image please!

Let me know if you need me to square some of the frames, the bottom left is a bit of a doozy now that I look at it

exactly. that one would be helpful

Look at the image on the bottom, with clip-path https://usercontent.irccloud-cdn.com/file/fw8oK...

these changes are hard to compare, really. :)

I'm exhausted. do you want to play with it for a while, zas?

I can give you commit access.

I should really go to bed.

well, I'm tired too, better look at this tomorrow

ok.

http://136.243.82.226:8000/coverart/cover-art-o... two done

after I fix this up, I'm off to bed.

I like the idea btw, with a bit of tuning it can look good I think. I noticed problems due to rotation precision, clipping, and order

yeah, it wasn't perfect.

it was literally a rough draft. :)

also I think we need some shadows around images

Squared up left LP

but overall, good raw draft ;)

There are shadows under the LPs (you can see it on that one) but possibly too subtle

subtle = realistic/exactly the same shadows from the photo

aerozol: better! http://136.243.82.226:8000/coverart/cover-art-o...

needs a tiny tweak, then it should be good.

speedy!

what is this new one?

^ non compressed 1mb image, has less artifacts. Not sure to tackle the compression thing atm

naw.

looking better all the time. :)

Cool, I’m going to keep mucking with the overlay a little bit but no sizes will change so you can just update the pic

https://grid.listenbrainz.org updated, but with a very interesting artifact.

oh, I think I know what that is. cute.

^ darker/unrealistic shadows

what are you saying? :)

That’s the same file but with the shadows that show the LPs overlapping darkened heaps (I think that was zas’ feedback)

want me to update it?

These shadows :D

working on that.

I reckon let’s see what it looks like

is that different?

I cant tell

haha subtle but let’s use the new one I think

super fiddely. :(

ok, that is best I can do for tonight:

the upper right edge of the bottom album keeps being pesky.

still, that looks freaking great. :)

!m aerozol

You're doing good work, aerozol!

Looking excellent mayhem!! Sleep tight and ping me if you need adjustments

check the squareness of the bottom cover art, plz. :)

where did that image of the wooden floor come from? did you take it?

There's a problem when using non-square images https://usercontent.irccloud-cdn.com/file/umKht...

yep, known problem in all the these images.

right now I assume they are square... because I have no image to work with.

we'll need to see if we can get more data or do some svg magic

CAA doesn't know image dimensions.

yup, tricky

huh, here is a thought.

what if we have the image of the table at the bottom most image.

and the backdrop of the coverart that is now white, is transparent.

on theory it would look like a rectangular LP. which could be funny. could be horrible or totally escape notice.

aerozol: ^^

actually in the image above the main problem is that top border is somehow messed up, it could work if the actual result was a square (blue image, over white)

yes, I see what you mean.

we know the "avg" color of any given cover.

mayhem: there's something called object-fit: cover that might help too -> https://www.sarasoueidan.com/blog/svg-object-fit/

we could fill album rect with that color, then render the cover over the background. it would appear that there are stripes of (possibly) complementary colors on the sides (or top/bottom). that would fix the problem and make the stripes appear as if intended.

grrr, I told I was tired, and you said you were off to bed... and here we are... :D

'tis such a good projec though.

good enough for tonight.

off to bed.

:) gn

mayhem: the base picture is taken by me on a ladder. (but didn’t avoid perspective completely unfortunately) There’s heaps more from that set

Sleep tight all!