yvanzo: hi, I saw you mentioned in the meeting yesterday that you also got solr compiling - is this the same solr 9 + java 17 that I was working on? where did you get to?
[listenbrainz-server] 14MonkeyDo merged pull request #2230 (03master…static-builder-local-user): Only mount static source files in builder; run as local user https://github.com/metabrainz/listenbrainz-server…
CatQuest: interestingly that ties in very closely to what we talked about last week with this ex-last.fm guy (and which we mentioned in yesterday's meeting)
2022-11-08 31252, 2022
alastairp
tag radio was one of the things that l.fm had (has?)
2022-11-08 31215, 2022
alastairp
~10% of people who used playback on l.fm used tag radio, and there were people who would build "communities" around music by using sillyname tags!
2022-11-08 31237, 2022
CatQuest
it *had* and yes I remember
2022-11-08 31242, 2022
CatQuest
I had several types liek that
2022-11-08 31208, 2022
CatQuest
i called all mine "mister so and such"
2022-11-08 31222, 2022
CatQuest
so "mister trans techno space man" or wahtever for electronic
2022-11-08 31218, 2022
CatQuest
I wanted to "import" this old tag playlist to lb from the start (since I had tagged so very much, including "stuff that looked interesting so i want to try listen to it to see if I liekd it")
2022-11-08 31223, 2022
CatQuest
liked*
2022-11-08 31246, 2022
CatQuest
aka "mr test"
2022-11-08 31226, 2022
CatQuest
oh! yea all the things iactually owned i tagged with "mister ownership-deal" :D
2022-11-08 31214, 2022
CatQuest
I don't think lastfm even has tags anymore
2022-11-08 31252, 2022
CatQuest
I don't understand why they sold to cbs it just seems so ruined the whole thing
2022-11-08 31201, 2022
mayhem
ch-ching. it was all about the money. nothing else.
oh man if I could tag stuff on lb like I could on lasfm. that'd be mr groovy bets man
2022-11-08 31230, 2022
mayhem
that is now on our roadmap. elevating tags to the last.fm level.
2022-11-08 31243, 2022
avane joined the channel
2022-11-08 31254, 2022
lucifer
fun, prometheus prohibits `-` in metric names and we use that extensively in lB
2022-11-08 31241, 2022
mayhem
go with `_`?
2022-11-08 31257, 2022
lucifer
yup added a s/-/_
2022-11-08 31252, 2022
mayhem
lucifer: on the art.lb.org vs lb.org/art for the web pages, having two root documents in one web server sounds like a pain to configure. what if we just add a redirect from art.lb.org to lb.org/art and call it good?
2022-11-08 31216, 2022
lucifer
sure sounds good
2022-11-08 31221, 2022
mayhem
(as well as the provisions for making sure that art.lb.org is the only place that cover art is served from)
2022-11-08 31234, 2022
mayhem
ok, then the rest is up to zas, I think.
2022-11-08 31236, 2022
lucifer
but then people can also directly visit lb.org/art?
2022-11-08 31201, 2022
mayhem
yes, but only for web requests. api will need to go to art.lb.org/1/...
2022-11-08 31227, 2022
mayhem
zas: when you have a bit of time to work with me on this stuff, please ping me.
2022-11-08 31233, 2022
lucifer
if you want i can take a look at configuring art.lb.org to work instead of lb.org/art, probably will need something similar to api compat app we have in LB
2022-11-08 31217, 2022
mayhem
the api compat stuff is always a pain and don't need another port open for that support?
2022-11-08 31224, 2022
mayhem
if you find a trivial solution, then great. but anything beyond that, I'm happy with /art for the art index page. that page is intended to demonstrate our capabilities --- not sure it has a long term purpose. so no point in working hard to make it happen.
2022-11-08 31230, 2022
zas
mayhem: pong
2022-11-08 31203, 2022
mayhem
hiya!
2022-11-08 31209, 2022
zas
Hey ;)
2022-11-08 31218, 2022
mayhem
so, the art.lb.org stuff has been released and DNS pointed correctly.
2022-11-08 31221, 2022
lucifer
uh yeah, you're right about the port thing. i had forgotten about that 😅. nvm then
2022-11-08 31221, 2022
BrainzGit
[listenbrainz-server] 14amCap1712 merged pull request #2235 (03master…cache-enhance): Add release group cover art, artist credit id and individual artist name to mb_metadata_cache https://github.com/metabrainz/listenbrainz-server…
2022-11-08 31223, 2022
zas
I see there are art-api.listenbrainz-web and art.listenbrainz-web
well, I'll try to prepare a patch for that, and we'll review it together
2022-11-08 31212, 2022
mayhem
k, thanks.
2022-11-08 31225, 2022
zas
what happens to existing stuff (related 410s) on LB ?
2022-11-08 31243, 2022
mayhem
nothing. they remain.
2022-11-08 31236, 2022
zas
ok, I'll see how to achieve that, I'm off for lunch for a while but I'll work on that this afternoon
2022-11-08 31242, 2022
mayhem
great
2022-11-08 31218, 2022
mayhem
lucifer: I am forcing a resync of the coverart color stuff -- not sure it fully picked up again once we released the fix for the data. this way it should be all caught up.
2022-11-08 31234, 2022
lucifer
mayhem: 👍
2022-11-08 31210, 2022
genpaku has quit
2022-11-08 31245, 2022
genpaku joined the channel
2022-11-08 31217, 2022
alastairp
2022-11-08 11:32:22.350 INFO (coreLoadExecutor-10-thread-1) [ x:annotation] o.a.s.c.SolrCore Opening new SolrCore at [/home/alastair/code/metabrainz/mb-solr/solr-9.0.0/server/solr/annotation], dataDir=[/home/alastair/code/metabrainz/mb-solr/solr-9.0.0/server/solr/data/annotation/]
so, maybe also add the subdomain argument to the art index page handler? That might do the trick.,..
2022-11-08 31247, 2022
mayhem
lets try it.
2022-11-08 31225, 2022
lucifer
yeah makes sense. i wonder what'll happen locally though
2022-11-08 31242, 2022
mayhem
let me find out.
2022-11-08 31235, 2022
mayhem
more specifically, lets see just HOW that breaks. :)
2022-11-08 31241, 2022
lucifer
it queries art.localhost locally that way
2022-11-08 31239, 2022
mayhem
let me see if passing subdomain="" undoes that.
2022-11-08 31252, 2022
lucifer
atj, zas: do you know till how much in past i can submit data to prometheus?
2022-11-08 31232, 2022
lucifer
i tried to find it on google but its mostly responses from people whose apps had issues and was reporting old timestamps but i want to explicitly submit timestamps in the past.
2022-11-08 31249, 2022
atj
not sure i understand the question, prometheus pulls metrics, so the timestamp is the time at which the metrics were retrieved
2022-11-08 31217, 2022
lucifer but this format allows me to specify a timestamp, https://prometheus.io/docs/instrumenting/exposition_formats/#comments-help-text-and-type-information
2022-11-08 31208, 2022
lucifer
the python client also allows me to pass in a timestamp manually
2022-11-08 31221, 2022
lucifer
i can see that prometheus is probably reading those timestamps because the logs mention the timestamp is too far in fast or too far in future.
2022-11-08 31206, 2022
mayhem
the subdomain stuff works as expected. passing subdomain="" undoes it. so we can conditionally set the subdomain in production. question is, how do we best do that?
2022-11-08 31231, 2022
lucifer
and when i passed out of order timestamps intentionally, it also errored as expected. but i have been unable to determine how far/if back i am allowed to submit
2022-11-08 31207, 2022
lucifer
mayhem: hmm, in rest of LB frontend we construct the url manually. i think we should do the same here.
2022-11-08 31227, 2022
mayhem
we could add a `ART_SUBDOMAIN=""` to config.py
2022-11-08 31228, 2022
lucifer
because current_app.config won't be available when this rule will be evaluated
2022-11-08 31244, 2022
mayhem
ahhh, good catch.
2022-11-08 31254, 2022
mayhem
but not sure what you mean by manually in this context?
2022-11-08 31258, 2022
lucifer
hmm i see. that might work actually.
2022-11-08 31208, 2022
lucifer back in ~15 mins
2022-11-08 31229, 2022
mayhem
we'd have to load it from config and not current_app.config, but ok.
