It’s an ancient acronym which originally meant “let’s go to MMXXIII”, almost there.
2022-12-23 35734, 2022
vibhoo_24 has quit
2022-12-23 35712, 2022
reosarevok
I thought it was "love good to-matoes"
2022-12-23 35701, 2022
reosarevok
aerozol: technically it's trap (edm), but I didn't add the parens because it's annoying to type tags with parens and because it's also not wrong as trap edm (it's edm of the trap sort :D )
2022-12-23 35754, 2022
alastairp
morning
2022-12-23 35704, 2022
mayhem
moin!
2022-12-23 35703, 2022
alastairp
yim looks great mayhem, nothing from my end here to sugget
2022-12-23 35712, 2022
mayhem
:D
2022-12-23 35725, 2022
alastairp
lucifer: hi, I saw that you tested and approved the manual mapper, but wasn't sure if you were going to go ahead and merge/release that to prod?
2022-12-23 35756, 2022
alastairp
today I want to fix the canonical table calculation based on lucifer and my conversation at the beginning of the week (or last week?)
2022-12-23 35707, 2022
mayhem
I can't wait to try that. Map the repeatgning daily jams tracks to the ones that CF wants me to listen to.
2022-12-23 35735, 2022
alastairp
mmm, not sure if we're using that in the data that goes to spark yet... lucifer?
2022-12-23 35756, 2022
vibhoo_24 joined the channel
2022-12-23 35710, 2022
lucifer
alastairp: waiting for monkey's approval on that PR for frontend parts.
2022-12-23 35743, 2022
lucifer
alastairp: yes. that part is pending I'll update the dumps code to include those manual mappings.
2022-12-23 35740, 2022
monkey
OK from me
2022-12-23 35717, 2022
alastairp
thansk monkey
2022-12-23 35739, 2022
monkey
Wlecome
2022-12-23 35715, 2022
vibhoo_24 has quit
2022-12-23 35758, 2022
alastairp
lucifer: btw, didn't get a daily jams yesterday. thought that maybe something was up due to me not having the right data around
I wonder if reosarevok says he got the final error in the chain ("TypeError: Cannot read properties of undefined (reading 'join')", and you say you got the first error that appears ("Error parsing playlist-top-discoveries-for-year: TypeError: Cannot set properties of undefined (setting 'description')")
it shouldn't return a song at all if it doesnt get the right song, rather than this bad a match
2022-12-23 35742, 2022
monkey
I'm on it
2022-12-23 35755, 2022
monkey
(the YIM page errors)
2022-12-23 35716, 2022
monkey
We had some custom code last year for fixing issues with the playlist, but looks like it's messing up this year's page.
2022-12-23 35730, 2022
alastairp
whoops, that sounds familiar, was it my code?
2022-12-23 35754, 2022
monkey
Don't think so
2022-12-23 35729, 2022
monkey
Oh, actually the problem is a lot simpler: test is not running the 2022 version of the frontend, so some code in there is not adapted to chenges we've made to the structure
2022-12-23 35733, 2022
monkey
changes*
2022-12-23 35744, 2022
alastairp
I remember writing some kind of hacky "fix some data before displaying it" javascript
But that's not the issue in the end. Let's see if the code still works once we have updated frontend + updated data with playlists
2022-12-23 35717, 2022
alastairp
yeah, that's what I was thinking of, but if that's not the cause then even easier to fix
2022-12-23 35729, 2022
monkey
Yep, I just need to create a PR for my frontend branch and we can merge it. Would you have time for a quick overview review?
2022-12-23 35745, 2022
lucifer
vibhoo_24: you should read about openapi. then see if there's a tool to convert flask endpoints to openapi otherwise do it manually.
2022-12-23 35708, 2022
lucifer
if you get stuck on something particular, let me know and I'll try to help
2022-12-23 35709, 2022
vibhoo_24 has quit
2022-12-23 35755, 2022
monkey
lucifer: Can I deploy the YIM frontend PR on test again?
2022-12-23 35712, 2022
monkey
er, branch* (PR incoming)
2022-12-23 35724, 2022
lucifer
monkey: sure
2022-12-23 35731, 2022
monkey
👍
2022-12-23 35708, 2022
vibhoo_24 joined the channel
2022-12-23 35723, 2022
monkey
By the way, good job on the manual mapping lucifer and alastairp !
2022-12-23 35735, 2022
monkey
It's very pleasing to fill in the blanks
2022-12-23 35759, 2022
lucifer
only alastairp :)
2022-12-23 35707, 2022
lucifer
!m alastairp
2022-12-23 35708, 2022
BrainzBot
You're doing good work, alastairp!
2022-12-23 35716, 2022
alastairp
thanks monkey. it'll be interesting to see what comes out of if, I see that you and mayhem are both interested in it, and lucifer did a neat trick to allow us to take the most popular mapping for an msid and apply it to everyone's listens
2022-12-23 35735, 2022
monkey
Neat-o
2022-12-23 35744, 2022
alastairp
so if people use it, I think it'll be a good way to fix the small problems, but also as a potential tool to improve the mapper
2022-12-23 35725, 2022
monkey
In my case, I've got issues with the bandcamp player on mobile and pano scrobbler (which sends listens from my phone) because the label appears instead of the artist name. Frustrating
2022-12-23 35748, 2022
monkey
People have been asking for a way to "edit" their listens, well, here's a simple way to make it happen
2022-12-23 35705, 2022
monkey
Enter the right info in MB, then link to it and bam.
2022-12-23 35717, 2022
monkey
At least fro presentational purposes, problem solved
2022-12-23 35737, 2022
tykling joined the channel
2022-12-23 35755, 2022
monkey
Some early interface feedback (I'll add it to the PR as well for reference): The text input in the modal should be auto selected when it opens, saving a click. It's cumbersome to add a whole album; not sure what a good way to select a whole album would be, but…
whole album is interesting, we kind of need a "select multiple listens" and have a single archive
2022-12-23 35707, 2022
monkey
Yeah. not an easy one to solve
2022-12-23 35750, 2022
alastairp
unless we have search and then keep some state around
2022-12-23 35736, 2022
alastairp
tag one, make a search, then when you do the next one click the "this is on the same album as the one that I just updated", it shows a list of all tracks, makes a guess of the corerct one based on metadata, and then single click to apply it
I still have some work to do on the cover art composite zoomable clickable thing, it turns out (surprise surprise) it's quite complex. Probably going to go in another page entirely, so the image preview we have at the bottom of the page will be a link to that special page.
2022-12-23 35754, 2022
monkey
Oh yeah, and the shareable images won't work until they are deployed in prod
2022-12-23 35724, 2022
monkey
alastairp, lucifer : If you have a moment, could you please have a cursory look at # 2302 to make sure I'm not doing anything *too* stupid?
2022-12-23 35738, 2022
alastairp
monkey: sure thing, just after lunch
2022-12-23 35750, 2022
monkey
No huge rush. Thanks !
2022-12-23 35713, 2022
vibhoo_24 joined the channel
2022-12-23 35700, 2022
Toasty joined the channel
2022-12-23 35725, 2022
jasje joined the channel
2022-12-23 35749, 2022
TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | BookBrainz: #bookbrainz | Channel is logged; see https://musicbrainz.org/doc/IRC for details | Agenda (9th Jan): Reviews, Docsprint - Qualifiers (yvanzo), Online digital release (yvanzo)
2022-12-23 35752, 2022
vibhoo_24 has quit
2022-12-23 35742, 2022
Toasty has quit
2022-12-23 35759, 2022
nbin has quit
2022-12-23 35736, 2022
nbin joined the channel
2022-12-23 35739, 2022
nbin has quit
2022-12-23 35740, 2022
alastairp
monkey: two small comments on YIM
2022-12-23 35728, 2022
alastairp
I see that the /year-in-music URL still goes to 2021, should this go to 2022? I can make that change
2022-12-23 35732, 2022
alastairp
did we decide how to link to 2021 yim from the 2022 page? (or in general, how to link to each yim in previous years)
2022-12-23 35756, 2022
nbin joined the channel
2022-12-23 35729, 2022
alastairp
my top tracks share modal shows nothing (top artists works)
2022-12-23 35714, 2022
alastairp
top albums doesn't work either
2022-12-23 35711, 2022
humhumxx has quit
2022-12-23 35717, 2022
Pratha-Fish
alastairp: Hi there, just got back home :)
2022-12-23 35725, 2022
Pratha-Fish
Might be a little too late ig
2022-12-23 35752, 2022
jivte joined the channel
2022-12-23 35734, 2022
jivte
monkey: lucifer: Hey my exams just got over i was not abk=le to contribute due to exams will now start implementing add a listen frontend :)
