#metabrainz

just realised "lgtm" could also mean "let's google that more" and now my language processor unit is depressed

hi salman, here you go: https://musicbrainz.org/doc/Development/Summer_... and https://musicbrainz.org/doc/How_to_Contribute

It’s an ancient acronym which originally meant “let’s go to MMXXIII”, almost there.

I thought it was "love good to-matoes"

aerozol: technically it's trap (edm), but I didn't add the parens because it's annoying to type tags with parens and because it's also not wrong as trap edm (it's edm of the trap sort :D )

morning

moin!

yim looks great mayhem, nothing from my end here to sugget

:D

lucifer: hi, I saw that you tested and approved the manual mapper, but wasn't sure if you were going to go ahead and merge/release that to prod?

today I want to fix the canonical table calculation based on lucifer and my conversation at the beginning of the week (or last week?)

I can't wait to try that. Map the repeatgning daily jams tracks to the ones that CF wants me to listen to.

mmm, not sure if we're using that in the data that goes to spark yet... lucifer?

alastairp: waiting for monkey's approval on that PR for frontend parts.

alastairp: yes. that part is pending I'll update the dumps code to include those manual mappings.

OK from me

thansk monkey

Wlecome

lucifer: btw, didn't get a daily jams yesterday. thought that maybe something was up due to me not having the right data around

but then got one today

[listenbrainz-server] 14alastair merged pull request #2299 (03master…mbid-manual-mapping): Manual mbid mapping https://github.com/metabrainz/listenbrainz-serv...

btw on vivaldi i get "type error" on https://test.listenbrainz.org/user/mr_monkey/ye... https://www.irccloud.com/pastebin/bCfWZijk/

this is modern browser and not old ff fartery

additionally on https://test.listenbrainz.org/profile/import/ i get " We were unable to import from lastfm, please try again.

If the problem persists please contact us.

Error: Something went wrong"

in the popup for import

note: same error on prod

I get a slightly different type error on Opera :)

loi

let me install vivaldi

thanks for the report KassOtsimine, and thanks also for trying on a modern browser too ;)

weird though, it uses blink (approximately equal to chrome)

i noticedon the vivaldi browser because i use t on windows 7. theold mac can't *use* vivaldi. so i have no option

vivaldi is... almost good enough to fill my needs. it still lacks some core features i still need ff44 for :ØC

erh

:C

on the other hand it has tab tiling wich is a killer featurei miss on ff !

:D

KassOtsimine: quick question, which one of these you have activated? https://usercontent.irccloud-cdn.com/file/TndtN...

eh.. i thikn i first installed it before that feature inmstill. but i got everyuthing enabled sothe last one prob

you cna modify thyme later.. i think?

them*

yeah, although I initially thought that "Fully Loaded" had different blocking code, but it seems that it just includes a mail client

it's worth pointing out that this error also occurs on chrome and firefox, so I think it's a YIM bug not a Vivaldi bug :)

[musicbrainz-server] 14reosarevok opened pull request #2787 (03master…MBS-12798): MBS-12798: Cancel open edits of user when it's marked as spammer https://github.com/metabrainz/musicbrainz-serve...

apropos of ingenting: chahahaha https://listenbrainz.org/user/CatCat/pins/

wait, reo said he got a differnt error on page like https://test.listenbrainz.org/user/catcat/year-...

maybe you can paste your error too reo

reosarevok:

I wonder if reosarevok says he got the final error in the chain ("TypeError: Cannot read properties of undefined (reading 'join')", and you say you got the first error that appears ("Error parsing playlist-top-discoveries-for-year: TypeError: Cannot set properties of undefined (setting 'description')")

but they both appear

Yes, I got join

huh also the track i get on youtube from https://listenbrainz.org/player/?recording_mbid... is SO the wrong song.. that's bad

it shouldn't return a song at all if it doesnt get the right song, rather than this bad a match

I'm on it

(the YIM page errors)

We had some custom code last year for fixing issues with the playlist, but looks like it's messing up this year's page.

whoops, that sounds familiar, was it my code?

Don't think so

Oh, actually the problem is a lot simpler: test is not running the 2022 version of the frontend, so some code in there is not adapted to chenges we've made to the structure

changes*

I remember writing some kind of hacky "fix some data before displaying it" javascript

Oh, then maybe alastairp :)

I was thinking about this: https://github.com/metabrainz/listenbrainz-serv...

But that's not the issue in the end. Let's see if the code still works once we have updated frontend + updated data with playlists

yeah, that's what I was thinking of, but if that's not the cause then even easier to fix

Yep, I just need to create a PR for my frontend branch and we can merge it. Would you have time for a quick overview review?

vibhoo_24: you should read about openapi. then see if there's a tool to convert flask endpoints to openapi otherwise do it manually.

if you get stuck on something particular, let me know and I'll try to help

lucifer: Can I deploy the YIM frontend PR on test again?

er, branch* (PR incoming)

monkey: sure

👍

By the way, good job on the manual mapping lucifer and alastairp !

It's very pleasing to fill in the blanks

only alastairp :)

!m alastairp

You're doing good work, alastairp!

thanks monkey. it'll be interesting to see what comes out of if, I see that you and mayhem are both interested in it, and lucifer did a neat trick to allow us to take the most popular mapping for an msid and apply it to everyone's listens

Neat-o

so if people use it, I think it'll be a good way to fix the small problems, but also as a potential tool to improve the mapper

In my case, I've got issues with the bandcamp player on mobile and pano scrobbler (which sends listens from my phone) because the label appears instead of the artist name. Frustrating

People have been asking for a way to "edit" their listens, well, here's a simple way to make it happen

Enter the right info in MB, then link to it and bam.

At least fro presentational purposes, problem solved

Some early interface feedback (I'll add it to the PR as well for reference): The text input in the modal should be auto selected when it opens, saving a click. It's cumbersome to add a whole album; not sure what a good way to select a whole album would be, but…

[listenbrainz-server] 14MonkeyDo opened pull request #2302 (03master…yim-22-frontend): Year in music 2022 frontend https://github.com/metabrainz/listenbrainz-serv...

monkey: I'll add autoselect to the rollup ticket (LB-1179)

LB-1179: Improve interface for manual mbid mapping https://tickets.metabrainz.org/browse/LB-1179

whole album is interesting, we kind of need a "select multiple listens" and have a single archive

Yeah. not an easy one to solve

unless we have search and then keep some state around

tag one, make a search, then when you do the next one click the "this is on the same album as the one that I just updated", it shows a list of all tracks, makes a guess of the corerct one based on metadata, and then single click to apply it

Mmm, good idea.

I updated test with YIM branch again for review: https://test.listenbrainz.org/user/mr_monkey/ye...

(at least confirming nothing breaks)

PR is LB#2302

Year in music 2022 frontend: https://github.com/metabrainz/listenbrainz-serv...

Don't expect tests for this page…

I still have some work to do on the cover art composite zoomable clickable thing, it turns out (surprise surprise) it's quite complex. Probably going to go in another page entirely, so the image preview we have at the bottom of the page will be a link to that special page.

Oh yeah, and the shareable images won't work until they are deployed in prod

alastairp, lucifer : If you have a moment, could you please have a cursory look at # 2302 to make sure I'm not doing anything *too* stupid?

monkey: sure thing, just after lunch

No huge rush. Thanks !

monkey: two small comments on YIM

I see that the /year-in-music URL still goes to 2021, should this go to 2022? I can make that change

did we decide how to link to 2021 yim from the 2022 page? (or in general, how to link to each yim in previous years)

my top tracks share modal shows nothing (top artists works)

top albums doesn't work either

alastairp: Hi there, just got back home :)

Might be a little too late ig

monkey: lucifer: Hey my exams just got over i was not abk=le to contribute due to exams will now start implementing add a listen frontend :)