#metabrainz

aerozol: The new mockup is good but It seems that the cross button twice looks bad like for user search as well as listen details

There is no such need

Jivte: one is the search bar right? It's not intuitive to use that to clear a selection below

If anything I would take it off the search bar

then why not we after search the track we make the search bar empty

and to clear the details we can keep that button

then no need of cross in search

Yeah, as long as we keep the cross button next to the album information? At least, that's where I would expect it. Maybe monkey has a second opinion

Pratha-Fish: hi, that's an interesting question about IRC. I think it's hard to find a balance here because people who know about IRC clearly understand that there are different networks and then each network has channels

anyways great mockup aerozol

better than mine

xDD

jivte: stretch goal for sure, but I was wondering if we do it that way we could queue up multiple tracks/albums under the search? E.g. with a box for each, that can be removed

It's yours with some changes! Always easy to fix things up after

alastairp: true that. And it looks like the new ones really just look up #metabrainz on the default matrix server and enter the wrong channel haha

the thing is for a single track we are showing cover-art

like in add album we will be showing them as a select-deselect feature

Also that reminds me, I've finished updating the IRC docs! Please check it out here and see if it's reasonable or if any changes can be made https://prathamesh-g.notion.site/IRC-Documentat...

alastairp CatQuest ^

thanks Pratha-Fish

^_^

but yeah aerozol for single track too we can add multiple tracks interesting add on

thanks

but you're right, I completely understand the possible confusion if someone just tells you "connect to #metabrainz on matrix IRC bridge"

Personally I think for the album add feature we should keep it simple with a single album. Might make the modal a bit messy otherwise.

(For a limited benefit, I guess)

I think single album for now for sure. Even for tracks

monkey: clarity is neededed

for add track option (single track or multiple)

Did you see my mockup monkey edit monkey? With that look I think it would be possible to do multiple if wanted later

I don't think automatically clearing the search field is a much used UX in the wild, I would advise against it

Personally don't see too much of a problem with the double cross

imo ignore everything I said about multiple tracks/albums for now jivte ;)

yeah I and monkey think single track/album is fine

Did see the mockup, still not super convinced about the idea of multi album, again mainly out of concern of simplicity both in look and in code

But maybe I'm obverse cautious

Over*

Monkey: I don't know if I understand, our other searches don't have crosses on them?

After someone's selected something from the results we could also just leave the text in there and they can backspace it

Search input? The one in the playlist page sure does

aerozol: I have a ides

idea

For adding a track to the playlist

Ah I was trying to find where it was, I only checked the user search at the top and the 'personally recommend' search

to not put the cross on search

'personally recommend' clears the search after a user has been clicked

as it will make the UX and overall feature messy

I think both would benefit to be more like the playlist one, based on the react-select library. Better accessibility etc

alastairp: exactly :)

and conveniently, element.io's network selection drop down box is placed super oddly, so most people don't even see it. But I hope the updated documentation solves it.

P.S. I've also added some features of the brainzbot that weren't covered before in the docs, put the channel details in a convenient table, added some more explanation about the asynchronous nature of IRC and why it doesn't store chats when you disconnect, etc.

Ugh I can't check on my phone. I wonder if it's a phone bug re. the personally suggest feature

monkey: both are fine but need some clearance on what both cross button does

If there's an accessibility benefit to keeping the last selection in the search bo until cleared I'm all good with that.

Hmm aerozol mine didn't work at first but it was because phone auto-capitalizes which returned no result

(just checked how it works on the playlist page)

Something to improve there

Ah that was it!

Yeah, I would be fine with mirroring the behavior in personally recommend (selection goes into the people box, which can then be cleared, last typed stays in the search bar) which works well for me. But if it's not best practice then let's do the other way :D

One other way we could solve this issue is keeping the cross in the search input, removing it from the album, and adding a "clear" button in the footer of the modal that will both remove the search words and the selected album

I'm heading to bed, hopefully you guys can sort out the 'close buttons' questions without too much trouble zzzzz

monkey: so what is final how many buttons we need

xd

To me I would look for the close button in the box with the album/track selection. That's all I'm sayin' ;)

[bookbrainz-site] 14dependabot[bot] opened pull request #921 (03master…dependabot/npm_and_yarn/cookiejar-2.1.4): chore(deps): bump cookiejar from 2.1.3 to 2.1.4 https://github.com/metabrainz/bookbrainz-site/p...

What about a garbage can icon instead in the album?

To differentiate them

alastairp: While you guys are at fixing, i wanted to mention an issue where when we scroll upwards in https://chatlogs.metabrainz.org/libera/metabrainz/ (chatlogs), there seems to a bug where i come back to the start or some other scroll position that is always before my target scroll position or offset

jasje_: yeah, this has been a problem forever :(

This happens on mobile and pc both

really annoying

That's inconsistent with how we do it in 'personally recommend'. That cross already looks different to the one used to clear the text from the playlist search bar though

So that's two different icons

unfortunately the chatlogs software isn't supported any more. we need to make a decision if we keep maintaining it and fixing bugs (which is annoying because it's not our software),

Fair enough

oh if its known then good

or if instead we rewrite it into a much simpler page

well, it's known but theres no time or resources to fix it, which isn't good :)

jasje_: unless you'd like to try and fix it??

Bed time for real real!!

jivte: I'd say put both cross icons as in the mockup, until we have consensus on a way we all think is an improvement over that

Nn aerozol

alastairp: i have the mobile dept no website :P

monkey: okk understood so now this is new UI

RIGHT?

alastairp: if you want there could be a mobile application

jasje_: for what? the chatlogs?

but that wont be so helpful on the pc part

I don't think that's very useful, not many people would use it

alastairp: yupp thats what i think too

What was your last question jivte ?

monkey: u already answered :)

mooooin!

We've successfully applied to 2023? :D

What would have happened if we didn't, the year would be cancelled? :D

version:MMD version, defaults to 2, version 1 is no longer supported since search overhaul in 2018.*

So basically, there's only one valid option and it defaults to it

much parameter, wow

O’Moin

mayhem, lucifer, alastairp: Who wants to review security alerts for troi-recommendation-playground such as SEC-1002 (vulnerability in spotipy)?

SEC-1002: [troi-recommendation-playground] CVE-2023-23608: spotipy < 2.22.1 https://tickets.metabrainz.org/browse/SEC-1002

lucifer is the best person for that. lucifer : we no longer use a custom version of that, right?

Alright, it seems to make sense as he is already assigned to LB security alerts such as SEC-1001 (about the same dependency).

SEC-1001: [listenbrainz-server] CVE-2023-23608: spotipy < 2.22.1 https://tickets.metabrainz.org/browse/SEC-1001

alastairp: Pong

Freso: hi!

I'm just finishing writing some technical docs about how botbot is deployed

I believe you switched the logs to libera back in the day, is that right?

Yes.

and I remember you also doing things like injecting log messages when the bot has disappeared for a while?

Nope.

are these steps documented somewhere?