I’m curious as to if some of the aspects here would help? One in particular is having a ‘edit’ background on edit pages to make it clear that you’re not viewing a regular page, you’re in a ‘workspace’. That should hopefully make it clearer that clicking ‘-’ or ‘+’ on something, and so on, wont immediately have an effect?
2023-02-13 04404, 2023
aerozol
The other thing that would be nice is using the UI at this stage to let people know things will go into the edit queue, which is always confusing for new users. I don’t want to have to explain it with a big paragraph they wont read, maybe this could help. I thought maybe the button could be orange if it’s not an auto edit, but I don’t know if people won’t get that it’s a submit button in that case
aerozol: what happens if there's a bunch of different changes submitted as different edits, and some will be entered as autoedits while others will not'
2023-02-13 04404, 2023
reosarevok
* ?
2023-02-13 04428, 2023
reosarevok
FWIW, we are still hoping to add a way to preview edits to all entity editing like we have for releases
2023-02-13 04454, 2023
reosarevok
Maybe when previewing, a small icon could be shown by each edit that will be entered with the info of what will happen to it?
2023-02-13 04450, 2023
aerozol
Good point - I'd probably do an orange submit button and just change the message to indicate the split. I don't think it has to be perfect, just a thought re. pointing out that there's more to the 'submit' button than people might think
2023-02-13 04410, 2023
aerozol
But highlighting each edit so people can see what's what would work in tandem well
2023-02-13 04437, 2023
reosarevok
mayhem: I was looking at the LB similar users - we have a fair amount of similar ones at the top which look legit (as in, not spammers) but also clearly have duplication. Your document said:
2023-02-13 04438, 2023
reosarevok
"it would be good to contact both users and ask what is going on. Due to storage reasons and gaming the overall stats for the whole site, it would be good to remove duplicate accounts. Not sure what to do if we get no response from the users. Thoughts?"
2023-02-13 04407, 2023
reosarevok
Since a bunch of these haven't listened for months, we probably should think about that indeed
2023-02-13 04424, 2023
reosarevok
Assuming aerozol and you are around for the meeting, maybe we can talk it there?
2023-02-13 04458, 2023
reosarevok
aerozol: I do think an orange button makes it look a bit like they did something wrong?
2023-02-13 04413, 2023
aerozol
I'm around for meeting (I left some comments on that part of the doc btw)
2023-02-13 04416, 2023
reosarevok
But yes, we should certainly make this clear in some way because people often get confused
2023-02-13 04440, 2023
aerozol
Can always have it green like in the screenshot, that was my initial thought too
2023-02-13 04402, 2023
TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | BookBrainz: #bookbrainz | Channel is logged; see https://musicbrainz.org/doc/IRC for details | Agenda: Reviews, LB similar users (reo)
jasje! Definitely! If you want to code it I’ll mock it up asap ;P
2023-02-13 04402, 2023
jasje
oh neo neo me only app dev
2023-02-13 04413, 2023
reosarevok
Don't apps use CSS? :D
2023-02-13 04417, 2023
jasje
just wanted you to give the web guys some push ;)
2023-02-13 04441, 2023
jasje
reosarevok: neoo
2023-02-13 04409, 2023
jasje
also we already have dark theme on the app ;)
2023-02-13 04458, 2023
reosarevok
yvanzo: See MBS-12894 - what do you think? I agree this seems useful, but it's kinda unclear to me how to do it *well*. I guess we still want to autoselect channel since that'll be the correct choice in most cases. I wonder if the least bad option would still be to preselect channel, but allow changing it to interview and say in the error message something like "if you want to add an interview, change this to interview"
Well, once we have that, then it shouldn't be a problem :)
2023-02-13 04438, 2023
reosarevok
(this is one of those instances the ticket talks about)
2023-02-13 04413, 2023
Maxr1998 joined the channel
2023-02-13 04437, 2023
reosarevok
We already kinda-sorta have a way to do that even, the issue here is that the *format* of the URL is different
2023-02-13 04441, 2023
Maxr1998 has quit
2023-02-13 04413, 2023
reosarevok
Normally the artist page errors when you post a video link, because the most common issue is that users copied a music video URL when we want them to link to the artist
2023-02-13 04430, 2023
reosarevok
But in this case I guess we'd want to allow video links, but only for interviews
2023-02-13 04457, 2023
aerozol
Yeah I understood that. Your suggestion makes sense - though we would, as always, have to deal with people abusing it to get in video links
but apparently our fix for daily jams didn't fix it yet. meh.
2023-02-13 04446, 2023
mayhem
reosarevok: talking about LB duplicate accounts before the meeting sound good.
2023-02-13 04436, 2023
lucifer
mayhem: i had forgotten to update the containers after merging the PRs 😓. done now
2023-02-13 04456, 2023
mayhem
d'oh.
2023-02-13 04458, 2023
lucifer
monkey: hi! that error aerozol mentioned is because the track metadata in the pin can be null sometimes.
2023-02-13 04405, 2023
mayhem
how about the mapping container, was that updated?
2023-02-13 04418, 2023
lucifer
updated that too a few mins ago
2023-02-13 04435, 2023
mayhem
also, lucifer and monkey : we should make sure we address that youtube issue that YT keeps whining about.
2023-02-13 04421, 2023
lucifer
monkey: i remember having some code to display an error message in the card to the user that we don't have data for this recording but can't find it now. do you remember anything about it?
2023-02-13 04459, 2023
lucifer
mayhem: yes makes sense. i guess we should talk with aerozol about how to structure the UI while conforming to Youtube requirements
2023-02-13 04434, 2023
mayhem
indeed.
2023-02-13 04438, 2023
aerozol
lucifer: re. error I did pin it while it was still playing, but the ’now playing’ box had links to MB. But I guess that’s not the same. Can I do anything to fix my homepage?
2023-02-13 04415, 2023
aerozol
Maybe we shouldn’t be able to pin from the ’now playing’ box (but I don’t know enough about this error)
2023-02-13 04423, 2023
lucifer
aerozol: i'll remove that pin from the db. due to some reason the data for that recording mbid is missing from MB.
2023-02-13 04450, 2023
lucifer
uh not from MB but from the data tables in LB that fetch data from MB.
2023-02-13 04432, 2023
lucifer
i'll have to investigate why the data is missing but in any the error can be better handled.
2023-02-13 04404, 2023
aerozol
Thanks!
2023-02-13 04431, 2023
jivte joined the channel
2023-02-13 04459, 2023
jivte
aerozol: Hey!!
2023-02-13 04400, 2023
aerozol
jivte: Hey! I’m heading to bed soon fyi but feel free to message anyway
2023-02-13 04450, 2023
jivte
oh no problem take rest!!
2023-02-13 04404, 2023
mayhem
HTF did HFA get MB into their DB??
2023-02-13 04415, 2023
reosarevok
Interesting question, innit
2023-02-13 04435, 2023
mayhem
does HFA need to pay us?
2023-02-13 04402, 2023
reosarevok
Interesting question, innit
2023-02-13 04415, 2023
reosarevok
Yeah I'm really confused about the whole thing
2023-02-13 04419, 2023
reosarevok
Let's see what they answer
2023-02-13 04437, 2023
reosarevok
I *really* hope they are not using MB as a source of anything rights-related...
2023-02-13 04415, 2023
mayhem
I doubt that, but likely as a source of metadata and they are not supporting us.
2023-02-13 04425, 2023
mayhem
time to add this as a board meeting agenda item.
2023-02-13 04401, 2023
yvanzo
O’Moin
2023-02-13 04409, 2023
mayhem
moin!
2023-02-13 04452, 2023
jivte has quit
2023-02-13 04414, 2023
jivte joined the channel
2023-02-13 04446, 2023
reosarevok
yvanzo: do you have any suggestions on how we could do MBS-12843 ? :)
(everyone ignore that PR for now, just putting old half-done code up to not forget about it once we go back to other React stuff)
2023-02-13 04407, 2023
yvanzo
reosarevok: not at the moment about this particular issue. But about edit search, I would consider profiling of higher priority given the outage that occurred in December: https://tickets.metabrainz.org/browse/MBS-12734
Agreed, not sure how we'd do the profiling though. Something to discuss in one of our team meetings I think ? :)
2023-02-13 04423, 2023
reosarevok
I do think it's a good idea though
2023-02-13 04451, 2023
yvanzo
It’s mainly based on Postgres queries and there are hopefully tons of tools for their performance analysis.
2023-02-13 04417, 2023
reosarevok
Sure, we just need to decide how to do it consistently and pick a tool and whatnot, and then do it :)
2023-02-13 04430, 2023
yvanzo
👍
2023-02-13 04431, 2023
monkey
jivte: yes, media queries should work fine to solve the overlap issue
2023-02-13 04457, 2023
jivte
monkey: I solved the issue it looks fine now
2023-02-13 04403, 2023
jivte
you can check it too
2023-02-13 04407, 2023
monkey
Thanks, will check
2023-02-13 04431, 2023
jivte
I resolved the conversations hope it will help
2023-02-13 04432, 2023
jivte
:)
2023-02-13 04432, 2023
monkey
lucifer: I don't remember an error message showed when pin data is missing
2023-02-13 04454, 2023
monkey
other recording data
2023-02-13 04401, 2023
monkey
or* other…
2023-02-13 04410, 2023
monkey
lucifer and mayhem: about the Youtube requirements, where I left it was that we needed to do two things, one of which is fine (removing the option to minimize the youtube video player).
2023-02-13 04410, 2023
monkey
The other breaks continuous playback: users need to manually click on the YT video play button once it's loaded, instead of our current play-next-track-when-finished mechanism. I guess if we don't have a choice that's what we gotta do, but it's very annoying.
2023-02-13 04450, 2023
monkey
> Proposed Solution: Please make the necessary changes so that YouTube player plays when the user initiates an action. Please update the YouTube icon on the video and only when the user clicks on the icon, the video has to be played.
2023-02-13 04441, 2023
monkey
💩
2023-02-13 04453, 2023
jivte has quit
2023-02-13 04456, 2023
jivte joined the channel
2023-02-13 04412, 2023
jivte_ joined the channel
2023-02-13 04426, 2023
reosarevok
monkey: have you tried to ask if it's ok for the user to play *once*, then get continuous playback?
