mayhem: We talked about this PR earlier; when you have the time, could you please have a look at LB#2298? Not the UI bits but the XSPF formatting and possible need to define additional XSPF extension docs somewhere? Also the python file changes please :)
Are we planning to put beta out to prod today/tomorrow, or to do another incremental beta fix?
bitmap
there are a few PRs that need to be merged before release still, and I didn't end up finishing the few smaller issues I was going to look at at the end of last week
if we delay the latter ones to the next release we could just merge the open ones and release tomorrow
monkey, reosarevok, mayhem: i guess we could ask them about it. only way to contact would be to reply to that email thread.
mayhem
lucifer: can you please do that?
lucifer
sure
TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | BookBrainz: #bookbrainz | Channel is logged; see https://musicbrainz.org/doc/IRC for details | Agenda: Reviews, LB similar users (reo), GSoC ideas pages (mayhem)
mayhem
thanks!
lucifer
mayhem: looks good to me but i don't we support soundcloud as a backend.
*don't think
mayhem
ok, I'll remove. that was leftover from last year
lucifer
there's some code in BP iirc but i have never seen that work in practice. and we definitely don't support recording listening from soundcloud.
maybe soundcloud integration could be another project idea.
will have to look into their APIs.
monkey
We do support playing from soundcloud if the listen has an appropriate soundcloud URL (they don't have a search API)
mayhem
ah, ok. then that is where it came from cool.
monkey
The use of "backend" there is ambiguous. Perhaps "third-party services" would be more suited
bitmap
reosarevok: I see at least one other link to a 'discogss' URL in some old chatlogs from 2012, so it seems likely that it was a former static resources domain that they used
mayhem
monkey: where exactly?
monkey
> As of now, it supports Spotify, Youtube and Soundcloud as a backend.
This sentence in each of the ideas about integrating another service
BrainzGit
[musicbrainz-android] 14dependabot[bot] opened pull request #197 (03master…dependabot/gradle/androidx.browser-browser-1.5.0): Bump androidx.browser:browser from 1.4.0 to 1.5.0 https://github.com/metabrainz/musicbrainz-andro...
[musicbrainz-android] 14dependabot[bot] opened pull request #198 (03master…dependabot/gradle/hilt_version-2.45): Bump hilt_version from 2.44.2 to 2.45 https://github.com/metabrainz/musicbrainz-andro...
[musicbrainz-android] 14dependabot[bot] opened pull request #199 (03master…dependabot/gradle/androidx.compose.material3-material3-1.1.0-alpha06): Bump androidx.compose.material3:material3 from 1.1.0-alpha03 to 1.1.0-alpha06 https://github.com/metabrainz/musicbrainz-andro...
[musicbrainz-android] 14dependabot[bot] closed pull request #194 (03master…dependabot/gradle/androidx.compose.material3-material3-1.1.0-alpha05): Bump androidx.compose.material3:material3 from 1.1.0-alpha03 to 1.1.0-alpha05 https://github.com/metabrainz/musicbrainz-andro...
[musicbrainz-android] 14dependabot[bot] opened pull request #200 (03master…dependabot/gradle/androidx.navigation-navigation-compose-2.6.0-alpha05): Bump androidx.navigation:navigation-compose from 2.6.0-alpha04 to 2.6.0-alpha05 https://github.com/metabrainz/musicbrainz-andro...
lucifer
emailed youtube support about the playback thing, cc'ed support.
BrainzGit
[musicbrainz-android] 14dependabot[bot] opened pull request #201 (03master…dependabot/gradle/androidx.appcompat-appcompat-1.6.1): Bump androidx.appcompat:appcompat from 1.5.1 to 1.6.1 https://github.com/metabrainz/musicbrainz-andro...
[musicbrainz-android] 14dependabot[bot] closed pull request #186 (03master…dependabot/gradle/androidx.appcompat-appcompat-1.6.0): Bump appcompat from 1.5.1 to 1.6.0 https://github.com/metabrainz/musicbrainz-andro...
monkey
Thanks
jasje joined the channel
BrainzGit
[musicbrainz-android] 14dependabot[bot] opened pull request #202 (03master…dependabot/gradle/androidx.compose.material3-material3-window-size-class-1.1.0-alpha06): Bump androidx.compose.material3:material3-window-size-class from 1.1.0-alpha03 to 1.1.0-alpha06 https://github.com/metabrainz/musicbrainz-andro...
[musicbrainz-android] 14dependabot[bot] closed pull request #193 (03master…dependabot/gradle/androidx.compose.material3-material3-window-size-class-1.1.0-alpha05): Bump androidx.compose.material3:material3-window-size-class from 1.1.0-alpha03 to 1.1.0-alpha05 https://github.com/metabrainz/musicbrainz-andro...
monkey: about that pinned recording error, how do you suggest we fix it? track_metadata for pinned recording can be null sometimes.
monkey
Ah, yes, let me look at the code
lucifer
should we hide the card altogther or show a message that metadata is missing?
yeah i tried to fix it but its not a clean fix. making track_metadata nullable in the typescript type seems sane but that requires changes at many other places.
lucifer: I forget, is it possible for us to generate daily-jams for all users now? not sure how that changed with the scheduled delivery of daily-jams. we've got some users who have been waiting days for their first daily-jams.
monkey
Just pushing some changes to the navigation mechanism, just waiting for updated snapshots before pushing that
Zhele joined the channel
lucifer
mayhem: it happens daily but we don't have a command to generate it at will. i guess we could add one.
mayhem
or be lazy about it and wait. :)
(or set the timezone to someplace where it will be midnight soon, lol)
lucifer
that's what i do but will have to wait ~35 mins
monkey
lucifer: Any clue why the track metadata is null in this case? Just out of curiosity for what we should do. I think as you say showing an error message maybe, but not sure that's necessary: I think it's a utility function trying to access the metadata here: https://github.com/metabrainz/listenbrainz-serv...
I think simply adding a `?` after track_metadata will be enough to solve this issue. Let me open a PR for it
lucifer
monkey: Listen type has track_metadata as not null so ts complains when you add ?
track_metadata is null when the data is missing from mb_metadata_cache tables, which usually is a bug or if the track was pinned from now playing and actual listen hasn't yet arrived in LB yet (temporary error resolves itself in a few mins usually)
monkey
Oh? I tried locally but don't see any TS complaints… Alternatively we could use the lodash get function we use in some other places: `_.get(listen, "track_metadata.mbid_mapping.artists");`
bitmap: if you and yvanzo feel nothing in those tickets is a must, I'm fine with releasing tomorrow or some time this week
Zhele has quit
Sophist_UK joined the channel
Sophist-UK has quit
BrainzGit
[listenbrainz-android] 14dependabot[bot] opened pull request #55 (03main…dependabot/gradle/hilt_version-2.45): Bump hilt_version from 2.44.2 to 2.45 https://github.com/metabrainz/listenbrainz-andr...
[listenbrainz-android] 14dependabot[bot] opened pull request #56 (03main…dependabot/gradle/androidx.appcompat-appcompat-1.6.1): Bump androidx.appcompat:appcompat from 1.6.0 to 1.6.1 https://github.com/metabrainz/listenbrainz-andr...
[listenbrainz-android] 14dependabot[bot] opened pull request #57 (03main…dependabot/gradle/androidx.compose.material3-material3-1.1.0-alpha06): Bump androidx.compose.material3:material3 from 1.1.0-alpha03 to 1.1.0-alpha06 https://github.com/metabrainz/listenbrainz-andr...
[listenbrainz-android] 14dependabot[bot] closed pull request #43 (03main…dependabot/gradle/androidx.compose.material3-material3-1.1.0-alpha05): Bump androidx.compose.material3:material3 from 1.1.0-alpha03 to 1.1.0-alpha05 https://github.com/metabrainz/listenbrainz-andr...
[listenbrainz-android] 14dependabot[bot] opened pull request #58 (03main…dependabot/gradle/androidx.browser-browser-1.5.0): Bump androidx.browser:browser from 1.4.0 to 1.5.0 https://github.com/metabrainz/listenbrainz-andr...