#metabrainz

[musicbrainz-server] 14mwiencek opened pull request #2840 (03master…mbs-12829): MBS-12829: Use link type phrases in autocomplete input value https://github.com/metabrainz/musicbrainz-serve...

aerozol: dunno if you get notified when someone @yous on github?

Just in case, https://github.com/metabrainz/musicbrainz-serve... :)

reosarevok: I do, just hadn’t gotten round to it. Thanks for the nudge!

Oh, that's ok :) Just wanted to make sure in case!

morning

Looking great btw bitmap + reosarevok!

mayhem: thanks for the review on the datasets page documents, I'm finishing a project at the uni the next few days, but will take another go at filling in the gaps

cool. should we set aside some time later this week to work on is together to drag it across the finish line?

sure, sounds good

Thursday?

friday?

thursday works too.

friday works too :) after lunch?

either after lunch works for me. pick one.

Friday after lunch

great, thanks.

mayhem, zas: regarding picard and gsoc I would be hesitant to put too much there, so I'd be fine with keeping the cover art task only. Experience from last week has shown that mentoring won't work that well for me. I struggle with finding the necessary time in between my full time job and family. As long as I can freely choose my time it's ok, but students deserve timely responses and availability, and I can't really

guarantee that :(

outsidecontext: speaking of :D did you see the email about the person who can use stuff on Win but not OSX?

outsidecontext: ok, thanks for the honest assessment. makes sense.

zas: I could co-mentor the task, but I am also not 100% convinced of this project.

reosarevok: no, had not seen the message yet. just looked at it. I can answer, I think I know what's going on

Thanks <3

reosarevok: guidelines take too long to do… I’m going to go to bed but here’s a ‘present’ for you to sweat over: https://community.metabrainz.org/t/broadcast-gu...

mayhem, zas: regarding autotag: I'm in general excited about exploring this further. the work on LB matching can help solve the issue of people wanting to tag their files against the most canonical representation of a recording. This is something requested a lot, but which is really hard to solve only client side. What I have seen so far by using my plugin the autotag approach works really well.

but I also think it shows that you can't really have one approach that fits all. autotag does not satisfy all use cases, and I actually don't think that's possible. So it makes sense for Picard to offer multiple approaches. Currently for Picard this is scan and lookup. Adding more options, tough, can also be confusing to the users (as it is already the case)

Agreed, 100%. Lucifer will work on the release name support for the mapping soon and once that is done auto tag work can continue.

I don’t think more options needs to be confusing! But UI/UX definitely needs to be considered

I agree on that sentiment too. It think auto tag should beat be considered a 'new clusting tool' for Picard.

for a long time I play with the idea that it should be possible to get much better general results also by combining the current "scan" and "lookup" approaches into a matching that takes both the audio fingerprints and the metadata into account

Oh oh oh, yes!

The core of auto tag is promising, but the added intelligence that is coming, including these things will really kick things up.

my idea was to have this combined approach as a default (hopefully giving better results for the standard user), but still offer the individual tools for people wanting to have more control. but I could also imagine autotag, depending on how well it performs, being the default

agreed, again.

once I can move autotag forward, lets chat again about how this might play out once we understand what it is capable of.

lucifer: monkey aerozol : Soon we will similar artists data, that effectively gives us a connected graph of artist relations. we've all see the artist relationship visualizations and many people have implemented them with our data. many have promising to contribute the code back to us, none have ever done that.

should we add that to the gsoc list for LB? it would be another page for the explore tab. but it doesn't fit cleanly into our roadmap of UI work for the year.

monkey: another thought -- do you think we could carve out a portion of the LB redesign as a gsoc project? sounds tricky.

I wouldn't make it a priority, even if it is enticing. Currently I don't think it's a feature that users are looking for. Maybe next year?

As for the redesign, my experience of GSOC is that design-related tasks are ill adapted

that's exactly it. its a feature we all want, but we dont need another poorly integrated page.

yeah, I suspect as much.

There are other non-design tasks in there, but they're so big they also sound like a bad idea

Sigh. I think it was a mistake to look at the beginner editors report

From the first page I found like 25 spam accounts, and while banning them, checking their IPs shows another 25+ spam accounts, and I bet while banning those some others will also be sharing other IPs with spam accounts, etc

!m reosarevok

You're doing good work, reosarevok!

Am I though, or is it a waste of time? I cannot figure it out :D

well, banning people who are making spam sounds like a good thing

!m reosarevok

You're doing good work, reosarevok!

Sure, but these are accounts who aren't active as such - they just have a spam bio

(obviously if they are making spam edits, we need to ban them)

I just don't know how much time it makes sense to spend looking at spam accounts vs waiting for an automated tool to find and ban them

(because I could be deleting spam full time and still not delete them all :( )

mayhem: Can I get your eyes on something quick? While working on the pins+love/hate page I realized the love/hate API endpoint returns a total_count of love+hate even if you're getting only love results, making it useless for pagination. I fixed it, but wondering now if it was intentional: https://github.com/metabrainz/listenbrainz-serv...

I doubt that was intentional.

OK, thanks for confirming.

[musicbrainz-server] 14reosarevok opened pull request #2841 (03master…MBS-12901): MBS-12901: Show user website and bio on the admin user views https://github.com/metabrainz/musicbrainz-serve...

yvanzo, bitmap ^ I'd love to have that added to beta / prod on next release so I can more easily deal with spammers, if you can find the time to quickly review it :)

lucifer: I finally had a breakthrough on the detuning engine design last night. have a look: https://docs.google.com/document/d/1ZvzMna-WoGQ...

alastairp: you might be interested in this as well. #notimportant

aerozol: still up?

aerozol: this was one of the few talks I wanted to attent, but it conflicted. of course. https://fosdem.org/2023/schedule/event/donation...

I think some of this knowledge can and should be applied to our donation page.

at some point, not urgent, I would like you to design us a "Support LB page, with the usual tiers that outline what you get for your support."

except it should be a bit cheeky.

param: you still about? there was a donation page that we looked at that was really cool and no matter how much you donated, you never got anything for it. Do you remember which page that was?

Hello akshaaatt I have added the rest two data to show favourite artist and total song listen in the profile.  can you review it once.

Hi rishav26 ! Thanks a lot for your swift work :) It’s great to see your motivation to work on features.

I want like us to discuss a few things before we move forward though rishav26

yeah sure bhaiya

It is evident that we require a profile screen for the user. However, we do not want to make a generic profile screen like other apps where a lot of features are available which might not be best suitable for our app

We should follow a particular standard of working together.

You found our project. You liked it, and you made an amazing PR adding a few things.

But when we are starting off with something entirely new on the project, we should discuss the scope of the features and how we might want it planned out

With respect to your profile screen PR, I love your enthusiasm but I would like us to discuss the screens and features first, before we start adding them

oh sorry for that the requirements. can you we disscuss what are the certain feature required

yeah sure bhaiya

Sure. I’m not saying we have everything planned out yet

So just for clarification, can i list out what i added in profile page, so community can know?

aerozol: is leading the designs for us. We usually make a JIRA ticket giving him our requirements, ideas for the design and when he finds the time, he gives us the figma for the screens

rishav26: sure that’s a good idea. You can discuss your ideas here with us and even on the forums community.metabrainz.org

The best way to start the thought process would be to have a look at the available APIs and make a sense of them. If you think a few more things should be added to the profile of which we do not have the data in the apis, you can contact and discuss things with lucifer

You can also explore https://listenbrainz.org/ and think what data could go in the profile page

That being said, I think we should discuss things more before moving forward with you profile page PR rishav26 . I think features like avg time spent on the app is not relevant for us right now

So its a simple profile page, in which i am getting username, email from the musicbrainz login api. after that it is giving option to put any display image, as in further app extend to follow follower model so user might need to add their profile photo, Then user can add their name. as in login i am not getting Name of user, then profile will show

5 stats out of which 3 is working, 1. weekly average time spent, 2. Favorite Artist , 3. Total song listen, Other which is not working stats are follower and following.

okay bhaiya. so we can remove weekly average time spent.

We do not storage the user profile picture anywhere rishav26

See these are the reasons why we should discuss things before

I don’t want your effort to go in vain

You’re doing a great job with the work

yess bhaiya i saw in musicbrainz server. so can i make changes so it will directly store it on server and we can get it during login.

sure i will discuss with lucifer on that

Store*

We should use the LB apis for the profile data. I’m not sure what’s making us use MB api for LB profile currently

Hi lucifer! What was the status for MeB oauth?

akshaaatt: jira ticket is already up

did it weeks back

rishav26: go through the docs i shared i have updated some stuff init

akshaaatt: made some changes to the doc check em out

rishav26: do read the contribution guidelines section in the doc

that’ll answer most of your questions

if any more doubts, you can always ask akshaaatt but just wanna say i can always help :)

akshaaatt: just wanna say I’d like to halt the profile feature for now or limit it to design part only

introducing jetpack nav will prolly cause merge conflicts

not to mention changes with the shared prefs

jasje_ : thanks for support. in shared preference only change done is email so it might not make any conflict.

rishav26: no no, the change is going to be on how we use them

about the profile i will share my figma design with aerozol

yupp have some discussion you’ll have fun working with him

feel free to leave comments on MOBILE-107

MOBILE-107: Profile page https://tickets.metabrainz.org/browse/MOBILE-107