reosarevok: I do, just hadn’t gotten round to it. Thanks for the nudge!
2023-02-14 04527, 2023
reosarevok
Oh, that's ok :) Just wanted to make sure in case!
2023-02-14 04559, 2023
alastairp
morning
2023-02-14 04539, 2023
aerozol
Looking great btw bitmap + reosarevok!
2023-02-14 04515, 2023
alastairp
mayhem: thanks for the review on the datasets page documents, I'm finishing a project at the uni the next few days, but will take another go at filling in the gaps
2023-02-14 04548, 2023
mayhem
cool. should we set aside some time later this week to work on is together to drag it across the finish line?
2023-02-14 04556, 2023
alastairp
sure, sounds good
2023-02-14 04515, 2023
alastairp
Thursday?
2023-02-14 04517, 2023
mayhem
friday?
2023-02-14 04522, 2023
mayhem
thursday works too.
2023-02-14 04531, 2023
alastairp
friday works too :) after lunch?
2023-02-14 04542, 2023
mayhem
either after lunch works for me. pick one.
2023-02-14 04548, 2023
alastairp
Friday after lunch
2023-02-14 04554, 2023
mayhem
great, thanks.
2023-02-14 04538, 2023
outsidecontext
mayhem, zas: regarding picard and gsoc I would be hesitant to put too much there, so I'd be fine with keeping the cover art task only. Experience from last week has shown that mentoring won't work that well for me. I struggle with finding the necessary time in between my full time job and family. As long as I can freely choose my time it's ok, but students deserve timely responses and availability, and I can't really
2023-02-14 04538, 2023
outsidecontext
guarantee that :(
2023-02-14 04518, 2023
reosarevok
outsidecontext: speaking of :D did you see the email about the person who can use stuff on Win but not OSX?
2023-02-14 04533, 2023
mayhem
outsidecontext: ok, thanks for the honest assessment. makes sense.
2023-02-14 04550, 2023
mayhem
zas: I could co-mentor the task, but I am also not 100% convinced of this project.
2023-02-14 04555, 2023
outsidecontext
reosarevok: no, had not seen the message yet. just looked at it. I can answer, I think I know what's going on
mayhem, zas: regarding autotag: I'm in general excited about exploring this further. the work on LB matching can help solve the issue of people wanting to tag their files against the most canonical representation of a recording. This is something requested a lot, but which is really hard to solve only client side. What I have seen so far by using my plugin the autotag approach works really well.
2023-02-14 04536, 2023
outsidecontext
but I also think it shows that you can't really have one approach that fits all. autotag does not satisfy all use cases, and I actually don't think that's possible. So it makes sense for Picard to offer multiple approaches. Currently for Picard this is scan and lookup. Adding more options, tough, can also be confusing to the users (as it is already the case)
2023-02-14 04544, 2023
mayhem
Agreed, 100%. Lucifer will work on the release name support for the mapping soon and once that is done auto tag work can continue.
2023-02-14 04525, 2023
aerozol
I don’t think more options needs to be confusing! But UI/UX definitely needs to be considered
2023-02-14 04542, 2023
mayhem
I agree on that sentiment too. It think auto tag should beat be considered a 'new clusting tool' for Picard.
2023-02-14 04543, 2023
outsidecontext
for a long time I play with the idea that it should be possible to get much better general results also by combining the current "scan" and "lookup" approaches into a matching that takes both the audio fingerprints and the metadata into account
2023-02-14 04506, 2023
mayhem
Oh oh oh, yes!
2023-02-14 04558, 2023
mayhem
The core of auto tag is promising, but the added intelligence that is coming, including these things will really kick things up.
2023-02-14 04543, 2023
outsidecontext
my idea was to have this combined approach as a default (hopefully giving better results for the standard user), but still offer the individual tools for people wanting to have more control. but I could also imagine autotag, depending on how well it performs, being the default
2023-02-14 04546, 2023
mayhem
agreed, again.
2023-02-14 04511, 2023
mayhem
once I can move autotag forward, lets chat again about how this might play out once we understand what it is capable of.
2023-02-14 04532, 2023
mayhem
lucifer: monkey aerozol : Soon we will similar artists data, that effectively gives us a connected graph of artist relations. we've all see the artist relationship visualizations and many people have implemented them with our data. many have promising to contribute the code back to us, none have ever done that.
2023-02-14 04513, 2023
mayhem
should we add that to the gsoc list for LB? it would be another page for the explore tab. but it doesn't fit cleanly into our roadmap of UI work for the year.
2023-02-14 04540, 2023
mayhem
monkey: another thought -- do you think we could carve out a portion of the LB redesign as a gsoc project? sounds tricky.
2023-02-14 04515, 2023
monkey
I wouldn't make it a priority, even if it is enticing. Currently I don't think it's a feature that users are looking for. Maybe next year?
2023-02-14 04540, 2023
monkey
As for the redesign, my experience of GSOC is that design-related tasks are ill adapted
2023-02-14 04546, 2023
mayhem
that's exactly it. its a feature we all want, but we dont need another poorly integrated page.
2023-02-14 04503, 2023
mayhem
yeah, I suspect as much.
2023-02-14 04512, 2023
monkey
There are other non-design tasks in there, but they're so big they also sound like a bad idea
2023-02-14 04553, 2023
reosarevok
Sigh. I think it was a mistake to look at the beginner editors report
2023-02-14 04531, 2023
reosarevok
From the first page I found like 25 spam accounts, and while banning them, checking their IPs shows another 25+ spam accounts, and I bet while banning those some others will also be sharing other IPs with spam accounts, etc
2023-02-14 04508, 2023
alastairp
!m reosarevok
2023-02-14 04508, 2023
BrainzBot
You're doing good work, reosarevok!
2023-02-14 04528, 2023
reosarevok
Am I though, or is it a waste of time? I cannot figure it out :D
2023-02-14 04546, 2023
alastairp
well, banning people who are making spam sounds like a good thing
2023-02-14 04549, 2023
aerozol
!m reosarevok
2023-02-14 04549, 2023
BrainzBot
You're doing good work, reosarevok!
2023-02-14 04557, 2023
reosarevok
Sure, but these are accounts who aren't active as such - they just have a spam bio
2023-02-14 04507, 2023
reosarevok
(obviously if they are making spam edits, we need to ban them)
2023-02-14 04530, 2023
reosarevok
I just don't know how much time it makes sense to spend looking at spam accounts vs waiting for an automated tool to find and ban them
2023-02-14 04546, 2023
reosarevok
(because I could be deleting spam full time and still not delete them all :( )
2023-02-14 04544, 2023
monkey
mayhem: Can I get your eyes on something quick? While working on the pins+love/hate page I realized the love/hate API endpoint returns a total_count of love+hate even if you're getting only love results, making it useless for pagination. I fixed it, but wondering now if it was intentional: https://github.com/metabrainz/listenbrainz-server…
yvanzo, bitmap ^ I'd love to have that added to beta / prod on next release so I can more easily deal with spammers, if you can find the time to quickly review it :)
I think some of this knowledge can and should be applied to our donation page.
2023-02-14 04552, 2023
mayhem
at some point, not urgent, I would like you to design us a "Support LB page, with the usual tiers that outline what you get for your support."
2023-02-14 04504, 2023
mayhem
except it should be a bit cheeky.
2023-02-14 04551, 2023
mayhem
param: you still about? there was a donation page that we looked at that was really cool and no matter how much you donated, you never got anything for it. Do you remember which page that was?
2023-02-14 04553, 2023
rishav26 joined the channel
2023-02-14 04509, 2023
rishav26
Hello akshaaatt I have added the rest two data to show favourite artist and total song listen in the profile. can you review it once.
2023-02-14 04530, 2023
akshaaatt
Hi rishav26 ! Thanks a lot for your swift work :) It’s great to see your motivation to work on features.
2023-02-14 04552, 2023
akshaaatt
I want like us to discuss a few things before we move forward though rishav26
2023-02-14 04502, 2023
rishav26
yeah sure bhaiya
2023-02-14 04502, 2023
akshaaatt
It is evident that we require a profile screen for the user. However, we do not want to make a generic profile screen like other apps where a lot of features are available which might not be best suitable for our app
2023-02-14 04537, 2023
akshaaatt
We should follow a particular standard of working together.
2023-02-14 04527, 2023
akshaaatt
You found our project. You liked it, and you made an amazing PR adding a few things.
2023-02-14 04558, 2023
akshaaatt
But when we are starting off with something entirely new on the project, we should discuss the scope of the features and how we might want it planned out
2023-02-14 04507, 2023
akshaaatt
With respect to your profile screen PR, I love your enthusiasm but I would like us to discuss the screens and features first, before we start adding them
2023-02-14 04526, 2023
rishav26
oh sorry for that the requirements. can you we disscuss what are the certain feature required
2023-02-14 04538, 2023
rishav26
yeah sure bhaiya
2023-02-14 04545, 2023
akshaaatt
Sure. I’m not saying we have everything planned out yet
2023-02-14 04536, 2023
rishav26
So just for clarification, can i list out what i added in profile page, so community can know?
2023-02-14 04553, 2023
akshaaatt
aerozol: is leading the designs for us. We usually make a JIRA ticket giving him our requirements, ideas for the design and when he finds the time, he gives us the figma for the screens
2023-02-14 04537, 2023
akshaaatt
rishav26: sure that’s a good idea. You can discuss your ideas here with us and even on the forums community.metabrainz.org
2023-02-14 04518, 2023
akshaaatt
The best way to start the thought process would be to have a look at the available APIs and make a sense of them. If you think a few more things should be added to the profile of which we do not have the data in the apis, you can contact and discuss things with lucifer
That being said, I think we should discuss things more before moving forward with you profile page PR rishav26 . I think features like avg time spent on the app is not relevant for us right now
2023-02-14 04538, 2023
rishav26
So its a simple profile page, in which i am getting username, email from the musicbrainz login api. after that it is giving option to put any display image, as in further app extend to follow follower model so user might need to add their profile photo, Then user can add their name. as in login i am not getting Name of user, then profile will show
2023-02-14 04538, 2023
rishav26
5 stats out of which 3 is working, 1. weekly average time spent, 2. Favorite Artist , 3. Total song listen, Other which is not working stats are follower and following.
2023-02-14 04501, 2023
rishav26
okay bhaiya. so we can remove weekly average time spent.
2023-02-14 04538, 2023
akshaaatt
We do not storage the user profile picture anywhere rishav26
2023-02-14 04551, 2023
akshaaatt
See these are the reasons why we should discuss things before
2023-02-14 04501, 2023
akshaaatt
I don’t want your effort to go in vain
2023-02-14 04510, 2023
akshaaatt
You’re doing a great job with the work
2023-02-14 04520, 2023
jivte joined the channel
2023-02-14 04559, 2023
rishav26
yess bhaiya i saw in musicbrainz server. so can i make changes so it will directly store it on server and we can get it during login.
2023-02-14 04518, 2023
rishav26
sure i will discuss with lucifer on that
2023-02-14 04536, 2023
akshaaatt
Store*
2023-02-14 04524, 2023
akshaaatt
We should use the LB apis for the profile data. I’m not sure what’s making us use MB api for LB profile currently
2023-02-14 04540, 2023
akshaaatt
Hi lucifer! What was the status for MeB oauth?
2023-02-14 04523, 2023
jasje_ joined the channel
2023-02-14 04539, 2023
jasje_
akshaaatt: jira ticket is already up
2023-02-14 04558, 2023
jasje_
did it weeks back
2023-02-14 04519, 2023
jasje_
rishav26: go through the docs i shared i have updated some stuff init
2023-02-14 04539, 2023
jasje_
akshaaatt: made some changes to the doc check em out
2023-02-14 04503, 2023
jasje_
rishav26: do read the contribution guidelines section in the doc
2023-02-14 04514, 2023
jasje_
that’ll answer most of your questions
2023-02-14 04516, 2023
jasje_
if any more doubts, you can always ask akshaaatt but just wanna say i can always help :)
2023-02-14 04549, 2023
jasje_
akshaaatt: just wanna say I’d like to halt the profile feature for now or limit it to design part only
2023-02-14 04511, 2023
jasje_
introducing jetpack nav will prolly cause merge conflicts
2023-02-14 04537, 2023
jasje_
not to mention changes with the shared prefs
2023-02-14 04531, 2023
rishav26
jasje_ : thanks for support. in shared preference only change done is email so it might not make any conflict.
2023-02-14 04554, 2023
jasje_
rishav26: no no, the change is going to be on how we use them
2023-02-14 04509, 2023
rishav26
about the profile i will share my figma design with aerozol
2023-02-14 04512, 2023
jasje_
yupp have some discussion you’ll have fun working with him