ok, well, if I need to move meb to flask 2, then I'll do that.
2023-02-16 04746, 2023
mayhem
with click 8.1.3 those deps install ok for me.
2023-02-16 04727, 2023
reosarevok
bitmap, yvanzo: I wonder if now that the new relationship editor collapses big lists of rels of the same type it would make sense to get rid of cardinality restrictions on the /edit pages, or at least be less conservative with which rels have many to one cardinality? (related, MBS-12905)
I guess it still makes sense not to show every recording of a place when editing a place though, so maybe the answer is "review what stuff has many-to-one set, and change any edge cases one-to-one now that we don't need to be so worried about it but leave the obvious cases as many-to-one"?
2023-02-16 04712, 2023
lucifer
mayhem: you'll also need to update flask-login to 0.6.2
2023-02-16 04733, 2023
mayhem
I've updated just about all flask related bits, still no luck.
2023-02-16 04733, 2023
lucifer
what error do you get?
2023-02-16 04756, 2023
mayhem
dependencies issues mostly.
2023-02-16 04715, 2023
lucifer
can you push your current changes? i'll take a look
you'll need to make some changes to click commands though.
2023-02-16 04757, 2023
mayhem
ok, let me do that.
2023-02-16 04759, 2023
lucifer
newer click versions, substitute `_` with `-`. so replace all usages of `init_db` with `init-db` so on.
2023-02-16 04720, 2023
lucifer
alternatively, modify the commands to explicitly specify the underscore name.
2023-02-16 04714, 2023
mayhem
do you know if code changes for flask 2.x are needed?
2023-02-16 04736, 2023
lucifer
probably not.
2023-02-16 04751, 2023
mayhem
ok, I'll keep on going then.
2023-02-16 04753, 2023
mayhem
thx
2023-02-16 04706, 2023
mayhem
so far only two tests have failed, so looks promising
2023-02-16 04754, 2023
mayhem
of course those test failures don't appear to be our fault, so lol.
2023-02-16 04719, 2023
yvanzo
reosarevok, cc bitmap: Yes, it would be helpful to document which (entity) types of relationships are hidden from which editing form and for which reason. There are likely some cases that are not longer justified.
Being able to edit the relationship credit for urls on both sides rather than just the url side
2023-02-16 04725, 2023
reosarevok
And yes, the relationship editor has never blocked adding any supported relationships, even if they are not usually visible there
2023-02-16 04726, 2023
yvanzo
Yes, but has there been any credit on URL relationship so far? What would it be used for?
2023-02-16 04752, 2023
reosarevok
That's useful at least for when you're adding a work and want to link several recordings in one go when adding it
2023-02-16 04702, 2023
reosarevok
It doesn't credit the url
2023-02-16 04708, 2023
reosarevok
It credits the other entity
2023-02-16 04724, 2023
reosarevok
So, this artist has a discogs page under name X or whatever
2023-02-16 04736, 2023
yvanzo
I understood that, I still don’t see the purpose.
2023-02-16 04747, 2023
reosarevok
If nothing else, merges set those sometimes so we should be able to remove them
2023-02-16 04716, 2023
reosarevok
But I know people use them for cases like "discogs has a page for legal name and one for artist name but we have one for both"
2023-02-16 04722, 2023
yvanzo
“That's useful at least for when you're adding a work and want to link several recordings in one go when adding it” how is it related to URL?
2023-02-16 04750, 2023
reosarevok
That one was for your previous question of relationship editors, sorry for the mixed answers :)
2023-02-16 04725, 2023
yvanzo
Now I’m not sure what answered to what...
2023-02-16 04715, 2023
reosarevok
Ok
2023-02-16 04731, 2023
reosarevok
To: "It is weird that a series can be linked from a label editing form which isn’t loading series."
2023-02-16 04758, 2023
reosarevok
"Yes, the relationship editor has never blocked adding any supported relationships, even if they are not usually visible there. That's useful at least for when you're adding a work and want to link several recordings in one go when adding it"
2023-02-16 04704, 2023
reosarevok
Everything else is about the urls
2023-02-16 04737, 2023
yvanzo
That’s useful but it might end up with duplicates.
2023-02-16 04751, 2023
yvanzo
about series-label ^
2023-02-16 04727, 2023
reosarevok
Well, it's not impossible
2023-02-16 04744, 2023
reosarevok
I wouldn't mind if the system had a way to load the stuff already there when you try to add new ones
2023-02-16 04707, 2023
reosarevok
But mostly if they're real duplicates the backend will ignore the edit
mayhem: considering LB#2344 is not ready for merging yet, if you still want to help with deploying LB I think we should do it now, and deploy again once 2344 is properly finished.
Huh, actually for that merge the edit history doesn't have any performers either, so unless it lost *all the edit history* too, then there probably wasn't any performer to begin with...
2023-02-16 04708, 2023
yvanzo
@All: Updating Jira app at :25
2023-02-16 04716, 2023
yvanzo
Done
2023-02-16 04756, 2023
reosarevok
Thanks!
2023-02-16 04746, 2023
bitmap
reosarevok: we could check the replication packet to be sure
2023-02-16 04726, 2023
reosarevok
bitmap: I haven't ever tried that - wanna do it and document it? :D
2023-02-16 04745, 2023
reosarevok
Also, hi, yvanzo, bitmap. Forgot the time, whoops :)
