#metabrainz

burgess has NO music released in his name. Godfrey, has two releases from 1994 and 2007.

I can't see how burgess is listed at all. And I feel that godfrey should not be so high up in the list.

somehow, I think godfrey is rising to the top because he is half of Morcheeba.

thoughts?

bitmap: yeah, can reproduce

aight, I'll let you know once it's deployed on test

Ok :) Why does it make sense to add a cancelled option to this useEffect but not the next one btw?

[musicbrainz-server] 14mwiencek merged pull request #2849 (03master…mbs-12915): MBS-12915: Default to 'artist' in the add-relationship dialog https://github.com/metabrainz/musicbrainz-serve...

reosarevok: we probably should define one for both

for that one we can just call clearTimeout

Maybe you should have a second commit to add cancelled then? (esp. if that's not required for the fix)

But dunno :)

sure

Huh

I got the same failure as you did earlier

can't reproduce that one

Yeah, it passed locally every time

I'm not sure why it's a problem there

there's another heisenbug in https://github.com/metabrainz/musicbrainz-serve... which went away when I spun up a tests container and ran them manually

reosarevok: Is there a reason for using DescriptiveLink rather than EntityLink in Relationship component?

lucifer: I deployed LB#2362 on test.LB which contains the frontend changes Youtube required for quota approval. Towards the end of my testing we ran out of quota, ironically, but I used a personal API key to finish testing it. No more autoplay, and no more button to minimize the window. I'm going to merge it, and was wondering if you could 1. deploy to prod and 2. follow up with Youtube and let them know we implemented their requirements?

Youtube player: remove autoplay and minimize features: https://github.com/metabrainz/listenbrainz-serv...

+that

reosarevok: the android fix has been deployed on test.mb if you have a moment to try it

yvanzo: IIRC so we get stuff like area containment and artist credits

In the preview

Or where do you mean?

Yes

Then yeah, to get better previews

Is there a problem derived from that?

Not really, I’m just looking at possible causes.

mayhem: when opening that link, i don't see burgess?

on https://labs.api.listenbrainz.org/similar-artis...

bitmap: looking at beta sentry issues, any idea what might have caused this one? https://sentry.metabrainz.org/organizations/met...

bitmap: also https://sentry.metabrainz.org/organizations/met... is confusing to me (loading the same page with the same seeded artist works for me rn in beta)

the second error happens on POST, not GET

you can reproduce it by entering a work name and hitting submit (without modifying the seeded rel at all)

mayhem: i am not sure. what's going on. will try to debug

ok, at least I can explain what I am seeing now. :)

[musicbrainz-android] 14dependabot[bot] opened pull request #203 (03master…dependabot/gradle/com.airbnb.android-lottie-compose-6.0.0): Bump com.airbnb.android:lottie-compose from 5.2.0 to 6.0.0 https://github.com/metabrainz/musicbrainz-andro...

[musicbrainz-android] 14dependabot[bot] opened pull request #204 (03master…dependabot/gradle/com.airbnb.android-lottie-6.0.0): Bump com.airbnb.android:lottie from 5.2.0 to 6.0.0 https://github.com/metabrainz/musicbrainz-andro...

[listenbrainz-server] 14MonkeyDo merged pull request #2362 (03master…remove-youtube-player-minimize): Youtube player: remove autoplay and minimize features https://github.com/metabrainz/listenbrainz-serv...

bitmap: oh, huh, wait, why do we even allow to submit with an error active?

idk but the code the disable the submit button is a mess/still using knockout so probably is completely broken in this case

Sigh

So what's the suggested fix here? A check to error more nicely if no type is set for a rel I guess?

I'll make a ticket

yeah I feel like we're missing some kind of validation on Form::Field::Relationship

Added MBS-12930 then

MBS-12930: Beta: Seeded rel with no type set can be submit, ISEs https://tickets.metabrainz.org/browse/MBS-12930

Will try to figure it out

Just found out that the sort name is correctly shown on hover for artist only in release preview.

There is just no sort name for other entity types.

Yeah, that seems correct

But don't we still show the original name elsewhere for name variations?

We should probably have a second line with ... credited as ... like in edit display.

monkey: will do

Fanks :)

reosarevok: not under preview

We do elsewhere - maybe that's connected with chaban's comment of it being missing name-variation

We should still show it on hover there

We do in edit pages.

Like we do for "Hate" in the AC of https://beta.musicbrainz.org/recording/f71297ea...

I think that's just a bug, in any case, not an intentional difference

So MBS-12917 should still be worked on :)

MBS-12917: Beta: Credits tooltip is missing but for artist in relationship preview https://tickets.metabrainz.org/browse/MBS-12917

I didn’t say otherwise

Ok, I was wondering because of the "We should probably have a second line with ... credited as ... like in edit display." bit

My bad then

No just that the text being displayed is the sort name, not the original name.

FWIW, I don't think we need a separate line for credits there if we have the hover, because we already have the credited-as text fields in the same form :)

It happens that in many case, the sort name is the same as the artist name.

Yeah, sure. IIRC it should display both, if the sortname is different *and* is a variation :)

It display both in edit pages, and elsewhere too as in your example.

[bookbrainz-site] 14MonkeyDo opened pull request #932 (03master…update-redis): chore: Update redis package to v4 https://github.com/metabrainz/bookbrainz-site/p...

iirc it worked in the previews at some point, so may have been broken recently

bitmap: adding this seems to work:

On Form::Field::Relationship

Although the added error is not being displayed - the page reloads and shows again "You must select a relationship type and target entity for every relationship"

But I guess that's also fine, dunno

Heh. That said, I found a way to trigger

yeah I figured it wouldn't show the message

but maybe the validation should also check the target too and use the same message

I guess

I'll add a second ticket for the invariant error I guess

Oh

wtf

I can reproduce the invariant locally but not on beta

how do you reproduce it?

hmm, well if it's the one invariant in compareRelationships that one only runs in __DEV__, so wouldn't trigger on beta

Oh

That'd be it I guess

By adding a new relationship with the + button on a relationship that has no type set yet

oic. still a bug in development at least

But can it cause issues elsewhere then? (not sure why we have this invariant but only on dev)

I might've been using it to debug something locally before

afaict one of the link types is 0 and the other is null, so the check fails. I'm not certain it won't cause other issues, but also might be fine

Any idea about the cannot-reproduce-locally issue in the perl test in https://github.com/metabrainz/musicbrainz-serve... anyway?

I'm guessing the ORDER BY in find_by_instrument is not deterministic. I'll try to improve it

Thanks

mayhem: is your topic still relevant?

[bookbrainz-site] release 03v-2023-02-20.0 has been published by 14MonkeyDo: https://github.com/metabrainz/bookbrainz-site/r...

bitmap: added MBS-12931 for the invariant thing, not sure how to mark it's dev only or whether it matters

MBS-12931: Beta: Invariant Violation on adding rel with + from no-type rel https://tickets.metabrainz.org/browse/MBS-12931

yes, lets keep it, just to follow up. then we can nuke it.

[musicbrainz-server] 14reosarevok opened pull request #2854 (03master…MBS-12930): MBS-12930: Validate relationship fields on Perl level https://github.com/metabrainz/musicbrainz-serve...

👍

bitmap: I'm going to assume MBS-12923 is a fairly trivial fix?

MBS-12923: Beta: Relationship editor stuck when "You haven’t made any changes!" https://tickets.metabrainz.org/browse/MBS-12923

(to make it stop "Submitting edits" if there's no edits)

seems like it should be

Just add submissionInProgress.current = false; to the catch?

Or after the try/catch?

I don't think this will affect the release relationship editor (isn't that what the ticket is about?)

Hmm

But root/static/scripts/release/components/ReleaseRelationshipEditor.js does not itself set submissionInProgress anywhere AFAICT, that's why I thought it'd be here :)

Guess not

Oh, it's with start-submission and stop-submission in the dispatch

yeah since it has a loading spinner and whatnot

So just dispatch({type: 'stop-submission'}); at the end of submitEdits I guess

Since it seems to recover the submit button after the alert then, and also to not cause issues if I *do* add a rel

sounds right to me

I guess the closest to an issue might be that it also re-enables the button while the user waits to be sent to the release page

Not sure that is a problem in any way though

Going to go with "not really"

well it shouldn't be a problem if it's re-enabled and they hit submit again somehow in that fraction of a second, since the edits can't be re-submitted

it updates all the relationships to their submitted state

reosarevok: I suppose sometimes you do want to add stuff twice, but not in the case of 'recording of'? I think? I don't see any prompt when I do that, just nothing happens when I click 'done'. When the search then rearranges it's pretty next level (next level annoying)

Guidelines after the meeting then reo? ;)

Even in that case, really

("the track includes a live recording of the song on day X, then silence, then a live recording of the song on day Y)

*")

I mean, it's a big edge case, but it's certainly not impossible

Or just twice in different order (so a medley of X, then Y, then X again)

That's not even such an edge case :)

reosarevok: tests pass on https://github.com/metabrainz/musicbrainz-serve... now so I'll merge per your comment

[musicbrainz-server] 14mwiencek merged pull request #2851 (03master…mbs-12921): MBS-12921: Can't search for works in the "Add related work" dialog https://github.com/metabrainz/musicbrainz-serve...