reosarevok: Is there a reason for using DescriptiveLink rather than EntityLink in Relationship component?
2023-02-20 05149, 2023
monkey
lucifer: I deployed LB#2362 on test.LB which contains the frontend changes Youtube required for quota approval. Towards the end of my testing we ran out of quota, ironically, but I used a personal API key to finish testing it. No more autoplay, and no more button to minimize the window. I'm going to merge it, and was wondering if you could 1. deploy to prod and 2. follow up with Youtube and let them know we implemented their requirements?
I'm not sure about the first one but it seems to imply the external links editor component was unmounted somehow
2023-02-20 05103, 2023
bitmap
the second error happens on POST, not GET
2023-02-20 05123, 2023
bitmap
you can reproduce it by entering a work name and hitting submit (without modifying the seeded rel at all)
2023-02-20 05128, 2023
lucifer
mayhem: i am not sure. what's going on. will try to debug
2023-02-20 05156, 2023
mayhem
ok, at least I can explain what I am seeing now. :)
2023-02-20 05109, 2023
BrainzGit
[musicbrainz-android] 14dependabot[bot] opened pull request #203 (03master…dependabot/gradle/com.airbnb.android-lottie-compose-6.0.0): Bump com.airbnb.android:lottie-compose from 5.2.0 to 6.0.0 https://github.com/metabrainz/musicbrainz-android…
2023-02-20 05127, 2023
BrainzGit
[musicbrainz-android] 14dependabot[bot] opened pull request #204 (03master…dependabot/gradle/com.airbnb.android-lottie-6.0.0): Bump com.airbnb.android:lottie from 5.2.0 to 6.0.0 https://github.com/metabrainz/musicbrainz-android…
2023-02-20 05159, 2023
BrainzGit
[listenbrainz-server] 14MonkeyDo merged pull request #2362 (03master…remove-youtube-player-minimize): Youtube player: remove autoplay and minimize features https://github.com/metabrainz/listenbrainz-server…
2023-02-20 05157, 2023
reosarevok
bitmap: oh, huh, wait, why do we even allow to submit with an error active?
2023-02-20 05159, 2023
bitmap
idk but the code the disable the submit button is a mess/still using knockout so probably is completely broken in this case
2023-02-20 05113, 2023
reosarevok
Sigh
2023-02-20 05137, 2023
reosarevok
So what's the suggested fix here? A check to error more nicely if no type is set for a rel I guess?
2023-02-20 05102, 2023
reosarevok
I'll make a ticket
2023-02-20 05147, 2023
bitmap
yeah I feel like we're missing some kind of validation on Form::Field::Relationship
Ok, I was wondering because of the "We should probably have a second line with ... credited as ... like in edit display." bit
2023-02-20 05114, 2023
reosarevok
My bad then
2023-02-20 05133, 2023
yvanzo
No just that the text being displayed is the sort name, not the original name.
2023-02-20 05150, 2023
reosarevok
FWIW, I don't think we need a separate line for credits there if we have the hover, because we already have the credited-as text fields in the same form :)
2023-02-20 05154, 2023
yvanzo
It happens that in many case, the sort name is the same as the artist name.
2023-02-20 05110, 2023
reosarevok
Yeah, sure. IIRC it should display both, if the sortname is different *and* is a variation :)
2023-02-20 05137, 2023
yvanzo
It display both in edit pages, and elsewhere too as in your example.
Although the added error is not being displayed - the page reloads and shows again "You must select a relationship type and target entity for every relationship"
I'm guessing the ORDER BY in find_by_instrument is not deterministic. I'll try to improve it
2023-02-20 05144, 2023
reosarevok
Thanks
2023-02-20 05155, 2023
TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | BookBrainz: #bookbrainz | Channel is logged; see https://musicbrainz.org/doc/IRC for details | Agenda: Reviews, GSoC ideas pages (mayhem)
Just add submissionInProgress.current = false; to the catch?
2023-02-20 05118, 2023
reosarevok
Or after the try/catch?
2023-02-20 05150, 2023
Tanmay joined the channel
2023-02-20 05113, 2023
bitmap
I don't think this will affect the release relationship editor (isn't that what the ticket is about?)
2023-02-20 05107, 2023
reosarevok
Hmm
2023-02-20 05129, 2023
reosarevok
But root/static/scripts/release/components/ReleaseRelationshipEditor.js does not itself set submissionInProgress anywhere AFAICT, that's why I thought it'd be here :)
2023-02-20 05131, 2023
reosarevok
Guess not
2023-02-20 05151, 2023
reosarevok
Oh, it's with start-submission and stop-submission in the dispatch
2023-02-20 05125, 2023
bitmap
yeah since it has a loading spinner and whatnot
2023-02-20 05122, 2023
reosarevok
So just dispatch({type: 'stop-submission'}); at the end of submitEdits I guess
2023-02-20 05113, 2023
reosarevok
Since it seems to recover the submit button after the alert then, and also to not cause issues if I *do* add a rel
2023-02-20 05127, 2023
bitmap
sounds right to me
2023-02-20 05128, 2023
reosarevok
I guess the closest to an issue might be that it also re-enables the button while the user waits to be sent to the release page
2023-02-20 05135, 2023
reosarevok
Not sure that is a problem in any way though
2023-02-20 05139, 2023
reosarevok
Going to go with "not really"
2023-02-20 05138, 2023
bitmap
well it shouldn't be a problem if it's re-enabled and they hit submit again somehow in that fraction of a second, since the edits can't be re-submitted
2023-02-20 05102, 2023
bitmap
it updates all the relationships to their submitted state
2023-02-20 05125, 2023
aerozol
reosarevok: I suppose sometimes you do want to add stuff twice, but not in the case of 'recording of'? I think? I don't see any prompt when I do that, just nothing happens when I click 'done'. When the search then rearranges it's pretty next level (next level annoying)
2023-02-20 05153, 2023
aerozol
Guidelines after the meeting then reo? ;)
2023-02-20 05124, 2023
reosarevok
Even in that case, really
2023-02-20 05149, 2023
reosarevok
("the track includes a live recording of the song on day X, then silence, then a live recording of the song on day Y)
2023-02-20 05151, 2023
reosarevok
*")
2023-02-20 05100, 2023
reosarevok
I mean, it's a big edge case, but it's certainly not impossible
2023-02-20 05119, 2023
reosarevok
Or just twice in different order (so a medley of X, then Y, then X again)
