15:09 PM
shelly
mayhem: What is your suggested way of debugging in listenbrainz frontend ?
2023-02-28 05955, 2023
15:09 PM
lucifer
shelly: what error do you get when you try to console.log?
2023-02-28 05917, 2023
15:10 PM
mayhem
if what you are debugging is react code, I would install the react dev plugins for your browser.
2023-02-28 05926, 2023
15:10 PM
shelly
lucifer: I don't get any error of sorts
2023-02-28 05952, 2023
15:11 PM
lucifer
okay if you push the code to github, can take a look at what's going on.
2023-02-28 05901, 2023
15:13 PM
lucifer
mayhem: LB#2370. if you could review it soon, i'll do another release.
2023-02-28 05902, 2023
15:13 PM
BrainzBot
2023-02-28 05909, 2023
15:13 PM
yvanzo
reosarevok: I’m starting to update cron containers.
2023-02-28 05922, 2023
15:13 PM
Rishika joined the channel
2023-02-28 05950, 2023
15:13 PM
Rishika
from where the data comes into the application
2023-02-28 05954, 2023
15:15 PM
lucifer
mayhem: i see one issue with that mockup. the for you data isn't calculated for arbitrary ranges which that selector allows to choose.
2023-02-28 05902, 2023
15:16 PM
shelly
2023-02-28 05930, 2023
15:16 PM
lucifer
Rishika: assuming you mean the fresh releases data, we have apis available for that and those are already integrated in the code.
2023-02-28 05947, 2023
15:16 PM
lucifer
you'll probably only need to do the ui parts.
2023-02-28 05955, 2023
15:16 PM
lucifer
have you checked out the existing page?
2023-02-28 05922, 2023
15:17 PM
Rishika
yes
2023-02-28 05949, 2023
15:17 PM
monkey
mayhem:
2023-02-28 05952, 2023
15:17 PM
monkey
background: linear-gradient(0.36deg, rgba(53, 48, 112, 0.8) 0.42%, rgba(53, 48, 112, 0.1) 99.8%);
2023-02-28 05915, 2023
15:18 PM
Rishika has quit
2023-02-28 05934, 2023
15:18 PM
Rishika joined the channel
2023-02-28 05934, 2023
15:18 PM
Rishika
how am I expected to contribute, I'm really excited to be a part
2023-02-28 05940, 2023
15:21 PM
lucifer
shelly: that seems like it should work. maybe some caching issue so the isn't getting updated, try in incognito or clearing cache. also is the static builder container yp.
2023-02-28 05919, 2023
15:22 PM
rudraksh[m] joined the channel
2023-02-28 05920, 2023
15:22 PM
lucifer
although you just want to view the state in this case so you should try using the dev plugins as mayhem suggested.
2023-02-28 05957, 2023
15:22 PM
lucifer
Rishika: first of setup the webserver locally and then the find a ticket to work on and get familiar with the codebase.
2023-02-28 05913, 2023
15:24 PM
shelly
lucifer: i am using react dev tools plugin but I wanted to know how the data is aggregated. I will try what you suggested
2023-02-28 05905, 2023
15:25 PM
bitmap
yvanzo: reosarevok: I'm around now, can I help with anything?
2023-02-28 05930, 2023
15:26 PM
shelly
2023-02-28 05933, 2023
15:26 PM
Rishika
lucifer I'm checking with it
2023-02-28 05921, 2023
15:27 PM
BrainzGit
2023-02-28 05921, 2023
15:27 PM
yvanzo
hi bitmap: reosarevok is trying a quickfix for MBS-12946, do you think that we should merge your two last PRs at the same time?
2023-02-28 05922, 2023
15:27 PM
BrainzBot
2023-02-28 05925, 2023
15:27 PM
reosarevok
bitmap: ^
2023-02-28 05950, 2023
15:27 PM
reosarevok
I think that's the best solution, but happy with alternative ones if you have better ideas
2023-02-28 05917, 2023
15:28 PM
reosarevok
I'll take the time to have a quick dinner, BIAB
2023-02-28 05928, 2023
15:28 PM
reosarevok
Feel free to take over that branch as needed
2023-02-28 05947, 2023
15:28 PM
Rishika has quit
2023-02-28 05949, 2023
15:30 PM
yvanzo
I updated cron/dump containers already, and I’m wrestling with the blog post editor atm.
2023-02-28 05919, 2023
15:35 PM
Rishika joined the channel
2023-02-28 05945, 2023
15:35 PM
Rishika
2023-02-28 05945, 2023
15:35 PM
BrainzBot
LB-1216: Exporting playlists to Spotify fails with some playlists
2023-02-28 05930, 2023
15:36 PM
JasjeetSingh[m] joined the channel
2023-02-28 05909, 2023
15:40 PM
Rishika has quit
2023-02-28 05909, 2023
15:41 PM
monkey
2023-02-28 05915, 2023
15:41 PM
monkey
In the preferences of the devtools
2023-02-28 05921, 2023
15:44 PM
Rishika joined the channel
2023-02-28 05905, 2023
15:45 PM
Rishika
2023-02-28 05925, 2023
15:46 PM
kepstin joined the channel
2023-02-28 05934, 2023
15:49 PM
jivte has quit
2023-02-28 05955, 2023
15:49 PM
elomatreb[m] joined the channel
2023-02-28 05945, 2023
15:50 PM
bitmap
yvanzo: my two PRs are mostly just to avoid Sentry spam (I think we may start seeing 10x more of the EntityLink ones once production is deployed)
2023-02-28 05900, 2023
15:51 PM
bitmap
so it might be a good idea to deploy that one at least
2023-02-28 05916, 2023
15:52 PM
sol[m] joined the channel
2023-02-28 05907, 2023
15:53 PM
yvanzo
I know it is just for that but we managed to break pages like this before :)
2023-02-28 05904, 2023
15:54 PM
yvanzo
Since we will have to pass reo's patch through beta (even just for a few minutes for us to test), it seems fine to merge your two PRs.
2023-02-28 05921, 2023
15:54 PM
atj
feels like someone should comment on LB-1216, it's over a month old
2023-02-28 05921, 2023
15:54 PM
BrainzBot
2023-02-28 05958, 2023
15:56 PM
mayhem
Rishika: yes
2023-02-28 05900, 2023
15:59 PM
Rishika
mayhem Thank you, will be back with PR or possibly some doubts about the setup
2023-02-28 05931, 2023
16:00 PM
BrainzGit
2023-02-28 05956, 2023
16:04 PM
jivte joined the channel
2023-02-28 05929, 2023
16:09 PM
yvanzo
reosarevok: Do you need any help with the PR?
2023-02-28 05911, 2023
16:10 PM
reosarevok
I'll be back in 5 minutes to check how's stuff:)
2023-02-28 05919, 2023
16:13 PM
Rishika has quit
2023-02-28 05939, 2023
16:14 PM
mayhem
monkey: can I put the explore page on test.lb so that aerozol can play later?
2023-02-28 05952, 2023
16:14 PM
bitmap
yvanzo: I'll merge mine to the beta branch then
2023-02-28 05956, 2023
16:14 PM
monkey
Yep, go ahead
2023-02-28 05902, 2023
16:15 PM
mayhem
k
2023-02-28 05936, 2023
16:16 PM
yvanzo
👍
2023-02-28 05916, 2023
16:17 PM
reosarevok
Now back
2023-02-28 05919, 2023
16:17 PM
monkey
Thanks atj, will answer.
2023-02-28 05933, 2023
16:17 PM
monkey
2023-02-28 05957, 2023
16:17 PM
atj
seems reasonable :)
2023-02-28 05928, 2023
16:21 PM
reosarevok
bitmap: inline-block seems fine. I had block because it's not like really inline, it's a tooltip, but still :)
2023-02-28 05930, 2023
16:21 PM
reosarevok
Can change it
2023-02-28 05938, 2023
16:21 PM
yvanzo
Go for it :)
2023-02-28 05908, 2023
16:22 PM
reosarevok
I capitalize ContainerElement because we did the same in CollapsibleList, and I thought the reason we did there is because they're component-like? But maybe not
2023-02-28 05932, 2023
16:22 PM
mayhem
2023-02-28 05940, 2023
16:22 PM
mayhem
now to make it actually work. :)
2023-02-28 05942, 2023
16:22 PM
reosarevok
I understand the second suggestion is for tooltips to be always just span?
2023-02-28 05945, 2023
16:22 PM
reosarevok
I can test it
2023-02-28 05931, 2023
16:23 PM
bitmap
reosarevok: yeah if we can always use span that would simplify things a lot
2023-02-28 05953, 2023
16:23 PM
bitmap
and make the capitalization irrelevant
2023-02-28 05904, 2023
16:24 PM
monkey
2023-02-28 05939, 2023
16:24 PM
mayhem
oh, right, the two columns are now a possibility
2023-02-28 05909, 2023
16:26 PM
BrainzGit
2023-02-28 05914, 2023
16:26 PM
reosarevok
bitmap: it works fine in the release rel editor tooltips at least
2023-02-28 05926, 2023
16:26 PM
reosarevok
So if you see no reason why it could become a problem later on, seems fine
2023-02-28 05910, 2023
16:27 PM
bitmap
I guess the only case would be when the content is a block-level element
2023-02-28 05913, 2023
16:27 PM
texke` joined the channel
2023-02-28 05953, 2023
16:27 PM
reosarevok
Do we expect to have a block-level tooltip?
2023-02-28 05900, 2023
16:28 PM
reosarevok
(rather than a popover)
2023-02-28 05931, 2023
16:29 PM
bitmap
probably not. HelpIcon uses a <div> as the target but it's just to render an icon, I think it could easily be an inline-block span
2023-02-28 05918, 2023
16:30 PM
reosarevok
Oh
2023-02-28 05923, 2023
16:30 PM
reosarevok
I guess we should change that one
2023-02-28 05944, 2023
16:30 PM
bitmap
I only see 5 uses of <Tooltip /> so they should be easy to check
2023-02-28 05952, 2023
16:30 PM
reosarevok
Yeah
2023-02-28 05954, 2023
16:30 PM
yvanzo
Not sure if the <span> issue is related but we should probably look into using ReactTooltip in the longer term, which BB and LB already use.
2023-02-28 05906, 2023
16:31 PM
reosarevok
Never heard. What's better about it?
2023-02-28 05933, 2023
16:31 PM
yvanzo
Not reinventing the wheel and having this kind of issue I hope.
2023-02-28 05953, 2023
16:31 PM
bitmap
iirc I forked our implementation from khan academy but we've made quite a few changes at this point
2023-02-28 05902, 2023
16:35 PM
reosarevok
bitmap: ButtonPopover has Popover which has Dialog which is a div
2023-02-28 05932, 2023
16:35 PM
Cronus1007 joined the channel
2023-02-28 05945, 2023
16:35 PM
bitmap
that uses a portal though (so the dialog isn't rendered inline), I think it should be fine
2023-02-28 05926, 2023
16:36 PM
milkii has quit
2023-02-28 05926, 2023
16:36 PM
texke has quit
2023-02-28 05926, 2023
16:36 PM
Sophist-UK has quit
2023-02-28 05927, 2023
16:36 PM
d4rkie has quit
2023-02-28 05928, 2023
16:36 PM
monotux has quit
2023-02-28 05929, 2023
16:36 PM
nyaomi has quit
2023-02-28 05934, 2023
16:37 PM
milkii joined the channel
2023-02-28 05934, 2023
16:37 PM
Sophist-UK joined the channel
2023-02-28 05934, 2023
16:37 PM
d4rkie joined the channel
2023-02-28 05934, 2023
16:37 PM
monotux joined the channel
2023-02-28 05934, 2023
16:37 PM
nyaomi joined the channel
2023-02-28 05951, 2023
16:37 PM
Cronus1007 has quit
2023-02-28 05907, 2023
16:38 PM
BrainzGit
2023-02-28 05917, 2023
16:38 PM
reosarevok
2023-02-28 05942, 2023
16:38 PM
mayhem
monkey: explore page update, works as expected now.
2023-02-28 05900, 2023
16:39 PM
mayhem
2023-02-28 05910, 2023
16:39 PM
reosarevok
bitmap: heh, MBS-12948
2023-02-28 05911, 2023
16:39 PM
BrainzBot
2023-02-28 05956, 2023
16:39 PM
bitmap
fun
2023-02-28 05916, 2023
16:40 PM
reosarevok
2023-02-28 05930, 2023
16:40 PM
reosarevok
Not a particularly horrible thing to live with for 2 weeks
2023-02-28 05941, 2023
16:40 PM
mayhem
when your mock-up didn't specify is how it should respond responsively -- monkey and I guessed at keeping the panels a constant size as per the image size that you set up. I've used the images from the figma when I could, but I had to create a couple of images because they were not part of the mock-up. Please review and let me know what else needs to be done to bring this up to your expectations.
2023-02-28 05956, 2023
16:40 PM
mayhem
aerozol: ^^ also meant for you.
2023-02-28 05933, 2023
16:41 PM
bitmap
reosarevok: I'll see how trivial it is. testing the toolip PR first
2023-02-28 05940, 2023
16:43 PM
BrainzGit
2023-02-28 05954, 2023
16:44 PM
monkey
!m lucifer
2023-02-28 05954, 2023
16:44 PM
BrainzBot
You're doing good work, lucifer!
2023-02-28 05958, 2023
16:44 PM
yvanzo
reosarevok: Added MBS-12946 to the blog post and split the lists as you suggested.
2023-02-28 05959, 2023
16:44 PM
BrainzBot
2023-02-28 05908, 2023
16:45 PM
monkey
I was just gathering some extra info to make your job easier :D
2023-02-28 05902, 2023
16:46 PM
BrainzGit
2023-02-28 05954, 2023
16:46 PM
monkey
lucifer: One thing I wanted to point out is that currently that spotify endpoint returns a 400 error which doesn't seem to be caught, resulting in a 500 server error
2023-02-28 05926, 2023
16:47 PM
lucifer
monkey: i see, will fix.
2023-02-28 05932, 2023
16:47 PM
monkey
Thx
2023-02-28 05912, 2023
16:48 PM
yvanzo
bitmap: I’m sure there potentially are thousands of trivial fixes :) but we don’t want to release at a later time than when we postponed yesterday :D
2023-02-28 05928, 2023
16:50 PM
bitmap
yvanzo: I think it can wait for the next release for sure
2023-02-28 05916, 2023
16:51 PM
bitmap
MBS-12946 doesn't seem like a showstopper either but we already have a fix, so
2023-02-28 05917, 2023
16:51 PM
BrainzBot
2023-02-28 05931, 2023
16:51 PM
reosarevok
I wanted to fix that one just because of how dumb it looks tbh :p
2023-02-28 05937, 2023
16:51 PM
reosarevok
The wrapping one is not so bad in comparison
2023-02-28 05943, 2023
16:51 PM
BrainzGit
2023-02-28 05927, 2023
16:52 PM
BrainzGit
2023-02-28 05917, 2023
16:53 PM
yvanzo
I agree, that was not a blocking bug but it was much more visible than the latest reported bug which is rather an edge case.
2023-02-28 05903, 2023
16:54 PM
reosarevok
bitmap: ok, I'll squash the commits in that PR and make the commit message better then
2023-02-28 05911, 2023
16:55 PM
mayhem
2023-02-28 05917, 2023
16:58 PM
reosarevok
bitmap, yvanzo: it's on the selenium queue - if you want we can wait, if you want we can merge if it passes circleci
