#metabrainz

/

      • mayhem
        legotkm was our goto person for maintaining the wiki,but he seems to be gone. :(
      • 2023-03-01 06039, 2023

      • Siddhart1o1 joined the channel
      • 2023-03-01 06004, 2023

      • monkey
        mayhem: done
      • 2023-03-01 06020, 2023

      • mayhem
        thanks.
      • 2023-03-01 06045, 2023

      • mayhem
        monkey: regarding the explore page -- aerozol would like to use RobotoBlack.
      • 2023-03-01 06001, 2023

      • mayhem
        what is our policy for adding a new font? what warrants us doing that?
      • 2023-03-01 06016, 2023

      • monkey
        We don't have a set policy. Us wanting to use it I warrants its use.
      • 2023-03-01 06040, 2023

      • mayhem
        ok, any tips for how to add a new font?
      • 2023-03-01 06000, 2023

      • monkey
        Yes, give me a minute I need to check the font itself
      • 2023-03-01 06001, 2023

      • monkey
        mayhem: Look at this file, you'll see we have Roboto defined in there up to font-weight=700 . Roboto black is weight 900 https://github.com/metabrainz/listenbrainz-server…
      • 2023-03-01 06034, 2023

      • monkey
        This is all CSS generated by google fonts. You can select roboto black on here https://fonts.google.com/specimen/Roboto and…(one minute please)
      • 2023-03-01 06059, 2023

      • mayhem hears big clive... one moment please!
      • 2023-03-01 06055, 2023

      • atj
      • 2023-03-01 06003, 2023

      • atj
        I guess you just add weight 900 to the URL in the comment https://fonts.googleapis.com/css?family=Roboto:10…
      • 2023-03-01 06038, 2023

      • mayhem
        I'm confused, monkey. yesterday we tried Roboto with weight 900 and it didn't look like RobotoBlack.
      • 2023-03-01 06010, 2023

      • monkey
        We didn't have 900, so that was either 700 which we have or the browser's attempt at making it bolder
      • 2023-03-01 06058, 2023

      • mayhem
        ok, but what needs doing isn't exactly clear right now.
      • 2023-03-01 06018, 2023

      • monkey
        Add this css to the google-fonts.less file I linked to : https://fonts.googleapis.com/css?family=Roboto:90…
      • 2023-03-01 06020, 2023

      • mayhem
        do I replace the contents of that file with the output of atj's link?
      • 2023-03-01 06050, 2023

      • mayhem
        k
      • 2023-03-01 06056, 2023

      • monkey
        Or yes, replace with the content of atj's link
      • 2023-03-01 06059, 2023

      • atj
        you can either append just the contents of the Roboto:900 link or copy paste the entire one
      • 2023-03-01 06002, 2023

      • monkey
        either will work really
      • 2023-03-01 06018, 2023

      • atj
        surprised you load fonts from Google
      • 2023-03-01 06019, 2023

      • mayhem
        k.
      • 2023-03-01 06033, 2023

      • monkey
        There was a PR started to load font assets from our server
      • 2023-03-01 06045, 2023

      • monkey
        Not sure what the status of that is
      • 2023-03-01 06000, 2023

      • monkey
        LB#1881
      • 2023-03-01 06000, 2023

      • BrainzBot
      • 2023-03-01 06008, 2023

      • atj
        monkey: iirc Google varies the CSS response based on your browser fingerprint?
      • 2023-03-01 06022, 2023

      • monkey
        Does it? What would change in this case?
      • 2023-03-01 06029, 2023

      • mayhem
        looks better. let me update test.
      • 2023-03-01 06023, 2023

      • atj
        monkey: the type of font, at least in the past some browsers didn't support the woff2 format
      • 2023-03-01 06034, 2023

      • BrainzGit
        [listenbrainz-server] 14MonkeyDo opened pull request #2375 (03master…fix-playlist-listencard-flex): Fix drag handle size in playlist listencard https://github.com/metabrainz/listenbrainz-server…
      • 2023-03-01 06048, 2023

      • atj
        probably not relevant now
      • 2023-03-01 06006, 2023

      • monkey
        Yeah, that hasn't been a problem in a while
      • 2023-03-01 06021, 2023

      • monkey
        (except for Opera Mini apparently)
      • 2023-03-01 06025, 2023

      • atj
        heh
      • 2023-03-01 06031, 2023

      • monkey
        And IE, but…
      • 2023-03-01 06041, 2023

      • atj
        well, that's a given
      • 2023-03-01 06027, 2023

      • monkey
        Thanks mayhem, fastest reviewer in the West :p
      • 2023-03-01 06029, 2023

      • reosarevok
        mayhem: done, AFAICT
      • 2023-03-01 06047, 2023

      • mayhem
        easy for three line changes.
      • 2023-03-01 06015, 2023

      • mayhem
      • 2023-03-01 06024, 2023

      • mayhem
        does the font look better for you now?
      • 2023-03-01 06004, 2023

      • atj
        where is the font used, explore-card-text-name?
      • 2023-03-01 06011, 2023

      • mayhem
        yes
      • 2023-03-01 06037, 2023

      • atj
        font-weight: 700
      • 2023-03-01 06012, 2023

      • monkey
        mayhem: The style of the anchor tag overwrites your font-weight
      • 2023-03-01 06036, 2023

      • mayhem
        ah.
      • 2023-03-01 06010, 2023

      • akshaaatt
        mayhem: Done with the acceptances.
      • 2023-03-01 06012, 2023

      • BrainzGit
        [artwork-redirect] 14dependabot[bot] opened pull request #45 (03master…dependabot/npm_and_yarn/minimist-and-mkdirp-1.2.8): Bump minimist and mkdirp https://github.com/metabrainz/artwork-redirect/pu…
      • 2023-03-01 06023, 2023

      • mayhem
        thanks akshaaatt, reosarevok
      • 2023-03-01 06030, 2023

      • monkey
        mayhem: I would also set the color of the anchor tags to the blue, even for visited and hovered links (currently, by default links will turn purple when visited). Let me come up with the bit of less you need
      • 2023-03-01 06031, 2023

      • mayhem
        monkey: when I apply the style to the a tag, it ignores the 900 weight.
      • 2023-03-01 06055, 2023

      • mayhem
      • 2023-03-01 06036, 2023

      • monkey
        Try this:
      • 2023-03-01 06040, 2023

      • monkey
      • 2023-03-01 06033, 2023

      • jasje has quit
      • 2023-03-01 06036, 2023

      • mayhem
        and does that style stay attached to the div, with the > a in there?
      • 2023-03-01 06009, 2023

      • monkey
        no, it will be applied to an anchor that is a direct child
      • 2023-03-01 06056, 2023

      • monkey
        But you don't have any other content in said div
      • 2023-03-01 06049, 2023

      • mayhem
        it works when applied to the div the encloses the <a>
      • 2023-03-01 06028, 2023

      • monkey
        Not sure what you mean
      • 2023-03-01 06012, 2023

      • mayhem
      • 2023-03-01 06014, 2023

      • mayhem
        that works.
      • 2023-03-01 06027, 2023

      • mayhem
        pushing to test.
      • 2023-03-01 06017, 2023

      • monkey
        To me that looks like the structure you had before (the one currently on test)
      • 2023-03-01 06037, 2023

      • mayhem
        it was, but the CSS is different now.
      • 2023-03-01 06038, 2023

      • monkey
      • 2023-03-01 06004, 2023

      • monkey
        Yes, the css now applies the style to the enclosed anchor tag rather than to the explore-card-text-name div
      • 2023-03-01 06012, 2023

      • mayhem nods
      • 2023-03-01 06054, 2023

      • mayhem
      • 2023-03-01 06020, 2023

      • mayhem
        the responsiveness now matches what aerozol wants, save for not scaling the images. that's next.
      • 2023-03-01 06044, 2023

      • monkey
        Yep, that looks good. Roboto black
      • 2023-03-01 06053, 2023

      • mayhem
        thanks for the help!
      • 2023-03-01 06046, 2023

      • jasje_ joined the channel
      • 2023-03-01 06001, 2023

      • monkey
        mayhem: we missed something else subtle yesterday, there's a faiiiiint border around the cards. Try applying this to the .explore-card:
      • 2023-03-01 06004, 2023

      • monkey
      • 2023-03-01 06043, 2023

      • mayhem
        I saw the border in the CSS that was disgorged by figma, but I couldn't see it.
      • 2023-03-01 06056, 2023

      • monkey
        Faiiiiiiiiiiiiiint :p
      • 2023-03-01 06041, 2023

      • mayhem
      • 2023-03-01 06042, 2023

      • jasje_
        mayhem: just tried out the explore page and it looks good. I do wanna point out that the hamburger dropdown animation is kinda laggy on my device¿
      • 2023-03-01 06005, 2023

      • monkey
        I see it a bit on the top left
      • 2023-03-01 06017, 2023

      • mayhem
        ok, cool. :)
      • 2023-03-01 06040, 2023

      • mayhem
        jasje_: good thing I didn't touch the hamburger icon. :)
      • 2023-03-01 06041, 2023

      • jasje_
        oh well monkey ^^
      • 2023-03-01 06044, 2023

      • monkey
        jasje_: Yeah, that's going away soon in any case
      • 2023-03-01 06006, 2023

      • jasje_
        oh noice den
      • 2023-03-01 06051, 2023

      • monkey
        We're on old Bootstrap 3, I think the animation performance improved on newer versions. But moot point, we're rolling out our own sidebar instead of top navbar
      • 2023-03-01 06027, 2023

      • zas
        not sure who's in charge of brainzbot-plugins-prod container on trille, but it is erroring since a while (and keep restarting)
      • 2023-03-01 06022, 2023

      • jasje_
        monkey: sidebar on mobile devices too?
      • 2023-03-01 06040, 2023

      • mayhem
        yvanzo: do you know anthing about brainzbot-plugins-prod container on trille?
      • 2023-03-01 06044, 2023

      • monkey
        jasje_: yes most likely. Collapsible though
      • 2023-03-01 06018, 2023

      • jasje_
        interesting
      • 2023-03-01 06042, 2023

      • reosarevok
        mayhem, zas: https://github.com/metabrainz/brainzbot-plugins was archived by alastair, FWIW
      • 2023-03-01 06053, 2023

      • reosarevok
        (not sure if that means we don't use that anymore or not)
      • 2023-03-01 06004, 2023

      • zas
        alastairp: ^^?
      • 2023-03-01 06007, 2023

      • reosarevok
        Oh, merged with the main repo
      • 2023-03-01 06014, 2023

      • reosarevok
        "Remove external plugins dependency, plugins are now local"
      • 2023-03-01 06030, 2023

      • reosarevok
      • 2023-03-01 06032, 2023

      • mayhem
        zas: alastairp is not paying attention to messages for the next 4 months or so.
      • 2023-03-01 06003, 2023

      • zas
        4 months? ... damn, he went on an polar expedition?
      • 2023-03-01 06011, 2023

      • mayhem
        yep.
      • 2023-03-01 06024, 2023

      • zas
        ok, I'll stop this container, as it errors anyway
      • 2023-03-01 06026, 2023

      • reosarevok
        Ok, let's see if brainzbot complains in any way
      • 2023-03-01 06041, 2023

      • BrainzGit has quit
      • 2023-03-01 06046, 2023

      • atj
        lol
      • 2023-03-01 06055, 2023

      • BrainzGit joined the channel
      • 2023-03-01 06049, 2023

      • dvzrv has quit
      • 2023-03-01 06001, 2023

      • dvzrv joined the channel
      • 2023-03-01 06017, 2023

      • prout has quit
      • 2023-03-01 06017, 2023

      • pprkut has quit
      • 2023-03-01 06017, 2023

      • FichteFoll has quit
      • 2023-03-01 06017, 2023

      • kori has quit
      • 2023-03-01 06018, 2023

      • rektide_ has quit
      • 2023-03-01 06018, 2023

      • ROpdebee has quit
      • 2023-03-01 06019, 2023

      • kgz has quit
      • 2023-03-01 06019, 2023

      • }8] has quit
      • 2023-03-01 06004, 2023

      • mayhem
      • 2023-03-01 06052, 2023

      • yvanzo
        mayhem: no
      • 2023-03-01 06014, 2023

      • mayhem
        monkey: I am working on improving how the images work. in this case, I want the image to be 100%, but I want it clipped if it is taller than the max height allowed. how do I do that?
      • 2023-03-01 06025, 2023

      • mayhem
        yvanzo: ok. thanks. we'll see what breaks. :)
      • 2023-03-01 06003, 2023

      • monkey
        mayhem: you create a containing div with the dimensions (max-height) you want, set `overflow: hidden` css on it, then put the image inside
      • 2023-03-01 06016, 2023

      • mayhem
        thx
      • 2023-03-01 06056, 2023

      • prout joined the channel
      • 2023-03-01 06056, 2023

      • pprkut joined the channel
      • 2023-03-01 06056, 2023

      • FichteFoll joined the channel
      • 2023-03-01 06056, 2023

      • kori joined the channel
      • 2023-03-01 06056, 2023

      • rektide_ joined the channel
      • 2023-03-01 06056, 2023

      • ROpdebee joined the channel
      • 2023-03-01 06056, 2023

      • kgz joined the channel
      • 2023-03-01 06056, 2023

      • }8] joined the channel
      • 2023-03-01 06037, 2023

      • kori has quit
      • 2023-03-01 06041, 2023

      • ROpdebee9 joined the channel
      • 2023-03-01 06052, 2023

      • ROpdebee has quit
      • 2023-03-01 06052, 2023

      • ROpdebee9 is now known as ROpdebee
      • 2023-03-01 06002, 2023

      • Siddhart1o1 has quit
      • 2023-03-01 06020, 2023

      • yvanzo
        aerozol: The ‘main author’ is bitmap who said he would get up (yesterday morning) if he had pings about prod update going wrong.
      • 2023-03-01 06031, 2023

      • Siddhart1o1 joined the channel
      • 2023-03-01 06044, 2023

      • yvanzo
        pbryan: The wiki is just a free-form facility, it can used it for drafts, RFCs... but I wouldn’t recommend using it for more structured content.
      • 2023-03-01 06050, 2023

      • yvanzo
        MB is currently using for docs/guidelines but it’s historical, and has some inconvenients, longer term is to get away from it rather than use it more.
      • 2023-03-01 06005, 2023

      • mayhem
        monkey: ok, I think I am done for now: https://test.listenbrainz.org/explore/
      • 2023-03-01 06010, 2023

      • monkey
        Yes that looks a lot better, nice work mayhem
      • 2023-03-01 06001, 2023

      • monkey
        I was toying with noise overlays in css, came up with something but not final. We can revisit it later
      • 2023-03-01 06029, 2023

      • monkey
        For posterity:
      • 2023-03-01 06036, 2023

      • monkey
      • 2023-03-01 06001, 2023

      • monkey
        Funky base64 PNG noise image + overlay blending modes
      • 2023-03-01 06043, 2023

      • mayhem
        great. :)
      • 2023-03-01 06049, 2023

      • yvanzo
        bitmap: friendly reminder, there are 6 unreviewed SEC tickets for you from 2 years old to 2 hours old: https://tickets.metabrainz.org/issues/?filter=115…