#metabrainz

/

      • yvanzo
        lucifer: friendly reminder, there are 10 unreviewed SEC tickets for you from 2 years old to 2 weeks old: https://tickets.metabrainz.org/issues/?filter=115…
      • 2023-03-01 06001, 2023

      • yvanzo
        monkey: friendly reminder, there are 11 unreviewed SEC tickets for you from 2 years old to 20 days old: https://tickets.metabrainz.org/issues/?filter=115…
      • 2023-03-01 06021, 2023

      • monkey
        Roger
      • 2023-03-01 06004, 2023

      • yvanzo
        Nice to meet you
      • 2023-03-01 06020, 2023

      • reosarevok
        Don't try to get Roger to do it, monkey, it's your job! :D
      • 2023-03-01 06025, 2023

      • monkey
        🤝
      • 2023-03-01 06008, 2023

      • kori1 joined the channel
      • 2023-03-01 06047, 2023

      • outsidecontext
        is something broken with daily jams generation on LB currently? Last one was on Monday
      • 2023-03-01 06031, 2023

      • BrainzGit
        [listenbrainz-server] 14MonkeyDo merged pull request #2375 (03master…fix-playlist-listencard-flex): Fix drag handle size in playlist listencard https://github.com/metabrainz/listenbrainz-server…
      • 2023-03-01 06034, 2023

      • vishwajeet590[m]
        <akshaaatt> "I think you can pick up the..." <- Got it, so we have to move the whole Listens sections into to the BP. I'll give it a shot and ask you something in doubt.
      • 2023-03-01 06034, 2023

      • vishwajeet590[m]
        Also I have updated that last PR.
      • 2023-03-01 06024, 2023

      • akshaaatt
        Awesome. Thanks a lot vishwajeet590[m] !
      • 2023-03-01 06036, 2023

      • Siddhart1o1 has quit
      • 2023-03-01 06038, 2023

      • reosarevok
        monkey: do you know where the (?) tooltop icon in https://listenbrainz.org/user/aerozol/year-in-mus… lives?
      • 2023-03-01 06047, 2023

      • reosarevok
        aerozol suggested using it for MB but I can't find it in the repo
      • 2023-03-01 06002, 2023

      • reosarevok
        *tooltip even
      • 2023-03-01 06031, 2023

      • mayhem
        outsidecontext: I got mine generated today.
      • 2023-03-01 06034, 2023

      • mayhem
        lucifer: any ideas?
      • 2023-03-01 06005, 2023

      • jasje_ has quit
      • 2023-03-01 06042, 2023

      • lucifer
        JasjeetSingh[m]: sorry didn't understand what you mean by "But there isn't any auth header given in definition to verify the user"
      • 2023-03-01 06051, 2023

      • lucifer
        mayhem: done, the gsoc dashboard thing.
      • 2023-03-01 06020, 2023

      • lucifer
        yvanzo: will look into it. thanks
      • 2023-03-01 06054, 2023

      • lucifer
        mayhem: i see some ratelimit errors for feedback api in sentry.
      • 2023-03-01 06018, 2023

      • adhawkins has quit
      • 2023-03-01 06043, 2023

      • bitmap
        mayhem: I logged in to the gsoc site but it says "There is no Google Summer of Code profile associated with this Google account". I thought I was an org admin last year but might be misremembering
      • 2023-03-01 06058, 2023

      • lucifer
        mayhem: i think a long term solution would be to add support to troi to read data from database directly but now maybe just retry on ratelimit.
      • 2023-03-01 06017, 2023

      • bitmap
        kellnerd: hey, I think I saw something in sentry about that. it might be because we added a _lineage property to the relationship state, can you try adding `_lineage: [],` to RELATIONSHIP_DEFAULTS and see if that fixes it?
      • 2023-03-01 06025, 2023

      • kori1 is now known as kori
      • 2023-03-01 06039, 2023

      • mayhem
        lucifer: I'll add a retry to troi. thanks for digging.
      • 2023-03-01 06039, 2023

      • kori has quit
      • 2023-03-01 06039, 2023

      • kori joined the channel
      • 2023-03-01 06050, 2023

      • mayhem
        bitmap: you were and it says that you were invited. odd.
      • 2023-03-01 06042, 2023

      • kellnerd
        bitmap: Great, that fixes it indeed, thanks a lot!
      • 2023-03-01 06046, 2023

      • bitmap
        👍
      • 2023-03-01 06023, 2023

      • adhawkins joined the channel
      • 2023-03-01 06019, 2023

      • jasje joined the channel
      • 2023-03-01 06024, 2023

      • bitmap
        mayhem: i'm using my bitmap@meb account but tried with my personal gmail just to make sure. was there an email I missed where I was supposed to do something with the invite?
      • 2023-03-01 06003, 2023

      • mayhem
        unsure. the whole system seems a bit buggy.
      • 2023-03-01 06052, 2023

      • mayhem
        check to see if you got an invite to bitmap@meb now.
      • 2023-03-01 06001, 2023

      • mayhem
        I just removed you from the system and re-added you.
      • 2023-03-01 06007, 2023

      • bitmap
        yeah I got this one, thanks
      • 2023-03-01 06034, 2023

      • mayhem
        are you about to log in now?
      • 2023-03-01 06058, 2023

      • bitmap
        mayhem: yeah it seems to work now since I have a menu at the top where I can view the org profile, members, etc.
      • 2023-03-01 06005, 2023

      • mayhem
        yes, confirmed.
      • 2023-03-01 06007, 2023

      • mayhem
        thanks!
      • 2023-03-01 06043, 2023

      • monkey
        reosarevok: We use FontAwesome icons all over the codebase, that's where that question mark comes from: https://github.com/metabrainz/listenbrainz-server…
      • 2023-03-01 06027, 2023

      • monkey
        jasje: Regarding the timeline event API, maybe you missed this line? https://github.com/metabrainz/listenbrainz-server…
      • 2023-03-01 06037, 2023

      • monkey
        By the way LB team my last daily jam was also generated on Monday
      • 2023-03-01 06051, 2023

      • mayhem
        working on a proposed fix now.
      • 2023-03-01 06009, 2023

      • jasje
        monkey: i have less experience in this api stuff right now :P (frontend only rn)
      • 2023-03-01 06011, 2023

      • monkey
        mayhem: Thanks, I was just replicating the issue mentioned :)
      • 2023-03-01 06028, 2023

      • monkey
        jasje: Was that what you were looking for?
      • 2023-03-01 06034, 2023

      • jasje
        i was just going through the docs where it said use user token for follow but not for other post apis
      • 2023-03-01 06044, 2023

      • monkey
        I'm awful at python so it's not very clear to me either
      • 2023-03-01 06044, 2023

      • jasje
        monkey: yess thankyou!
      • 2023-03-01 06055, 2023

      • jasje
        high five
      • 2023-03-01 06016, 2023

      • mayhem
        jasje: monkey : THe user token is used by submission clients to submit listens.
      • 2023-03-01 06032, 2023

      • mayhem
        as well as authentication for our API.
      • 2023-03-01 06052, 2023

      • mayhem
        it means you need set the Authorization header.
      • 2023-03-01 06030, 2023

      • jasje
        As i expected, can you tell someone to update the docs tho?
      • 2023-03-01 06045, 2023

      • mayhem
        jasje: please update our docs!
      • 2023-03-01 06000, 2023

      • jasje
        mayhem: sure
      • 2023-03-01 06025, 2023

      • jasje
        But being a lil naive in this dept
      • 2023-03-01 06032, 2023

      • mayhem
        not sure where the problem is, but the docs have it:
      • 2023-03-01 06032, 2023

      • mayhem
      • 2023-03-01 06035, 2023

      • reosarevok
        bitmap: heh. Is there a way to break an import into two rows?
      • 2023-03-01 06039, 2023

      • reosarevok
      • 2023-03-01 06042, 2023

      • reosarevok
        That's actually too long :D
      • 2023-03-01 06044, 2023

      • mayhem
        see Request Headers section
      • 2023-03-01 06014, 2023

      • jasje
        mayhem: check out the social apis
      • 2023-03-01 06021, 2023

      • monkey
        mayhem: some of the follow api endpoints mention request headers (including Auth header) but not all of them: https://listenbrainz.readthedocs.io/en/latest/use…
      • 2023-03-01 06045, 2023

      • monkey
        jasje: You identified what's missing correctly. all those endpoints need the authorization header
      • 2023-03-01 06055, 2023

      • mayhem
        ok, this should be an easy job for jasje to update then. :p
      • 2023-03-01 06059, 2023

      • monkey
        Well, all the POST endpoints at least
      • 2023-03-01 06013, 2023

      • jasje
        Okey ill do it
      • 2023-03-01 06001, 2023

      • monkey
        Thanks !
      • 2023-03-01 06021, 2023

      • bitmap
        reosarevok: heh I don't think so
      • 2023-03-01 06040, 2023

      • reosarevok
        bitmap: also, aerozol is suggesting some FontAwesome icons for us, I guess that'd meant we have to install FontAwesome? :) Have you played with that before?
      • 2023-03-01 06053, 2023

      • reosarevok
        (for now, specifically the question icon on https://listenbrainz.org/user/aerozol/year-in-mus…)
      • 2023-03-01 06017, 2023

      • reosarevok
        I mean, I could probably just copy the icon as an image for now, but I guess if we want to do this more often / consistently we'll want to install it properly
      • 2023-03-01 06021, 2023

      • BrainzGit
        [troi-recommendation-playground] 14amCap1712 opened pull request #94 (03main…version-fix): Relax spotipy version limit https://github.com/metabrainz/troi-recommendation…
      • 2023-03-01 06046, 2023

      • monkey
        FWIW I find the FontAwesome icons very handy to have. Not a huge bulk since you can import specific icons rather than the whole thing.
      • 2023-03-01 06011, 2023

      • monkey
        Since they've rolled out their own React library icons have been a breeze for me.
      • 2023-03-01 06037, 2023

      • monkey
        But, if you don't want to jump into that now, you can get the SVG here (there's a button to copy/DL the SVG code) : https://fontawesome.com/icons/circle-question?s=s…
      • 2023-03-01 06009, 2023

      • reosarevok
        bitmap: oh, and one last question, which I should probably know the answer of
      • 2023-03-01 06047, 2023

      • bitmap
        reosarevok: yes, we use react-fontawesome in the homepage-revamp branch afaik
      • 2023-03-01 06055, 2023

      • reosarevok
        How does $loaded work in a place like https://github.com/reosarevok/musicbrainz-server/… ?
      • 2023-03-01 06008, 2023

      • reosarevok
        I thought if the type existed with that ID it would find it, but it does not seem to
      • 2023-03-01 06037, 2023

      • bitmap
        iirc anything that's added in sub foreign_keys will end up in there
      • 2023-03-01 06038, 2023

      • reosarevok
        Hmm
      • 2023-03-01 06040, 2023

      • reosarevok
        That has $ids{LinkType} = [$self->data->{link}{type}{id}];
      • 2023-03-01 06053, 2023

      • bitmap
        maybe check if that's defined properly
      • 2023-03-01 06003, 2023

      • bitmap
        (the $self->data->{link}{type}{id} bit)
      • 2023-03-01 06031, 2023

      • reosarevok
        oh
      • 2023-03-01 06032, 2023

      • reosarevok
        duh
      • 2023-03-01 06031, 2023

      • reosarevok
        Should be $self->data->{relationship}{link}{type}{id}
      • 2023-03-01 06045, 2023

      • reosarevok
        Been borked for 4 years, lol
      • 2023-03-01 06013, 2023

      • bitmap
        oof
      • 2023-03-01 06044, 2023

      • reosarevok
        I mean, apparently it didn't really matter
      • 2023-03-01 06050, 2023

      • atj
        "apparently"
      • 2023-03-01 06051, 2023

      • reosarevok
        Since the data displayed was just fine
      • 2023-03-01 06058, 2023

      • reosarevok
        But still, yeah
      • 2023-03-01 06031, 2023

      • monkey
        atj: I love the peanut gallery commentary :D
      • 2023-03-01 06046, 2023

      • reosarevok
        Wonder if I should move getRelationshipLinkType actually, since I'm using it in /edit/components now (to link to link type docs from rel edits)
      • 2023-03-01 06029, 2023

      • reosarevok
        bitmap: would it make sense to move this from relationship-editor/utility to edit/utility instead? It has the main benefit that it fits inside max-len :p
      • 2023-03-01 06048, 2023

      • reosarevok
        I can also just disable max-len for that line, of course, but it might actually make sense to move if I'm using it outside rel-editor
      • 2023-03-01 06052, 2023

      • bitmap
        go ahead :) it doesn't look specific to the rel editor
      • 2023-03-01 06015, 2023

      • atj throws a peanut at monkey
      • 2023-03-01 06056, 2023

      • monkey throws a monkey at atj
      • 2023-03-01 06035, 2023

      • atj
        hopefully it was a friendly monkey
      • 2023-03-01 06005, 2023

      • reosarevok
        bitmap: sigh, I guess flow is not smart enough to use .filter?
      • 2023-03-01 06012, 2023

      • reosarevok
      • 2023-03-01 06032, 2023

      • reosarevok
        "but relationshipType might be null" it complains
      • 2023-03-01 06054, 2023

      • bitmap
        `type => type.gid && type.name` doesn't look like it will work if the link type is null
      • 2023-03-01 06038, 2023

      • bitmap
        but if you replace the map+filter with reduce it should grok that
      • 2023-03-01 06030, 2023

      • reosarevok
        Eh
      • 2023-03-01 06048, 2023

      • reosarevok
        I had added type && there, and it still failed :)
      • 2023-03-01 06056, 2023

      • reosarevok
        Not sure why I managed to undo that :D
      • 2023-03-01 06007, 2023

      • reosarevok
        But ok, I'll try reduce
      • 2023-03-01 06028, 2023

      • mayhem finally squares away the expired bank card drama.
      • 2023-03-01 06049, 2023

      • jivte joined the channel
      • 2023-03-01 06006, 2023

      • kellnerd
        bitmap: Strange though that the missing `_lineage` property was only affecting batch-creating recording rels but not creating a single release rel for which my script uses the same RELATIONSHIP_DEFAULTS object ... that's probably why I didn't think it could be related to that.
      • 2023-03-01 06016, 2023

      • bitmap
        kellnerd: not sure, the failure I saw in sentry was related to it trying to spread [...rel._lineage] somewhere. I guess we don't update _lineage in the single rel case
      • 2023-03-01 06006, 2023

      • kellnerd
        Hmm, then I probably failed to parse the sentry request properly. I only saw an `e is undefined` type error in the payload.
      • 2023-03-01 06038, 2023

      • bitmap
        full error is: TypeError: undefined is not iterable (cannot read property Symbol(Symbol.iterator))
      • 2023-03-01 06046, 2023

      • kellnerd
        Interesting, maybe I will try to reproduce the error once more to see whether I was blind this morning...
      • 2023-03-01 06019, 2023

      • reosarevok
        Hide. I'll go with hide. (UI from my bank) https://usercontent.irccloud-cdn.com/file/u701ZIU…
      • 2023-03-01 06039, 2023

      • pbryan
        lol
      • 2023-03-01 06011, 2023

      • BrainzGit
        [listenbrainz-server] 1407jasjeet opened pull request #2376 (03master…master): Fixed Documentation of User Timeline APIs (user_timeline_event_api.py) https://github.com/metabrainz/listenbrainz-server…
      • 2023-03-01 06040, 2023

      • jasje
        monkey mayhem ^^
      • 2023-03-01 06054, 2023

      • BrainzGit
        [musicbrainz-server] 14reosarevok opened pull request #2876 (03master…MBS-12841): MBS-12841 / MBS-8242: Link to edit and relationship docs from edits https://github.com/metabrainz/musicbrainz-server/…
      • 2023-03-01 06046, 2023

      • BrainzGit
        [troi-recommendation-playground] 14mayhem opened pull request #95 (03main…feedback-rate-limiting): Data fetching rate limiting https://github.com/metabrainz/troi-recommendation…
      • 2023-03-01 06008, 2023

      • mayhem
        lucifer: ^^
      • 2023-03-01 06035, 2023

      • reosarevok
        zas: I'm off for the evening, but tomorrow maybe you can help me answer the user-admins French email I got today? The user doesn't understand what they are doing wrong apparently because they don't really speak much English :)
      • 2023-03-01 06056, 2023

      • reosarevok
        (I understand you have access to those emails)
      • 2023-03-01 06059, 2023

      • zas
        reosarevok: ok ;)
      • 2023-03-01 06020, 2023

      • BrainzGit
        [troi-recommendation-playground] 14mayhem merged pull request #95 (03main…feedback-rate-limiting): Data fetching rate limiting https://github.com/metabrainz/troi-recommendation…
      • 2023-03-01 06002, 2023

      • BrainzGit
        [troi-recommendation-playground] release 03v-2023-03-01 has been published by 14mayhem: https://github.com/metabrainz/troi-recommendation…
      • 2023-03-01 06008, 2023

      • BrainzGit
        [listenbrainz-server] 14mayhem opened pull request #2377 (03master…troi-update-v-2023-03-01): Update for troi release https://github.com/metabrainz/listenbrainz-server…
      • 2023-03-01 06010, 2023

      • mayhem
        zas: this is what I was talking about bank card drama.
      • 2023-03-01 06040, 2023

      • mayhem
        I finally today received the updated bank card, after having to work too hard to make the bank do their job.
      • 2023-03-01 06000, 2023

      • mayhem
        I updated all our key service providers with the new card details. no further action should be needed.
      • 2023-03-01 06056, 2023

      • BrainzGit
        [troi-recommendation-playground] 14amCap1712 merged pull request #94 (03main…version-fix): Relax spotipy version limit https://github.com/metabrainz/troi-recommendation…
      • 2023-03-01 06051, 2023

      • mayhem
        lucifer: that spotipy version change is also needed in LB. I'm already including it on the PR to upddate troi.
      • 2023-03-01 06030, 2023

      • jasje
        akshaaatt: converting the app to compose nav is turning out to be cumbersome
      • 2023-03-01 06056, 2023

      • akshaaatt
        How so jasje ?
      • 2023-03-01 06011, 2023

      • jasje
        Login activity uses XML layouts
      • 2023-03-01 06038, 2023

      • jasje
        listens activity and login both under-use the viewmodel
      • 2023-03-01 06016, 2023

      • akshaaatt
        Sounds like good time to convert them to composables then
      • 2023-03-01 06052, 2023

      • jasje
        unless