#metabrainz

/

      • agatzk joined the channel
      • 2023-03-02 06106, 2023

      • SothoTalKer has quit
      • 2023-03-02 06140, 2023

      • SothoTalKer joined the channel
      • 2023-03-02 06142, 2023

      • trolley has quit
      • 2023-03-02 06119, 2023

      • trolley joined the channel
      • 2023-03-02 06136, 2023

      • aerozol
      • 2023-03-02 06121, 2023

      • aerozol
      • 2023-03-02 06114, 2023

      • theraspberry joined the channel
      • 2023-03-02 06125, 2023

      • kaine2 has quit
      • 2023-03-02 06149, 2023

      • kaine2 joined the channel
      • 2023-03-02 06146, 2023

      • rozlav joined the channel
      • 2023-03-02 06119, 2023

      • monotux has quit
      • 2023-03-02 06121, 2023

      • monotux joined the channel
      • 2023-03-02 06135, 2023

      • Vishwajeet878 joined the channel
      • 2023-03-02 06109, 2023

      • aerozol
        yvanzo: I knew who you were talking any re. 'main developer' :p Nice to let bitmap rest for once!
      • 2023-03-02 06102, 2023

      • Vishwajeet878 has quit
      • 2023-03-02 06116, 2023

      • smach joined the channel
      • 2023-03-02 06120, 2023

      • jasje joined the channel
      • 2023-03-02 06138, 2023

      • kellnerd joined the channel
      • 2023-03-02 06114, 2023

      • BrainzGit
        [musicbrainz-server] 14reosarevok opened pull request #2877 (03master…MBS-12848): MBS-12848: Reject inc=various-artists without inc=releases https://github.com/metabrainz/musicbrainz-server/…
      • 2023-03-02 06116, 2023

      • CatQuest
        re test server, Pratha-Fish you cna even log in as some other user since all passwords are reset to "mb", you cna edit relationships or really modify all kinds of thing. it's snadbox for testing edits, scripts, bots younameit
      • 2023-03-02 06117, 2023

      • Pratha-Fish
        CatQuest: Thanks for the tip :)
      • 2023-03-02 06148, 2023

      • CatQuest
        it's great becasue you cna wreck tings in order to test unlikly bugs etcetera
      • 2023-03-02 06128, 2023

      • CatQuest
        there is also a "accept edit right away" override function to test edits so oyu don't have to wait a week for passing edits
      • 2023-03-02 06128, 2023

      • jivte joined the channel
      • 2023-03-02 06142, 2023

      • mayhem
        mooin!
      • 2023-03-02 06131, 2023

      • jasje
        moin!
      • 2023-03-02 06104, 2023

      • jasje
        akshaaatt: why isn't minify build true for release?
      • 2023-03-02 06130, 2023

      • jasje
        also no shrinkResources true either
      • 2023-03-02 06112, 2023

      • akshaaatt
        We were facing some issue with DI or something a year back when the code was all in java
      • 2023-03-02 06112, 2023

      • jasje
        I've seen that alot of compose bugs are gone using R8 conv and performance jump is 4x
      • 2023-03-02 06137, 2023

      • akshaaatt
        I’m aligned if we wanna enable it
      • 2023-03-02 06141, 2023

      • jasje
        Well a task for you then eh :devil-face:
      • 2023-03-02 06100, 2023

      • akshaaatt
        Well, if tasks were this easy then what was the problem even
      • 2023-03-02 06104, 2023

      • akshaaatt
        Lol
      • 2023-03-02 06112, 2023

      • jasje
        ill get into it
      • 2023-03-02 06140, 2023

      • jasje
        try install the release, it does give me some error related to sentry
      • 2023-03-02 06127, 2023

      • jasje
        (with minifyEnabled)
      • 2023-03-02 06143, 2023

      • Pratha-Fish
        CatQuest: epiccc
      • 2023-03-02 06134, 2023

      • mayhem
        lucifer: cron restarted.
      • 2023-03-02 06103, 2023

      • jivte
        aerozol: Hey!!
      • 2023-03-02 06114, 2023

      • atj
        zas: this borg role has some issues (nothing too bad so far). i'm trying to subdue my "not invented here" syndrome but it's difficult
      • 2023-03-02 06141, 2023

      • jivte has quit
      • 2023-03-02 06117, 2023

      • jasje
        hi vishwajeet590[m]
      • 2023-03-02 06142, 2023

      • jasje
        Have you completed the assigned work?
      • 2023-03-02 06108, 2023

      • jasje
        (I have mine)
      • 2023-03-02 06156, 2023

      • akshaaatt
        Assigned? By who?
      • 2023-03-02 06110, 2023

      • jasje
        I just told him to do it under your nose
      • 2023-03-02 06112, 2023

      • jasje
        :P
      • 2023-03-02 06122, 2023

      • jasje
        Afterall we should share the good ol prs
      • 2023-03-02 06140, 2023

      • jasje
        akshaaatt: btw i just converted the listens activity
      • 2023-03-02 06144, 2023

      • jasje
        to a composable
      • 2023-03-02 06151, 2023

      • jasje
        and the navigation is gooood
      • 2023-03-02 06129, 2023

      • jasje
        Brainzplayer mini player also stays there
      • 2023-03-02 06120, 2023

      • akshaaatt
        Ah alright. I remembered discussing a few things with vishwajeet590[m] but didn’t assign him anything. I thought we were talking about that.
      • 2023-03-02 06151, 2023

      • akshaaatt
        You boys can manage things amongst each other if that’s what you like :)
      • 2023-03-02 06109, 2023

      • jasje
        Yeah i saw that convo and thought of sharin sum work
      • 2023-03-02 06121, 2023

      • akshaaatt
        Cool
      • 2023-03-02 06148, 2023

      • akshaaatt
        Let’s get the PR then jasje !
      • 2023-03-02 06149, 2023

      • jasje
        converting bp will be a real mess uh
      • 2023-03-02 06119, 2023

      • jasje
        akshaaatt: aite but its unfinished (bp and profile left)
      • 2023-03-02 06127, 2023

      • akshaaatt
        It might be but BP was written in compose from the beginning
      • 2023-03-02 06134, 2023

      • akshaaatt
        Shouldn’t be that big of a deal
      • 2023-03-02 06151, 2023

      • akshaaatt
        Let’s define what difficult is.
      • 2023-03-02 06111, 2023

      • akshaaatt
        For me difficult is something which might take 3 months minimum
      • 2023-03-02 06136, 2023

      • akshaaatt
        Medium would be a month long
      • 2023-03-02 06159, 2023

      • akshaaatt
        If it can be done in a week, it should be easy
      • 2023-03-02 06131, 2023

      • jasje
        akshaaatt: its not about the compose
      • 2023-03-02 06145, 2023

      • jasje
        its about deciding where to put the heavier processes
      • 2023-03-02 06131, 2023

      • jasje
        since compose nav is faster than an actual activity creation
      • 2023-03-02 06149, 2023

      • jasje
        users sometime just keep clicking stuff
      • 2023-03-02 06158, 2023

      • jasje
        like spamming bottom nav
      • 2023-03-02 06134, 2023

      • jasje
        So more heavier processes are killed before they even complete
      • 2023-03-02 06104, 2023

      • akshaaatt
        I think thread management should be key here
      • 2023-03-02 06112, 2023

      • jasje
        check out my pr (just a sec) and check out dashboard activity, i've left some comments
      • 2023-03-02 06130, 2023

      • jasje
        akshaaatt: yes, i was thinking of using jetpack work manager
      • 2023-03-02 06157, 2023

      • jasje
        we get to decide what process to stacked and what to be run in parallel
      • 2023-03-02 06106, 2023

      • akshaaatt
        Kewl
      • 2023-03-02 06157, 2023

      • BrainzGit
        [listenbrainz-android] 1407jasjeet opened pull request #77 (03main…fix-app-nav-jasje): Converted activities to Composables https://github.com/metabrainz/listenbrainz-androi…
      • 2023-03-02 06100, 2023

      • jasje
        akshaaatt ^^
      • 2023-03-02 06102, 2023

      • vishwajeet590[m]
        <akshaaatt> "You boys can manage things..." <- UYup i am converting profile page to
      • 2023-03-02 06116, 2023

      • vishwajeet590[m]
        * Yup i am converting profile page to
      • 2023-03-02 06154, 2023

      • jasje
        vishwajeet590[m]: less goo. Expected time?
      • 2023-03-02 06124, 2023

      • vishwajeet590[m]
        <jasje> "Have you completed the assigned..." <- I had some doubts yesterday i messaged you at night.... Check it please
      • 2023-03-02 06148, 2023

      • jasje
        in IRC or personal?
      • 2023-03-02 06118, 2023

      • vishwajeet590[m]
        jasje: On matrix
      • 2023-03-02 06143, 2023

      • jasje
        Oh i don't use that, and feel free to carry on convos herre
      • 2023-03-02 06127, 2023

      • jasje
        All convos should be held here as per the rules in docs
      • 2023-03-02 06153, 2023

      • jasje
        Its easier for akshaaatt to see ya working
      • 2023-03-02 06122, 2023

      • vishwajeet590[m]
        jasje: Ahh, my bad.... I just want to confirm that when you meant profile you meant this right?
      • 2023-03-02 06124, 2023

      • vishwajeet590[m] uploaded an image: (68KiB) < https://libera.ems.host/_matrix/media/v3/download/matrix.org/YzeEQELYYbkUUGPFkzAIyobt/Screenshot_2023-03-01-23-40-02-44_59c729eaaf66e99c549e18aff5b20e11_20230302170335.jpg >
      • 2023-03-02 06103, 2023

      • akshaaatt
        Let’s do all dev related conversations on this channel and avoid personal dms
      • 2023-03-02 06131, 2023

      • jasje
        vishwajeet590[m] no top bar and thats it
      • 2023-03-02 06140, 2023

      • vishwajeet590[m]
        akshaaatt: Sorry wasn't aware of that..
      • 2023-03-02 06103, 2023

      • akshaaatt
        It’s alright! :)
      • 2023-03-02 06139, 2023

      • jasje_ joined the channel
      • 2023-03-02 06149, 2023

      • akshaaatt
        XD our profile page has to be rated one of the worst lmao
      • 2023-03-02 06159, 2023

      • akshaaatt
        Need to populate it
      • 2023-03-02 06110, 2023

      • jasje
        akshaaatt: tru xD
      • 2023-03-02 06122, 2023

      • jasje
      • 2023-03-02 06124, 2023

      • jivte joined the channel
      • 2023-03-02 06136, 2023

      • vishwajeet590[m]
        jasje: 😅 Didn't catch that...
      • 2023-03-02 06103, 2023

      • jasje
        vishwajeet590[m]: for the animation, use lottieanimation (we have already used it)
      • 2023-03-02 06126, 2023

      • akshaaatt
        vishwajeet590[m]: the idea is to keep the top bar and the bottom nav as components
      • 2023-03-02 06150, 2023

      • jasje
        The pic that i sent is what you have to convert to composable (only)
      • 2023-03-02 06103, 2023

      • jasje
        yupp same as above
      • 2023-03-02 06127, 2023

      • vishwajeet590[m]
        jasje: Oh ok got it now..
      • 2023-03-02 06154, 2023

      • jasje
        vishwajeet590[m]: animations are in values/raw file
      • 2023-03-02 06118, 2023

      • jasje
        R.raw.<anim>
      • 2023-03-02 06140, 2023

      • jasje has quit
      • 2023-03-02 06152, 2023

      • jivte has quit
      • 2023-03-02 06131, 2023

      • jivte joined the channel
      • 2023-03-02 06140, 2023

      • jivte has quit
      • 2023-03-02 06121, 2023

      • jasje_ has quit
      • 2023-03-02 06106, 2023

      • outsidecontext
        mayhem: would you copy these files once more? https://github.com/metabrainz/libdiscid/releases/…
      • 2023-03-02 06154, 2023

      • kellnerd has quit
      • 2023-03-02 06150, 2023

      • agatzk has quit
      • 2023-03-02 06155, 2023

      • agatzk joined the channel
      • 2023-03-02 06156, 2023

      • atj
        zas: are you around?
      • 2023-03-02 06148, 2023

      • reosarevok
        zas: same :D
      • 2023-03-02 06110, 2023

      • reosarevok
        bitmap, yvanzo: hi!
      • 2023-03-02 06123, 2023

      • yvanzo
        ho
      • 2023-03-02 06154, 2023

      • reosarevok
        I added aliases, annotations, tags, ratings and genres to the artist json schema thingy. Only *checks notes* half a million things to go
      • 2023-03-02 06113, 2023

      • bitmap
        hello
      • 2023-03-02 06139, 2023

      • reosarevok
        Would be nice to finish at least the artist lookup example and put it up on test though or something, hopefully next week
      • 2023-03-02 06151, 2023

      • reosarevok
        So, is it time to look at our schema change? :)
      • 2023-03-02 06109, 2023

      • bitmap
        yep, let me check my notes
      • 2023-03-02 06128, 2023

      • bitmap
        so MBS-12497 has already been released and is already in upgrade.json
      • 2023-03-02 06128, 2023

      • BrainzBot
        MBS-12497: artist_credit_gid_redirect blocks deleting artist credits https://tickets.metabrainz.org/browse/MBS-12497
      • 2023-03-02 06135, 2023

      • wargreen joined the channel
      • 2023-03-02 06145, 2023

      • yvanzo
        reosarevok: “I added…” where? link?
      • 2023-03-02 06149, 2023

      • bitmap
        and I see MBS-12704 already has a PR open. were there any other open PRs that are schema changes?
      • 2023-03-02 06149, 2023

      • BrainzBot
        MBS-12704: Remove historical "Watch artist" code https://tickets.metabrainz.org/browse/MBS-12704
      • 2023-03-02 06108, 2023

      • reosarevok
      • 2023-03-02 06122, 2023

      • yvanzo
        added to what?
      • 2023-03-02 06149, 2023

      • reosarevok
        bitmap: the milestone (https://github.com/metabrainz/musicbrainz-server/…) at least has no other PRs
      • 2023-03-02 06153, 2023

      • bitmap
        the openapi specification I assume
      • 2023-03-02 06119, 2023

      • reosarevok
      • 2023-03-02 06124, 2023

      • reosarevok
        (that I was working on now)
      • 2023-03-02 06132, 2023

      • yvanzo
        I thought the topic was schema change+s
      • 2023-03-02 06101, 2023

      • yvanzo
        I don’t see the WIP PR in this milestone.
      • 2023-03-02 06103, 2023

      • reosarevok
        Yeah, I wasn't talking schema change *yet*, this was before we started talking schema change :D
      • 2023-03-02 06125, 2023

      • reosarevok
        I was just sighing to the team about the whole thing, really :D Sorry for the confusion
      • 2023-03-02 06138, 2023

      • yvanzo
        About documentation then, we have the entity type naming issue to resolve.
      • 2023-03-02 06147, 2023

      • yvanzo
        It was due for the latest schema change.
      • 2023-03-02 06133, 2023

      • yvanzo
        Ok, thanks
      • 2023-03-02 06156, 2023

      • reosarevok
        [off topic from this convo] lol, just discovered the crazy person who self-assigned 800 jira tickets a few months ago also created a bunch of jira boards, removing them now
      • 2023-03-02 06119, 2023

      • reosarevok
        IIRC we have a few schema change tickets set to the next schema change fixversion in jira
      • 2023-03-02 06155, 2023

      • reosarevok
      • 2023-03-02 06129, 2023

      • reosarevok
        (so, actually, I guess https://github.com/metabrainz/musicbrainz-server/… should be in that milestone, heh - adding it now)