jivte: Looks like a great start! I will leave some comments
2023-03-06 06508, 2023
jivte
aerozol: Thanks comments improve design a lot (learning from add listen design) :)
2023-03-06 06513, 2023
aerozol
jivte: is there a ticket for this? I thought there was, but I can’t find it
2023-03-06 06544, 2023
aerozol
jivte: I think this is looking really nice! Everything is in my comments, but overall I think it looks good, and a very good start that we could add more complexity to later.
2023-03-06 06502, 2023
aerozol
I’d be keen for monkey to jump in and have a look too, once he’s up!
2023-03-06 06528, 2023
jivte
aerozol: No there was no ticket
2023-03-06 06503, 2023
jivte
actually i was planning this feature for gsoc so just needed a little help from you anyway thanks
2023-03-06 06517, 2023
jivte
was asked to develop the design myself
2023-03-06 06521, 2023
jivte
:|
2023-03-06 06543, 2023
aerozol
jivte: All good, good luck with the submission! I’m sure we will work together more if you get it :)
2023-03-06 06554, 2023
jivte
yeah will show design in today/tomorrow meet and yes that comment on addon features will discuss with monkey
2023-03-06 06511, 2023
akshaaatt
jasje I had fixed that issue already from what I remember
2023-03-06 06524, 2023
akshaaatt
Are you on the latest main?
2023-03-06 06555, 2023
aerozol
lucifer: is this text still accurate? “Importing the same listens from two different sources such as Last.FM and Spotify may cause the creation of duplicates in your listen history. If you opt into our automatic Spotify import, you may notice duplications in the last 50 listens on Spotify.This is a temporary issue while we find better ways to deduplicate listens.”
I would also like a prominent mention on the homepage aerozol
2023-03-06 06520, 2023
akshaaatt
Usually bigger websites have it on their footers
2023-03-06 06529, 2023
aerozol
WOULD YOU NOW
2023-03-06 06519, 2023
aerozol
In the footer sounds good, since we’re wanting to move away from people going to the homepage much
2023-03-06 06529, 2023
akshaaatt
Right
2023-03-06 06521, 2023
aerozol
It might be worth doing a ticket for that akshaaatt, I’ve made a note in my mockup, but there’s so many things to be implemented there. Unless you’re happy to wait
2023-03-06 06545, 2023
akshaaatt
Sure
2023-03-06 06548, 2023
akshaaatt
Will add
2023-03-06 06528, 2023
jivte has quit
2023-03-06 06542, 2023
aerozol
Hmm what license is all the ListenBrainz data made available under? I can’t find it anywhere
2023-03-06 06534, 2023
olbld has quit
2023-03-06 06532, 2023
aerozol
Not on the LB website or in the docs. Is my search-fu failing me once again?
2023-03-06 06533, 2023
olbld joined the channel
2023-03-06 06537, 2023
kapil joined the channel
2023-03-06 06514, 2023
kapil has quit
2023-03-06 06533, 2023
antlarr has quit
2023-03-06 06524, 2023
kapil_9441 joined the channel
2023-03-06 06518, 2023
kapil_9441
hello, I am Kapil, a 2nd year Computer Science undergraduate . I am new to open source contributions, but I have good knowledge of C, Html, CSS, JS, React and NodeJs . I would love to contribute to your organisation . Can you suggest me some Good first issues ?
2023-03-06 06504, 2023
kapil_9441 has quit
2023-03-06 06513, 2023
jasje_ joined the channel
2023-03-06 06508, 2023
jasje_
akshaaatt: i synced but the updates still didn’t come (Git desktops fault)
2023-03-06 06509, 2023
jasje_
anyways looks like the issue is fixed ill revert my commit :P
2023-03-06 06558, 2023
akshaaatt
That’s fine jasje_ but let’s avoid raising a concern until we are absolutely sure about something
2023-03-06 06517, 2023
akshaaatt
Otherwise it would end up leaving a false impression of the fixes we’ve made
2023-03-06 06502, 2023
jasje_
:P mb didn’t see that merged pr
2023-03-06 06536, 2023
jasje_
actually i got little time left yesterday and remembered the convo some days back
2023-03-06 06545, 2023
akshaaatt
lucifer: ended up spending some time looking into the thing and it makes it look like I didn’t fix the issue even though I had released
2023-03-06 06508, 2023
akshaaatt
It’s fine jasje_ :) let’s just take care in future
2023-03-06 06516, 2023
jasje_
akshaaatt: i had some questions
2023-03-06 06522, 2023
akshaaatt is off to river rafting now
2023-03-06 06527, 2023
akshaaatt
Anything urgent?
2023-03-06 06539, 2023
jasje_
well no
2023-03-06 06546, 2023
jasje_
go go
2023-03-06 06548, 2023
akshaaatt
Awesome then
2023-03-06 06555, 2023
aerozol
River rafting!! have fun akshaaatt
2023-03-06 06512, 2023
akshaaatt
Thanks a lot aerozol !
2023-03-06 06541, 2023
olbld has quit
2023-03-06 06559, 2023
olbld joined the channel
2023-03-06 06542, 2023
jasje joined the channel
2023-03-06 06542, 2023
jasje
aerozol: access granted!
2023-03-06 06511, 2023
aerozol
jasje: thanks! Now - what do you want me to do :)
2023-03-06 06533, 2023
jasje
The upper section looks bland to me like
2023-03-06 06547, 2023
jasje
the username pill isn't just feeling right
2023-03-06 06510, 2023
jasje
neither the follow following btn
2023-03-06 06542, 2023
jasje
also, not to mention the interface for a user to view someone else's profile
2023-03-06 06554, 2023
jasje
where to fit the follow button
2023-03-06 06551, 2023
jasje
the main problem with the design is that we can't include the profile picture which cancels out all the design i see online :(
2023-03-06 06526, 2023
aerozol
jasje: Cool, I’ve added it to my notes on the ticket: MOBILE-107
Cause you’ve caught me at the end of my workday. I have a few urgent things to do for monkey that he asked for last week, then I’ll dig into your mockup :)
2023-03-06 06550, 2023
jasje
aerozol: no problemo, ill be fixing my design until then!
monkey: I also did a mockup for how we could identify the user more clearly in the top menu. I didn’t workshop this much, but thought I’d check in if this is what you’re imagining. Or if you already have a great idea https://www.figma.com/file/YRbCOtFHBez8XmMdCKbGta…
2023-03-06 06543, 2023
aerozol
Tomorrow: How the sub-navbar works on mobile, and then I think I’ve covered the things we discussed Friday?
2023-03-06 06528, 2023
aerozol runs off to have dinner before the rest of the team gets up and I get caught in a loop of work
2023-03-06 06556, 2023
antlarr joined the channel
2023-03-06 06501, 2023
jasje_ has quit
2023-03-06 06556, 2023
shelly joined the channel
2023-03-06 06539, 2023
shelly
jasje: Currently a track can be pinned multiple times but I wanted to propose a solution for pinning a track only once. Can I raise an issue for that?
2023-03-06 06504, 2023
jasje
shelly: im probably not the right guy for this but as general advice you can always make tickets if you feel something is wrong and eventually youll have a response if the design is intended or not :)
2023-03-06 06550, 2023
jasje
ping mr_monkey maybe
2023-03-06 06508, 2023
shelly
jasje: Sure thing.
2023-03-06 06556, 2023
Pokey has quit
2023-03-06 06540, 2023
trolley has quit
2023-03-06 06501, 2023
trolley joined the channel
2023-03-06 06513, 2023
yvanzo
O’Moin
2023-03-06 06516, 2023
shelly has quit
2023-03-06 06553, 2023
reosarevok
moin!
2023-03-06 06516, 2023
reosarevok sighs
2023-03-06 06523, 2023
reosarevok
For some reason, I again can't get to JIRA
2023-03-06 06527, 2023
reosarevok
It works for everyone else, I assume?
2023-03-06 06506, 2023
zas
it works for me
2023-03-06 06539, 2023
yvanzo
Thanks zas, I checked logs, looks like an HW failure indeed. I’m not sure why PG refused to start either; bitmap might have a better insight of the “pooler error”.
2023-03-06 06501, 2023
mayhem
mooin!
2023-03-06 06558, 2023
zas
yes, it looks like a pure HW reset, nothing got reported by the kernel, and nothing was unusual before the crash
2023-03-06 06500, 2023
zas
PG didn't close cleanly in this context, so perhaps that's why it failed to come back
2023-03-06 06509, 2023
reosarevok
Sigh. Well, phone hotspot it is for now :)
2023-03-06 06540, 2023
yvanzo
reosarevok: Added a ticket for the sluggish report.
2023-03-06 06545, 2023
reosarevok
Thanks
2023-03-06 06553, 2023
kellnerd joined the channel
2023-03-06 06526, 2023
lucifer
aerozol: yeah that description sounds right.
2023-03-06 06557, 2023
lucifer
mayhem: about the troi rate limit issues, i think directly accessing the database is the best solution.
2023-03-06 06546, 2023
lucifer
i tried using the extended ratelimit with approved token but that exhausts soon too.
2023-03-06 06512, 2023
lucifer
would likely work for a few days and break again if more users register for daily jams.
2023-03-06 06541, 2023
mayhem
remember that we can change rate limits on a per key basis.
2023-03-06 06547, 2023
mayhem
we can make troi's key unlimited.
2023-03-06 06556, 2023
mayhem
should we try that first?
2023-03-06 06513, 2023
mayhem
because instead of direct DB access, I would much prefer to port solid patches to spark.
2023-03-06 06535, 2023
lucifer
sure can try that.
2023-03-06 06506, 2023
lucifer
yeah i guess if we port it to spark then adding db access isn't worthwhile.
2023-03-06 06500, 2023
mayhem
porting to spark has always been the plan -- troi is literally just the sandbox to learn how to do it. but weekly jams and weekly new jams are likely the first candidates to be ported.
2023-03-06 06509, 2023
mayhem
once those are shaken out.
2023-03-06 06541, 2023
mayhem
I wonder about the best way for troi to ensure it has a high rate limit since those are kept in redis.
2023-03-06 06514, 2023
mayhem
might just be good to have a small function automatically set the key limit to something huge before we invoke troi for running recs.
2023-03-06 06516, 2023
mayhem
what do you think?
2023-03-06 06512, 2023
lucifer
mayhem: we have define those on app init, currently it is 50. we can just change it to say 50000.
2023-03-06 06531, 2023
mayhem
yep, that
2023-03-06 06507, 2023
mayhem
but lets not add that rate limiting code to troi -- it think it should live in the spark code that calls troi
2023-03-06 06537, 2023
lucifer
uh not that ratelimit code will go to LB main webserver.
2023-03-06 06548, 2023
mayhem
when do you plan to call the rate limit setting code? at start of app? what is redis is reset after the start of app?
the current number of requests is in redis, the threshold to check it against in python and we already have a function to configure the threshold in BU.
2023-03-06 06512, 2023
mayhem
but doesn't that chance the rate limit for *all* tokens? that's not what we want, is it?
2023-03-06 06534, 2023
shelly joined the channel
2023-03-06 06539, 2023
lucifer
yeah that changes the ratelimit for all tokens but we only have one token currently.
