#metabrainz

/

      • mayhem
        we should in the future have an API endpoint where we provide a list of recording_mbids and get back that list of recording_mbids with last (or never) listened at.
      • 2023-03-06 06506, 2023

      • mayhem
        the thing is, all other patches will need this too.
      • 2023-03-06 06520, 2023

      • mayhem
        well, not so much new jams, but artists radio does.
      • 2023-03-06 06548, 2023

      • lucifer
        i think TS can support that fast once we resize the chunks.
      • 2023-03-06 06501, 2023

      • lucifer
        scan the 8-10 latest chunks only.
      • 2023-03-06 06532, 2023

      • mayhem
        it would be nice to not have to make yet another dataset.
      • 2023-03-06 06535, 2023

      • lucifer
        that gives us whether the track was listened to in the last 3 months
      • 2023-03-06 06545, 2023

      • mayhem
        that should be sufficient.
      • 2023-03-06 06517, 2023

      • mayhem
        I forget, we still had a rewrite of the listens table planned, but that hasn't happened yet, right?
      • 2023-03-06 06523, 2023

      • lucifer
        i'll add that endpoint and once we resize the chunks i hope it to become faster.
      • 2023-03-06 06527, 2023

      • mayhem
        resizing chunks should be done at the same time?
      • 2023-03-06 06542, 2023

      • lucifer
        not necessarily,
      • 2023-03-06 06553, 2023

      • lucifer
        but we planned to do it at the same time.
      • 2023-03-06 06514, 2023

      • lucifer
        the rewrite is pending on figuring out how to display the timezone data to users.
      • 2023-03-06 06517, 2023

      • mayhem
        ok, sounds good. that will improve the run time of the upcoming patches. they keep getting more and more intensive. :(
      • 2023-03-06 06540, 2023

      • mayhem
        how to display it or how to store it?
      • 2023-03-06 06501, 2023

      • lucifer
        figure out how to display so that we can work out what exactly to store.
      • 2023-03-06 06533, 2023

      • mayhem
        what are the sticking points on this topic?
      • 2023-03-06 06522, 2023

      • lucifer
        LB-1213 is the ticket.
      • 2023-03-06 06523, 2023

      • BrainzBot
        LB-1213: How to display timezone aware listens to users? https://tickets.metabrainz.org/browse/LB-1213
      • 2023-03-06 06548, 2023

      • lucifer
        but i see it doesn't have the updated info from the last discussion with aerozol and alastairp. i'll re read the chatlogs and update it.
      • 2023-03-06 06558, 2023

      • lucifer
        and we can discuss it again sometime later this week i guess.
      • 2023-03-06 06517, 2023

      • mayhem
        ok, let make a decision on how to proceed this week.
      • 2023-03-06 06531, 2023

      • BrainzGit
        [listenbrainz-server] 14amCap1712 merged pull request #2381 (03master…dep-updates): Update numpy and decode-uri-component https://github.com/metabrainz/listenbrainz-server…
      • 2023-03-06 06535, 2023

      • lucifer
        cool sounds good
      • 2023-03-06 06551, 2023

      • BrainzGit
        [listenbrainz-server] 14amCap1712 merged pull request #2383 (03master…ac-mbid-fmt-fix): LB-1223: /1/metadata/lookup should return array for "artist_mbids" https://github.com/metabrainz/listenbrainz-server…
      • 2023-03-06 06516, 2023

      • kapil_9441 joined the channel
      • 2023-03-06 06530, 2023

      • BrainzGit
        [listenbrainz-server] 14amCap1712 merged pull request #2382 (03master…current-pin): LB-1232: Add an API endpoint to get a user's current pin https://github.com/metabrainz/listenbrainz-server…
      • 2023-03-06 06504, 2023

      • d4rkie joined the channel
      • 2023-03-06 06531, 2023

      • d4rk-ph0enix has quit
      • 2023-03-06 06538, 2023

      • rozlav joined the channel
      • 2023-03-06 06520, 2023

      • jasje has quit
      • 2023-03-06 06502, 2023

      • kapil_9441 has quit
      • 2023-03-06 06512, 2023

      • mayhem
        monkey: how do you center an image in a div? lolololol. rookie question. :)
      • 2023-03-06 06532, 2023

      • mayhem
        can I put the explore page back on test for you to look to give me some tips?
      • 2023-03-06 06537, 2023

      • monkey
        Ahaaa, it really depends.
      • 2023-03-06 06545, 2023

      • monkey
        Sure thing, you can put it on test
      • 2023-03-06 06547, 2023

      • mayhem
        I've spent half an hour on it and I am not making any headway.
      • 2023-03-06 06547, 2023

      • mayhem
        ok
      • 2023-03-06 06500, 2023

      • monkey
        Is that the background image that is clipped?
      • 2023-03-06 06507, 2023

      • mayhem
        yes.
      • 2023-03-06 06514, 2023

      • mayhem
        it should be vertically centered.
      • 2023-03-06 06557, 2023

      • monkey
      • 2023-03-06 06511, 2023

      • mayhem looks
      • 2023-03-06 06512, 2023

      • mayhem
        thanks
      • 2023-03-06 06520, 2023

      • monkey
        Most likely `background-position: center center`
      • 2023-03-06 06508, 2023

      • mayhem
        does background-position require the image to be CSS backgroun image? because right now its an img tag.
      • 2023-03-06 06507, 2023

      • mayhem
      • 2023-03-06 06502, 2023

      • monkey
        Ah, I see, that's why I was asking if it was a background :) It won't work that way then. Let me take a look
      • 2023-03-06 06538, 2023

      • mayhem
        oh, sorry, I didn't quite understand that question correctly.
      • 2023-03-06 06544, 2023

      • monkey
        No worries.
      • 2023-03-06 06500, 2023

      • monkey
        CSS, amirite?
      • 2023-03-06 06507, 2023

      • mayhem
        yerp
      • 2023-03-06 06510, 2023

      • antlarr has quit
      • 2023-03-06 06537, 2023

      • antlarr joined the channel
      • 2023-03-06 06534, 2023

      • monkey
        OK, maybe not the absolute most bare-bones approach, but definitely the easiest way to do this is to add the `flex-center` class to the parent element.
      • 2023-03-06 06535, 2023

      • monkey
        This is one of our custom classes that makes the parent a flex container and centers the children.
      • 2023-03-06 06505, 2023

      • monkey
      • 2023-03-06 06510, 2023

      • monkey
        I reckon that does what you had in mind
      • 2023-03-06 06514, 2023

      • mayhem
        parent being explore-card-img-clip?
      • 2023-03-06 06517, 2023

      • mayhem
        yes!
      • 2023-03-06 06518, 2023

      • monkey
        yes
      • 2023-03-06 06528, 2023

      • monkey
      • 2023-03-06 06541, 2023

      • mayhem
        what am I doing 'wrong?
      • 2023-03-06 06544, 2023

      • mayhem
      • 2023-03-06 06524, 2023

      • olbld has quit
      • 2023-03-06 06555, 2023

      • shelly has quit
      • 2023-03-06 06523, 2023

      • antlarr has quit
      • 2023-03-06 06518, 2023

      • antlarr joined the channel
      • 2023-03-06 06512, 2023

      • monkey
        I have no idea. Works in my browser… What browser are you using?
      • 2023-03-06 06525, 2023

      • monkey spins up FF
      • 2023-03-06 06507, 2023

      • olbld joined the channel
      • 2023-03-06 06533, 2023

      • monkey
      • 2023-03-06 06518, 2023

      • mayhem
        FF. odd.
      • 2023-03-06 06536, 2023

      • mayhem
        🤦
      • 2023-03-06 06548, 2023

      • mayhem
        looking at the wrong tab. FFS, Mr. Kaye.
      • 2023-03-06 06549, 2023

      • mayhem
        sorry.
      • 2023-03-06 06553, 2023

      • monkey
        Hehe
      • 2023-03-06 06525, 2023

      • mayhem
      • 2023-03-06 06525, 2023

      • mayhem
      • 2023-03-06 06552, 2023

      • mayhem
        monkey: ^^ I think changing the breaks is the only thing that is left. any tips on how to do that?
      • 2023-03-06 06535, 2023

      • olbld has quit
      • 2023-03-06 06552, 2023

      • olbld joined the channel
      • 2023-03-06 06558, 2023

      • atj
        this is bootstrap right?
      • 2023-03-06 06504, 2023

      • monkey
        Yes, media queries. But this means departing from bootstrap scaffolding
      • 2023-03-06 06530, 2023

      • monkey
        I'm trying out some of the existing BS breakpoints to see if they could match those dimensions close enough
      • 2023-03-06 06541, 2023

      • mayhem
        ok
      • 2023-03-06 06506, 2023

      • atj
        can you not use bootstrap breakpoints?
      • 2023-03-06 06508, 2023

      • atj
        ah
      • 2023-03-06 06515, 2023

      • monkey
        Other wise it will mean removing the BS scaffolding classes, and writing custom CSS to manage the element width as percentages depending on screen size. Not toooo ticky.
      • 2023-03-06 06510, 2023

      • mayhem
        is that worth it? for this page?
      • 2023-03-06 06523, 2023

      • monkey
        It's only a few lines of CSS in the end
      • 2023-03-06 06530, 2023

      • mayhem
        ok
      • 2023-03-06 06550, 2023

      • reosarevok
        zas: oops, I just noticed you replied only to the account admins account with that French email
      • 2023-03-06 06512, 2023

      • reosarevok
        Because for some reason reply-to is kept when they answer me?
      • 2023-03-06 06519, 2023

      • reosarevok
        I'll forward it to them
      • 2023-03-06 06532, 2023

      • monkey
        We're too limited by BS breakpoints I think mayhem.
      • 2023-03-06 06532, 2023

      • monkey
        Instead of using BS scaffolding classes (col-xx-xx), you'll need to give the card container element a class name to target.
      • 2023-03-06 06532, 2023

      • monkey
        Then here's what the css would look like for those elements:
      • 2023-03-06 06539, 2023

      • monkey
      • 2023-03-06 06531, 2023

      • monkey
        Oh, and you will also need `float: left;` to replicate the way bootstrap grid elements stack neatly
      • 2023-03-06 06526, 2023

      • monkey
        And apply the padding again as well :)
      • 2023-03-06 06527, 2023

      • monkey
        `padding-left: 15px; padding-right: 15px;`
      • 2023-03-06 06521, 2023

      • mayhem
        sorry, I can't say I am following all of that.
      • 2023-03-06 06529, 2023

      • monkey
        Yep. One sec plz :)
      • 2023-03-06 06522, 2023

      • monkey
        So: the top-most divs for each card get their bootstrap classes removed, and replaced by a custom class name. I went for `explore-card-container`: https://usercontent.irccloud-cdn.com/file/F7FzmYM…
      • 2023-03-06 06538, 2023

      • monkey
        And then here's the css code for said class:
      • 2023-03-06 06542, 2023

      • monkey
      • 2023-03-06 06507, 2023

      • monkey
        You'll see we defined a width of 100%, then in the media queries below we overwrite it based on the screen size
      • 2023-03-06 06507, 2023

      • monkey
        In LESS we can shorten that a tiny bit because we can do nesting:
      • 2023-03-06 06514, 2023

      • monkey
      • 2023-03-06 06548, 2023

      • mayhem
      • 2023-03-06 06544, 2023

      • mayhem
        not working flawlessly here:
      • 2023-03-06 06547, 2023

      • mayhem
      • 2023-03-06 06500, 2023

      • mayhem
        let me push to test
      • 2023-03-06 06507, 2023

      • mayhem
        I must've gotten something wrong: https://test.listenbrainz.org/explore/
      • 2023-03-06 06506, 2023

      • monkey
        mmm, something not quite right with one of the card images, let me dig
      • 2023-03-06 06529, 2023

      • trolley has quit
      • 2023-03-06 06556, 2023

      • trolley joined the channel
      • 2023-03-06 06508, 2023

      • trolley has quit
      • 2023-03-06 06535, 2023

      • trolley joined the channel
      • 2023-03-06 06534, 2023

      • trolley has quit
      • 2023-03-06 06540, 2023

      • monkey
        Right, the cover art collage image when resized is smaller than the 171px we need to fill the card image container, which results in this weird layout. one fix is to change the .explore-card-img-clip `max-height` css property to `height` instead, which will fix the layout (but not the image ration as you can see in this screenshot:)
      • 2023-03-06 06543, 2023

      • monkey
      • 2023-03-06 06551, 2023

      • monkey
        s/ration/ratio
      • 2023-03-06 06525, 2023

      • trolley joined the channel
      • 2023-03-06 06525, 2023

      • mayhem
        confirmed.
      • 2023-03-06 06545, 2023

      • monkey
        That was all probably introduced by the flex centering of the images
      • 2023-03-06 06533, 2023

      • trolley has quit
      • 2023-03-06 06502, 2023

      • trolley joined the channel
      • 2023-03-06 06508, 2023

      • trolley has quit
      • 2023-03-06 06533, 2023

      • monkey
        If I'm honest at this point the easiest fix is probably to resize that one image…
      • 2023-03-06 06551, 2023

      • mayhem
        the collage one?
      • 2023-03-06 06552, 2023

      • trolley joined the channel
      • 2023-03-06 06555, 2023

      • monkey
        Yes
      • 2023-03-06 06556, 2023

      • mayhem
        k, let me try
      • 2023-03-06 06533, 2023

      • BrainzGit
        [musicbrainz-server] 14reosarevok opened pull request #2882 (03master…MBS-12962): MBS-12962: Don't ISE on undef track_offset https://github.com/metabrainz/musicbrainz-server/…
      • 2023-03-06 06503, 2023

      • mayhem
        monkey: thanks for all the help, let's hope that was the last of it: https://test.listenbrainz.org/explore/
      • 2023-03-06 06536, 2023

      • monkey
        Oh, I'm sure i'll come up with some pesky details in review ;p
      • 2023-03-06 06544, 2023

      • monkey
        That being said, it looks great at the moment
      • 2023-03-06 06547, 2023

      • monkey
        !m
      • 2023-03-06 06551, 2023

      • monkey
        !m mayhem
      • 2023-03-06 06551, 2023

      • BrainzBot
        You're doing good work, mayhem!
      • 2023-03-06 06532, 2023

      • monkey
        Stamp of approval as far as I'm concerned
      • 2023-03-06 06545, 2023

      • mayhem
        let me get the PR ready for review then
      • 2023-03-06 06529, 2023

      • Sophist_UK has quit
      • 2023-03-06 06528, 2023

      • mayhem
        monkey: I merged in the latest master but frontend tests are failing from... unrelated things?
      • 2023-03-06 06529, 2023

      • mayhem
      • 2023-03-06 06557, 2023

      • ShivamAwasthi joined the channel
      • 2023-03-06 06512, 2023

      • monkey
        It looks like the linting of your less files is what's failing, unless I'm missing something. Try running `npm run lint:less` if you have node installed locally, or `./test.sh fe -f` for docker version