#metabrainz

/

      • monkey
      • 2023-03-06 06500, 2023

      • reosarevok
        yvanzo: around?
      • 2023-03-06 06507, 2023

      • yvanzo
        yes
      • 2023-03-06 06519, 2023

      • ShivamAwasthi
        Can someone tell me what is this arrow/connection graphic being used here in this mockup (https://tickets.metabrainz.org/secure/attachment/…
      • 2023-03-06 06520, 2023

      • BrainzBot
        MBS-12866: Make grouping relationship types more visible in dropdowns
      • 2023-03-06 06515, 2023

      • reosarevok
        yvanzo: so, you added the Content of type ' + typeof content + ' cannot be compared as a string to entity name for name variation error recently
      • 2023-03-06 06529, 2023

      • yvanzo
        ShivamAwasthi: It matches relationship types hierarchy; See https://musicbrainz.org/relationships/artist-reco…
      • 2023-03-06 06541, 2023

      • reosarevok
        But content is actually supposed to be Expand2ReactOutput, so it being an object is perfectly legitimate
      • 2023-03-06 06519, 2023

      • reosarevok
      • 2023-03-06 06527, 2023

      • reosarevok
        (that is hitting the error right now)
      • 2023-03-06 06534, 2023

      • reosarevok
        What was the expected action in these cases? :)
      • 2023-03-06 06524, 2023

      • reosarevok
        (I opened MBS-12970 for this, in any case)
      • 2023-03-06 06525, 2023

      • BrainzBot
        MBS-12970: Name variation error on Edit release edit https://tickets.metabrainz.org/browse/MBS-12970
      • 2023-03-06 06531, 2023

      • reosarevok
        I assume the point of nameVariation === undefined && typeof content === 'string' is that if we're passing an object, we assume that's a name variation, so should we just pass nameVariation={true} in those cases?
      • 2023-03-06 06529, 2023

      • ShivamAwasthi
        yvanzo I meant what is the icon/graphic being used in this mockup for depicting the hierarchy. I am looking at BB-625 but can't find an icon similar to that in the icon library which we are using on BB. How to get that graphic/icon? Here's where I'm at (https://pasteboard.co/6gHBlWumE9uv.png)
      • 2023-03-06 06529, 2023

      • BrainzBot
        BB-625: Indication between parent and child in relationship search field https://tickets.metabrainz.org/browse/BB-625
      • 2023-03-06 06535, 2023

      • yvanzo
        reosarevok: It seems that nameVariation should be set here.
      • 2023-03-06 06503, 2023

      • yvanzo
        The entity link is not just using the name of the entity.
      • 2023-03-06 06511, 2023

      • yvanzo
        (for content)
      • 2023-03-06 06557, 2023

      • yvanzo
        ShivamAwasthi: no idea, it's just a mockup, maybe aerozol knows as he drew it.
      • 2023-03-06 06510, 2023

      • reosarevok
        So just set it by hand, ok, can do
      • 2023-03-06 06549, 2023

      • yvanzo
        yes, thanks
      • 2023-03-06 06508, 2023

      • yvanzo
        ShivamAwasthi: if you find a way to implement it in BB, please share it in comment to https://tickets.metabrainz.org/browse/MBS-12866 :)
      • 2023-03-06 06509, 2023

      • BrainzBot
        MBS-12866: Make grouping relationship types more visible in dropdowns
      • 2023-03-06 06538, 2023

      • ShivamAwasthi
        yvanzo sure
      • 2023-03-06 06527, 2023

      • mayhem
      • 2023-03-06 06528, 2023

      • reosarevok
        yvanzo: actually... the span content is sideACountry.name
      • 2023-03-06 06548, 2023

      • reosarevok
        So I'm actually thinking maybe it should instead be manually set to nameVariation={false}?
      • 2023-03-06 06557, 2023

      • reosarevok
        Since sure, there's a span, but the name itself is the name itself
      • 2023-03-06 06524, 2023

      • reosarevok
        (the point of the span is just to add diff-only-a or whatnot as needed AFAICT)
      • 2023-03-06 06549, 2023

      • ShivamAwasthi has quit
      • 2023-03-06 06551, 2023

      • reosarevok
        I think I'll set it as false for now
      • 2023-03-06 06554, 2023

      • yvanzo
        It's possibly a span, not just the name.
      • 2023-03-06 06506, 2023

      • yvanzo
        Whichever value makes sense is fine.
      • 2023-03-06 06542, 2023

      • yvanzo
        It is also possible to move the ternary operator out of EntityLink’s content.
      • 2023-03-06 06508, 2023

      • ShivamAwasthi joined the channel
      • 2023-03-06 06529, 2023

      • reosarevok
        Yes, but the content of the span is just the name
      • 2023-03-06 06556, 2023

      • reosarevok
        If I understand correctly, the point of nameVariation is basically so people can see which printed content does not match the entity name
      • 2023-03-06 06504, 2023

      • reosarevok
        So in this case, both printed contents will match it :)
      • 2023-03-06 06508, 2023

      • ShivamAwasthi has quit
      • 2023-03-06 06533, 2023

      • BrainzGit
        [musicbrainz-server] 14reosarevok opened pull request #2883 (03master…MBS-12970): MBS-12970: Negate nameVariation for release country diffs https://github.com/metabrainz/musicbrainz-server/…
      • 2023-03-06 06552, 2023

      • yvanzo
        "the point of nameVariation" +set to true "is..."
      • 2023-03-06 06544, 2023

      • yvanzo
        (we agree about it anyway)
      • 2023-03-06 06514, 2023

      • reosarevok
        Ok :)
      • 2023-03-06 06516, 2023

      • jasje joined the channel
      • 2023-03-06 06548, 2023

      • jasje
        vishwajeet590[m]: how's work going?
      • 2023-03-06 06558, 2023

      • smach joined the channel
      • 2023-03-06 06517, 2023

      • bitmap
        zas: iirc pg will only autostart if there's an AUTOSTART file in the postgres home directory. (this isn't a pg feature, but something we added to control which order primary/standby start in if needed)
      • 2023-03-06 06532, 2023

      • bitmap
        I guess that file is missing, I will add it
      • 2023-03-06 06523, 2023

      • smach has quit
      • 2023-03-06 06530, 2023

      • reosarevok
        bitmap: hi! can you take a quick look at MBS-12966 and see if you agree with my understanding?
      • 2023-03-06 06531, 2023

      • BrainzBot
        MBS-12966: Regression: Specifying an attribute to a relationship duplicates it https://tickets.metabrainz.org/browse/MBS-12966
      • 2023-03-06 06523, 2023

      • BrainzGit
        [musicbrainz-server] 14reosarevok closed pull request #2883 (03master…MBS-12970): MBS-12970: Negate nameVariation for release country diffs https://github.com/metabrainz/musicbrainz-server/…
      • 2023-03-06 06537, 2023

      • reosarevok doing a smart.
      • 2023-03-06 06515, 2023

      • bitmap
        :)
      • 2023-03-06 06527, 2023

      • bitmap
        I think it was merged to production actually. maybe prod wasn't merged to master yet?
      • 2023-03-06 06550, 2023

      • reosarevok
        Oh. Maybe? Did we merge it with my hotfix? I might not have merged that back to master
      • 2023-03-06 06522, 2023

      • reosarevok
        Double sigh
      • 2023-03-06 06550, 2023

      • bitmap
        pretty sure we included it in the initial release, so before your hotfix
      • 2023-03-06 06547, 2023

      • reosarevok
        Did we? the PR said we were waiting
      • 2023-03-06 06557, 2023

      • reosarevok
        Anyway, I did the prod to master merge and it was there
      • 2023-03-06 06503, 2023

      • reosarevok
        So it's now on master and I'm dumb :p
      • 2023-03-06 06506, 2023

      • reosarevok
        Thanks!
      • 2023-03-06 06557, 2023

      • bitmap
        well I thought we ended up releasing it anyway but not 100% sure
      • 2023-03-06 06503, 2023

      • reosarevok
        At least the ticket is new :p
      • 2023-03-06 06511, 2023

      • reosarevok
        Anyway, all good now, sorry for the noise
      • 2023-03-06 06540, 2023

      • bitmap
        I think you're understanding of that ticket is correct btw, but that behavior isn't new
      • 2023-03-06 06544, 2023

      • bitmap
        your*
      • 2023-03-06 06506, 2023

      • bitmap
        it was changed years ago by MBS-11181
      • 2023-03-06 06507, 2023

      • BrainzBot
        MBS-11181: Unable to add ended relationship when another relationship to the same target already exists https://tickets.metabrainz.org/browse/MBS-11181
      • 2023-03-06 06509, 2023

      • bitmap
        however in Griomo's example both their dates are ended, so I'm not sure what is preventing those from being merged for them
      • 2023-03-06 06549, 2023

      • reosarevok
        That report comes from the beta period, was the merge temporarily broken then.
      • 2023-03-06 06553, 2023

      • reosarevok
        *?
      • 2023-03-06 06556, 2023

      • bitmap
        not that I can remember, and they commented again after the prod release
      • 2023-03-06 06559, 2023

      • reosarevok
        Yeah, I just wasn't sure if that second comment was only re task
      • 2023-03-06 06538, 2023

      • bitmap
        (unrelated) maybe we should revert back to the old related works UI, hiding rels for duplicate works. the new one seems endlessly confusing to people (and I don't blame them)
      • 2023-03-06 06530, 2023

      • BrainzGit
        [musicbrainz-android] 14dependabot[bot] opened pull request #212 (03master…dependabot/gradle/com.android.tools.build-gradle-7.4.2): Bump com.android.tools.build:gradle from 7.3.1 to 7.4.2 https://github.com/metabrainz/musicbrainz-android…
      • 2023-03-06 06535, 2023

      • BrainzGit
        [musicbrainz-android] 14dependabot[bot] closed pull request #196 (03master…dependabot/gradle/com.android.tools.build-gradle-7.4.1): Bump com.android.tools.build:gradle from 7.3.1 to 7.4.1 https://github.com/metabrainz/musicbrainz-android…
      • 2023-03-06 06508, 2023

      • BrainzGit
        [listenbrainz-android] 14dependabot[bot] opened pull request #81 (03main…dependabot/gradle/com.google.android.exoplayer-exoplayer-ui-2.18.4): Bump com.google.android.exoplayer:exoplayer-ui from 2.18.3 to 2.18.4 https://github.com/metabrainz/listenbrainz-androi…
      • 2023-03-06 06523, 2023

      • BrainzGit
        [listenbrainz-android] 14dependabot[bot] opened pull request #82 (03main…dependabot/gradle/com.google.android.exoplayer-exoplayer-core-2.18.4): Bump com.google.android.exoplayer:exoplayer-core from 2.18.3 to 2.18.4 https://github.com/metabrainz/listenbrainz-androi…
      • 2023-03-06 06534, 2023

      • BrainzGit
        [listenbrainz-android] 14dependabot[bot] opened pull request #83 (03main…dependabot/gradle/com.google.android.exoplayer-extension-mediasession-2.18.4): Bump com.google.android.exoplayer:extension-mediasession from 2.18.3 to 2.18.4 https://github.com/metabrainz/listenbrainz-androi…
      • 2023-03-06 06507, 2023

      • mayhem
        monkey: do you have a page that shows the page layout you mentioned in the PR review?
      • 2023-03-06 06522, 2023

      • mayhem
        I've got function ExplorePage, but I am lost at how to pass it the current_user.
      • 2023-03-06 06539, 2023

      • monkey
        I see, let me get that for you.
      • 2023-03-06 06506, 2023

      • monkey
      • 2023-03-06 06525, 2023

      • monkey
        You'll need to import `GlobalAppContext` as well : https://github.com/metabrainz/listenbrainz-server…
      • 2023-03-06 06515, 2023

      • mayhem
        oh, totes obvious.
      • 2023-03-06 06517, 2023

      • mayhem
        thanks!
      • 2023-03-06 06526, 2023

      • monkey
        Well, less so for class components ! :)
      • 2023-03-06 06533, 2023

      • monkey
        But yes, easy to use with hooks
      • 2023-03-06 06515, 2023

      • mayhem
        ok, PR improvement fix pushed. have a look!
      • 2023-03-06 06521, 2023

      • kellnerd49 joined the channel
      • 2023-03-06 06547, 2023

      • monkey
        mayhem: Re-reviewed, pretty much ready to merge. Can I deploy LB#2378 to test, or would you rather I waited?
      • 2023-03-06 06548, 2023

      • BrainzBot
        Remove "Charts" tab from user page: https://github.com/metabrainz/listenbrainz-server…
      • 2023-03-06 06505, 2023

      • mayhem
        go for it.
      • 2023-03-06 06509, 2023

      • monkey
        👍
      • 2023-03-06 06512, 2023

      • mayhem
        I'll make the last fix and merge.
      • 2023-03-06 06552, 2023

      • kellnerd has quit
      • 2023-03-06 06509, 2023

      • kellnerd49 is now known as kellnerd
      • 2023-03-06 06514, 2023

      • mayhem
        monkey: for the new datasets page:
      • 2023-03-06 06517, 2023

      • mayhem
      • 2023-03-06 06534, 2023

      • mayhem
        are there any vomit inducing things I should take care of right away?
      • 2023-03-06 06541, 2023

      • jivte joined the channel
      • 2023-03-06 06552, 2023

      • mayhem
        icon centering for one.
      • 2023-03-06 06537, 2023

      • mayhem
        which, of course, I've spend half an hour on before giving up again. lol
      • 2023-03-06 06521, 2023

      • jivte
        monkey: Hey!!
      • 2023-03-06 06558, 2023

      • jivte
        a little help needed could you too review this figma design
      • 2023-03-06 06501, 2023

      • jivte
      • 2023-03-06 06546, 2023

      • BrainzGit
        [listenbrainz-server] 14mayhem merged pull request #2372 (03master…explore-page): Explore page https://github.com/metabrainz/listenbrainz-server…
      • 2023-03-06 06503, 2023

      • monkey
        mayhem, yes, the icon centering :) apart from that it looks better than the previous version, so 👍
      • 2023-03-06 06525, 2023

      • monkey
        jivte: Hi! I'll try to do that tomorrow, but I've got a lot of things to review at the moment
      • 2023-03-06 06528, 2023

      • mayhem
        cool.
      • 2023-03-06 06540, 2023

      • mayhem
        I'm not going to worry about fixing all the little details just yet.
      • 2023-03-06 06513, 2023

      • mayhem
        one bit of feedback and all that could be wasted, so I'll proceed with this and make minor improvements, but start getting text up tomorrow.
      • 2023-03-06 06522, 2023

      • monkey
        OK
      • 2023-03-06 06516, 2023

      • jasje_ joined the channel
      • 2023-03-06 06516, 2023

      • reosarevok
        bitmap: if you can find a way to make it not confusing when there's duplicate works and you hide some rels?
      • 2023-03-06 06518, 2023

      • reosarevok
        Also
      • 2023-03-06 06521, 2023

      • reosarevok
        <BANG>
      • 2023-03-06 06542, 2023

      • KassOtsimine
        bimbam boom bimbam boom
      • 2023-03-06 06547, 2023

      • reosarevok
        Welcome to the next edition of What Is Happening at MetaBrainzLand!
      • 2023-03-06 06548, 2023

      • aerozol cheers
      • 2023-03-06 06516, 2023

      • reosarevok
        Nobody has sent a mailed in review this time
      • 2023-03-06 06533, 2023

      • reosarevok
        So, let's start
      • 2023-03-06 06540, 2023

      • ZaphodBeeblebrox
        hi
      • 2023-03-06 06545, 2023

      • reosarevok
        ZaphodBeeblebrox: go!
      • 2023-03-06 06500, 2023

      • reosarevok
        Other people on my list today: reosarevok, bitmap, zas, mayhem, yvanzo, monkey, lucifer, akshaaatt, atj, aerozol, Pratha-Fish, riksucks, jasje, jivte, kellnerd
      • 2023-03-06 06501, 2023

      • ZaphodBeeblebrox
        so I've been working on bagpipe aliases slwoly
      • 2023-03-06 06510, 2023

      • ZaphodBeeblebrox
        still kinda got a throat bug but it's clearing up
      • 2023-03-06 06533, 2023

      • ZaphodBeeblebrox
        hoping to finish with gaita like aliases this week and move on to closing more bagpipess after that
      • 2023-03-06 06546, 2023

      • ZaphodBeeblebrox
        next can be kellnerd
      • 2023-03-06 06504, 2023

      • kellnerd
        Hi all, last week I mostly worked on BB-530.
      • 2023-03-06 06505, 2023

      • BrainzBot
      • 2023-03-06 06516, 2023

      • ZaphodBeeblebrox
        :o
      • 2023-03-06 06529, 2023

      • kellnerd
        Wikipedia abstracts are now displayed for all entities which have a Wikidata identifier, language is selected based on the HTTP Accept-Language header, i.e. your browser settings.
      • 2023-03-06 06544, 2023

      • reosarevok
        Sweet.
      • 2023-03-06 06508, 2023

      • monkey
        Eventually
      • 2023-03-06 06512, 2023

      • kellnerd
        Fallback are English and alias languages as BB does not have i18n support yet.
      • 2023-03-06 06513, 2023

      • ZaphodBeeblebrox
        sweet
      • 2023-03-06 06537, 2023

      • kellnerd
        Still to be done: Automatic collapsing and caching
      • 2023-03-06 06517, 2023

      • kellnerd
        Other than that I fixed a userscript bug following the MBS release and deleted code for the old relationship editor :)
      • 2023-03-06 06540, 2023

      • kellnerd
        That's it from me. Go atj!
      • 2023-03-06 06553, 2023

      • atj
        thanks kellnerd
      • 2023-03-06 06525, 2023

      • atj
        last week I started working on an ansible role for installing and managing borg and borgmatic
      • 2023-03-06 06548, 2023

      • atj
        so that we can automate backups
      • 2023-03-06 06518, 2023

      • atj
        that's it, bitmap?
      • 2023-03-06 06537, 2023

      • bitmap
        hey
      • 2023-03-06 06549, 2023

      • reosarevok
        Other people still on my list: reosarevok, zas, mayhem, yvanzo, monkey, lucifer, akshaaatt, aerozol, Pratha-Fish, riksucks, jasje, jivte
      • 2023-03-06 06513, 2023

      • bitmap
        last week we released the new relationship editor code to production and I opened a few final fixes beforehand (nothing user-facing iirc, just Sentry logging improvements and developer nitpicks)
      • 2023-03-06 06542, 2023

      • bitmap
        there have been a few minor bug reports but nothing major afaict