#metabrainz

reosarevok, bitmap after 6 hours of fiddling around I finally figured out how to add the rest of the attributes using the mechanize browser API (using Requests) to tackle the lack of javascript support 😭

I've updated the PR with 3 separate commits and examples as well: https://github.com/metabrainz/musicbrainz-bot/p...

<lucifer> "pixelpenguin: 1. you can write a..." <- Okay, I will add the tests. Thanks

Hi, everyone. I am applying as a contributor for GSoC and I'm really thrilled to have found a music-related project! I am an aspiring front-end developer and I hope I can add to the community, nice to meet y'all :)

Hi andrerodriguex. Welcome!

O’Moin

when I am trying to run this command

./develop.sh build

It shows me this "unknown shorthand flag: 'f' in -f"

I don't know why this is coming can anybody help me ? I removed all the -f from the build.sh and tried to run the command again but still I got the same error

Diviloper: which project is this?

ListenBrainz

lucifer

Diviloper: weird, it was working fine for me. i am currently afk but can take a look in a few hours.

[musicbrainz-server] 14yvanzo opened pull request #2907 (03production…mbs-13007): MBS-13007: Fix a regressive ISE on broken WikiLink https://github.com/metabrainz/musicbrainz-serve...

Diviloper: Which version of bash is installed on your system? To find out, run: echo ${BASH_VERSINFO[@]}

Diviloper: macOS usually comes with an old version, you can install a more recent one using Homebrew: https://brew.sh/ https://formulae.brew.sh/formula/bash#default

reosarevok: are you around for reviewing a regression? ^

yvanzo: if it's a short review. I'll check

it is

(it should be)

Ok, let's see

bitmap, reosarevok: We didn't ack an MB dev meeting date yet, will be resetting trille today, but I'm available tomorrow, 3pm UTC as usual?

yvanzo: looks good, thanks :) Easy thing to miss too

I think tomorrow is good for me, yes

(might meet a friend an hour or two after that time, so let's not make it super long :) )

What should we have as the topic?

More entity naming, a schema change ticket status review, or do we have something else?

yvanzo: also, re: that support SPARQL query... there was a working LinkedBrainz dump at some point, although missing a lot of data

I worked on that a bit a couple years ago, but the interest just wasn't there so I mostly gave up on it... the dump is probably some 4 years old and maybe not of any use, anyway, though :)

Not even sure where that lives :D

So, I think your answer was mostly good, just wanted to let you know what the actual status of that mess is :D

reosarevok: apparently there was a ~2010 dump https://chatlogs.metabrainz.org/libera/metabrai...

reosarevok: as you seem to know a lot about it, do you think it will be resurrected some day?

I mean, if someone actually cares about SPARQL and MB and wants to work on it, I'd be happy to give a hand

But I'm not going to be the main person there because I just don't know enough

I remember asking alastairp for help with stuff and him asking others IIRC

About schema issues and whatnot

I agree that we would be clearly missing manpower to carry it on, it just seems that it was something quite important and useful to keep it in mind for the future.

reosarevok: about tomorrow's meeting, yes mostly that; as we won't have time for something else: search, docker, infra...

[musicbrainz-docker] release 03v-2023-03-21-hotfix has been published by 14yvanzo: https://github.com/metabrainz/musicbrainz-docke...

Deploying the patch to beta.

Deploying the patch to prod website containers only.

aerozol: No huge rush for the landing pages, we still have a lot of other work to do that we can focus on

Done with hotfix release.

[listenbrainz-server] 14MonkeyDo opened pull request #2418 (03master…comment-out-add-to-mb): Hide "Add to MB" button from missing MB links page https://github.com/metabrainz/listenbrainz-serv...

[bookbrainz-site] 14stoichy closed pull request #955 (03master…master): BB-583: Changed button-links and contact-links size in homepage https://github.com/metabrainz/bookbrainz-site/p...

[listenbrainz-server] 14MonkeyDo opened pull request #2419 (03master…lb-1148): LB-1148: Distinguish "no cover art" and "not mapped" listens https://github.com/metabrainz/listenbrainz-serv...

Hi reosarevok / bitmap I have submitteed an updated to my PR on the musicbrainz bot. Can someone kindly help me review it? :)

P.S. I'll be off for a few days due to my college exams, and will be back on 25th. So if possible I'd love to get some more work sorted out today before leaving

*submitted an update

Pratha-Fish: it looks like you could use the approach already used here: https://github.com/Prathamesh-Ghatole/musicbrai...

rather than using requests directly and having to duplicate headers

very minor, but as a general rule you don't define uppercase constants in the body of a function

atj: thanks for the recommendation :)

I'll try and update my function to use the built-in functions ASAP.

The uppercase constraints will be dealt with too 👌

hi akshaaatt

Hi jasje

akshaaatt: So i was thinking about the critiqueBrainz part of the project

do i need to implement auth(if its possible)

You don’t have to worry about auth fpr this

We need to connect to cb though

so should i just redirect user to website

Hmm I mean yeah it is a part of auth

akshaaatt: is there a CritiqueBrainz token

lookin at the website's frontend code

it just says a generic token

idk if its mb token or lb token

or cb token (if it exists)

Consider my webdev skills limited to html only

Give me 10mins

alrighty

maybe monkey can help tho

uh-oh, what did I do?

no problems just queries

This is for the app, yes?

in APIService, what token is used to submit the CBReview?

monkey yess

On the LB frontend, we pass the CB token as a prop in a global context. Let me fish the code out

oh no

3 tokens

So we pass a number of global props which we inject in the HTML page, then parse in React: https://github.com/metabrainz/listenbrainz-serv...

the CB token is one of these global props.

looks like we need the user to enter that to the app just like lb token

That sounds right.

feels very primitive

Yeah, single sign-on would be ideal for these use-cases

also monkey: seems like the create review API endpoint doc isn't updated

In the meantime, there are two ways to do it: 1. users can get a token here: https://critiquebrainz.org/profile/applications/ or 2. users can link their CB account to LB here https://listenbrainz.org/profile/music-services... and then you can call an LB API endpoint to get a token for the user

I reckon 2 might be easier since you already have an LB token, but it does require users go to the LB page

Yeah, missing Request Headers: Authorization in the docs it looks like

Would you mind opening a PR or a ticket for that?

monkey ill update em no worries

Thanks !

btw i did wanna ask that

my last changes haven't taken effect on the docs

monkey^^

lucifer: Hi! I think one of the recent PRs (LB#2415 possibly) is making a server test fail : https://github.com/metabrainz/listenbrainz-serv...

Daily Jams Fixes (yet again): https://github.com/metabrainz/listenbrainz-serv...

jasje: I'm not exactly sure how the API docs are updated or at what frequency

Looks like the docs compilations are failing

Nope, nothing you did jasje :) Looks like a package update gone wrong

looks like updating docs is something i could do in freetime for the server

seeing all those prs with 5/10 commits fixing tests really scares me on server xD

Thanks monkey for clarifying things.

Just to confirm, which endpoint helps us fetch the CB token from LB?

akshaaatt: https://critiquebrainz.readthedocs.io/api/oauth...

this looks the one

I didn't realize before but why are we hardcoding the refresh tokens in the app?

zas: looking into trille containers now; how long the downtime to be announced? 10 minutes?