#metabrainz

yes, we only need to deploy changes and reboot

Android apps can easily be decompiled. Any user could get our refresh token, which is a concerning thing

akshaaatt: no idea what refresh tokens do :(

As the name suggests, refresh tokens allow us to refresh the access tokens for a user

access tokens live for a short period of time

Hence, we use refresh tokens to keep the user signed in to the app at regular intervals of time

when does mb token expire?

For example, access tokens can live for 1hr but a refresh token can live for 30 days

lucifer, mayhem : Looks like our LB API docs cannot build since LB#2360 due to an incompatibility between the newer versions of werkzeug (> 2.1.2) and sphinxcontrib.autohttp

The issue is described in more details here: https://github.com/sphinx-contrib/httpdomain/is...

In the issue, people are suggesting to copy the missing `werkzeug.routing.parse_rule` method as described here: https://github.com/python-restx/flask-restx/pul...

I have no idea if that is a good way to resolve this sort of python dependency issues; if you don't mind I'll leave that with you. I did however create a ticket for it with all the details I could find: LB-1239

Update werkzeug and Flask-Login: https://github.com/metabrainz/listenbrainz-serv...

LB-1239: API documentation builds are broken https://tickets.metabrainz.org/browse/LB-1239

jasje https://musicbrainz.org/doc/Development/OAuth2

akshaaatt: how do other website do that on app login?

zas: announcing for 16:45 UTC then

ok

like other apps don't usually redirect user to a webpage

what auth is that?

Actually lucifer mayhem I think I figured it out in the end. Opening a PR.

I just checked and we save the refresh token in local storage and no users can just get it jasje

Which is fine

But I am unsure of when the refresh tokens we get from MB expire

It would be a good practice to expire these once in every 30 days or so and have the user login again. So a login once a month

akshaaatt: my thought too since ive been using the same token for long time

[listenbrainz-server] 14MonkeyDo opened pull request #2420 (03master…update-autohttp): LB-1239: Update sphinxcontrib httpdomain dependency https://github.com/metabrainz/listenbrainz-serv...

Anyway, no that we have this sorted

now*

Any other questions for CB integration jasje?

akshaaatt: the main one: oauth will be part of it right then?

Yes. Doesn't seem much work

Let me know if you think otherwise

akshaaatt: id love too

i don't want the app to be dependent of website

Thanks for reporting the issue with the docs jasje 👍

monkey: my pleasure

I guess we won't be dependent now, right?

akshaaatt: Sorry I missed your question earlier. The API endpoint to get a fresh CB token is `/profile/music-services/critiquebrainz/refresh/`

Thanks a lot monkey!

That's on the LB side

akshaaatt: yees

akshaaatt: the timeline should be only 12 weeks right?

its kinda getting big for that time

since its 350 hrs, add more weeks to the proposal?

I am solving the issue LB-812. Can i use third party libraries like enzyme?

LB-812: Add tests for playlist feature React components https://tickets.metabrainz.org/browse/LB-812

Hi nexus ! We already use Enzyme in our test suite

However, we will be moving away from using it, as it is pretty much abandoned

For now though, that's how we're testing react components

Oh right.. okay then..i will try to not use it as you are anyways not using it in future

I haven’t calculated the exact math yet jasje

Do it as suits you

In preparation for our future move from enzyme to react-testing-library, if possible, try to avoid setting or asserting the state or props directly, and instead emulate user actions and then assert that the UI is doing what is expected

nexus: I think you'll have a very hard time without Enzyme ! Do use it, but prefer testing UI and user interaction rather than internal state of the component :)

Sure ..i'll try

The entire codebase is nothing but tests of the internal state of the component, so it's not a great example to follow

We do have a couple of tests I can point you to however. Give me one minute

Sure

nexus (or nexus55 ?) this test file is a good example where we test user interactions: https://github.com/metabrainz/listenbrainz-serv...

Since it tests a functional component that uses hooks, we cannot touch the internals like the state.

thanks

that sure would be a lot helpful

akshaaatt: alrighty

yvanzo: in 4 minutes I'll apply changes and reboot

ok?

zas: no :D

16:45

ah UTC....

yes

:)

I checked every container, it seems fine to have brainzbot down for a few minutes, picard *beta* website too (prod website has a second container on zappa), mbspotify too.

For MB, I will just stop cron after it completed both on trille and aretha (for hourly json dumps incremental).

k

alastairp, lucifer: crontab -l says that critiquebrainz-cron-prod has currently no crontab (for root and critiquebrainz users).

The file /etc/cron.d/critiquebrainz is present but it is probably not parsed.

nvm, log files show that it ran daily as expected.

I thought that 'crontab -l' would list jobs from this file too.

yvanzo: so all fine?

yes :)

:D

monkey: how do i use `/profile/music-services/critiquebrainz/refresh/` :P

like its a POST method

but base url?

listenbrainz.org ?

jasje: Have a look here: https://github.com/metabrainz/listenbrainz-serv...

Post request

base url is https://api.listenbrainz.org/

Nope.

i was looking at it but cant seem to understand

bodY?

So the full endpoint is https://api.listenbrainz.org/1/profile/music-se...

There's no body

then how does it know who's cb account to get token of?

With cookies. I see that could be a problem if all you have is a token

API with cookie auth 🙃

The decorator @api_login_required here ensures the request is from an authenticated user

Yeah, they weren't meant to be used from outside the LB website

looks like akshaaatt can bridge the my lack of knowledge here

bridge my*

zas: all cron services stopped now

ok, I'll apply changes and reboot in 4 mins

jasje: that is not the intended way to use CB api.

you should directly register an app in CB UI and then use it with OAuth.

lucifer: oh alrightyy

that solves it thanks monkey, lucifer!

atj: apparently it’s messy enough to create a business about it: https://cronitor.io/guides/how-to-list-all-cron...

zas: ok

rebooting

yvanzo: trille is back

jasje: we’ll manage the cb token as we do the mb token currently

As lucifer mentioned, register the app there and use it

Ideally we should just have a MeB auth and provide it with the scopes we want to access from each service

lucifer I could help with the meb oauth stuff if it’s not too big of a deal anymore

We should just get it done and proceed with life. Otherwise, we’ll be stuck in an endless loop of rewriting the same logic again and again

earthquake just hit

akshaaatt: agreed

will be following this one: https://critiquebrainz.readthedocs.io/api/oauth...

!m zas

You're doing good work, zas!

Tweeted about sites restoration.

Yes jasje, that’s the one

Checked that cron services are back too. (They just started with containers.)

akshaaatt: alright adding to the proposal

Cgroup Driver: systemd / Cgroup Version: 2

akshaaatt: there's lots of stuff to do about it. alastairp was going to take it up but probably a few weeks in that. but he may available for discussion sometime sooner, we can sketch out what work is pending and divideit accordingly.

Awesome!

[listenbrainz-server] 14amCap1712 merged pull request #2420 (03master…update-autohttp): LB-1239: Update sphinxcontrib httpdomain dependency https://github.com/metabrainz/listenbrainz-serv...

yvanzo: hallelujah

(almost forgot restarting json dump hourly cron on aretha)

ROpdebee: we got the following exception in Sentry: "Error: cannot call methods on artworkViewer prior to initialization; attempted to call method 'close'"

Previous click was "tbody > tr > td.ROpdebee_comparisonImage.edit-cover-art > button[type="button"]" :)

Just in case there's something somewhere that needs to be patient :)