Android apps can easily be decompiled. Any user could get our refresh token, which is a concerning thing
2023-03-21 08056, 2023
jasje
akshaaatt: no idea what refresh tokens do :(
2023-03-21 08046, 2023
akshaaatt
As the name suggests, refresh tokens allow us to refresh the access tokens for a user
2023-03-21 08000, 2023
akshaaatt
access tokens live for a short period of time
2023-03-21 08030, 2023
akshaaatt
Hence, we use refresh tokens to keep the user signed in to the app at regular intervals of time
2023-03-21 08044, 2023
jasje
when does mb token expire?
2023-03-21 08050, 2023
akshaaatt
For example, access tokens can live for 1hr but a refresh token can live for 30 days
2023-03-21 08052, 2023
monkey
lucifer, mayhem : Looks like our LB API docs cannot build since LB#2360 due to an incompatibility between the newer versions of werkzeug (> 2.1.2) and sphinxcontrib.autohttp
I have no idea if that is a good way to resolve this sort of python dependency issues; if you don't mind I'll leave that with you. I did however create a ticket for it with all the details I could find: LB-1239
Hi nexus ! We already use Enzyme in our test suite
2023-03-21 08005, 2023
monkey
However, we will be moving away from using it, as it is pretty much abandoned
2023-03-21 08019, 2023
monkey
For now though, that's how we're testing react components
2023-03-21 08010, 2023
nexus
Oh right.. okay then..i will try to not use it as you are anyways not using it in future
2023-03-21 08027, 2023
akshaaatt
I haven’t calculated the exact math yet jasje
2023-03-21 08049, 2023
akshaaatt
Do it as suits you
2023-03-21 08024, 2023
monkey
In preparation for our future move from enzyme to react-testing-library, if possible, try to avoid setting or asserting the state or props directly, and instead emulate user actions and then assert that the UI is doing what is expected
2023-03-21 08008, 2023
monkey
nexus: I think you'll have a very hard time without Enzyme ! Do use it, but prefer testing UI and user interaction rather than internal state of the component :)
2023-03-21 08008, 2023
nexus
Sure ..i'll try
2023-03-21 08054, 2023
monkey
The entire codebase is nothing but tests of the internal state of the component, so it's not a great example to follow
2023-03-21 08015, 2023
monkey
We do have a couple of tests I can point you to however. Give me one minute
Since it tests a functional component that uses hooks, we cannot touch the internals like the state.
2023-03-21 08046, 2023
nexus
thanks
2023-03-21 08059, 2023
nexus
that sure would be a lot helpful
2023-03-21 08020, 2023
jasje
akshaaatt: alrighty
2023-03-21 08047, 2023
zas
yvanzo: in 4 minutes I'll apply changes and reboot
2023-03-21 08050, 2023
zas
ok?
2023-03-21 08056, 2023
yvanzo
zas: no :D
2023-03-21 08006, 2023
yvanzo
16:45
2023-03-21 08018, 2023
zas
ah UTC....
2023-03-21 08024, 2023
yvanzo
yes
2023-03-21 08002, 2023
zas
:)
2023-03-21 08022, 2023
yvanzo
I checked every container, it seems fine to have brainzbot down for a few minutes, picard *beta* website too (prod website has a second container on zappa), mbspotify too.
2023-03-21 08014, 2023
yvanzo
For MB, I will just stop cron after it completed both on trille and aretha (for hourly json dumps incremental).
2023-03-21 08024, 2023
jivte joined the channel
2023-03-21 08026, 2023
d4rkie joined the channel
2023-03-21 08006, 2023
d4rk has quit
2023-03-21 08045, 2023
zas
k
2023-03-21 08039, 2023
yvanzo
alastairp, lucifer: crontab -l says that critiquebrainz-cron-prod has currently no crontab (for root and critiquebrainz users).
2023-03-21 08042, 2023
jivte has quit
2023-03-21 08039, 2023
yvanzo
The file /etc/cron.d/critiquebrainz is present but it is probably not parsed.
2023-03-21 08051, 2023
yvanzo
nvm, log files show that it ran daily as expected.
2023-03-21 08031, 2023
yvanzo
I thought that 'crontab -l' would list jobs from this file too.
2023-03-21 08002, 2023
nexus has quit
2023-03-21 08006, 2023
lucifer
yvanzo: so all fine?
2023-03-21 08016, 2023
yvanzo
yes :)
2023-03-21 08036, 2023
atj
yvanzo: why would you think that? it's far too logical!
2023-03-21 08000, 2023
yvanzo
:D
2023-03-21 08015, 2023
jasje
monkey: how do i use `/profile/music-services/critiquebrainz/refresh/` :P
Checked that cron services are back too. (They just started with containers.)
2023-03-21 08013, 2023
jasje
akshaaatt: alright adding to the proposal
2023-03-21 08016, 2023
yvanzo
Cgroup Driver: systemd / Cgroup Version: 2
2023-03-21 08016, 2023
lucifer
akshaaatt: there's lots of stuff to do about it. alastairp was going to take it up but probably a few weeks in that. but he may available for discussion sometime sooner, we can sketch out what work is pending and divideit accordingly.
(almost forgot restarting json dump hourly cron on aretha)
2023-03-21 08011, 2023
reosarevok
ROpdebee: we got the following exception in Sentry: "Error: cannot call methods on artworkViewer prior to initialization; attempted to call method 'close'"
