iconoclasthero_: I looked at your flac file. The file is not strictly valid (not having the STREAMINFO block first), but reading such files got fixed already in latest mutagen version, see https://github.com/quodlibet/mutagen/pull/500
2023-03-22 08117, 2023
lucifer
mayhem: the inside [] stuff just means enable flask support too. doesn't impact the version to unstall
mayhem: I'm ignoring any GSoC emails which do not mention our name or projects in any way and just talk about "your organization" or whatnot since they sound like they're sent to many orgs at once, but let me know if you want me to try and answer those instead
2023-03-22 08110, 2023
akshaaatt
Hi jasje
2023-03-22 08119, 2023
akshaaatt
I've fixed your Login PR
2023-03-22 08138, 2023
akshaaatt
Are you planning to make any changes to it or is it ready to be merged?
2023-03-22 08139, 2023
akshaaatt
Hi lucifer
2023-03-22 08104, 2023
akshaaatt
Just for my knowledge, CB has a way to create an application through oauth but LB doesn't, right?
2023-03-22 08157, 2023
Siddhart1o1 joined the channel
2023-03-22 08108, 2023
lucifer
akshaaatt: yes
2023-03-22 08134, 2023
akshaaatt
Is there a reason why LB doesn’t have it?
2023-03-22 08145, 2023
akshaaatt
Because auth on LB android app is useless rn
2023-03-22 08154, 2023
akshaaatt
We are authenticating to MB.
2023-03-22 08108, 2023
akshaaatt
We only have a way to hardcore the user token by the user currently
2023-03-22 08125, 2023
akshaaatt
For LB
2023-03-22 08157, 2023
Pratha-Fish
Hey reosarevok can I please get a review on this PR if you're free today?
2023-03-22 08157, 2023
Pratha-Fish
I have exams from from 23rd-25th, so I won't be able to do much for the next few days. :smiling_face_with_tear:
If we want to work on the feed for a user, we need to have them authenticated.
2023-03-22 08120, 2023
reosarevok
Pratha-Fish: I will try :)
2023-03-22 08134, 2023
Pratha-Fish
Thanks :)
2023-03-22 08149, 2023
reosarevok
But you should be studying then today, not doing MusicBrainz stuff! :p
2023-03-22 08151, 2023
akshaaatt
lucifer, mayhem, monkey Can we get some progress done on the oauth stuff please because we want to authenticate the user on the app and not have them manually add their user token on the app. That is as good as not using the app. We have user-related stuff coming up such as Feed. we got away with the auth requirement because Listens history and YIM api doesnt require auth
When they talk about linking your CB account to LB, all it means is that do the oauth setup of CB from LB
2023-03-22 08133, 2023
akshaaatt
So that LB can store the access token and refresh token of that user
2023-03-22 08146, 2023
akshaaatt
And when the user hits the create/review api,
2023-03-22 08106, 2023
akshaaatt
They create a CB review as is and create an event in the timeline
2023-03-22 08110, 2023
akshaaatt
That’s it
2023-03-22 08159, 2023
akshaaatt
So instead of using the create review api endpoint, we can do the first part directly and just use another api endpoint from LB to just create an event on the timeline of the review
2023-03-22 08113, 2023
akshaaatt
Does that make sense jasje?
2023-03-22 08138, 2023
jasje
akshaaatt: as far as i made sense of the code, the fetch access token thing is done on the server itself
2023-03-22 08149, 2023
jasje
not on the frontend
2023-03-22 08105, 2023
jasje
the endpoint: /user/<user_name>/timeline-event/create/review'
2023-03-22 08118, 2023
jasje
has access to create an event that the frontend doesn't