#metabrainz

/

      • genpaku has quit
      • 2023-03-22 08117, 2023

      • genpaku joined the channel
      • 2023-03-22 08121, 2023

      • Maxr1998_ joined the channel
      • 2023-03-22 08157, 2023

      • Maxr1998 has quit
      • 2023-03-22 08133, 2023

      • rektide has quit
      • 2023-03-22 08124, 2023

      • nawcom has quit
      • 2023-03-22 08114, 2023

      • nawcom joined the channel
      • 2023-03-22 08142, 2023

      • nexus joined the channel
      • 2023-03-22 08151, 2023

      • nexus
        i am solving issue LB-812. i am getting error like `Cannot find name JSPFPlaylist`.. i am kind of confused..
      • 2023-03-22 08152, 2023

      • BrainzBot
        LB-812: Add tests for playlist feature React components https://tickets.metabrainz.org/browse/LB-812
      • 2023-03-22 08106, 2023

      • nexus has quit
      • 2023-03-22 08136, 2023

      • outsidecontext
        iconoclasthero_: I looked at your flac file. The file is not strictly valid (not having the STREAMINFO block first), but reading such files got fixed already in latest mutagen version, see https://github.com/quodlibet/mutagen/pull/500
      • 2023-03-22 08117, 2023

      • lucifer
        mayhem: the inside [] stuff just means enable flask support too. doesn't impact the version to unstall
      • 2023-03-22 08138, 2023

      • BrainzGit
        [listenbrainz-server] 14amCap1712 merged pull request #2421 (03master…dependabot/pip/sentry-sdk-1.14.0): Bump sentry-sdk from 0.20.3 to 1.14.0 https://github.com/metabrainz/listenbrainz-server…
      • 2023-03-22 08150, 2023

      • lucifer
        mayhem: the CVE only seems to applicable to django anyways, so we aren't affected.
      • 2023-03-22 08123, 2023

      • BrainzGit
        [metabrainz.org] 14amCap1712 opened pull request #400 (03master…cve-sentry): Bump sentry-sdk from 0.20.3 to 1.14.0 https://github.com/metabrainz/metabrainz.org/pull…
      • 2023-03-22 08115, 2023

      • BrainzGit
        [metabrainz.org] 14amCap1712 merged pull request #400 (03master…cve-sentry): Bump sentry-sdk from 0.20.3 to 1.14.0 https://github.com/metabrainz/metabrainz.org/pull…
      • 2023-03-22 08132, 2023

      • jivte joined the channel
      • 2023-03-22 08152, 2023

      • jivte_ joined the channel
      • 2023-03-22 08144, 2023

      • jivte has quit
      • 2023-03-22 08101, 2023

      • jivte_ has quit
      • 2023-03-22 08115, 2023

      • reosarevok
        mayhem: I'm ignoring any GSoC emails which do not mention our name or projects in any way and just talk about "your organization" or whatnot since they sound like they're sent to many orgs at once, but let me know if you want me to try and answer those instead
      • 2023-03-22 08110, 2023

      • akshaaatt
        Hi jasje
      • 2023-03-22 08119, 2023

      • akshaaatt
        I've fixed your Login PR
      • 2023-03-22 08138, 2023

      • akshaaatt
        Are you planning to make any changes to it or is it ready to be merged?
      • 2023-03-22 08139, 2023

      • akshaaatt
        Hi lucifer
      • 2023-03-22 08104, 2023

      • akshaaatt
        Just for my knowledge, CB has a way to create an application through oauth but LB doesn't, right?
      • 2023-03-22 08157, 2023

      • Siddhart1o1 joined the channel
      • 2023-03-22 08108, 2023

      • lucifer
        akshaaatt: yes
      • 2023-03-22 08134, 2023

      • akshaaatt
        Is there a reason why LB doesn’t have it?
      • 2023-03-22 08145, 2023

      • akshaaatt
        Because auth on LB android app is useless rn
      • 2023-03-22 08154, 2023

      • akshaaatt
        We are authenticating to MB.
      • 2023-03-22 08108, 2023

      • akshaaatt
        We only have a way to hardcore the user token by the user currently
      • 2023-03-22 08125, 2023

      • akshaaatt
        For LB
      • 2023-03-22 08157, 2023

      • Pratha-Fish
        Hey reosarevok can I please get a review on this PR if you're free today?
      • 2023-03-22 08157, 2023

      • Pratha-Fish
        I have exams from from 23rd-25th, so I won't be able to do much for the next few days. :smiling_face_with_tear:
      • 2023-03-22 08104, 2023

      • Pratha-Fish
      • 2023-03-22 08110, 2023

      • akshaaatt
        If we want to work on the feed for a user, we need to have them authenticated.
      • 2023-03-22 08120, 2023

      • reosarevok
        Pratha-Fish: I will try :)
      • 2023-03-22 08134, 2023

      • Pratha-Fish
        Thanks :)
      • 2023-03-22 08149, 2023

      • reosarevok
        But you should be studying then today, not doing MusicBrainz stuff! :p
      • 2023-03-22 08151, 2023

      • akshaaatt
        lucifer, mayhem, monkey Can we get some progress done on the oauth stuff please because we want to authenticate the user on the app and not have them manually add their user token on the app. That is as good as not using the app. We have user-related stuff coming up such as Feed. we got away with the auth requirement because Listens history and YIM api doesnt require auth
      • 2023-03-22 08158, 2023

      • atj
        Pratha-Fish: I don't see the squashed commit - https://github.com/metabrainz/musicbrainz-bot/pul…
      • 2023-03-22 08125, 2023

      • atj
        you should probably squash the last 3 commits into the second one
      • 2023-03-22 08143, 2023

      • reosarevok
        I think it's fine to squash after review really
      • 2023-03-22 08148, 2023

      • akshaaatt
        Before when updates for the app were coming. But now, we can't get away with it
      • 2023-03-22 08154, 2023

      • reosarevok
        But yeah, before merge we should squash it :)
      • 2023-03-22 08122, 2023

      • Pratha-Fish
      • 2023-03-22 08104, 2023

      • Pratha-Fish
        ^ This is why I've kept the commits different. I can still squash if I misunderstood the statement tho https://usercontent.irccloud-cdn.com/file/l7ffyo9…
      • 2023-03-22 08118, 2023

      • atj
        but you're not using mechanize browser API now are you?
      • 2023-03-22 08140, 2023

      • atj
        oh
      • 2023-03-22 08141, 2023

      • atj
        hang on
      • 2023-03-22 08151, 2023

      • Pratha-Fish
        Wellll technically we are
      • 2023-03-22 08149, 2023

      • Pratha-Fish
        atj: I get the confusion! I was confused when squashing, so i just kept both the commit messages in the "squash message"
      • 2023-03-22 08140, 2023

      • atj
        ok, well you should probably edit the commit message for https://github.com/metabrainz/musicbrainz-bot/pul…
      • 2023-03-22 08102, 2023

      • atj
        i'll leave it to reosarevok, don't want to cause more confusion
      • 2023-03-22 08133, 2023

      • jasje joined the channel
      • 2023-03-22 08104, 2023

      • jasje
        akshaaatt: left a comment, check it out
      • 2023-03-22 08136, 2023

      • jasje
        also akshaaatt: the oauth for cb we discussed to post reviews to the feed is useless
      • 2023-03-22 08158, 2023

      • jasje
        only way to post a review that is showed on the feed is through lb site only
      • 2023-03-22 08102, 2023

      • jasje
        no other way
      • 2023-03-22 08130, 2023

      • jasje
      • 2023-03-22 08137, 2023

      • jasje
        and enable reviews
      • 2023-03-22 08109, 2023

      • jasje
        the one we discussed, will post reviews, but won't be shown to feed
      • 2023-03-22 08129, 2023

      • jasje
        dependency on site ++
      • 2023-03-22 08103, 2023

      • akshaaatt
        We will add the functionality in app jasje
      • 2023-03-22 08118, 2023

      • akshaaatt
        We will replicate what the website does on the music service page
      • 2023-03-22 08130, 2023

      • akshaaatt
        For the oauth stuff, we will need a user’s cb token to post a review to cb from my under
      • 2023-03-22 08138, 2023

      • akshaaatt
        Understanding*
      • 2023-03-22 08151, 2023

      • jasje
        but that review won't be shown to feed
      • 2023-03-22 08158, 2023

      • Pratha-Fish
        atj: Updated the commit message :)
      • 2023-03-22 08132, 2023

      • jasje
        for the review to be on feed, it does the music-services thing
      • 2023-03-22 08147, 2023

      • jasje
        cookie API as monkey said yesterday
      • 2023-03-22 08121, 2023

      • akshaaatt
        No I still don’t get it
      • 2023-03-22 08147, 2023

      • akshaaatt
        If I get the authoziation to CB done, I can post reviews
      • 2023-03-22 08116, 2023

      • akshaaatt
        And now to link those to LB, what is it that’s required?
      • 2023-03-22 08138, 2023

      • jasje
        alright here i go:
      • 2023-03-22 08156, 2023

      • jasje
        case 1: CB review upload ONLY
      • 2023-03-22 08102, 2023

      • jasje
        oauth is only required
      • 2023-03-22 08122, 2023

      • jasje
        case 2: CB review in feed
      • 2023-03-22 08138, 2023

      • jasje
        linking is required, no cb token is required
      • 2023-03-22 08146, 2023

      • jasje
        lb token is used
      • 2023-03-22 08118, 2023

      • akshaaatt
        But that particular lb token will have to be authorized in cb
      • 2023-03-22 08134, 2023

      • akshaaatt
        I’m not talking about authentication rather authorization
      • 2023-03-22 08132, 2023

      • jasje
        so how do we do authorization?
      • 2023-03-22 08103, 2023

      • akshaaatt
        If we inspect the website and see the network calls,
      • 2023-03-22 08129, 2023

      • jasje
        akshaaatt: can you give me the permalink?
      • 2023-03-22 08142, 2023

      • jasje
        i can't find music-services page eh
      • 2023-03-22 08148, 2023

      • akshaaatt
      • 2023-03-22 08122, 2023

      • akshaaatt
      • 2023-03-22 08141, 2023

      • jasje
        no no, the code in the frontend
      • 2023-03-22 08100, 2023

      • akshaaatt
      • 2023-03-22 08104, 2023

      • akshaaatt
        Ah wait
      • 2023-03-22 08113, 2023

      • akshaaatt
      • 2023-03-22 08126, 2023

      • akshaaatt
        This is where the endpoints are defined
      • 2023-03-22 08142, 2023

      • jasje
        uh this will take time
      • 2023-03-22 08153, 2023

      • akshaaatt
      • 2023-03-22 08156, 2023

      • akshaaatt
        Frontend code
      • 2023-03-22 08144, 2023

      • akshaaatt
        Submitting reviews to cb is the way we discussed jasje
      • 2023-03-22 08105, 2023

      • akshaaatt
        Your question should only be on how that link is done on LB
      • 2023-03-22 08145, 2023

      • BrainzGit
        [listenbrainz-server] 14MonkeyDo merged pull request #2418 (03master…comment-out-add-to-mb): Hide "Add to MB" button from missing MB links page https://github.com/metabrainz/listenbrainz-server…
      • 2023-03-22 08141, 2023

      • akshaaatt
      • 2023-03-22 08111, 2023

      • akshaaatt
      • 2023-03-22 08113, 2023

      • jasje
        akshaaatt: having a look just a sec
      • 2023-03-22 08117, 2023

      • akshaaatt
        jasje solved it
      • 2023-03-22 08129, 2023

      • jasje
        ?
      • 2023-03-22 08122, 2023

      • jasje
        akshaaatt: elaborate pleej
      • 2023-03-22 08120, 2023

      • akshaaatt
        When they talk about linking your CB account to LB, all it means is that do the oauth setup of CB from LB
      • 2023-03-22 08133, 2023

      • akshaaatt
        So that LB can store the access token and refresh token of that user
      • 2023-03-22 08146, 2023

      • akshaaatt
        And when the user hits the create/review api,
      • 2023-03-22 08106, 2023

      • akshaaatt
        They create a CB review as is and create an event in the timeline
      • 2023-03-22 08110, 2023

      • akshaaatt
        That’s it
      • 2023-03-22 08159, 2023

      • akshaaatt
        So instead of using the create review api endpoint, we can do the first part directly and just use another api endpoint from LB to just create an event on the timeline of the review
      • 2023-03-22 08113, 2023

      • akshaaatt
        Does that make sense jasje?
      • 2023-03-22 08138, 2023

      • jasje
        akshaaatt: as far as i made sense of the code, the fetch access token thing is done on the server itself
      • 2023-03-22 08149, 2023

      • jasje
        not on the frontend
      • 2023-03-22 08105, 2023

      • jasje
        the endpoint: /user/<user_name>/timeline-event/create/review'
      • 2023-03-22 08118, 2023

      • jasje
        has access to create an event that the frontend doesn't
      • 2023-03-22 08135, 2023

      • jasje
        to create a review, that we can do
      • 2023-03-22 08146, 2023

      • jasje
        but to create an event, that we cannot
      • 2023-03-22 08110, 2023

      • jasje
      • 2023-03-22 08128, 2023

      • jasje
        it directly interacts with the db
      • 2023-03-22 08106, 2023

      • akshaaatt
        Yes jasje that’s a good point
      • 2023-03-22 08116, 2023

      • jasje
        that means, if i was to implement an on app cb login, i would need a new api endpoint
      • 2023-03-22 08126, 2023

      • jasje
        that is just used to inform db that cb is posted
      • 2023-03-22 08145, 2023

      • akshaaatt
        We can ask lucifer to create an endpoint which accepts the user’s CB token as well and does the job for us
      • 2023-03-22 08149, 2023

      • akshaaatt
        Should be pretty standard
      • 2023-03-22 08157, 2023

      • jasje
        akshaaatt: let me have a go
      • 2023-03-22 08121, 2023

      • jasje
        I'm learning flask and would do it in once im comfortable
      • 2023-03-22 08128, 2023

      • akshaaatt
        So I guess we are sorted on this front then
      • 2023-03-22 08132, 2023

      • akshaaatt
        Seems easy
      • 2023-03-22 08137, 2023

      • BrainzGit
        [listenbrainz-server] 14MonkeyDo opened pull request #2422 (03master…fix-rec-test): Fix test_cf_recording_recommendations_complete test https://github.com/metabrainz/listenbrainz-server…
      • 2023-03-22 08139, 2023

      • jasje
        akshaaatt: not so much
      • 2023-03-22 08104, 2023

      • akshaaatt
        What concerns you about this jasje?
      • 2023-03-22 08132, 2023

      • jasje
        informing lb site that user has allowed access
      • 2023-03-22 08150, 2023

      • jasje
        which automatically changes disable to enable
      • 2023-03-22 08102, 2023

      • akshaaatt
        Another endpoint for that
      • 2023-03-22 08106, 2023

      • akshaaatt
        Kewl
      • 2023-03-22 08114, 2023

      • reosarevok
        bitmap: would something like this work?
      • 2023-03-22 08115, 2023

      • jasje
        lawd
      • 2023-03-22 08123, 2023

      • reosarevok
      • 2023-03-22 08132, 2023

      • reosarevok
        bitmap: or maybe there's a better way of doing it, heh
      • 2023-03-22 08132, 2023

      • akshaaatt
        Hit lucifer with a PR and he’ll connect with you with these scenarios better
      • 2023-03-22 08134, 2023

      • jasje
        spamming api endpoints is the way
      • 2023-03-22 08140, 2023

      • akshaaatt
        But I don’t see this as a blocker anymore
      • 2023-03-22 08100, 2023

      • jasje
        yeah, should i do this in gsoc or later?
      • 2023-03-22 08117, 2023

      • jasje
        by later in mean in a few days
      • 2023-03-22 08122, 2023

      • jasje
        i mean**
      • 2023-03-22 08130, 2023

      • akshaaatt
        You decide. I just want clarity on what is taken up when for gsoc
      • 2023-03-22 08148, 2023

      • akshaaatt
        I’m fine with excluding this task if you feel it’s too much