#metabrainz

i am solving issue LB-812. i am getting error like `Cannot find name JSPFPlaylist`.. i am kind of confused..

LB-812: Add tests for playlist feature React components https://tickets.metabrainz.org/browse/LB-812

iconoclasthero_: I looked at your flac file. The file is not strictly valid (not having the STREAMINFO block first), but reading such files got fixed already in latest mutagen version, see https://github.com/quodlibet/mutagen/pull/500

mayhem: the inside [] stuff just means enable flask support too. doesn't impact the version to unstall

[listenbrainz-server] 14amCap1712 merged pull request #2421 (03master…dependabot/pip/sentry-sdk-1.14.0): Bump sentry-sdk from 0.20.3 to 1.14.0 https://github.com/metabrainz/listenbrainz-serv...

mayhem: the CVE only seems to applicable to django anyways, so we aren't affected.

[metabrainz.org] 14amCap1712 opened pull request #400 (03master…cve-sentry): Bump sentry-sdk from 0.20.3 to 1.14.0 https://github.com/metabrainz/metabrainz.org/pu...

[metabrainz.org] 14amCap1712 merged pull request #400 (03master…cve-sentry): Bump sentry-sdk from 0.20.3 to 1.14.0 https://github.com/metabrainz/metabrainz.org/pu...

mayhem: I'm ignoring any GSoC emails which do not mention our name or projects in any way and just talk about "your organization" or whatnot since they sound like they're sent to many orgs at once, but let me know if you want me to try and answer those instead

Hi jasje

I've fixed your Login PR

Are you planning to make any changes to it or is it ready to be merged?

Hi lucifer

Just for my knowledge, CB has a way to create an application through oauth but LB doesn't, right?

akshaaatt: yes

Is there a reason why LB doesn’t have it?

Because auth on LB android app is useless rn

We are authenticating to MB.

We only have a way to hardcore the user token by the user currently

For LB

Hey reosarevok can I please get a review on this PR if you're free today?

I have exams from from 23rd-25th, so I won't be able to do much for the next few days. :smiling_face_with_tear:

If we want to work on the feed for a user, we need to have them authenticated.

Pratha-Fish: I will try :)

Thanks :)

But you should be studying then today, not doing MusicBrainz stuff! :p

lucifer, mayhem, monkey Can we get some progress done on the oauth stuff please because we want to authenticate the user on the app and not have them manually add their user token on the app. That is as good as not using the app. We have user-related stuff coming up such as Feed. we got away with the auth requirement because Listens history and YIM api doesnt require auth

Pratha-Fish: I don't see the squashed commit - https://github.com/metabrainz/musicbrainz-bot/p...

you should probably squash the last 3 commits into the second one

I think it's fine to squash after review really

Before when updates for the app were coming. But now, we can't get away with it

But yeah, before merge we should squash it :)

atj: this is the squashed commit https://usercontent.irccloud-cdn.com/file/xIful...

^ This is why I've kept the commits different. I can still squash if I misunderstood the statement tho https://usercontent.irccloud-cdn.com/file/l7ffy...

but you're not using mechanize browser API now are you?

oh

hang on

Wellll technically we are

atj: I get the confusion! I was confused when squashing, so i just kept both the commit messages in the "squash message"

ok, well you should probably edit the commit message for https://github.com/metabrainz/musicbrainz-bot/p...

i'll leave it to reosarevok, don't want to cause more confusion

akshaaatt: left a comment, check it out

also akshaaatt: the oauth for cb we discussed to post reviews to the feed is useless

only way to post a review that is showed on the feed is through lb site only

no other way

user has to go to this page: https://listenbrainz.org/profile/music-services...

and enable reviews

the one we discussed, will post reviews, but won't be shown to feed

dependency on site ++

We will add the functionality in app jasje

We will replicate what the website does on the music service page

For the oauth stuff, we will need a user’s cb token to post a review to cb from my under

Understanding*

but that review won't be shown to feed

atj: Updated the commit message :)

for the review to be on feed, it does the music-services thing

cookie API as monkey said yesterday

No I still don’t get it

If I get the authoziation to CB done, I can post reviews

And now to link those to LB, what is it that’s required?

alright here i go:

case 1: CB review upload ONLY

oauth is only required

case 2: CB review in feed

linking is required, no cb token is required

lb token is used

But that particular lb token will have to be authorized in cb

I’m not talking about authentication rather authorization

so how do we do authorization?

If we inspect the website and see the network calls,

akshaaatt: can you give me the permalink?

i can't find music-services page eh

ttps://critiquebrainz.org/oauth/authorize is being used

https://listenbrainz.org/profile/music-services... jasje

no no, the code in the frontend

Ah wait

This is where the endpoints are defined

uh this will take time

Frontend code

Submitting reviews to cb is the way we discussed jasje

Your question should only be on how that link is done on LB

[listenbrainz-server] 14MonkeyDo merged pull request #2418 (03master…comment-out-add-to-mb): Hide "Add to MB" button from missing MB links page https://github.com/metabrainz/listenbrainz-serv...

akshaaatt: having a look just a sec

?

akshaaatt: elaborate pleej

When they talk about linking your CB account to LB, all it means is that do the oauth setup of CB from LB

So that LB can store the access token and refresh token of that user

And when the user hits the create/review api,

They create a CB review as is and create an event in the timeline

That’s it

So instead of using the create review api endpoint, we can do the first part directly and just use another api endpoint from LB to just create an event on the timeline of the review

Does that make sense jasje?

akshaaatt: as far as i made sense of the code, the fetch access token thing is done on the server itself

not on the frontend

the endpoint: /user/<user_name>/timeline-event/create/review'

has access to create an event that the frontend doesn't

to create a review, that we can do

but to create an event, that we cannot

akshaaatt: check this line: https://github.com/metabrainz/listenbrainz-serv...

it directly interacts with the db

Yes jasje that’s a good point

that means, if i was to implement an on app cb login, i would need a new api endpoint

that is just used to inform db that cb is posted

We can ask lucifer to create an endpoint which accepts the user’s CB token as well and does the job for us

Should be pretty standard

akshaaatt: let me have a go

I'm learning flask and would do it in once im comfortable

So I guess we are sorted on this front then

Seems easy

[listenbrainz-server] 14MonkeyDo opened pull request #2422 (03master…fix-rec-test): Fix test_cf_recording_recommendations_complete test https://github.com/metabrainz/listenbrainz-serv...

akshaaatt: not so much

What concerns you about this jasje?

informing lb site that user has allowed access

which automatically changes disable to enable

Another endpoint for that

Kewl

bitmap: would something like this work?

lawd

bitmap: or maybe there's a better way of doing it, heh

Hit lucifer with a PR and he’ll connect with you with these scenarios better

spamming api endpoints is the way

But I don’t see this as a blocker anymore

yeah, should i do this in gsoc or later?

by later in mean in a few days

i mean**

You decide. I just want clarity on what is taken up when for gsoc

I’m fine with excluding this task if you feel it’s too much