Pratha-Fish: Ok, I thought that AreaBot would be using musicbrainz-bot.
2023-03-28 08728, 2023
Pratha-Fish
Yes I have the mb2wikidatabot noted as a reference too :D
2023-03-28 08734, 2023
ZaphodBeeblebrox
:D
2023-03-28 08723, 2023
Pratha-Fish
yvanzo: Yes, areabot does use musicbrainz-bot at its core as far as I understand.. Kind of like https://github.com/metabrainz/mb2wikidatabot that ZaphodBeeblebrox just shared :)
2023-03-28 08742, 2023
yvanzo
Pratha-Fish: It is unclear whether AreaBot will be an instance (bot user account) using "musicbrainz-bot" code (in which case both should be documented/tested) or a new repository forking it (in which case the stretch goals make sense).
2023-03-28 08728, 2023
sb2318 joined the channel
2023-03-28 08735, 2023
Pratha-Fish
Yess, ig it would count as a fork
2023-03-28 08712, 2023
Pratha-Fish
but ig I should just discuss these requirements in detail with reo or bitmap and see what they have in mind for it
monkey: It’s a depedency of jest, so not a security issue for LB.
2023-03-28 08743, 2023
Shelly joined the channel
2023-03-28 08733, 2023
yvanzo
Checked all security alerts for LB.
2023-03-28 08740, 2023
monkey
❤️
2023-03-28 08707, 2023
Shelly
monkey: I have fixed some small issues such as broken youtube link in brainzplayer and ugly error notifications on local server on fresh releases page and listens page. How should I draft a PR for that?
2023-03-28 08745, 2023
monkey
Thanks! you should fork the repo, ad your commits in a new branch, and you should see an option to open a PR against the main repo on the Github website
Thanks for the concise answer. But I wanted to know if I should open a PR for each fix or just one PR for all the fixes?
2023-03-28 08733, 2023
atj
Shelly: it depends, if all the fixes are trivial and self-contained then you can combine them into one PR (in multiple commits), but generally you should open separate PRs
2023-03-28 08717, 2023
Shelly
Okay, got it. The changes are trivial so I'll open one PR only describing the changes.
2023-03-28 08708, 2023
Shelly has quit
2023-03-28 08706, 2023
yvanzo
monkey, lucifer: Also reviewed dependabot alerts, closed some of these but also reopened 2 SEC tickets.
