#metabrainz

/

      • atj
        a lot of new code uses it but can be a pain to add to an existing codebase
      • 2023-04-13 10338, 2023

      • arsh joined the channel
      • 2023-04-13 10346, 2023

      • atj
        my interpretation of that code snippet is that update should be a tuple or list of strings
      • 2023-04-13 10312, 2023

      • BrainzGit
        [listenbrainz-server] 14amCap1712 closed pull request #2167 (03master…import-spotify): Import collections as playlist https://github.com/metabrainz/listenbrainz-server…
      • 2023-04-13 10355, 2023

      • rdswift
        <mayhem> "but then all deletes take an hour." Another (hacky) alternative might be to let the user know that their delete has been queued and provide two buttons -- "Delete Now" and "Undo Delete" while the delete is still pending?
      • 2023-04-13 10357, 2023

      • mayhem
        that would be ideal, yes.
      • 2023-04-13 10323, 2023

      • mayhem
        but the do deletes in batches because deletes are expensive. so, the last thing we want to do is give user control over when to hammer our servers.
      • 2023-04-13 10347, 2023

      • rdswift
        Good point.
      • 2023-04-13 10327, 2023

      • rdswift
        Perhaps just a simple message that the deletion has been added to the queue, with an option to remove it from the deletion queue (or is that what you're already doing -- I admit that I haven't really been following this closely)?
      • 2023-04-13 10332, 2023

      • mayhem
        that's the direction we're heading in, for sure.
      • 2023-04-13 10313, 2023

      • rdswift
        In that case, sorry for the noise. :-)
      • 2023-04-13 10314, 2023

      • lucifer
        mayhem, monkey: if you'd like to test the new schema, `ssh -L 8100:10.10.10.190:3031 quest`
      • 2023-04-13 10356, 2023

      • lucifer
        mayhem, any updates on the soundcloud front?
      • 2023-04-13 10341, 2023

      • mayhem
        on quest the idea is that it should be/behave identically to production, save for some missing listens, yes?
      • 2023-04-13 10350, 2023

      • lucifer
        yup
      • 2023-04-13 10359, 2023

      • lucifer
        except listens page, pages can be slow because those are retrieved via a FDW.
      • 2023-04-13 10319, 2023

      • mayhem
        FDW?
      • 2023-04-13 10323, 2023

      • lucifer
        listens page should hoepfully be faster though the server hardware can be a factor too.
      • 2023-04-13 10328, 2023

      • lucifer
        Foreign Data Wrapper.
      • 2023-04-13 10345, 2023

      • mayhem
        is login supposed to work?
      • 2023-04-13 10350, 2023

      • lucifer
        yes
      • 2023-04-13 10315, 2023

      • lucifer
        but it points to a different app so you'll have to re-auth
      • 2023-04-13 10322, 2023

      • lucifer
      • 2023-04-13 10327, 2023

      • mayhem
        I keep getting Login Failed. :(
      • 2023-04-13 10336, 2023

      • lucifer
        hmm weird.
      • 2023-04-13 10356, 2023

      • mayhem didn't know about FDW
      • 2023-04-13 10321, 2023

      • Pratha-Fish
        atj: ooh that explains it. It looks like a relatively new concept in python. Understood.
      • 2023-04-13 10320, 2023

      • Pratha-Fish
        And I"ll try out the list of strings method too 👍
      • 2023-04-13 10325, 2023

      • mayhem
        tried a different browser, lucifer , same thing.
      • 2023-04-13 10351, 2023

      • atj
        Pratha-Fish: BTW, I wouldn't say that most languages implement type hints. Most languages are either compiled and statically typed, or dynamic and typeless.
      • 2023-04-13 10315, 2023

      • outsidecontext
        mayhem, lucifer: cool you are considering the delete undo. Maybe it does not need 60 minutes delay, 15 minutes or so probably is enough to undo the accidental deletion
      • 2023-04-13 10340, 2023

      • outsidecontext
        mayhem: I did not look into creating the installer package for the python script yet :( still on my list
      • 2023-04-13 10348, 2023

      • outsidecontext is off swimming
      • 2023-04-13 10344, 2023

      • mayhem
        outsidecontext: swimming is important. (no stress!)
      • 2023-04-13 10323, 2023

      • bitmap has quit
      • 2023-04-13 10355, 2023

      • Pratha-Fish
        atj: True that, but at the end of the day they do help a little in writing more robust code hopefully. I just don't understand why python's implementation is so weird, not to mention other domains like multi threading and stuff 🗿
      • 2023-04-13 10330, 2023

      • Pratha-Fish
        BTW if any new guys here are facing similar issues in wrapping their heads around Python, Arjan Codes on YouTube is a great resource 👀
      • 2023-04-13 10347, 2023

      • bitmap joined the channel
      • 2023-04-13 10349, 2023

      • atj
        why do you think Python's type hinting is weird? I found it quite easy to use.
      • 2023-04-13 10311, 2023

      • theflash_ has quit
      • 2023-04-13 10321, 2023

      • nawcom has quit
      • 2023-04-13 10317, 2023

      • nawcom joined the channel
      • 2023-04-13 10315, 2023

      • dseomn has quit
      • 2023-04-13 10337, 2023

      • dseomn joined the channel
      • 2023-04-13 10304, 2023

      • elomatreb[m]
        Is there a test environment for Listenbrainz similar to test.musicbrainz.org? I.e. something where I can try things without messing up real data
      • 2023-04-13 10358, 2023

      • mayhem
        not really.
      • 2023-04-13 10309, 2023

      • mayhem
        why not import a partial dump and try it on your own machine?
      • 2023-04-13 10354, 2023

      • void09 joined the channel
      • 2023-04-13 10344, 2023

      • void09 has quit
      • 2023-04-13 10330, 2023

      • void09 joined the channel
      • 2023-04-13 10326, 2023

      • arsh has quit
      • 2023-04-13 10313, 2023

      • void09 has quit
      • 2023-04-13 10343, 2023

      • void09 joined the channel
      • 2023-04-13 10300, 2023

      • elomatreb[m]
        mayhem: I'll do that, just wanted to know if there is an easier method for some quick experiments
      • 2023-04-13 10307, 2023

      • elomatreb[m]
        But I guess LB is easy enough to setup locally
      • 2023-04-13 10331, 2023

      • mayhem nods at both
      • 2023-04-13 10346, 2023

      • Maxr1998 joined the channel
      • 2023-04-13 10301, 2023

      • Maxr1998_ has quit
      • 2023-04-13 10323, 2023

      • v6lur joined the channel
      • 2023-04-13 10332, 2023

      • v6lur has quit
      • 2023-04-13 10350, 2023

      • v6lur joined the channel
      • 2023-04-13 10312, 2023

      • tykling_ has quit
      • 2023-04-13 10330, 2023

      • lucifer
        mayhem: try logging in now?
      • 2023-04-13 10313, 2023

      • mayhem
        login works now!
      • 2023-04-13 10352, 2023

      • tykling joined the channel
      • 2023-04-13 10333, 2023

      • jasje
        aerozol ?
      • 2023-04-13 10316, 2023

      • jasje
        akshaaatt ?
      • 2023-04-13 10312, 2023

      • aerozol
        Mōrena jasje!
      • 2023-04-13 10331, 2023

      • jasje
        Mōrena!!
      • 2023-04-13 10348, 2023

      • jasje
        so i was making design for the updated feed
      • 2023-04-13 10302, 2023

      • jasje
      • 2023-04-13 10321, 2023

      • jasje
        aerozol ^^
      • 2023-04-13 10324, 2023

      • aerozol
        Jasje: is that the same as the website version?
      • 2023-04-13 10334, 2023

      • aerozol
        If so it's an easy sign off from me 😉
      • 2023-04-13 10355, 2023

      • jasje
        The new redesigned one ;)
      • 2023-04-13 10308, 2023

      • jasje
        just have a look at the tabs and stuff
      • 2023-04-13 10337, 2023

      • jasje
        Should I separate feed events from user listens?
      • 2023-04-13 10347, 2023

      • jasje
        like the new redesign does now?
      • 2023-04-13 10320, 2023

      • aerozol
        My only feedback is that the pills at the top should be the same as everywhere else on the app
      • 2023-04-13 10348, 2023

      • jasje
        aerozol: there are no pills in the app for tabs in the app yet
      • 2023-04-13 10356, 2023

      • jasje
        oops
      • 2023-04-13 10306, 2023

      • jasje
        said it twice
      • 2023-04-13 10330, 2023

      • jasje
        Ive made some comments in the figma file
      • 2023-04-13 10324, 2023

      • jasje
        also if you want to make the mobile design for the website you can use the group in my design ;) ive made sure you could use it too
      • 2023-04-13 10333, 2023

      • aerozol
        Am I looking at the right file? Three pills at the top, my feed, user listens, global listens
      • 2023-04-13 10350, 2023

      • jasje
        aerozol: yess
      • 2023-04-13 10324, 2023

      • aerozol
        Hmm maybe I can't see comments on my phone 😔
      • 2023-04-13 10341, 2023

      • jasje
        ou
      • 2023-04-13 10349, 2023

      • jasje
        lemme quote it for you
      • 2023-04-13 10302, 2023

      • aerozol
        But yeah those three pills need to look the same as the pills elsewhere in the app, that is all
      • 2023-04-13 10324, 2023

      • jasje
        User Listens Page: "What to do here? Listens only or Listens + Similar Users"
      • 2023-04-13 10357, 2023

      • jasje
        Bottom App Bar: "Need to update the bottom nav with new icons and preferrably remove text from them"
      • 2023-04-13 10342, 2023

      • jasje
        Can you make or point me to some new icons for the bottom nav bar of the app?
      • 2023-04-13 10300, 2023

      • aerozol
        I think feed is the perfect place for similar users. I was planning to propose monkey move it for the website too
      • 2023-04-13 10318, 2023

      • jasje
        aerozol: thats what i think too!
      • 2023-04-13 10339, 2023

      • aerozol
        💪
      • 2023-04-13 10304, 2023

      • jasje
        99% of the time i find similar users in the feed useful
      • 2023-04-13 10316, 2023

      • aerozol
        I haven't been involved with the icons so far, I would check if there's any suitable ones in the library the other ones came from
      • 2023-04-13 10322, 2023

      • jasje
        most of my random follows are from there.
      • 2023-04-13 10359, 2023

      • jasje
        aerozol: yes please
      • 2023-04-13 10317, 2023

      • aerozol
        I don't know what library got used sorry, maybe you can see it in the code?
      • 2023-04-13 10319, 2023

      • aerozol
        What's the 'user listens' pill by the way?
      • 2023-04-13 10357, 2023

      • jasje
        That screen is supposed to show listens from followed users
      • 2023-04-13 10308, 2023

      • jasje
        just like the redesign
      • 2023-04-13 10330, 2023

      • lucifer
        mayhem: need any help with the art generator page?
      • 2023-04-13 10353, 2023

      • jasje
        the redesign used the extra estate to put it in the same page
      • 2023-04-13 10301, 2023

      • jasje
        I can not :(
      • 2023-04-13 10333, 2023

      • aerozol
        Might be a question for akshaaatt
      • 2023-04-13 10358, 2023

      • aerozol
        Oh right, that feed is hidden on my phone. I think leave it out of the app, it just doubles up the profile page right
      • 2023-04-13 10340, 2023

      • jasje
        no no
      • 2023-04-13 10323, 2023

      • jasje_ joined the channel
      • 2023-04-13 10338, 2023

      • jasje
      • 2023-04-13 10345, 2023

      • jasje
        aerozol ^^
      • 2023-04-13 10327, 2023

      • jasje
        these are feed events only
      • 2023-04-13 10334, 2023

      • aerozol
        Yeah that's hidden on mobile view
      • 2023-04-13 10319, 2023

      • aerozol
        And we show those on the profile page right? The logged in users listens? Or is it something else
      • 2023-04-13 10334, 2023

      • jasje
        no no
      • 2023-04-13 10340, 2023

      • jasje
        lets say im logged in
      • 2023-04-13 10346, 2023

      • jasje
        i follow you on LB
      • 2023-04-13 10358, 2023

      • jasje
        You listen to a xyz track
      • 2023-04-13 10301, 2023

      • aerozol closes eyes and imagines really hard
      • 2023-04-13 10308, 2023

      • jasje
        that xyz track shows up there
      • 2023-04-13 10313, 2023

      • jasje
        with your name
      • 2023-04-13 10325, 2023

      • jasje
        xD
      • 2023-04-13 10357, 2023

      • jasje
        its just like "aerozol listened to a track"
      • 2023-04-13 10312, 2023

      • jasje
        but now filtered out of other feed events
      • 2023-04-13 10333, 2023

      • jasje
        because no. of songs listened >> other feed events
      • 2023-04-13 10315, 2023

      • jasje
        check out the screenshot above youll get it
      • 2023-04-13 10318, 2023

      • aerozol
        Gotcha. I wonder if the pills could use some renaming
      • 2023-04-13 10326, 2023

      • jasje
        like?
      • 2023-04-13 10311, 2023

      • jasje
        Oh i see why you were confused there xDD
      • 2023-04-13 10317, 2023

      • jasje
        my bad
      • 2023-04-13 10340, 2023

      • jasje
        aerozol: you have edit access
      • 2023-04-13 10312, 2023

      • aerozol
        The desktop site does drop it in mobile I'm pretty syre https://usercontent.irccloud-cdn.com/file/L6m84AU…
      • 2023-04-13 10316, 2023

      • jasje
        aerozol: yeah but ive found it useful so..
      • 2023-04-13 10320, 2023

      • aerozol
        Usually i would say to use the same names as the website for the app, but it doesn't work with the extra pill/tab
      • 2023-04-13 10337, 2023

      • aerozol
        'follow listens'?
      • 2023-04-13 10309, 2023

      • jasje
        sounds nice to me
      • 2023-04-13 10315, 2023

      • aerozol
        Tbh I think it's trivial to rename so you can probably consider the design signed off, as long as the pills aren't a new bit of design compared to the rest
      • 2023-04-13 10330, 2023

      • aerozol
        ...of the app
      • 2023-04-13 10347, 2023

      • aerozol
        (on my phone so can't get stuck into the figma sorry)
      • 2023-04-13 10340, 2023

      • jasje
        alrighty
      • 2023-04-13 10344, 2023

      • jasje
        pills approved then
      • 2023-04-13 10309, 2023

      • jasje
        now coming to the follow listens page
      • 2023-04-13 10347, 2023

      • jasje
        how do i squeeze in similar users?
      • 2023-04-13 10322, 2023

      • aerozol
        Oof
      • 2023-04-13 10345, 2023

      • v6lur has quit
      • 2023-04-13 10351, 2023

      • aerozol
        I can think of a couple of ways
      • 2023-04-13 10321, 2023

      • aerozol
        1. A narrow band at the top or bottom, with a horizontal scroll. So it's always there but not too in the way
      • 2023-04-13 10314, 2023

      • aerozol
        2. Seed the occasional listen from similar users into the feed, with a note saying it's a similar user to you, and a button to follow