#metabrainz

O’Moin

[musicbrainz-server] 14reosarevok opened pull request #2922 (03master…MBS-13045): MBS-13045: Display artist rename relationship on overview https://github.com/metabrainz/musicbrainz-serve...

moin!

Hi bitmap , reosarevok ! Can you please help fix the tests for https://github.com/metabrainz/musicbrainz-serve... ?

fish

reosarevok: Your wiki markup is fine. It seems that the transclusion code is unnecessarily assuming a thumbnail instead of the original file in "src"; See https://github.com/metabrainz/musicbrainz-serve...

akshaaatt: I posted the right comment for invoking tests.

mayhem: please ping when around :)

pingeling.

which is different from pingelig.

akshaaatt: the failure seems consistent, it's failing to find the log out button

Have you checked that nothing broke with some update?

[listenbrainz-server] 14MonkeyDo merged pull request #2462 (03master…cover-art-fallback-2): Take 2: Improve ListenCard cover art fallback https://github.com/metabrainz/listenbrainz-serv...

yvanzo: is the suggestion to just have $href =~ s,^$WIKI_IMAGE_PREFIX(?:/thumb),//$wiki_server$WIKI_IMAGE_PREFIX,; there?

(I'm not just sure how to test this :) )

Oh, flushing redis was it?

Yes, that line has somehow to be adapter to work with other formats than just SVG.

Here is how I flushed the cache locally: redis-cli --scan --pattern 'MB:wikidoc:*' | xargs redis-cli DEL

monkey: regarding LB#1800, i am wondering whether it should be on frontend or backend.

Import from spotify extended streaming history: https://github.com/metabrainz/listenbrainz-serv...

Which part? the submission of listens?

yvanzo: thanks, got it working

What are the pros and cons of either solution?

we intend to move the LFM importer to the backend for more stability. so doesn't seem wise to add another frontend importer.

Yeah, I think that makes sense.

I would also like to request the ability to add a start and/or end timestamps to import from (to avoid duplicates). It's been mentioned in the forums too.

I can think of two cons: 1) this file has IP addresses. 2) we need to store these files on backend for a short while they are processed so opens a small opportunity of DDoS.

sure, makes sense to have start/end but i hope spotify is consistent in their timestamps and it isn't a problem.

most people won't bother to choose a range imo.

emailing to spotify, downloading/extracting a zip then uploading a file is friction enough imo.

Hm. We could potentially have some minimal manipulation of the file on the front-end to only send the required fields, and also get earliest/latest timestamps from the file, but it's probably a bad idea to process it once on front-end then again on the server

Right, by default we want to import everything, makes snese

yeah, i wouldn't recommend processing both on frontend and backend.

mayhem: thoughts?

PS: no need to email spotify anymore, there's a page where you can request with a click. However, not sure about the precision of timestamps and how that relates to deduping listens

i think they had the button before too but you do need to email to get the precise timestamps.

need to request again to be sure though

Hm. I'm pretty sure I requested twice and got this format for both: `"ts":"2016-02-18T19:33:55Z"`

ah cool then.

monkey: oh actually that's not precise enough.

"I recently gained access to my extended streaming history. Looking through the streaming history, I found that the timestamp precision of streams is second. However, Spotify Developer APIs (recently played tracks endpoint) provide the timestamps for recent streams with precision to the millisecond."

Ah, I thought there was something like that :)

I would prefer backend.

this is what i wrote to spotify last year

Right. I did request with more precise timestamps, and got the same files with second precision

they round off to ms to s which can cause duplicates.

IMO it's going to be too much work for non-technical users to get the right data, and we should instead adapt to the second precision (which means the cutoff date option would be required)

*if* they can get said data

I still think our frontend philosophy should be "for presentation/user interaction only". Data processing should be done on the backend.

I think that is wise

[musicbrainz-server] 14reosarevok opened pull request #2923 (03master…MBS-13047): MBS-13047: Do not assume every wiki image has /thumb https://github.com/metabrainz/musicbrainz-serve...

i looked back at the email thread. monkey, they send seconds precision by default. had to ask them repeatedly to ms precision. after a chain of 15 emails back and forth, i got the correct files.

Right, I think that's bogus :)

yeah indeed

But if that's what we get, then let's make the best of it

reosarevok: you missed a chance to call that branch wiki-opposable-thumb

Anyway lucifer I guess you have a lot of refactoring on your hands, but the offer still stands if you want help testing and/or implementing the UI

monkey: oh no

monkey: yes, we'll need some UI for users to upload the files. but no hurry.

I don't think I've ever implemented a file upload input. Exciting !

monkey: also if you have time, could you help with the css of this PR? https://github.com/metabrainz/metabrainz.org/pu.... a single list sounds good to me but can we make the entire box clickable instead of just the small checkbox.

Sure thing

monkey: I updated the forum logo, to the long-form, after talking to yvanzo and reading some other replies

Looks okay I think, what about you?

yvanzo: Ready to update the wiki logo to green, and change the favicon, when you are. The files are here: https://github.com/metabrainz/design-system/tre...

Let me know if you need something else

aerozol: Thanks, is it expected that the ICO size is 29x32?

hmm probably not… let me have a look

If I remember correctly, the wiki resizing the main logo looked bad as well. Here’s one at the same size as the current one if it looks better: https://drive.google.com/file/d/1z9tmJ9w7N570dI...

aerozol: We can have several versions of the logos if needed: https://www.mediawiki.org/wiki/Manual:$wgLogos

yvanzo: Thanks, let’s keep it simple for nopw

👍

yvanzo: please use this one (I’ll update github with it later): https://drive.google.com/file/d/1tIXln6SvcBPI8E...

+ good catch thanks

[musicbrainz-server] 14reosarevok opened pull request #2924 (03master…MBS-13048): MBS-13048: Add Uta-Net composer & lyricist links to artist https://github.com/metabrainz/musicbrainz-serve...

:D thanks, it will help

no rack spot. I thought we had one left... ok, let's rethink the plan.

lucifer: I cobbled this together:

Paste in an html file and open it with your browser

Required CSS in the file, and you'll need to follow the same markup

aerozol: I think the long form logo looks good on the website, and we don't sacrifice any brand recognition. Good feedback yvanzo

reosarevok: the flow of the pages for the dataset signup pages are in place: https://test.metabrainz.org/datasets

the text and layout is not, but I'll add that next.

monkey: 🎉

lucifer: actually, let me update that with the header + text styles inside the liste group items so it matches the screenshot

[musicbrainz-server] 14reosarevok opened pull request #2925 (03master…MBS-13049): MBS-13049: Add Uta-Ten songWriter links to artist https://github.com/metabrainz/musicbrainz-serve...

ok, it's time to switch to new gateways, and retire kiki & herb. It will free 2 spots in the rack. I'll run on one (new) gateway until we have centralized log system so we can still have mbstats (which is needed for many alerts).

that does make sense.

I'll prepare the switch, for it to happen early next week. We'll see how new gateways handle the traffic (as much of it still goes through kiki). At worse we'll switch back. I'll ensure DNS TTLs are set to minimum.

aerozol: Thanks, favicon+logos deployed to the wiki.

Thank you! favicon hasn’t updated for me but can take a while

Never mind, there it goes :D

mayhem: I'll check after I'm done making / eating lunch :) If you get some more stuff added in the meantime I'll check that too I guess

aerozol: open https://wiki.musicbrainz.org/favicon.ico and force-reload

yvanzo: thanks, it’s popped up now

You don’t happen to have admin access to Jira do you? The last piece of the puzzle

Yes but the icon isn't square either, should be PNG.

Not sure which (PNG) logo to pick.

You’re too quick, just fixing the favicon now!

Does it recommend a size for the logo in Jira?

The image seems to be scaled to 199x29.

I don't think there is any recommended geometry and the size is likely changed depending on the height of the navbar.

fixed favicon: https://drive.google.com/file/d/1Xka_Neh_2VyDxd...

"The height of the logo image must be constrained to 30 pixels. We also recommend you use an image with a width of 57 pixels" (at least I guess) from https://support.atlassian.com/jira-cloud-admini...

Thanks!

lucifer: Modified markup and css:

There's a small padding inside each item where you can't click to check/uncheck, but 90% of the area is, it's well usable.

yvanzo: Jira logo @ 30px high: https://drive.google.com/file/d/1BOHIphVHkZI3i7...

monkey: i was hoping something like we have on LB site for connecting services.

Oh. Then maybe copy css from LB? :D

Unless you have something more specific in mind

ah well yes. that was for radio buttons, let me see if i can get it to work on checkboxes.

Should be similar, just input type="checkbox" instead of type="radio"

cool, thanks

aerozol: Thanks, uploaded both.

yvanzo: thank you! My taskbar truly looks more useful now. I might tweak the Jira logo to have a bit of whitespace above and below though, if that’s okay

I think the other image must have had some padding built in

I still have it if you want it.

Let’s try it with regardless: https://drive.google.com/file/d/1FUNhcHw6TzdVpl...

uploaded ^

Here’s lucky number three, run through svg instead of png to try get rid of the fuzz… https://drive.google.com/file/d/12l5ceMLmN5Qv1D...

yvanzo: ^

uploaded

Thank you! I’m happy with these now! Sanity check please yvanzo: Anything I forgot or that doesn’t look good?

aerozol: You're doing good.

Thanks yvanzo. I’ll upload the fixed files to github, close the ticket, and then let’s both take a 8 hour break as a reward

Thanks for doing it so quickly, I thought I would be chasing people for a while

Thanks for the same, good night!

zas: I'm going to deploy borgmatic on all the remaining servers this afternoon. if know of any servers that should backup folders other than /etc let me know

ok. BTW, I'll prolly need you to be around when I'll proceed to DNS switch in order to fully switch to new gateways (likely Tuesday next week)

[design-system] 14Aerozol opened pull request #101 (03master…community-icons-fixes): Community logo fixes https://github.com/metabrainz/design-system/pul...

[design-system] 14Aerozol merged pull request #101 (03master…community-icons-fixes): Community logo fixes https://github.com/metabrainz/design-system/pul...