reosarevok: Your wiki markup is fine. It seems that the transclusion code is unnecessarily assuming a thumbnail instead of the original file in "src"; See https://github.com/metabrainz/musicbrainz-server/…
2023-04-27 11741, 2023
yvanzo
akshaaatt: I posted the right comment for invoking tests.
2023-04-27 11711, 2023
siinamon has quit
2023-04-27 11720, 2023
siinamon joined the channel
2023-04-27 11742, 2023
reosarevok
mayhem: please ping when around :)
2023-04-27 11709, 2023
mayhem
pingeling.
2023-04-27 11720, 2023
mayhem
which is different from pingelig.
2023-04-27 11731, 2023
petitminion has quit
2023-04-27 11738, 2023
petitminion joined the channel
2023-04-27 11718, 2023
petitminion has quit
2023-04-27 11711, 2023
pranay joined the channel
2023-04-27 11728, 2023
reosarevok
akshaaatt: the failure seems consistent, it's failing to find the log out button
2023-04-27 11737, 2023
reosarevok
Have you checked that nothing broke with some update?
we intend to move the LFM importer to the backend for more stability. so doesn't seem wise to add another frontend importer.
2023-04-27 11750, 2023
monkey
Yeah, I think that makes sense.
2023-04-27 11753, 2023
monkey
I would also like to request the ability to add a start and/or end timestamps to import from (to avoid duplicates). It's been mentioned in the forums too.
2023-04-27 11705, 2023
lucifer
I can think of two cons: 1) this file has IP addresses. 2) we need to store these files on backend for a short while they are processed so opens a small opportunity of DDoS.
2023-04-27 11754, 2023
lucifer
sure, makes sense to have start/end but i hope spotify is consistent in their timestamps and it isn't a problem.
2023-04-27 11707, 2023
lucifer
most people won't bother to choose a range imo.
2023-04-27 11754, 2023
lucifer
emailing to spotify, downloading/extracting a zip then uploading a file is friction enough imo.
2023-04-27 11735, 2023
monkey
Hm. We could potentially have some minimal manipulation of the file on the front-end to only send the required fields, and also get earliest/latest timestamps from the file, but it's probably a bad idea to process it once on front-end then again on the server
2023-04-27 11704, 2023
monkey
Right, by default we want to import everything, makes snese
2023-04-27 11715, 2023
lucifer
yeah, i wouldn't recommend processing both on frontend and backend.
2023-04-27 11728, 2023
lucifer
mayhem: thoughts?
2023-04-27 11743, 2023
monkey
PS: no need to email spotify anymore, there's a page where you can request with a click. However, not sure about the precision of timestamps and how that relates to deduping listens
2023-04-27 11710, 2023
lucifer
i think they had the button before too but you do need to email to get the precise timestamps.
2023-04-27 11718, 2023
lucifer
need to request again to be sure though
2023-04-27 11722, 2023
monkey
Hm. I'm pretty sure I requested twice and got this format for both: `"ts":"2016-02-18T19:33:55Z"`
2023-04-27 11732, 2023
mayhem reads
2023-04-27 11736, 2023
lucifer
ah cool then.
2023-04-27 11740, 2023
lucifer
monkey: oh actually that's not precise enough.
2023-04-27 11759, 2023
lucifer
"I recently gained access to my extended streaming history. Looking through the streaming history, I found that the timestamp precision of streams is second. However, Spotify Developer APIs (recently played tracks endpoint) provide the timestamps for recent streams with precision to the millisecond."
2023-04-27 11759, 2023
monkey
Ah, I thought there was something like that :)
2023-04-27 11706, 2023
mayhem
I would prefer backend.
2023-04-27 11709, 2023
lucifer
this is what i wrote to spotify last year
2023-04-27 11728, 2023
monkey
Right. I did request with more precise timestamps, and got the same files with second precision
2023-04-27 11728, 2023
lucifer
they round off to ms to s which can cause duplicates.
2023-04-27 11720, 2023
monkey
IMO it's going to be too much work for non-technical users to get the right data, and we should instead adapt to the second precision (which means the cutoff date option would be required)
2023-04-27 11736, 2023
monkey
*if* they can get said data
2023-04-27 11739, 2023
mayhem
I still think our frontend philosophy should be "for presentation/user interaction only". Data processing should be done on the backend.
i looked back at the email thread. monkey, they send seconds precision by default. had to ask them repeatedly to ms precision. after a chain of 15 emails back and forth, i got the correct files.
2023-04-27 11730, 2023
monkey
Right, I think that's bogus :)
2023-04-27 11755, 2023
lucifer
yeah indeed
2023-04-27 11710, 2023
monkey
But if that's what we get, then let's make the best of it
2023-04-27 11750, 2023
monkey
reosarevok: you missed a chance to call that branch wiki-opposable-thumb
2023-04-27 11749, 2023
monkey
Anyway lucifer I guess you have a lot of refactoring on your hands, but the offer still stands if you want help testing and/or implementing the UI
2023-04-27 11753, 2023
reosarevok
monkey: oh no
2023-04-27 11709, 2023
lucifer
monkey: yes, we'll need some UI for users to upload the files. but no hurry.
2023-04-27 11733, 2023
monkey
I don't think I've ever implemented a file upload input. Exciting !
2023-04-27 11757, 2023
lucifer
monkey: also if you have time, could you help with the css of this PR? https://github.com/metabrainz/metabrainz.org/pull…. a single list sounds good to me but can we make the entire box clickable instead of just the small checkbox.
2023-04-27 11741, 2023
monkey
Sure thing
2023-04-27 11739, 2023
aerozol
monkey: I updated the forum logo, to the long-form, after talking to yvanzo and reading some other replies
ok, it's time to switch to new gateways, and retire kiki & herb. It will free 2 spots in the rack. I'll run on one (new) gateway until we have centralized log system so we can still have mbstats (which is needed for many alerts).
2023-04-27 11725, 2023
mayhem
that does make sense.
2023-04-27 11718, 2023
zas
I'll prepare the switch, for it to happen early next week. We'll see how new gateways handle the traffic (as much of it still goes through kiki). At worse we'll switch back. I'll ensure DNS TTLs are set to minimum.
2023-04-27 11757, 2023
yvanzo
aerozol: Thanks, favicon+logos deployed to the wiki.
2023-04-27 11741, 2023
aerozol
Thank you! favicon hasn’t updated for me but can take a while
2023-04-27 11749, 2023
aerozol
Never mind, there it goes :D
2023-04-27 11757, 2023
reosarevok
mayhem: I'll check after I'm done making / eating lunch :) If you get some more stuff added in the meantime I'll check that too I guess
"The height of the logo image must be constrained to 30 pixels. We also recommend you use an image with a width of 57 pixels" (at least I guess) from https://support.atlassian.com/jira-cloud-administ…
monkey: i was hoping something like we have on LB site for connecting services.
2023-04-27 11725, 2023
monkey
Oh. Then maybe copy css from LB? :D
2023-04-27 11733, 2023
monkey
Unless you have something more specific in mind
2023-04-27 11703, 2023
lucifer
ah well yes. that was for radio buttons, let me see if i can get it to work on checkboxes.
2023-04-27 11745, 2023
monkey
Should be similar, just input type="checkbox" instead of type="radio"
2023-04-27 11754, 2023
lucifer
cool, thanks
2023-04-27 11706, 2023
yvanzo
aerozol: Thanks, uploaded both.
2023-04-27 11703, 2023
aerozol
yvanzo: thank you! My taskbar truly looks more useful now. I might tweak the Jira logo to have a bit of whitespace above and below though, if that’s okay
2023-04-27 11720, 2023
aerozol
I think the other image must have had some padding built in
Thank you! I’m happy with these now! Sanity check please yvanzo: Anything I forgot or that doesn’t look good?
2023-04-27 11705, 2023
yvanzo
aerozol: You're doing good.
2023-04-27 11746, 2023
aerozol
Thanks yvanzo. I’ll upload the fixed files to github, close the ticket, and then let’s both take a 8 hour break as a reward
2023-04-27 11743, 2023
aerozol
Thanks for doing it so quickly, I thought I would be chasing people for a while
2023-04-27 11758, 2023
yvanzo
Thanks for the same, good night!
2023-04-27 11753, 2023
atj
zas: I'm going to deploy borgmatic on all the remaining servers this afternoon. if know of any servers that should backup folders other than /etc let me know
2023-04-27 11726, 2023
zas
ok. BTW, I'll prolly need you to be around when I'll proceed to DNS switch in order to fully switch to new gateways (likely Tuesday next week)
