So we only do this when 1. user submitted a release MBID and 2. it is not the same as the mapped release MBID
2023-04-27 11748, 2023
lucifer
because release date
2023-04-27 11749, 2023
lucifer
monkey: yes sounds good.
2023-04-27 11713, 2023
lucifer
mayhem: the redesign PR, why not release today?
2023-04-27 11728, 2023
mayhem
friday.
2023-04-27 11734, 2023
mayhem
err, thursday.
2023-04-27 11739, 2023
lucifer
thursday. yeah
2023-04-27 11742, 2023
mayhem
big shit like this is best to go out monday.
2023-04-27 11737, 2023
mayhem
ok, I really want to get some datasets work done. does anyone else need me before I put my head down for an hour or so? speak up now.
2023-04-27 11757, 2023
monkey
I'd like our resident designer to have another pass, give another few days for users to chime, and have a blog post ready to be posted when we do deploy.
sorry, i couldn't find a way to add my commits to the already existing PR 😢
2023-04-27 11714, 2023
mayhem
you likely dont have the rights to do that. :(
2023-04-27 11729, 2023
mayhem
but this should work fine, methinks.
2023-04-27 11730, 2023
mayhem
reosarevok: for when you return to work: https://test.metabrainz.org/datasets -- the datasets page flow is done now and can be checked for all manners of mishappen things. the only thing left on my list is redirecting users who took the signup plunge to the download page, but that is a project for the morning.
Two things from #137. 1) Where are we picking up the now playing feature in this PR? 2) I am not sure if maintaining our own timer is the right solution.
2023-04-27 11744, 2023
akshaaatt
Have we checked what impacts it has on performance?
2023-04-27 11734, 2023
jasje joined the channel
2023-04-27 11747, 2023
jasje
akshaaatt: no playing now will be done later.
2023-04-27 11735, 2023
akshaaatt
You have it linked in the description of the PR
2023-04-27 11708, 2023
jasje
2) Timer is just one solution, since it executes a little amount of code after 1 sec
2023-04-27 11753, 2023
jasje
actually the reporter mixed up the title and description
2023-04-27 11710, 2023
jasje
just read the description for details
2023-04-27 11705, 2023
jasje
the exact thing timer solves is that it keeps track of how much a track is played. lets say i were to skip to some part of the song, the timer will keep track of total listen time
2023-04-27 11734, 2023
jasje
but ofcourse this a very initial approach and I would like some suggestions on it
2023-04-27 11746, 2023
jasje
this approach is also used due to the unstability of android's APIs
2023-04-27 11723, 2023
jasje has quit
2023-04-27 11726, 2023
pranay has quit
2023-04-27 11707, 2023
BrainzGit
[listenbrainz-server] 14faraz16iqbal opened pull request #2463 (03master…refresh-playlists-page): fix: refresh playlists page on while creating, editing and deleting a… https://github.com/metabrainz/listenbrainz-server…
2023-04-27 11728, 2023
akshaaatt
I think we can just use the delayed message thing to submit the listen after 1min or so has been played jasje
2023-04-27 11748, 2023
akshaaatt
What’s the harm in doing that?
2023-04-27 11739, 2023
pranay joined the channel
2023-04-27 11714, 2023
jasje joined the channel
2023-04-27 11708, 2023
jasje
akshaaatt: pausing and playing again doesn't extend delay.
2023-04-27 11738, 2023
jasje
we might have to cancel listen, then note down the remaining appropriate duration left
2023-04-27 11706, 2023
jasje
and post the message again when the user plays with calculated duration.
I think MusicBrainz app should just be converted to a sdk type of thing
2023-04-27 11749, 2023
jasje
akshaaatt^^
2023-04-27 11725, 2023
akshaaatt
SDK for what jasje?
2023-04-27 11739, 2023
jasje
for search apis?
2023-04-27 11757, 2023
akshaaatt
An app is just an interface jasje
2023-04-27 11710, 2023
akshaaatt
The app itself uses apis from the backend
2023-04-27 11711, 2023
jasje
all apis musicbrainz has to offer
2023-04-27 11721, 2023
akshaaatt
MB already offers them
2023-04-27 11746, 2023
jasje
but i would be simpler if we just made the calls. none of the retrofit stuff
2023-04-27 11752, 2023
jasje
it would*
2023-04-27 11708, 2023
akshaaatt
Lol
2023-04-27 11714, 2023
jasje
probably create a module inside that others can access
2023-04-27 11731, 2023
jasje
some suggested this in tickets :P
2023-04-27 11740, 2023
akshaaatt
Ouu
2023-04-27 11751, 2023
akshaaatt
I don’t think that’s what we are aiming for currently
2023-04-27 11710, 2023
jasje
tru but still putting the idea out
2023-04-27 11712, 2023
akshaaatt
The mb app is still great for searching, barcodes thing, picard thing and collections
2023-04-27 11750, 2023
akshaaatt
I am not focusing on the mb app currently but I do think we should continue that in future
2023-04-27 11716, 2023
akshaaatt
I want to experiment with some ML stuff soon on both MB and LB based on user interactions in the app
2023-04-27 11729, 2023
jasje
its not that helpful if adding artist takes you to web anyways
2023-04-27 11701, 2023
akshaaatt
Sure we can look into that soon. We just need apis made for those
2023-04-27 11726, 2023
jasje
all the apis are so clunked together with the website
2023-04-27 11726, 2023
akshaaatt
Plus some hard UI/UX decisions which are hard to make currently. But we can do so in future
2023-04-27 11734, 2023
jasje
alot of work indeed
2023-04-27 11712, 2023
akshaaatt
Tbh we already have the base ready for things now. It’s just a matter of pumping features out
2023-04-27 11751, 2023
akshaaatt
I’m assuming MeB will soon come out of that hell hole where we were just refactoring stuff everywhere. The important decisions have already been made and are in progress
2023-04-27 11714, 2023
v6lur joined the channel
2023-04-27 11716, 2023
jasje
less workforce
2023-04-27 11716, 2023
akshaaatt
The only major thing left is the MB revamp… let’s see if santiagofn and I can work through some of it
2023-04-27 11704, 2023
akshaaatt
It’s not just about the workforce jasje. Tbh there are only a few people who understand the tech we are working on and have experience with it
2023-04-27 11720, 2023
jasje
mb sure does need the revamp
2023-04-27 11744, 2023
jasje
akshaaatt: no no not mb/lb, the apps
2023-04-27 11755, 2023
jasje
android is pretty abundant
2023-04-27 11745, 2023
akshaaatt
The fact is that our user base MB wide is not a fan of editing on the app yet because of obvious reasons
2023-04-27 11746, 2023
jasje
but still very less people here
2023-04-27 11754, 2023
akshaaatt
Opening browser for stuff and all..
2023-04-27 11716, 2023
jasje
agree on that
2023-04-27 11720, 2023
akshaaatt
LB android has a huge chance of winning people according to me because it is relevant to the use case
2023-04-27 11730, 2023
akshaaatt
But LB lacks a brand yet overall
2023-04-27 11755, 2023
akshaaatt
Which we need to create via the revamp, app, and more exciting features like yim
2023-04-27 11705, 2023
akshaaatt
Recommendation engine is the key here
2023-04-27 11710, 2023
jasje
true
2023-04-27 11702, 2023
akshaaatt
Once we have the apps and things there for us, we can focus closely on user interactions and work on stuff which people want more
2023-04-27 11713, 2023
jasje
I guess recommendation engine could use some help from users
2023-04-27 11724, 2023
akshaaatt
Right. Exactly that
2023-04-27 11742, 2023
akshaaatt
I want to use ML on the app side to recommend songs better to the users
2023-04-27 11752, 2023
jasje
like dislike a recommendation
2023-04-27 11702, 2023
akshaaatt
Yeah. Tiktok does that
2023-04-27 11708, 2023
jasje
use listen time
2023-04-27 11715, 2023
akshaaatt
Yeah
2023-04-27 11730, 2023
akshaaatt
Even on server side more of what your following listen to and stuff
2023-04-27 11746, 2023
akshaaatt
Plus better engagement with users through stuff like yim or push notifications..
2023-04-27 11759, 2023
jasje
push notifications is a must
2023-04-27 11705, 2023
jasje
FCM is the way
2023-04-27 11712, 2023
akshaaatt
Let’s see…
2023-04-27 11729, 2023
jasje
can we replicate FCM tho?
2023-04-27 11735, 2023
akshaaatt
Lol no
2023-04-27 11739, 2023
jasje
how on earth do they do it
2023-04-27 11754, 2023
akshaaatt
Google uses the play services for it internally
2023-04-27 11717, 2023
akshaaatt
They don’t want to expose push notifications to users now because a lot of people used to misuse it earlier
2023-04-27 11735, 2023
akshaaatt
Like reading other ap’s notifications
2023-04-27 11736, 2023
jasje
it should be just repeated API calls?
2023-04-27 11702, 2023
akshaaatt
Yeah but that drains the battery jasje
2023-04-27 11716, 2023
jasje
what extra do they do then?
2023-04-27 11708, 2023
akshaaatt
Google and these smartphone guys don’t want it to seem like their phones are shitty and that they drain in 4hrs just because some shady slim wanted to do repeated api calls every 2secs throughout the phone’s lifetime
2023-04-27 11740, 2023
jasje
xD
2023-04-27 11750, 2023
akshaaatt
The thing with push notifications are that they run even when the app is closed
2023-04-27 11757, 2023
akshaaatt
That’s the whole point of them
2023-04-27 11731, 2023
jasje
is there competitor of FCM?
2023-04-27 11733, 2023
santiagofn
Talking about MB revamp, it's the first time I see a backend done using Perl. It's also the first time I encountered Flow instead of typescript
