#metabrainz

akshaaatt: I have not lol. I just keep sidelining it :P

Why Spotify Wants You to Rely on Playlists: https://corydoctorow.bandcamp.com/track/chapter...

jasje we should have completed the migration. It got really confusing for me when I was working on some stuff because half the app uses one and the half another and their is code duplication.

We shouldn’t de-prioritise such things.

akshaaatt: alright will do it

I’ve made the changes now jasje

But the point is that we shouldn’t abandon such things and move on to solving other things

understood

[listenbrainz-android] 14akshaaatt opened pull request #143 (03main…migration): Complete Migration from UserPreferences to AppPreferences, Fix Listens Service and cleanup code https://github.com/metabrainz/listenbrainz-andr...

Pratha-Fish: yes!

hi akshaaatt

Hi jasje!

So what I meant originally was: onActiveSessionsChangedListener gets called a lot

like a lot

so if the user is logged in

It’s called whenever a new app opens up

that makes username != null true

akshaaatt: its buggy

Right. That could help us lol

Nice hack

so whenever i switch to another app or the callback itself bugs

the API would be called

I think this is a bad sign for us. We should move the services api to some place else then

yes

Call it in app start

save its result

call it when user logs in

but not the service

ive debugged it for hours and learned how shit code android devs wrote

😂😂😂😂

all callbacks are called like 2-3 times ffs

sometime out of nowhere

the username variable is fine btw

the process of registering is pretty instantaneous

so no worries there

I have to see now. This is shitty. What if the controllers register spotify first and then the services api fetches the results

When do we remove it?

when the service bugs out or activeSessionsChange

bugging out is rare but there

CatQuest: epic! As an EDM guy that place is a pilgrimage site for me 😭

swiping away notification causes an app to lose its current mediaSession

so its like if we really try to make it sync, we lose performance

but if we let nature do its thing

Right

it'd be nice

XD

I was thinking of using broadcast recievers

But don't know much about it

Yeah. That could be another option

My mind is already too fucked today. This PR was hell for me

great

take rest soldier

xD

or shall i say]

cap'n

akshaaatt: btw i would like to do the broadcast part

so dont worry there

jasje: I don’t think calling the services api even on app start is a good idea

The user could unlink their spotify account so we have to call it somewhere for frequent updates

akshaaatt: its really a problem where the server needs to send the update and not what the frontend demands

But the app is closed and opened a lot

Yeah

seems fcm thing to me

hmmm

That is a valid point

push notifications...

push notifications push notifications push notifications

push notifications push notifications push notifications

lol

xD

lets leave that thing for the user now then

just add a disclaimer or sumn

Lol

"i" icon

we can't really do much here anyways

its not like we don't have the ability

its just that we are bottlenecked

I mean… our app is great but there are some things which are like… wtf do I do here. “Just ask the user to add their 100 lines token in the app and make them do a pseudo login just to get the username”

We haven’t yet handled the case where the user might update their username. What would we do then😂

bottlenecked by server

username can't be updated in lb

afaik

It was under work somewhere

Tbh we have the same username everywhere

There is an update functionality somehwere

Might be MB, I think

that would again be an FCM problem

No jasje

why

We need a getUser api which gives us everything when the app opens

That will solve everything

All user details at once for that session

We just take care of the token.. everything else will be provided in runtime and not persisted

XD

these cases are just the cases where "server needs to send update"

or server wants to communicate

not the device

Well. We have REST apis. For your use case jasje, we might have to look knto socket io connection

Fcm won’t be good for handling small updates

It’s usually used for promotion and user notifications