#metabrainz

/

      • jasje
        but they only change with system theme
      • 2023-05-28 14837, 2023

      • akshaaatt
        No I didn’t port white icons jasje
      • 2023-05-28 14854, 2023

      • akshaaatt
        I have switched the color to a variable in xml
      • 2023-05-28 14836, 2023

      • jasje
        huh so thats the problem
      • 2023-05-28 14812, 2023

      • jasje
        need to convert it to compose
      • 2023-05-28 14848, 2023

      • akshaaatt
        How do you convert the icons to compose?
      • 2023-05-28 14833, 2023

      • jasje
        use drawable res and then apply tint
      • 2023-05-28 14811, 2023

      • akshaaatt
        Umm. I mean yeah. But is there anything in the current implementation?
      • 2023-05-28 14837, 2023

      • akshaaatt
        Missing *
      • 2023-05-28 14841, 2023

      • jasje
        yup
      • 2023-05-28 14851, 2023

      • jasje
        system theme chooses icon color
      • 2023-05-28 14858, 2023

      • jasje
        user override does not
      • 2023-05-28 14824, 2023

      • jasje
        you have use Color.Unspecified
      • 2023-05-28 14828, 2023

      • jasje
        used*
      • 2023-05-28 14837, 2023

      • jasje
        it should be conditional
      • 2023-05-28 14801, 2023

      • jasje
        MaterialTheme.colorScheme.onSurface
      • 2023-05-28 14802, 2023

      • akshaaatt
        Yeah that was for those colored icons
      • 2023-05-28 14810, 2023

      • akshaaatt
        We had previously
      • 2023-05-28 14851, 2023

      • jasje
        yes
      • 2023-05-28 14838, 2023

      • jasje
        use MaterialTheme.colorScheme.onSurface anywhere you want contrasting color
      • 2023-05-28 14842, 2023

      • jasje
        white on black
      • 2023-05-28 14847, 2023

      • jasje
        or black on white
      • 2023-05-28 14819, 2023

      • akshaaatt
        Yus
      • 2023-05-28 14816, 2023

      • akshaaatt
        Android made the worst transition in history from MVC pattern to JC
      • 2023-05-28 14846, 2023

      • jasje
        xD
      • 2023-05-28 14800, 2023

      • akshaaatt
        Projects are literally all over the place. They smartly called it compatibility for both the old style and composables
      • 2023-05-28 14825, 2023

      • akshaaatt
        Literally see our project, it’s everywhere. Half of the things use res things and half use compose
      • 2023-05-28 14844, 2023

      • akshaaatt
        Plus I can’t have an app with composables managing their own lifecycles
      • 2023-05-28 14826, 2023

      • jasje
        i told you
      • 2023-05-28 14848, 2023

      • jasje
        this app needs a 9-5 juicer
      • 2023-05-28 14854, 2023

      • akshaaatt
        Lmao
      • 2023-05-28 14803, 2023

      • jasje
        to get those little things right
      • 2023-05-28 14843, 2023

      • jasje
        alot of stuff is here and there
      • 2023-05-28 14811, 2023

      • akshaaatt
        Tbh google android needs to get serious in life. The way they manage dependencies is so shitty. Modularizing every small thing
      • 2023-05-28 14835, 2023

      • akshaaatt
        Wtf is material, appcompat, material3? It should have all been one damn thing
      • 2023-05-28 14802, 2023

      • akshaaatt
        They just have the reputation of scrapping things and starting new
      • 2023-05-28 14848, 2023

      • akshaaatt
        I remember 3-4 years back, you had to add dependencies separately for card, recycler view, etc separately
      • 2023-05-28 14805, 2023

      • akshaaatt
        Huh
      • 2023-05-28 14803, 2023

      • jasje
        it is what it is
      • 2023-05-28 14830, 2023

      • jasje
        my work is gonna have so many conflicts with your work
      • 2023-05-28 14835, 2023

      • jasje
        me is tired
      • 2023-05-28 14830, 2023

      • BrainzGit
        [listenbrainz-android] 1407jasjeet opened pull request #159 (03main…Fix-theme-switch): Fixed theme switch https://github.com/metabrainz/listenbrainz-androi…
      • 2023-05-28 14855, 2023

      • akshaaatt
        Which work jasje?
      • 2023-05-28 14815, 2023

      • jasje
        search
      • 2023-05-28 14823, 2023

      • jasje
        featury
      • 2023-05-28 14827, 2023

      • jasje
        feature*
      • 2023-05-28 14840, 2023

      • akshaaatt
        How is search impacted by the changes I made?
      • 2023-05-28 14819, 2023

      • jasje
        i was working with top app bar and was doing animations
      • 2023-05-28 14811, 2023

      • Lotheric_ joined the channel
      • 2023-05-28 14828, 2023

      • Lotheric has quit
      • 2023-05-28 14837, 2023

      • lucifer
        zas: not urgent, but sentry.meb.org consistently 502s for me
      • 2023-05-28 14820, 2023

      • BrainzGit
        [listenbrainz-android] 14prabalsingh24 opened pull request #160 (03main…add-newsbrainz-activity-android-manifest): Fix: Declare NewsBrainzActivity in androidManifest https://github.com/metabrainz/listenbrainz-androi…
      • 2023-05-28 14850, 2023

      • zas
        lucifer: I rebooted the server, it seems to work now
      • 2023-05-28 14809, 2023

      • lucifer
        thanks zas
      • 2023-05-28 14812, 2023

      • lucifer
      • 2023-05-28 14802, 2023

      • petitminion joined the channel
      • 2023-05-28 14845, 2023

      • tykling has quit
      • 2023-05-28 14831, 2023

      • tykling joined the channel
      • 2023-05-28 14851, 2023

      • petitminion has quit
      • 2023-05-28 14804, 2023

      • prabalsingh joined the channel
      • 2023-05-28 14858, 2023

      • prabalsingh has quit
      • 2023-05-28 14839, 2023

      • Maxr1998 joined the channel
      • 2023-05-28 14845, 2023

      • Maxr1998_ has quit
      • 2023-05-28 14855, 2023

      • petitminion joined the channel
      • 2023-05-28 14852, 2023

      • petitminion has quit
      • 2023-05-28 14856, 2023

      • elomatreb[m]
        Is sending outgoing email possibly broken right now? I didn't get either my weekly edit summary mail or a notification about a note left on my edit
      • 2023-05-28 14855, 2023

      • petitminion joined the channel
      • 2023-05-28 14805, 2023

      • petitminion has quit
      • 2023-05-28 14837, 2023

      • petitminion joined the channel
      • 2023-05-28 14850, 2023

      • BrainzGit
        [listenbrainz-server] 14vardansaini opened pull request #2499 (03master…Fix-uses-of-APIUnauthorized-error): LB-1256 Fix uses of APIUnauthorized error https://github.com/metabrainz/listenbrainz-server…
      • 2023-05-28 14853, 2023

      • vscode
        lucifer: added a New PR https://github.com/metabrainz/listenbrainz-server… can you please review it. Thank you!
      • 2023-05-28 14845, 2023

      • petitminion has quit
      • 2023-05-28 14835, 2023

      • prabalsingh joined the channel
      • 2023-05-28 14823, 2023

      • prabalsingh
        Hey everyone. long time no see:)
      • 2023-05-28 14823, 2023

      • prabalsingh
        akshaaatt i want to contribute to some android project. I am playing around with listenbrainz-android right now. Hope it's ok with you if I pick up some bugs:)
      • 2023-05-28 14824, 2023

      • prabalsingh
        I am not able to load my listens in the android app. I did some digging and it's because the api is taking foreever to load, but when I changed the query param to fetch 5-10 listens, it was able to load the listens in the page.
      • 2023-05-28 14824, 2023

      • prabalsingh
      • 2023-05-28 14825, 2023

      • prabalsingh
        This api takes a really long time to load, is this the normal behaviour of listenbrainz api?
      • 2023-05-28 14825, 2023

      • prabalsingh