mayhem: (replying to something from way back) - that is clearly a keyboard
2023-05-29 14913, 2023
aerozol
jasje: akshaaatt: icon changes, exiting! Hopefully sticking to the ones we discussed :P
2023-05-29 14941, 2023
aerozol
Also, remember that in the style guide we avoid using 100% black, we have a different ‘black’ colour
2023-05-29 14909, 2023
aerozol
reosarevok: when you’re online can you check the report I sent? Would be good to have it looked at soon, and have the community managers input before re-allowing editing rights (let me know if you can’t)
2023-05-29 14911, 2023
akshaaatt
Hi prabalsingh! Thanks a lot for your contributions :) We would love any help we can get for our projects. Feel free to pick up bugs and submit a PR for them. Let me know if you need some help understanding anything or fixing any issues.
akshaaatt: we should probably use viewpager for this'
2023-05-29 14930, 2023
akshaaatt
Yeah. Infinite loading will be the key
2023-05-29 14941, 2023
akshaaatt
You are already making it for feed, right jasje?
2023-05-29 14946, 2023
jasje
yes
2023-05-29 14902, 2023
akshaaatt
Then you would be the right person to update it for profile as well
2023-05-29 14906, 2023
jasje
but i need to edit the endpoints themselves first
2023-05-29 14916, 2023
jasje
akshaaatt: or
2023-05-29 14925, 2023
akshaaatt
Not the endpoints but the params which go in
2023-05-29 14956, 2023
jasje
iss complicated
2023-05-29 14925, 2023
bitmap
zas: is 15 UTC ok for the database downtime?
2023-05-29 14935, 2023
akshaaatt
It's not. I have the code for things if you want me to work on it.
2023-05-29 14947, 2023
jasje
akshaaatt: but anyways i see you removed preloader from listens screen
2023-05-29 14959, 2023
akshaaatt
Yes that was causing a crash
2023-05-29 14902, 2023
jasje
akshaaatt: im talking about feed
2023-05-29 14915, 2023
akshaaatt
There seems be to be some fault from glide
2023-05-29 14932, 2023
jasje
akshaaatt: its kinda restrictive but works good when it does
2023-05-29 14942, 2023
jasje
coil is so shit
2023-05-29 14939, 2023
jasje
akshaaatt: since we have removed the preloader
2023-05-29 14948, 2023
lucifer
akshaaatt: load the listens in smaller batches. `https://api.listenbrainz.org/1/user/prabalsingh24/listens` will give 25 listens at max by default. look at the listened_at value of the last listen in that list and then next time query with that as `max_ts`, `https://api.listenbrainz.org/1/user/prabalsingh24/listens?max_ts=1685294816` so on.
2023-05-29 14914, 2023
jasje
might as well add the fallback cover art innit?
2023-05-29 14953, 2023
bitmap
zas: anyway I prepared a google doc & invited you & others
2023-05-29 14914, 2023
avane has quit
2023-05-29 14915, 2023
SothoTalKer has quit
2023-05-29 14915, 2023
KassOtsimine has quit
2023-05-29 14916, 2023
vscode has quit
2023-05-29 14916, 2023
jasje has quit
2023-05-29 14916, 2023
Freso has quit
2023-05-29 14917, 2023
atj has quit
2023-05-29 14917, 2023
bitmap has quit
2023-05-29 14925, 2023
vscode joined the channel
2023-05-29 14927, 2023
KassOtsimine joined the channel
2023-05-29 14927, 2023
jasje joined the channel
2023-05-29 14931, 2023
theraspberry has quit
2023-05-29 14943, 2023
Freso joined the channel
2023-05-29 14915, 2023
atj joined the channel
2023-05-29 14915, 2023
SothoTalKer joined the channel
2023-05-29 14931, 2023
avane joined the channel
2023-05-29 14955, 2023
bitmap joined the channel
2023-05-29 14900, 2023
yvanzo
O’Moin
2023-05-29 14947, 2023
yvanzo
bitmap: ok for me
2023-05-29 14940, 2023
tux0r has quit
2023-05-29 14918, 2023
jasje
monkey: up?
2023-05-29 14906, 2023
jasje
lucifer: ?
2023-05-29 14958, 2023
jasje
just added the test to the new endpoint
2023-05-29 14928, 2023
jasje
also wanted to know
2023-05-29 14900, 2023
jasje
what max limit do you suggest for getting follow listens?
2023-05-29 14912, 2023
jasje
current is 2
2023-05-29 14922, 2023
jasje
per user
2023-05-29 14925, 2023
jasje
and 10 overall
2023-05-29 14900, 2023
akshaaatt
Cool lucifer. We'll do that soon. Just wanted to confirm that the api had no issues
2023-05-29 14949, 2023
mayhem
moooin!
2023-05-29 14957, 2023
mayhem
aerozol: key-board. ha, love it!
2023-05-29 14927, 2023
aerozol
Moin!
2023-05-29 14951, 2023
mayhem
after this weekend its going to take a bit to readjust to work -- spring in BCN is really lovely with loads of stuff going on.
Hold on, for "processing replication changes" actually.
2023-05-29 14907, 2023
aerozol
jasje: It’s limited in the other feed, sure
2023-05-29 14928, 2023
reosarevok
yvanzo: oh, ok :)
2023-05-29 14900, 2023
aerozol
If it’s limited we might need to reconsider the UI/UX jasje, to indicate that people aren’t getting all the listens of their follows in chronological order (which I would assume)
2023-05-29 14901, 2023
jasje
aerozol: current feed shows only 2 listens per user and total 10 listen events only
2023-05-29 14922, 2023
aerozol
jasje: Yup, no point in making the same feed in another tab though, right!
2023-05-29 14952, 2023
jasje
yup i was thing 4-5 per user and 25 as the limit
2023-05-29 14959, 2023
jasje
was thinking**
2023-05-29 14908, 2023
jasje
the frontend can then fetch next 25 by using min_ts of present list
autoAddReplicas is dropped from Solr 9 anyway, not going to use it.
2023-05-29 14953, 2023
jasje
monkey: about the listens section in feed
2023-05-29 14932, 2023
monkey
Just reading the backlog now. I agree with aerozol, I think for this feature of your friends' listens, maybe we shouldn't limit the number of listens, and instead just show listens chronologically
2023-05-29 14912, 2023
monkey
We limited it originally in the feed so that it wouldn't take over other feed events, but I'm not sure that's what we want if we separate the feature
2023-05-29 14909, 2023
jasje
alright
2023-05-29 14922, 2023
jasje
if you still wanted to limit somehow
2023-05-29 14911, 2023
jasje
so that a single user cannot just take up the whole listens section because their listens have the timestamp priority
2023-05-29 14948, 2023
monkey
Sorry, i'm not sure of what you're asking
2023-05-29 14911, 2023
monkey
I understand we could have cases where one user's listens takes most or all of the page, but I think that's more logical (to me at least) than arbitrary limits. As aerozol said the UI would need to be different in ways I don't really know yet if we wanted to do that
2023-05-29 14947, 2023
monkey
It makes pagination more complicated, and probably not reproducible
2023-05-29 14902, 2023
monkey
as in moving form one page to another and then back, you might not have the same page
2023-05-29 14939, 2023
yvanzo
zas: DELETEREPLICA gave a more useful error message: the replica identifier is "core_nodeX" rather than core name "annotation_shard1_replicaY"
