I assume there's no way to match those RFE links to anything current?
2023-05-30 15026, 2023
yvanzo
links are to an older bug tracker
2023-05-30 15051, 2023
reosarevok
Yeah. It's like two bug trackers out of date I think :D
2023-05-30 15052, 2023
yvanzo
SUHH now is in the database :)
2023-05-30 15039, 2023
reosarevok
"Some extra "countries" have been requested, notably for "Benelux", the European Union, "Unknown" and "Worldwide" releases RFE 987023." I think we have tickets for the first two, and obviously the last exists
2023-05-30 15049, 2023
reosarevok
I haven't heard of "Unknown" as a request I think?
2023-05-30 15051, 2023
yvanzo
But the wiki table for country codes is likely outdated, we should probably have MBS to generate it.
mayhem: it only happens on docker upgrade, afaik, so, if you restarted containers, it shouldn't happen anymore until next upgrade. We reported it upstream, and it seems more people have same or similar issue, so I expect it to be fixed in next versions
2023-05-30 15037, 2023
mayhem
i restarted containsers many many times, it keeps happening.
2023-05-30 15038, 2023
yvanzo
reosarevok: btw there are many conflicts in React conversion PRs
2023-05-30 15048, 2023
reosarevok
I can imagine
2023-05-30 15050, 2023
reosarevok
I'll look them over
2023-05-30 15056, 2023
mayhem
downgrading to 5:23.0.6-1~ubuntu.20.04~focal
2023-05-30 15010, 2023
zas
mayhem: then it's likely another issue, yes, you can downgrade <24
2023-05-30 15020, 2023
mayhem
k
2023-05-30 15002, 2023
zas
mayhem: does downgrading solve the issue for you?
2023-05-30 15003, 2023
mayhem
everything started up again, but not enough time has passed for the problem to reoccur.
2023-05-30 15012, 2023
yvanzo
reosarevok: Re extra countries, they have all been requested and accepted but "Benelux" which has been refused as AREQ-2021 but that did not take the release country issue into account.
Europe is not the European Union, as users will remind each other of often
2023-05-30 15017, 2023
yvanzo
"Unknown Country" used to be available at least 8 years ago according to the documentation, probably been removed a while ago for a good reason.
2023-05-30 15017, 2023
reosarevok
That said, I think it makes sense not to add random groupings
2023-05-30 15047, 2023
reosarevok
The EU grows so an EU release from 1980 would be in a different area from an EU release in 2023
2023-05-30 15051, 2023
yvanzo
Oh right, Europe != EU.
2023-05-30 15003, 2023
reosarevok
And Benelux is just a grouping of three countries and it's not hard to just set the three if they apply IMO
2023-05-30 15010, 2023
reosarevok
For the release
2023-05-30 15048, 2023
yvanzo
Ok, it should probably be documented.
2023-05-30 15046, 2023
yvanzo
The other paragraphs about display are outdated.
2023-05-30 15058, 2023
reosarevok
lol, just realized I mixed up release countries and languages earlier
2023-05-30 15000, 2023
reosarevok
Sorry yvanzo
2023-05-30 15019, 2023
reosarevok
That said, I think the right place to list release countries is the same place as languages and whatnot, under /attributes
2023-05-30 15040, 2023
reosarevok
IIUC there's no way currently of editing the stuff in release_country from the website either?
2023-05-30 15049, 2023
reosarevok
If so, that should be part of the implementation I'd say :)
2023-05-30 15054, 2023
yvanzo
Countries are edited from area editing pages.
2023-05-30 15012, 2023
yvanzo
Those are area attributes.
2023-05-30 15006, 2023
yvanzo
It has nothing to do with types.
2023-05-30 15029, 2023
reosarevok
Gender is there, Language is there, it's not about types, it's about making stuff available to edit that is not elsewhere
2023-05-30 15010, 2023
reosarevok
Areas should be edited from the area pages, sure, but whether an area qualifies as a release country should be the decision of schema people, not area people, IMO, and indicated elsewhere
2023-05-30 15004, 2023
yvanzo
Gender is an attribute type, not an entity attribute.
2023-05-30 15025, 2023
yvanzo
Country codes are area attributes.
2023-05-30 15039, 2023
yvanzo
It’s available to edit already.
2023-05-30 15026, 2023
yvanzo
I see your point but there is no conflict with the area editor either :)
2023-05-30 15056, 2023
yvanzo
reosarevok: Where should country groups be documented?
2023-05-30 15013, 2023
reosarevok
I'm not talking about country codes, I'm talking about the release_country table that dictates which areas can be release countries.
2023-05-30 15015, 2023
reosarevok
Sorry, "country_area"
2023-05-30 15025, 2023
reosarevok
That's just a list of area ids, not related to country codes :)
2023-05-30 15007, 2023
reosarevok
You mean "worldwide" and "europe"? Honestly, not sure. Either on their respective annotations or under doc/Area I guess?
2023-05-30 15009, 2023
yvanzo
Alright I didn’t dig the details, thanks for having looked into it :)
2023-05-30 15048, 2023
yvanzo
reosarevok: I mean Benelux and stuff that won't be in the database but might appear on physical releases.
I guess that could be under /Release, possibly, saying that if it says it's for a specific set of countries you should set them
2023-05-30 15041, 2023
yvanzo
I just moved it from "Release Country".
2023-05-30 15055, 2023
reosarevok
Ok :) Maybe there then? :D
2023-05-30 15006, 2023
yvanzo
But I’m not sure why Europe is there and not Benelux?
2023-05-30 15027, 2023
yvanzo
Would probably fit under "What a Release Country is not"
2023-05-30 15040, 2023
reosarevok
Honestly, I'm not sure why Europe is there either
2023-05-30 15046, 2023
reosarevok
I think it just got grandfathered in
2023-05-30 15017, 2023
yvanzo
It kinda unknown but European.
2023-05-30 15017, 2023
reosarevok
Because it's fairly common to have "US release and European release" but it's a lot harder to figure out where in Europe it was available, I guess?
2023-05-30 15047, 2023
reosarevok
I expect that was the reasoning for this - it's kinda different from a Benelux release in that for that you know it applies to all three countries
2023-05-30 15007, 2023
reosarevok
But yes, it does basically seem to be "unknown, but some European countries, anyway" :p
2023-05-30 15059, 2023
monkey
aerozol for when you wake up: I suppose you made the background images for the recommendations page using a vector application? Could you please export them as SVGs? (these guys:) https://usercontent.irccloud-cdn.com/file/hd84VCk…
2023-05-30 15033, 2023
yvanzo
reosarevok: Up for review in the transclusion table
<yvanzo> "Is the Tagger section...still up-to-date?" Not really. I'll take a look, but I think any outstanding issues are already captured on tickets.
2023-05-30 15057, 2023
rdswift has quit
2023-05-30 15025, 2023
rdswift joined the channel
2023-05-30 15005, 2023
jasje
yo akshaaatt
2023-05-30 15026, 2023
jasje
should i put unit test for API calls when the api returns 40X status codes too?
2023-05-30 15001, 2023
jasje
i guess yes
2023-05-30 15035, 2023
jasje
lucifer^^
2023-05-30 15049, 2023
lucifer
jasje: yes
2023-05-30 15000, 2023
jasje
im pushing code to my draft pr
2023-05-30 15002, 2023
jasje
have a look
2023-05-30 15006, 2023
jasje
in a sec
2023-05-30 15015, 2023
lucifer
will do later.
2023-05-30 15011, 2023
jasje
okeyy
2023-05-30 15045, 2023
Maxr1998_ has quit
2023-05-30 15003, 2023
Maxr1998 joined the channel
2023-05-30 15031, 2023
bitmap
zas: 👍
2023-05-30 15051, 2023
bitmap
yvanzo: thanks for taking care of the docker-server-configs PRs. looking into reosarevok's RG test now
2023-05-30 15041, 2023
rdswift
yvanzo, I checked with outsidecontext about the "Tagger" section of https://wiki.musicbrainz.org/Internationalization and his comment was, "That info is all totally outdated. There is some validity for the issue of the filesystem if non-Unicode encoding would be used. But in practice all modern OS deal well with the Unicode filenames Picard writes."
2023-05-30 15058, 2023
yvanzo
rdswift: Thanks, dropped
2023-05-30 15015, 2023
rdswift
👍
2023-05-30 15015, 2023
yvanzo
bitmap: That reminds me that I initially wanted to update all working copies. On it!
2023-05-30 15054, 2023
bitmap
oh good idea
2023-05-30 15034, 2023
akshaaatt
Sure jasje
2023-05-30 15046, 2023
bitmap
reosarevok: yeah it's likely because the AC fields are rendered by JS after the page loads. www::mechanize expects them to be in the HTML already
2023-05-30 15042, 2023
bitmap
one way around this would be to just submit the post request manually instead of with the $mech->submit_form_ok api. let me see if I can find an example
2023-05-30 15056, 2023
bitmap
though i'd recommend using a selenium test since you can interact with the fields on the page using JS
bitmap: thanks, will try that in the morning. The goal of this is to have a reasonably standard set of tests for all Create controllers, and we already do for the other ones, hence wanting it here, although we could *also* have a more wide Selenium one added later :)
2023-05-30 15005, 2023
bitmap
makes sense (though I'm not 100% sure if you can actually test the fix in the PR with the mechanize test?)
2023-05-30 15022, 2023
bitmap
(guessing not since posting the form directly will bypass any template code entirely)
2023-05-30 15052, 2023
yvanzo
bitmap, reosarevok: Updated docker-server-configs and fixed their SSH setup (on all of MB hosts at least for now).
2023-05-30 15022, 2023
bitmap
thanks! that will prevent some headaches in the future
2023-05-30 15027, 2023
yvanzo
zas: There was another glitch (fixed it for all hosts listed in docker-server-configs): /root/.ssh/known_hosts still had the old GitHub RSA key (on a few hosts only) or for some IPs (on most hosts).
2023-05-30 15051, 2023
yvanzo
So git operations would fail randomly depending on which IP was reached.
2023-05-30 15059, 2023
reosarevok
bitmap: yeah, I was wondering that myself, I might need to add a second Selenium test for that already now. Oh well. There's worse things than Selenium tests. Probably. Physical torture.
2023-05-30 15012, 2023
reosarevok
I'll look into it tomorrow, thanks :)
2023-05-30 15016, 2023
bitmap
lol
2023-05-30 15029, 2023
bitmap
if it's really that bad let me know how I can help and maybe we can improve things
2023-05-30 15012, 2023
reosarevok
It's just a lot more confusing to me than standard Perl or JS tests, but that's just me and I'd probably solve it by writing a lot of them so I get used to it really
[musicbrainz-server] 14mwiencek merged pull request #2951 (03master…mbs-13015): MBS-13015: Tracks with only URL relationships don't show in the relationship editor https://github.com/metabrainz/musicbrainz-server/…
2023-05-30 15013, 2023
reosarevok
Yeah, my selenium tests were a mess for a long time, I *think* they maybe pass now? Or maybe some still break
2023-05-30 15025, 2023
reosarevok
Usually I just wrote them, sent them up to CI for testing, hoped they pass, sigh
2023-05-30 15028, 2023
bitmap
ok I should probably try setting it up with docker, I only ever did it on the host
