#metabrainz

/

      • arsh
        Sure aerozol: your help will be great
      • 2023-06-16 16703, 2023

      • Sciencentistguy4 joined the channel
      • 2023-06-16 16732, 2023

      • Sciencentistguy has quit
      • 2023-06-16 16732, 2023

      • Sciencentistguy4 is now known as Sciencentistguy
      • 2023-06-16 16750, 2023

      • bigquestion has quit
      • 2023-06-16 16723, 2023

      • bigquestion joined the channel
      • 2023-06-16 16745, 2023

      • outsidecontext
        aerozol: that would be great
      • 2023-06-16 16719, 2023

      • nyaomi has quit
      • 2023-06-16 16731, 2023

      • nyaomi joined the channel
      • 2023-06-16 16751, 2023

      • monotux has quit
      • 2023-06-16 16701, 2023

      • monotux joined the channel
      • 2023-06-16 16740, 2023

      • aerozol
        outsidecontext: done, I’ll assume that when stuff goes on the blog it’s okay to also share elsewhere, let me know if that’s ever not the case
      • 2023-06-16 16754, 2023

      • outsidecontext
        aerozol: I'm fine with that :) thanks a lot
      • 2023-06-16 16732, 2023

      • aerozol
        Any time! I’m starting to feel nice and comfortable with MeB communications now
      • 2023-06-16 16704, 2023

      • aerozol
        It helps that nowhere is as scary as our very own forums :P
      • 2023-06-16 16723, 2023

      • ApeKattQuest
        zas: it seems static.brainz doesn't actually work (yet) so I'm using staticbrainz for now
      • 2023-06-16 16725, 2023

      • ApeKattQuest
      • 2023-06-16 16758, 2023

      • zas
      • 2023-06-16 16706, 2023

      • rozlav has quit
      • 2023-06-16 16717, 2023

      • rozlav joined the channel
      • 2023-06-16 16705, 2023

      • yyoung[m] has quit
      • 2023-06-16 16748, 2023

      • ApeKattQuest
        zas: yes but but it does not show here https://beta.musicbrainz.org/instrument/dc17c2a5-…
      • 2023-06-16 16717, 2023

      • reosarevok
        aerozol: what's scary about our forums? :D
      • 2023-06-16 16727, 2023

      • reosarevok
        ApeKattQuest: yeah, that will only show after the next release
      • 2023-06-16 16753, 2023

      • reosarevok
        So, in beta soon, elsewhere in two weeks or so I guess?
      • 2023-06-16 16747, 2023

      • theflash_ joined the channel
      • 2023-06-16 16755, 2023

      • theflash_
        Hi akshaaatt !
      • 2023-06-16 16715, 2023

      • akshaaatt
        Hi theflash_ !
      • 2023-06-16 16752, 2023

      • BrainzGit
        [musicbrainz-server] 14reosarevok merged pull request #2950 (03master…test-js-utilities): Split and improve JS utilities tests https://github.com/metabrainz/musicbrainz-server/…
      • 2023-06-16 16710, 2023

      • theflash_
        The api you told me to work on is giving data in this format
      • 2023-06-16 16737, 2023

      • theflash_
      • 2023-06-16 16714, 2023

      • theflash_
        After entering the authorisation header == token
      • 2023-06-16 16736, 2023

      • theflash_
        Can you bring more light to how we have to use token to fetch listens
      • 2023-06-16 16724, 2023

      • akshaaatt
        That looks good but why don't you have any data?
      • 2023-06-16 16745, 2023

      • akshaaatt
        The token is unique for every user
      • 2023-06-16 16753, 2023

      • akshaaatt
        It’s like your password
      • 2023-06-16 16703, 2023

      • akshaaatt
        Username is chill. Anyone could know your username
      • 2023-06-16 16725, 2023

      • akshaaatt
        But only the people with your token (ideally only you) can view your private stuff as well
      • 2023-06-16 16737, 2023

      • akshaaatt
        A lot of stuff on LB is public
      • 2023-06-16 16744, 2023

      • akshaaatt
        For example, your listens
      • 2023-06-16 16751, 2023

      • akshaaatt
        So you won’t need a token for it
      • 2023-06-16 16706, 2023

      • akshaaatt
        But for accessing things like your settings, etc, a token is essential
      • 2023-06-16 16730, 2023

      • akshaaatt
        Same way, a feed is unique to the user and requires a token so that only you can access your feed
      • 2023-06-16 16720, 2023

      • akshaaatt
        Do go through the LB docs to figure out which api requires a token and which doesn’t
      • 2023-06-16 16729, 2023

      • akshaaatt
        Makes sense, theflash_ ?
      • 2023-06-16 16749, 2023

      • theflash_
        My feed is empty when I go to the lb website, that’s why it is not showing
      • 2023-06-16 16700, 2023

      • akshaaatt
        Cool, makes sense then
      • 2023-06-16 16709, 2023

      • akshaaatt
        You should probably follow a few people on LB
      • 2023-06-16 16725, 2023

      • akshaaatt
        Follow me for instance! akshaaatt is my username there
      • 2023-06-16 16744, 2023

      • theflash_
        Ya gotcha!!!
      • 2023-06-16 16709, 2023

      • theflash_
        akshaaatt: I want to know that how can we use token to prevent hard-code in the user-listens api
      • 2023-06-16 16752, 2023

      • BrainzGit
        [musicbrainz-server] 14reosarevok opened pull request #2970 (03master…MBS-13130): Mbs 13130 https://github.com/metabrainz/musicbrainz-server/…
      • 2023-06-16 16725, 2023

      • reosarevok
        lol, forgot to fix the name :) Anyway, new edit icon then
      • 2023-06-16 16714, 2023

      • nawcom has quit
      • 2023-06-16 16732, 2023

      • nawcom joined the channel
      • 2023-06-16 16721, 2023

      • BrainzGit
        [musicbrainz-server] 14reosarevok merged pull request #2967 (03master…MBS-13131): MBS-13131: Move staticbrainz to static.metabrainz for instruments https://github.com/metabrainz/musicbrainz-server/…
      • 2023-06-16 16704, 2023

      • akshaaatt
        As I said theflash_ , the users listens api doesn’t need a token
      • 2023-06-16 16727, 2023

      • akshaaatt
        So what you can do is just keep the username dynamic for dev ease
      • 2023-06-16 16720, 2023

      • theflash_
        Alright!
      • 2023-06-16 16756, 2023

      • avane has quit
      • 2023-06-16 16715, 2023

      • BrainzGit
        [musicbrainz-server] 14reosarevok merged pull request #2715 (03master…more-perl-critic-builtinfunctions): Follow more Perl::Critic::Policy::BuiltinFunctions rules https://github.com/metabrainz/musicbrainz-server/…
      • 2023-06-16 16733, 2023

      • avane joined the channel
      • 2023-06-16 16720, 2023

      • q3lont joined the channel
      • 2023-06-16 16724, 2023

      • rozlav has quit
      • 2023-06-16 16747, 2023

      • mayhem
      • 2023-06-16 16706, 2023

      • mayhem
        aerozol: ^^ lolololol
      • 2023-06-16 16706, 2023

      • q3lont has quit
      • 2023-06-16 16737, 2023

      • atj
      • 2023-06-16 16742, 2023

      • akshaaatt
        😂😂😂😂😂😂
      • 2023-06-16 16736, 2023

      • theflash_ has quit
      • 2023-06-16 16732, 2023

      • Maxr1998 has quit
      • 2023-06-16 16713, 2023

      • Maxr1998 joined the channel
      • 2023-06-16 16757, 2023

      • reosarevok
        bitmap: around? :)
      • 2023-06-16 16707, 2023

      • Pratha-Fish peeks around the corner
      • 2023-06-16 16729, 2023

      • ApeKattQuest
        🐟
      • 2023-06-16 16716, 2023

      • rozlav joined the channel
      • 2023-06-16 16721, 2023

      • Pratha-Fish
        ApeKattQuest: cool new username :D
      • 2023-06-16 16721, 2023

      • Pratha-Fish
        reminds me of the ape titan
      • 2023-06-16 16748, 2023

      • ApeKattQuest
        so funny little story: in norwegian "monkey" is literally "ape cat"
      • 2023-06-16 16751, 2023

      • ApeKattQuest
        apekatt
      • 2023-06-16 16755, 2023

      • ApeKattQuest
        :D
      • 2023-06-16 16702, 2023

      • ApeKattQuest
        Pratha-Fish: thanks :D
      • 2023-06-16 16720, 2023

      • Pratha-Fish
        lmao ape cat sounds suitable for a monkey
      • 2023-06-16 16755, 2023

      • ApeKattQuest
        YES!
      • 2023-06-16 16718, 2023

      • ApeKattQuest
        so guess what hare is?
      • 2023-06-16 16730, 2023

      • Pratha-Fish
        smol cat?
      • 2023-06-16 16731, 2023

      • ApeKattQuest
        hare, but also "harepus" hare pussy(cat)
      • 2023-06-16 16748, 2023

      • Pratha-Fish
        hehe as expected
      • 2023-06-16 16758, 2023

      • ApeKattQuest
        it amuses me
      • 2023-06-16 16708, 2023

      • Pratha-Fish
        W Norwegian
      • 2023-06-16 16712, 2023

      • bitmap
        reosarevok: yeah
      • 2023-06-16 16736, 2023

      • reosarevok
        Pratha-Fish, bitmap: hi! :)
      • 2023-06-16 16753, 2023

      • Pratha-Fish
        Hellow ^_^
      • 2023-06-16 16756, 2023

      • ApeKattQuest
        though "pus" isn't necessary cat, but the sensation of something soft and furry. something can be "pusete" and that's the feeling of.. well you ever petted a tiny kitten or a very soft furry thing? that's "pusete"
      • 2023-06-16 16701, 2023

      • reosarevok
        How do things feel so far?
      • 2023-06-16 16709, 2023

      • ApeKattQuest will shut up so bitmap, reo and fish can have theri meeting
      • 2023-06-16 16714, 2023

      • reosarevok
        "pus" feels soft and furry, I guess
      • 2023-06-16 16719, 2023

      • ApeKattQuest
        reosarevok: YES
      • 2023-06-16 16720, 2023

      • reosarevok
        But GSoC things :D
      • 2023-06-16 16749, 2023

      • Pratha-Fish splits brain in 2 to continue both conversations
      • 2023-06-16 16705, 2023

      • ApeKattQuest goes of fishing for dinner instead
      • 2023-06-16 16716, 2023

      • Pratha-Fish please don't the fish
      • 2023-06-16 16722, 2023

      • ApeKattQuest
        🐟
      • 2023-06-16 16733, 2023

      • Pratha-Fish
        reosarevok: the project feels nice so far :D
      • 2023-06-16 16733, 2023

      • Pratha-Fish
        Just a little confused with what to do lol
      • 2023-06-16 16700, 2023

      • Pratha-Fish
        Not to mention, we're a little behind the schedule due to my own few issues 🥲
      • 2023-06-16 16713, 2023

      • Pratha-Fish
        So I'm a little worried about that too
      • 2023-06-16 16715, 2023

      • reosarevok
        The summer is long, we can manage I'm sure :)
      • 2023-06-16 16733, 2023

      • reosarevok
        But yeah. bitmap: how do you feel re: that PR?
      • 2023-06-16 16748, 2023

      • reosarevok
        Pratha-Fish: how much have you tested it? Did you manage to test the autoedit bit?
      • 2023-06-16 16759, 2023

      • Pratha-Fish
        reosarevok: ye, and worst case scenario, GSoC projects can be extended by a few weeks since last year :)
      • 2023-06-16 16700, 2023

      • bitmap
        the PR looks good to me, I did leave one comment and it would be nice to have tests, but otherwise it's nice
      • 2023-06-16 16723, 2023

      • reosarevok
        I think "having tests for the bot" is a big thing we need to work on
      • 2023-06-16 16729, 2023

      • bitmap
        Pratha-Fish: do you have a local musicbrainz-server setup that you can run tests against?
      • 2023-06-16 16740, 2023

      • Pratha-Fish
        reosarevok: bitmap I am testing the new features with this little script, which is totally unideal https://github.com/Prathamesh-Ghatole/MusicBrainz…
      • 2023-06-16 16720, 2023

      • bitmap
        that's good actually, we just need to automate it :)
      • 2023-06-16 16729, 2023

      • Pratha-Fish
        bitmap: I don't have a musicbrainz-server setup unfortunately. I just hit the test.musicbrainz.org website for everything
      • 2023-06-16 16723, 2023

      • Pratha-Fish
        bitmap: sounds good :D
      • 2023-06-16 16723, 2023

      • Pratha-Fish
        The only issue with the script I've found so far is that it doesn't test everything in a function.
      • 2023-06-16 16723, 2023

      • Pratha-Fish
        also reosarevok I haven't tested the autoedit bit yet, I was unaware of it untill yesterday
      • 2023-06-16 16738, 2023

      • reosarevok
        No worries :)
      • 2023-06-16 16743, 2023

      • bitmap
        ok. yeah, test.mb is fine for manual testing, but you'll need a local server for automated tests
      • 2023-06-16 16720, 2023

      • bitmap
      • 2023-06-16 16734, 2023

      • Pratha-Fish
        bitmap: Aight, I'll go ahead and set it up then :)
      • 2023-06-16 16752, 2023

      • Pratha-Fish
        How resource intensive is it tho?
      • 2023-06-16 16730, 2023

      • Pratha-Fish
        My dev environment is a WSL setup running debian on Windows 11. It's limited to 8GB of memory in WSL (I have 16GB total). Would it be enough?
      • 2023-06-16 16734, 2023

      • bitmap
        well, you don't need a full database imported (in fact you don't even need a sample DB, you'll have be running the tests against an empty test DB)
      • 2023-06-16 16734, 2023

      • Pratha-Fish
        infact I'd prefer an empty db, as the complete db always throws errors when I try to put an existing ISO 3166 code in a test area lol
      • 2023-06-16 16751, 2023

      • bitmap
        the requirements are documented in the README too. since you don't need search indexes either, I guess 8GB would more than suffice
      • 2023-06-16 16701, 2023

      • reosarevok
        Yeah, an empty db should work just fine
      • 2023-06-16 16713, 2023

      • Pratha-Fish
        epic!
      • 2023-06-16 16715, 2023

      • reosarevok
        I mean, IIRC my work laptop has 8GB and I manage fine
      • 2023-06-16 16726, 2023

      • reosarevok
        (with no local search server)
      • 2023-06-16 16704, 2023

      • reosarevok
        We actually have a process in MB already to generate an empty test db that gets cleared each time, but not sure how easy it would be to use here?
      • 2023-06-16 16736, 2023

      • bitmap
        yeah, I guess you would skip the createdb.sh step entirely? not sure
      • 2023-06-16 16741, 2023

      • reosarevok
        bitmap: more generally, I assume we can eventually make it so that tests are ran automatically with CI in github as well?
      • 2023-06-16 16741, 2023

      • bitmap
        yep, there is a tests-database Dockerfile in musicbrainz-server it could probably use
      • 2023-06-16 16746, 2023

      • Pratha-Fish
        reosarevok: CI would be sick. I don't know much about it either, so I am eager to learn and implement it
      • 2023-06-16 16716, 2023

      • reosarevok
        I haven't really configured ours either, so I wouldn't mind learning with you, lol, but that means I hope bitmap can teach it :D
      • 2023-06-16 16725, 2023

      • bitmap
        hmm this might actually be easier than musicbrainz-docker
      • 2023-06-16 16729, 2023

      • Pratha-Fish
        Which also reminds me, the codebase for the area bot is currently hosted here: https://github.com/Prathamesh-Ghatole/MusicBrainz…
      • 2023-06-16 16729, 2023

      • Pratha-Fish
        It might be a good idea to move it to MetaBrainz github maybe
      • 2023-06-16 16749, 2023

      • Pratha-Fish
        bitmap: would it be a good idea to dockerize the whole area bot too?
      • 2023-06-16 16702, 2023

      • reosarevok
        Eventually, yes
      • 2023-06-16 16717, 2023

      • reosarevok
        Because we'll want it to run in a container in our setup
      • 2023-06-16 16722, 2023

      • reosarevok
        Like mb2wikidatabot
      • 2023-06-16 16738, 2023

      • reosarevok
        At what step of the work that should happen I dunno, bitmap, what do you think?
      • 2023-06-16 16719, 2023

      • bitmap
        yes, we can worry about that at the end though
      • 2023-06-16 16750, 2023

      • bitmap
      • 2023-06-16 16702, 2023

      • Pratha-Fish
        reosarevok: Great, I'll start learning docker too then. ig we might have a good idea of the timeline of implementing everything within the time bounds of this project during the second half of the summer