you can see the comment, session number: etc. stuff.
2023-07-03 18400, 2023
lucifer
we want to remove those lines from the json endpoints response.
2023-07-03 18445, 2023
lucifer
there multiple solutions possible for that but i think the easiest could be accepting a parameter in the `fetch()` whether the query response will be served to web or returned as json.
2023-07-03 18458, 2023
lucifer
so that the query can generate the response appopriately.
<lucifer> "does that make sense?" <- 1. I did tried to test it in ui, I will fix the issue.
2023-07-03 18407, 2023
pixelpenguin
2. Okay, I understand. I will make the required changes
2023-07-03 18420, 2023
pixelpenguin
Thanks for the quick review
2023-07-03 18424, 2023
AbhinavOhri[m]
monkey: Can you please tell how to integrate my code with listenbrainz?
2023-07-03 18437, 2023
monkey
Sure thing. First step will be to fork the repo and create a new branch to work on. Then copy your components into a new folder in frontend/js/src/explore (I would suggest "stats-art-designer" or something along those lines)
2023-07-03 18450, 2023
monkey
The CSS will need to move to a new .less file in frontend/css/ , and don't forget to import that new less file in main.less
2023-07-03 18423, 2023
monkey
Then have a look at `frontend/js/src/explore/fresh-releases/FreshReleases.tsx` which will show you how to create a new "page" (i.e. a React entry point). Basically you define your functional component (or component class), then further down the file use it on document load: https://github.com/metabrainz/listenbrainz-server…
something to keep an eye on; if they decide to go ahead with removing portal channels but keep support for plumbed channels, then setting up matrix rooms with plumbed connections to the irc rooms would be a good idea.
2023-07-03 18438, 2023
ApeKattQuest
fish
2023-07-03 18418, 2023
reosarevok
<BANG>
2023-07-03 18440, 2023
reosarevok
Welcome to "Half the year is gone, how come" Monday!
2023-07-03 18447, 2023
reosarevok
On my list today: reosarevok, bitmap, zas, mayhem, yvanzo, monkey, lucifer, akshaaatt, CatQuest, riksucks, kellnerd, Pratha-Fish, ShivamAwasthi, vscode, pixelpenguin, arsh, jasje
2023-07-03 18455, 2023
reosarevok
But before, there's two (2) writers today!
2023-07-03 18423, 2023
reosarevok
atj is on holiday, and saw a hoopoe
2023-07-03 18430, 2023
reosarevok
Oh, wait, no, that was not the big part of the report
2023-07-03 18432, 2023
reosarevok
That was
2023-07-03 18432, 2023
ApeKattQuest
a whatnow?
2023-07-03 18432, 2023
reosarevok
'''
2023-07-03 18438, 2023
reosarevok
Last week I continued working on the openresty and consul-template ansible roles and migrating the complex configuration.
2023-07-03 18440, 2023
reosarevok
I also finished implementing a new role for managing apt package installation which will make life easier now we have some servers running Ubuntu 22.04 as well as 20.04
2023-07-03 18441, 2023
reosarevok
'''
2023-07-03 18450, 2023
reosarevok
Enjoy your holiday, atj!
2023-07-03 18417, 2023
reosarevok
aerozol is not *yet* on holiday, but said:
2023-07-03 18418, 2023
reosarevok
'''
2023-07-03 18421, 2023
reosarevok
Getting packed for my holiday! I’ll keep writing meeting notes (which lets me keep up with MeB happenings as well), but not within the usual 24 hours.
2023-07-03 18424, 2023
reosarevok
Last week I did some fun stickers with mayhem, and worked on some long overdue LB release page mockups.
2023-07-03 18428, 2023
reosarevok
That’s me! Gooooo yvanzo
2023-07-03 18429, 2023
reosarevok
'''
2023-07-03 18433, 2023
yvanzo
Hiiiii
2023-07-03 18434, 2023
reosarevok
So, gooooo yvanzo? :)
2023-07-03 18442, 2023
reosarevok
Hiiii indeeeed!
2023-07-03 18453, 2023
yvanzo
Last week I looked into GDPR vs. reCAPTCHA & alternatives for MBS-13146.
This week I've so far worked on a bunch of small guess case issues
2023-07-03 18429, 2023
reosarevok
Pratha-Fish: wanna go? :)
2023-07-03 18434, 2023
ApeKattQuest
uh
2023-07-03 18435, 2023
Pratha-Fish
Sure!
2023-07-03 18440, 2023
Pratha-Fish
Hi all :)
2023-07-03 18442, 2023
ApeKattQuest
hi
2023-07-03 18453, 2023
Pratha-Fish
Last week was quite happening as well :)
2023-07-03 18453, 2023
reosarevok
On my list today: bitmap, zas, mayhem, monkey, lucifer, akshaaatt, ApeKattQuest, riksucks, kellnerd, ShivamAwasthi, vscode, pixelpenguin, arsh, jasje
2023-07-03 18415, 2023
Pratha-Fish
I worked on fixing my local docker setup, which went smoothly, and *finally* got things working as they should
2023-07-03 18425, 2023
Pratha-Fish
Now I've been writing some tests for the new features!
2023-07-03 18453, 2023
Pratha-Fish
Also with the help of bitmap, I closed PR #1 and opened two new PRs for the musicbrainz-bot
2023-07-03 18405, 2023
reosarevok
Yay for closing the PR :)
2023-07-03 18411, 2023
reosarevok
Not even that, merging it!
2023-07-03 18412, 2023
reosarevok
:p
2023-07-03 18424, 2023
Pratha-Fish
xD wrong choice of words
2023-07-03 18424, 2023
ApeKattQuest
yay for writing tests!
2023-07-03 18433, 2023
ApeKattQuest
(as far as i understand that's the most annoying part? :D)
2023-07-03 18437, 2023
Pratha-Fish
Learning something new ^_^ ApeKattQuest
2023-07-03 18444, 2023
Pratha-Fish
well that's it for me for today :D
2023-07-03 18451, 2023
Pratha-Fish
bitmap: would you like to go next?
2023-07-03 18402, 2023
bitmap
sure! hi
2023-07-03 18408, 2023
Pratha-Fish realizes ApeKattQuest was left too 💀
2023-07-03 18415, 2023
mayhem appears
2023-07-03 18419, 2023
ApeKattQuest
:|
2023-07-03 18452, 2023
bitmap
sorry, was it ApeKattQuest's turn?
2023-07-03 18422, 2023
reosarevok
Not really, but you can call ApeKattQuest after you :)
2023-07-03 18426, 2023
ApeKattQuest
no bitmap go i cna go after you!
2023-07-03 18426, 2023
reosarevok
Go for now? :)
2023-07-03 18429, 2023
Pratha-Fish am I disconnected, or is no one typing?
2023-07-03 18429, 2023
trolley has quit
2023-07-03 18431, 2023
bitmap
ok
2023-07-03 18436, 2023
bitmap
slow week for me, but mostly similar to the previous: some code review, gsoc, fixing issues with the pgbouncer container (still need to test it on hetzner servers), and testing a few new Flow features in the MBS codebase
2023-07-03 18445, 2023
bitmap
fin.. go ApeKattQuest!
2023-07-03 18405, 2023
trolley joined the channel
2023-07-03 18409, 2023
Pratha-Fish realizes he was disconnected (How annoying)
2023-07-03 18410, 2023
ApeKattQuest
Arararara~! hi!
2023-07-03 18431, 2023
ApeKattQuest
Did some instrument images because the weather has ben shait, it'll be again this weekend so more instruments to follow♊
2023-07-03 18431, 2023
ApeKattQuest
go uh kellnerd ?
2023-07-03 18442, 2023
kellnerd
Thanks!
2023-07-03 18446, 2023
reosarevok
Still on my list today: zas, mayhem, monkey, lucifer, akshaaatt, riksucks, ShivamAwasthi, vscode, pixelpenguin, arsh, jasje
2023-07-03 18449, 2023
kellnerd
Hey all!
2023-07-03 18456, 2023
kellnerd
I'm through another week of debugging the OpenLibrary importer's producer script, which was hanging instead of running or at least throwing an error.
2023-07-03 18412, 2023
kellnerd
The script basically has two asynchronous parts where I suspected the error: 1) Streaming lines from the database dump, 2) Library to push messages into RabbitMQ
2023-07-03 18432, 2023
kellnerd
Both worked in my separate testing with minimal examples, but nevertheless the idea seemed plausible as there were reports online of similar problems for each of them.
2023-07-03 18455, 2023
kellnerd
But after having wasted multiple days with debugging this (commenting out various combinations of lines), I found the real culprit:
2023-07-03 18421, 2023
monkey
*drumroll*
2023-07-03 18428, 2023
reosarevok
was it kellnerd?
2023-07-03 18435, 2023
ShivamAwasthi
🫣
2023-07-03 18444, 2023
kellnerd
It was the import statement for the logging library, which caused side effects which were severe enough to get the RabbitMQ library hanging
2023-07-03 18455, 2023
reosarevok
Phew, it was not kellnerd at least
2023-07-03 18420, 2023
kellnerd
I kind of guessed it would 've been faster if I had rewritten the script from scratch and I was right.
2023-07-03 18422, 2023
monkey
Oh my.
2023-07-03 18435, 2023
kellnerd
I probably wouldn't have used that library.
2023-07-03 18408, 2023
kellnerd
Weird enough nevertheless. Now I still have to fix some things, but I hope I've dealt with the worst.
I reviewed some PRs and helped GSoC projects along.
2023-07-03 18437, 2023
monkey
Also had a good video chat with aerozol, reviewing the design of the above PRs and planning for the next steps (LB album and artist pages).
2023-07-03 18441, 2023
monkey
And finally did some general housekeeping and ticket triage
2023-07-03 18453, 2023
monkey
Calling Dr. lucifer
2023-07-03 18459, 2023
monkey
You're up :)
2023-07-03 18401, 2023
lucifer
hi all!
2023-07-03 18428, 2023
lucifer
last week i worked on the migrating the tag endpoints to spark and LB db so that mayhem could use those in tags-radio.
2023-07-03 18447, 2023
lucifer
then i worked on adding support for exporting batch generated weekly playlists to spotify.
2023-07-03 18456, 2023
lucifer
also reviewed a couple of PRs.
2023-07-03 18407, 2023
lucifer
that's it for me.
2023-07-03 18409, 2023
lucifer
zas: next?
2023-07-03 18415, 2023
zas
Hey
2023-07-03 18412, 2023
reosarevok
Still on my list today: mayhem, akshaaatt, riksucks, ShivamAwasthi, vscode, pixelpenguin, arsh, jasje
2023-07-03 18424, 2023
zas
last week I spent some time on investigating an annoying issue concerning Picard threading and remote command pipes, a patch was made by phw today based on my findings
2023-07-03 18402, 2023
zas
I also improved monitoring regarding a keydb issue we have on rex/rudi, and updated informations in upstream bug report
2023-07-03 18434, 2023
zas
apart that, I did usual upgrades, user support, supervision and minor fixes. fin. mayhem ?
2023-07-03 18443, 2023
mayhem
ok
2023-07-03 18457, 2023
mayhem
last week I mostly worked on LB radio and getting a few new features in.
2023-07-03 18442, 2023
mayhem
I've improved the syntax and made it consistent with MB -- hopefully in the next day or so I can integrate lucifer's new tag data, which brings the lb-radio to a solid alpha phase where I'll ask for feedback from the community.
2023-07-03 18419, 2023
mayhem
I've already found and rediscovered music, so I am very excited by this!
2023-07-03 18432, 2023
mayhem
I did a few other projects here and there, small stuff.
2023-07-03 18446, 2023
mayhem
reviewed Arsh's work, which is starting to look really nice.
