aerozol: "But if you want to take a shot at something in particular let me know"
2023-07-06 18733, 2023
mayhem
ok sounds good.
2023-07-06 18713, 2023
jasje
aerozol: haha yess my like’s there ;)
2023-07-06 18722, 2023
jasje
mayhem: good luck reviewing arsh's pr
2023-07-06 18752, 2023
jasje
akshaaatt: see i ain't that harsh on you <3
2023-07-06 18723, 2023
mayhem
uh oh, I haven't looked yet. coffee just hitting veins.
2023-07-06 18706, 2023
jasje
+1 on the coffee part
2023-07-06 18704, 2023
akshaaatt
jasje if you ever wanna compare, compare yourself with those above you :) checkout how monkey submits PRs for example
2023-07-06 18749, 2023
jasje
akshaaatt: just kidding and no way arsh is below me
2023-07-06 18716, 2023
akshaaatt
He’s on the same level as
2023-07-06 18718, 2023
jasje
he def better
2023-07-06 18719, 2023
akshaaatt
You
2023-07-06 18729, 2023
akshaaatt
XD jasje already feeling superior
2023-07-06 18741, 2023
jasje
alright i read that wrong
2023-07-06 18717, 2023
jasje
but the boomer(admit it) lecture is there xD
2023-07-06 18739, 2023
akshaaatt
🤣🤣
2023-07-06 18721, 2023
dseomn has quit
2023-07-06 18740, 2023
dseomn joined the channel
2023-07-06 18759, 2023
monkey
Haha, no shame for my monster PRs
2023-07-06 18715, 2023
Cdubuluz83 joined the channel
2023-07-06 18714, 2023
pprkut has quit
2023-07-06 18720, 2023
mayhem
monkey, lucifer : could one of you two please look at LB#2517 and have a look at the javascript/reactness of the code? I've commented on the general nature and calculation side of things. (see review)
keeping in mind that this isn't intended to be merged, but mostly for review.
2023-07-06 18747, 2023
monkey
Actually I'll do that now. Had a quick peek already this morning
2023-07-06 18748, 2023
mayhem
thanks, monkey !
2023-07-06 18738, 2023
mayhem
lucifer: one request on the tag data query -- can you please sort recordings by tag_count?
2023-07-06 18703, 2023
pprkut joined the channel
2023-07-06 18718, 2023
lucifer
sure
2023-07-06 18702, 2023
Cdubuluz83 has quit
2023-07-06 18716, 2023
Cdubuluz83 joined the channel
2023-07-06 18721, 2023
lucifer
mayhem: remove random ordering and order by tag_count?
2023-07-06 18715, 2023
mayhem
the random ordering is important for the selection process that your query does. but for the results, they should be ordered by tag_count. does that make sense?
2023-07-06 18718, 2023
lucifer
or first randomize results and then order by tag count
2023-07-06 18722, 2023
mayhem
that
2023-07-06 18725, 2023
lucifer
👍
2023-07-06 18704, 2023
mayhem
this project was so simple in my mind. but really, its been a bear -- there are so many things to think of. oy.
2023-07-06 18731, 2023
Cdubuluz83 has quit
2023-07-06 18752, 2023
lucifer
mayhem: check now.
2023-07-06 18705, 2023
lucifer
also you don't need to specify a condition if passing one tag now.
2023-07-06 18713, 2023
mayhem
great, thanks!
2023-07-06 18742, 2023
mayhem
all the perfectn values are 1 currently -- thats not intended, is it?
2023-07-06 18751, 2023
mayhem
*percent
2023-07-06 18723, 2023
lucifer
hmm seems like a bug somewhere
2023-07-06 18719, 2023
lucifer
will fix
2023-07-06 18727, 2023
mayhem
thx, not urgent.
2023-07-06 18728, 2023
mayhem
monkey: did export to spotify on prod break again?
ah, that would have lucifer 's fingerprints all over it. :)
2023-07-06 18718, 2023
lucifer
mayhem: labs api returning BAD GATEWAY errors it seems, cascading 500s
2023-07-06 18750, 2023
mayhem
is the original error from spotify?
2023-07-06 18741, 2023
lucifer
nope
2023-07-06 18759, 2023
lucifer
try again
2023-07-06 18736, 2023
mayhem
still barfs
2023-07-06 18728, 2023
lucifer
okay i see the correct error now.
2023-07-06 18732, 2023
lucifer
mayhem: it fails because there is a standalone recording in the playlist which are not considered when generating canonical data.
2023-07-06 18711, 2023
lucifer
a 500 is not ideal ofc.
2023-07-06 18727, 2023
mayhem
I guess it should just skip that recording and try to move on?
2023-07-06 18754, 2023
lucifer
yeah i was thinking about that but we might be relying that the list of items is ordered
2023-07-06 18710, 2023
lucifer
and there won't be gaps etc so have to review other uses of this query
2023-07-06 18701, 2023
BrainzGit
[listenbrainz-server] 14amCap1712 merged pull request #2516 (03master…apple-music-key): Lay foundations for generating and storing apple music tokens https://github.com/metabrainz/listenbrainz-server…
[bookbrainz-site] 14the-good-boy opened pull request #1000 (03administration-system…middlewareTS): feat(Admin System): Change files to .ts to increase type validation https://github.com/metabrainz/bookbrainz-site/pul…
2023-07-06 18736, 2023
zas
who deployed wikidata-bot on zappa? It seems to have an issue
Hey riksucks and lucifer: I updated the PR as we according to our chat yesterday. because i dont have the keys which are required for the generate developer token method I had stubbed it with static token which was shared with me earlier for the purpose of testing the rest of the implementation.
2023-07-06 18728, 2023
kellnerd
Congrats ShivamAwasthi, I had briefly considered to create a PR just to get number 1000 myself ;)
2023-07-06 18752, 2023
mayhem
PR sniping, wow. :)
2023-07-06 18711, 2023
lucifer
vscode_: cool, for the next part you need to send over the music user token to the backend. it needs to be stored in the backend but we dont have an appropriate column for it, i think just store it in the refresh token column.
2023-07-06 18723, 2023
lucifer
let me look into it and share more details on how'd go about it.
2023-07-06 18747, 2023
AbhinavOhri[m] uploaded an image: (293KiB) < https://libera.ems.host/_matrix/media/v3/download/matrix.org/DEtAYznTfiTXStXunupbTEsM/Screenshot%20from%202023-07-06%2023-07-29.png >
2023-07-06 18736, 2023
AbhinavOhri[m]
monkey: I added the page it looks like this. From where should I start correcting it?
2023-07-06 18754, 2023
monkey
AbhinavOhri[m]: I would say the best would be to create a draft PR on the main website so I can run it and review it with better answers that on the fly here
2023-07-06 18719, 2023
monkey
From there I can look at the css and see how best to go about it
2023-07-06 18741, 2023
monkey
lucifer: I wonder if some code disappeared in smoke somewhere. I'm getting 404s hitting /beta.listenbrainz.org/profile/music-services/musicbrainz/refresh/
