0:00 AM
piwu1 has quit
2023-07-15 19615, 2023
0:01 AM
piwu1 joined the channel
2023-07-15 19601, 2023
0:49 AM
aerozol
akshaaatt: btw, did you want the Android updates shared to MeB social channels?
2023-07-15 19645, 2023
0:50 AM
aerozol
2023-07-15 19654, 2023
0:52 AM
aerozol
“Press Release 2023-07-14 - The music industry is failing musicians”
2023-07-15 19606, 2023
0:53 AM
aerozol
🌶️
2023-07-15 19644, 2023
1:06 AM
aerozol
Anyone who cares: I’m going to start reposting stuff we put on Twitter via my personal mastodon account, see what the engagement is like (even if we never make an official account there I might just keep it up anyway)
2023-07-15 19626, 2023
1:25 AM
aerozol
Holiday news: Watched a national emergency go down here in Japan yesterday! Dog poo in the train station! Five employees, a gallon of disinfectant, and we are safe again - the offender is in newspaper, in a plastic bag, in another really big plastic bag, and safely disposed of. Great work tīmu
2023-07-15 19630, 2023
1:59 AM
aerozol
2023-07-15 19611, 2023
2:02 AM
aerozol
2023-07-15 19626, 2023
3:30 AM
Maxr1998 has quit
2023-07-15 19609, 2023
3:31 AM
Maxr1998 joined the channel
2023-07-15 19628, 2023
4:44 AM
akshaaatt
Sure aerozol! That sounds like a good idea
2023-07-15 19621, 2023
5:11 AM
aerozol
2023-07-15 19617, 2023
5:19 AM
akshaaatt
On it
2023-07-15 19649, 2023
7:25 AM
OrbitalTeapot joined the channel
2023-07-15 19614, 2023
7:40 AM
OrbitalTeapot has quit
2023-07-15 19650, 2023
7:44 AM
OrbitalTeapot joined the channel
2023-07-15 19623, 2023
7:45 AM
OrbitalTeapot has quit
2023-07-15 19633, 2023
8:11 AM
d4rkie joined the channel
2023-07-15 19650, 2023
8:13 AM
d4rk has quit
2023-07-15 19656, 2023
8:56 AM
mayhem
sorry aerozol , I've now read it and damn, that quote is spicy. who wrote that stuff? Lol.
2023-07-15 19602, 2023
8:57 AM
mayhem
Looks great to me, fire at will!
2023-07-15 19607, 2023
9:18 AM
Maxr1998_ joined the channel
2023-07-15 19605, 2023
9:19 AM
Maxr1998 has quit
2023-07-15 19615, 2023
9:36 AM
jasje
akshaaatt: merge with main pls so I can work with latest main. Some bugs im facing that i want to make sure are not caused by my code.
2023-07-15 19629, 2023
9:36 AM
jasje
if you want I can do it
2023-07-15 19619, 2023
10:06 AM
ApeKattQuest
man I wish they put in a quarter the effort japan does about dog-poo here. it's gross some places
2023-07-15 19624, 2023
10:49 AM
OrbitalTeapot joined the channel
2023-07-15 19631, 2023
10:49 AM
OrbitalTeapot has quit
2023-07-15 19610, 2023
11:04 AM
OrbitalTeapot joined the channel
2023-07-15 19608, 2023
11:06 AM
OrbitalTeapot has quit
2023-07-15 19651, 2023
11:15 AM
orbitalteapot joined the channel
2023-07-15 19609, 2023
14:48 PM
akshaaatt
Hi jasje
2023-07-15 19619, 2023
14:48 PM
akshaaatt
You had mentioned about a discussion on github
2023-07-15 19625, 2023
16:04 PM
jasje
akshaaatt: will ping you outside rn
2023-07-15 19606, 2023
16:09 PM
akshaaatt
Cool
2023-07-15 19648, 2023
17:28 PM
Maxr1998_ has quit
2023-07-15 19618, 2023
17:31 PM
jasje
akshaaatt: yo
2023-07-15 19600, 2023
17:32 PM
akshaaatt
Hi
2023-07-15 19652, 2023
17:32 PM
Maxr1998 joined the channel
2023-07-15 19640, 2023
17:34 PM
jasje
so
2023-07-15 19648, 2023
17:34 PM
jasje
about the singleton annotation
2023-07-15 19633, 2023
17:35 PM
akshaaatt
Yeah
2023-07-15 19646, 2023
17:35 PM
akshaaatt
Any reasoning you have for removing it?
2023-07-15 19656, 2023
17:35 PM
jasje
2023-07-15 19610, 2023
17:38 PM
akshaaatt
I have
2023-07-15 19630, 2023
17:38 PM
akshaaatt
Please point out the reason for the removal of
2023-07-15 19642, 2023
17:38 PM
akshaaatt
Omit of*
2023-07-15 19656, 2023
17:39 PM
jasje
So basically when we scope all of our stuff to singleton
2023-07-15 19610, 2023
17:40 PM
jasje
stuff -> dependencies
2023-07-15 19618, 2023
17:40 PM
jasje
one instance is created
2023-07-15 19628, 2023
17:40 PM
jasje
which reamins until app is destroyed
2023-07-15 19631, 2023
17:40 PM
akshaaatt
Yeah that is correct
2023-07-15 19640, 2023
17:40 PM
jasje
since we have listen submitter service
2023-07-15 19654, 2023
17:40 PM
jasje
which causes the app to never call onDestroy
2023-07-15 19618, 2023
17:41 PM
jasje
those dependencies remain forever (metaphor)
2023-07-15 19609, 2023
17:42 PM
jasje
thus memory is always occupied for those objects as long as onDestory isn't called
2023-07-15 19625, 2023
17:42 PM
jasje
even though they aren't even being used
2023-07-15 19640, 2023
17:42 PM
akshaaatt
From my understanding, singleton just prevents the application from creating more than one instance and reuses the existing resources
2023-07-15 19602, 2023
17:43 PM
akshaaatt
How is it related to the lifecycle?
2023-07-15 19615, 2023
17:43 PM
jasje
but it still retains the instance even though it isn't being used'
2023-07-15 19657, 2023
17:43 PM
jasje
lifecycle is what the Installin() part defines
2023-07-15 19625, 2023
17:44 PM
akshaaatt
Even if I were to create multiple instances, do you mean to say that even those won't be destroyed?
2023-07-15 19651, 2023
17:44 PM
jasje
2023-07-15 19620, 2023
17:45 PM
jasje
akshaaatt: if we scope them to singleton, no
2023-07-15 19628, 2023
17:45 PM
jasje
but any other should be good
2023-07-15 19605, 2023
17:46 PM
akshaaatt
I think service component should be the one to use here then?
2023-07-15 19613, 2023
17:46 PM
jasje
usually hilt recommends don't scope bindings that don't require concurrency or are not heavy to create instance of
2023-07-15 19630, 2023
17:46 PM
jasje
service component is used for brainplayer
2023-07-15 19641, 2023
17:46 PM
jasje
yellowhatpro made sure of that
2023-07-15 19647, 2023
17:46 PM
jasje
for rest
2023-07-15 19659, 2023
17:46 PM
jasje
I think no scoping should be good
2023-07-15 19603, 2023
17:47 PM
jasje
because hilt says
2023-07-15 19628, 2023
17:47 PM
jasje
the amount of extra code for scoping usually outweighs the benefits
2023-07-15 19641, 2023
17:47 PM
jasje
thus decreasing the performance
2023-07-15 19648, 2023
17:47 PM
jasje
also
2023-07-15 19609, 2023
17:48 PM
jasje
a component is only scoped if it has component and scope defined
2023-07-15 19639, 2023
17:48 PM
jasje
if we just do Installin(singletoncomp){ // and not annotate @singleton here }
2023-07-15 19653, 2023
17:48 PM
jasje
then the dependency wont be scoped
2023-07-15 19601, 2023
17:49 PM
jasje
it'll be factory
2023-07-15 19610, 2023
17:49 PM
jasje
i.e., new instance is created
2023-07-15 19613, 2023
17:49 PM
jasje
everytime
2023-07-15 19649, 2023
17:49 PM
jasje
2023-07-15 19632, 2023
17:50 PM
jasje
2023-07-15 19612, 2023
17:51 PM
akshaaatt
I think the services we create should be scoped
2023-07-15 19631, 2023
17:51 PM
jasje
2023-07-15 19601, 2023
17:53 PM
jasje
this is very interesting to me and if you'd give some time figuring this stuff out i'd love to improve the code
2023-07-15 19628, 2023
17:53 PM
akshaaatt
2023-07-15 19631, 2023
17:53 PM
jasje
bec my interpretations are half baked as well
2023-07-15 19624, 2023
17:55 PM
akshaaatt
Don't get too much into this rn. Focus on the gsoc project first
2023-07-15 19645, 2023
17:55 PM
akshaaatt
I feel we would end up falling off track with the project if you don't focus
2023-07-15 19657, 2023
17:55 PM
akshaaatt
These changes can be done in a day or two later
2023-07-15 19608, 2023
17:56 PM
akshaaatt
But yeah, I do think it'll be good
2023-07-15 19612, 2023
17:57 PM
jasje
akshaaatt: dw
2023-07-15 19628, 2023
17:57 PM
akshaaatt
I don't think services should be allowed to have multiple instances, and the way I see it is scoping them currently or resuing somehow.
2023-07-15 19659, 2023
17:57 PM
jasje
alright
2023-07-15 19603, 2023
17:58 PM
jasje
first of all
2023-07-15 19628, 2023
17:58 PM
jasje
lets call the repositories something else
2023-07-15 19658, 2023
17:58 PM
jasje
Im getting confused with the android services again and again xD
2023-07-15 19606, 2023
17:59 PM
jasje
so
2023-07-15 19608, 2023
17:59 PM
akshaaatt
Like?
2023-07-15 19633, 2023
17:59 PM
jasje
in your above sentence, you mean the retrofit instances right?
2023-07-15 19648, 2023
17:59 PM
akshaaatt
Yes
2023-07-15 19652, 2023
17:59 PM
jasje
yes
2023-07-15 19610, 2023
18:00 PM
jasje
so we need to scope retrofit instances to something else
2023-07-15 19620, 2023
18:00 PM
jasje
not singleton agree?
2023-07-15 19642, 2023
18:00 PM
akshaaatt
I don't agree yet. Need to read more on this
2023-07-15 19655, 2023
18:00 PM
jasje
alright
2023-07-15 19626, 2023
18:01 PM
akshaaatt
But I know for sure that these should only be created once throughout the app
2023-07-15 19606, 2023
18:02 PM
jasje
i mean we can
2023-07-15 19626, 2023
18:02 PM
jasje
because retrofit is heavy'
2023-07-15 19647, 2023
18:02 PM
jasje
but can we scope it to activity?
2023-07-15 19604, 2023
18:03 PM
jasje
because our app is single activity arch
2023-07-15 19609, 2023
18:03 PM
akshaaatt
No. Multiple activities can use one service/repo
2023-07-15 19610, 2023
18:03 PM
jasje
architecture
2023-07-15 19626, 2023
18:03 PM
jasje
our app has only one activity
2023-07-15 19631, 2023
18:03 PM
akshaaatt
jasje we need to do something about it though. It's not perfect yet
2023-07-15 19640, 2023
18:03 PM
jasje
yess
2023-07-15 19644, 2023
18:03 PM
akshaaatt
No. About, etc are separate activites for now
2023-07-15 19608, 2023
18:04 PM
akshaaatt
Compose is still new and we need to see what is the best practice for all this
2023-07-15 19639, 2023
18:04 PM
jasje
akshaaatt: our main activity isn't destroyed when we open about tho
2023-07-15 19643, 2023
18:04 PM
jasje
so no problem there
2023-07-15 19645, 2023
18:04 PM
akshaaatt
I hate that a composable cannot manage it's lifecycle yet
2023-07-15 19600, 2023
18:05 PM
jasje
akshaaatt: true (fragments are noice)
2023-07-15 19609, 2023
18:05 PM
akshaaatt
yeah
2023-07-15 19622, 2023
18:05 PM
jasje
our main activity only gets destroyed when we close our app
2023-07-15 19629, 2023
18:05 PM
jasje
thats what we want
2023-07-15 19651, 2023
18:05 PM
jasje
except for the service (retrofit instance) that our submitter uses
2023-07-15 19659, 2023
18:05 PM
jasje
that should be singleton
2023-07-15 19605, 2023
18:06 PM
akshaaatt
Google should be working on getting compose right there. Because iOS has swiftui (jc counterpart) which does all of this perfectly
2023-07-15 19628, 2023
18:06 PM
akshaaatt
Not just the submitter, but other stuffs are also a singleton
2023-07-15 19648, 2023
18:06 PM
jasje
yim service doesn't need to be singleton
2023-07-15 19607, 2023
18:07 PM
akshaaatt
Okay. That sounds fair
2023-07-15 19614, 2023
18:07 PM
akshaaatt
But social and login stuff does
2023-07-15 19649, 2023
18:07 PM
jasje
social service also doesn't need to be singleton
2023-07-15 19603, 2023
18:08 PM
jasje
only listensService is required to be singleton
2023-07-15 19611, 2023
18:08 PM
akshaaatt
for now it doesn't. But soon it will
2023-07-15 19622, 2023
18:08 PM
jasje
how?
2023-07-15 19632, 2023
18:08 PM
jasje
any future plans i don know hehe?
2023-07-15 19643, 2023
18:08 PM
akshaaatt
Let me just look at how service scoping and singletons are different
2023-07-15 19610, 2023
18:09 PM
jasje
refer the screenshots above
2023-07-15 19616, 2023
18:09 PM
jasje
for quick snippets
2023-07-15 19601, 2023
18:11 PM
akshaaatt
If the listens submitter were not there, singletons would have been fine for the app
2023-07-15 19620, 2023
18:11 PM
jasje
akshaaatt: yes
2023-07-15 19622, 2023
18:11 PM
akshaaatt
But I get your point as to how resources are left even though the app is closed
2023-07-15 19607, 2023
18:12 PM
akshaaatt
I mean, if our app is single activity, we can scope all these services to the activity then
2023-07-15 19613, 2023
18:12 PM
jasje
yes
2023-07-15 19654, 2023
18:12 PM
akshaaatt
But I am certain this is not how things are going to be for long. Single activity app in itself is bad currently.
2023-07-15 19644, 2023
18:13 PM
jasje
akshaaatt: why?
