2:11 AM
milkii has quit
2023-07-17 19819, 2023
2:13 AM
milkii joined the channel
2023-07-17 19840, 2023
3:29 AM
aerozol
2023-07-17 19807, 2023
3:30 AM
aerozol
But they are not signed off, monkey and I are still brainstorming them. Feedback/comments on the figma very welcome!
2023-07-17 19845, 2023
3:50 AM
milkii has quit
2023-07-17 19812, 2023
3:52 AM
milkii joined the channel
2023-07-17 19847, 2023
6:45 AM
d4rkie has quit
2023-07-17 19842, 2023
6:47 AM
d4rkie joined the channel
2023-07-17 19817, 2023
9:42 AM
mayhem
moooin! everyone!
2023-07-17 19844, 2023
9:42 AM
mayhem
today is MusicBrainz' birthday -- at least what is says on the birth-certificate. whoo hoo happy birthday MusicBrainz!
2023-07-17 19834, 2023
9:44 AM
mayhem
gah, taylor swift barfed all over my fresh releases. ick.
2023-07-17 19840, 2023
9:55 AM
texke has quit
2023-07-17 19833, 2023
10:03 AM
texke joined the channel
2023-07-17 19803, 2023
10:50 AM
lucifer
2023-07-17 19824, 2023
10:58 AM
mayhem
I will get to reviews, this afternoon, promise
2023-07-17 19820, 2023
11:43 AM
texke has quit
2023-07-17 19810, 2023
11:55 AM
texke joined the channel
2023-07-17 19803, 2023
12:19 PM
mayhem
lucifer: done. what other PRs should I look at ?
2023-07-17 19822, 2023
12:32 PM
lucifer
mayhem: meb react PR
2023-07-17 19845, 2023
12:33 PM
mayhem
ah, still marked as draft, so it was not on my radar. will look now.
2023-07-17 19824, 2023
13:38 PM
mayhem
done.
2023-07-17 19802, 2023
13:39 PM
mayhem
lucifer: I see that periodic jams were not generated today -- but they should've no? did the cron container get updated?
2023-07-17 19812, 2023
13:41 PM
lucifer
mayhem: will take a look
2023-07-17 19824, 2023
13:44 PM
mayhem
thanks. now the other task that is blocking me from pushing lb-radio for community feedback period is that the tag query is on test and if someone updates test then lb-radio will break. how much work would a PR for that feature be?
2023-07-17 19821, 2023
13:50 PM
lucifer
mayhem: can do that by tomorrow. just need to make the tags dataset refreshable.
2023-07-17 19837, 2023
13:50 PM
BrainzGit
2023-07-17 19854, 2023
13:50 PM
mayhem
great, thanks!
2023-07-17 19802, 2023
13:51 PM
BrainzGit
2023-07-17 19844, 2023
13:51 PM
BrainzGit
2023-07-17 19820, 2023
14:42 PM
BrainzGit
2023-07-17 19824, 2023
14:46 PM
lucifer
vscode_: hi! riksucks is currently unwell so he is unable to review your PR currently. I took a quick look and its looks mostly fine to me. I would suggest working on adding some tests for the AppleMusicPlayer component. you can look at the existing players for ideas on what tests need to be added.
2023-07-17 19822, 2023
14:47 PM
lucifer
also, I will put up the PR for testing on ListenBrainz Beta/Test so that others can take a look at how it works and suggest improvements to the workflow.
2023-07-17 19851, 2023
14:58 PM
mayhem
Happy 23rd birthday MusicBrainz!
2023-07-17 19859, 2023
14:58 PM
mayhem
2023-07-17 19817, 2023
14:59 PM
lucifer
🎉🎉
2023-07-17 19828, 2023
14:59 PM
mayhem
aerozol: not sure if this fluff piece is working attempting to make noise about, but I'll post it to LI.
2023-07-17 19836, 2023
15:00 PM
lucifer
mayhem: add some corp speak to it and it'll be a linkedin hit
2023-07-17 19848, 2023
15:00 PM
mayhem
urgh.
2023-07-17 19802, 2023
15:02 PM
mayhem
Have you been unaware of the advent of the less-than-institutional name MusicBrainz? Gain many synergy points for your next ROI phase by reading this amazing article that will drastically improve many of your KPIs!
https://blog.metabrainz.org/2023/07/17/happy-23rd…
2023-07-17 19807, 2023
15:02 PM
mayhem
or more?
2023-07-17 19815, 2023
15:02 PM
lucifer
2023-07-17 19821, 2023
15:02 PM
lucifer
chatgpt suggests ^
2023-07-17 19854, 2023
15:02 PM
mayhem
🤣
2023-07-17 19849, 2023
15:03 PM
lucifer
mayhem: with your version, i think some consultancies might reach out asking for a quote 🤣
2023-07-17 19839, 2023
15:04 PM
yvanzo
Happy Birthday! 🥳
2023-07-17 19836, 2023
15:15 PM
lucifer
2023-07-17 19801, 2023
15:16 PM
akshaaatt
I could see mayhem registering the name
2023-07-17 19805, 2023
15:16 PM
lucifer
if something doesn't work for you, lmk and i'll fix it in the setup. if the page works fine, i'll merge and deploy.
2023-07-17 19819, 2023
15:16 PM
mayhem
akshaaatt: that was a fun party too. :)
2023-07-17 19829, 2023
15:16 PM
akshaaatt
⚡️⚡️
2023-07-17 19858, 2023
15:16 PM
mayhem
lucifer: we should probably loop aerozol in before releasing the patron page -- he has some ideas on this front.
2023-07-17 19828, 2023
15:17 PM
lucifer
mayhem: yes makes sense, by merge and deploy i meant the just adding react support to MeB PR.
2023-07-17 19816, 2023
15:18 PM
jasje
any function to put in a key:value pair into jsonb in postgres?
2023-07-17 19817, 2023
15:18 PM
mayhem
ah got it. thanks. just trying to not have to deal with the wrath of aerozol . :)
2023-07-17 19825, 2023
15:18 PM
jasje
jsonb dict**
2023-07-17 19840, 2023
15:18 PM
lucifer
jasje: json.dumps({key: value})
2023-07-17 19815, 2023
15:19 PM
lucifer
or inside the SQL query, jsonb_build_object(:key, :value)
2023-07-17 19834, 2023
15:19 PM
jasje
yea i need the one in sql query
2023-07-17 19856, 2023
15:19 PM
jasje
i already have a key:value pair inside
2023-07-17 19803, 2023
15:20 PM
jasje
i don't want that to be lost
2023-07-17 19817, 2023
15:20 PM
lucifer
can you share the code/sql query, hard to tell without that
2023-07-17 19830, 2023
15:20 PM
jasje
well since its come to that
2023-07-17 19850, 2023
15:20 PM
jasje
i was trying to add similar users into recommendation.similar_user
2023-07-17 19805, 2023
15:21 PM
jasje
it has a column similar_users
2023-07-17 19814, 2023
15:21 PM
jasje
which is of type jsonb
2023-07-17 19820, 2023
15:21 PM
jasje
and has data as follows
2023-07-17 19837, 2023
15:21 PM
jasje
{1:[0.75,0.01]}
2023-07-17 19852, 2023
15:21 PM
jasje
{user_id:[local_sim, global_sim]}
2023-07-17 19857, 2023
15:21 PM
jasje
is that right?
2023-07-17 19819, 2023
15:22 PM
lucifer
let me check the code
2023-07-17 19854, 2023
15:22 PM
lucifer
yup that's right
2023-07-17 19809, 2023
15:23 PM
jasje
2023-07-17 19821, 2023
15:23 PM
jasje
so to add another similar user
2023-07-17 19825, 2023
15:23 PM
jasje
i just do
2023-07-17 19852, 2023
15:23 PM
jasje
{1:[0.75, 0.01], 2:[local, global]}
2023-07-17 19853, 2023
15:23 PM
lucifer
you mean you want to add a similar user for tests?
2023-07-17 19859, 2023
15:23 PM
jasje
yessir
2023-07-17 19812, 2023
15:24 PM
lucifer
yeah modify that `data = ` line
2023-07-17 19838, 2023
15:24 PM
jasje
i want to use ON CONFLICT
2023-07-17 19858, 2023
15:24 PM
lucifer
no need for tests
2023-07-17 19835, 2023
15:25 PM
jasje
okeys
2023-07-17 19849, 2023
15:25 PM
jasje
so this function
2023-07-17 19820, 2023
15:26 PM
jasje
ill just save data globally and append to it when called?
2023-07-17 19840, 2023
15:26 PM
jasje
like self.data
2023-07-17 19812, 2023
15:27 PM
jasje
because without memory this function won't be resuable
2023-07-17 19836, 2023
15:28 PM
jasje
2023-07-17 19859, 2023
15:28 PM
jasje
lucifer^
2023-07-17 19815, 2023
15:34 PM
lucifer
jasje: i am not sure what you are trying to do. can you put an updated test on github that i can look at?
2023-07-17 19821, 2023
15:34 PM
mayhem
3 albums discovered and loved because of lb-radio. #happy
2023-07-17 19849, 2023
15:34 PM
lucifer
just put a test that shows what you want to test, i'll help in figuring how to implement the necessary/missing details.
2023-07-17 19807, 2023
15:35 PM
jasje
lucifer: alright ill push it
2023-07-17 19828, 2023
15:35 PM
jasje
give me some mins
2023-07-17 19854, 2023
15:35 PM
lucifer
sure
2023-07-17 19800, 2023
15:44 PM
mayhem
2023-07-17 19819, 2023
15:44 PM
lucifer
mayhem: the canonical release?
2023-07-17 19836, 2023
15:44 PM
mayhem
yyes, sure.
2023-07-17 19802, 2023
15:45 PM
mayhem
yea, any would be fine, but canonical would be easiest, I suppose.
2023-07-17 19851, 2023
15:45 PM
lucifer
yeah i mean you need to find a way to pick from one of the all available, i guess we'd end with similar criteria and at canonical anyways.
2023-07-17 19801, 2023
15:46 PM
mayhem
yep
2023-07-17 19830, 2023
16:08 PM
jasje
lucifer: code pushed
2023-07-17 19826, 2023
16:12 PM
lucifer
2023-07-17 19840, 2023
16:12 PM
lucifer
jasje: these 3 lines should go in the start of your test function
2023-07-17 19811, 2023
16:13 PM
jasje
Alright Ill shift them
2023-07-17 19823, 2023
16:14 PM
lucifer
as for the method i see what you are trying to do now.
2023-07-17 19858, 2023
16:14 PM
lucifer
SET similar_users = EXCLUDED.similar_users || {json.dumps(self.similar_user_data)}
2023-07-17 19803, 2023
16:15 PM
lucifer
and it should work
2023-07-17 19828, 2023
16:18 PM
jasje
trying
2023-07-17 19832, 2023
16:19 PM
lucifer
there are other issues with that method but let's come to fixing those later
2023-07-17 19816, 2023
16:45 PM
jasje
ambigious column user_id
2023-07-17 19850, 2023
16:59 PM
jasje
welp excluded to the rescue
2023-07-17 19809, 2023
17:00 PM
reosarevok
<BANG>
2023-07-17 19822, 2023
17:00 PM
mayhem
Happy Birthday to MusicBrainz!
2023-07-17 19839, 2023
17:00 PM
reosarevok
Hi and welcome to Birthday Monday
2023-07-17 19814, 2023
17:01 PM
ShivamAwasthi
🎊
2023-07-17 19814, 2023
17:01 PM
reosarevok
I have two mailed-in reviews this time:
2023-07-17 19823, 2023
17:01 PM
reosarevok
monkey says:
2023-07-17 19824, 2023
17:01 PM
reosarevok
'''
2023-07-17 19829, 2023
17:01 PM
reosarevok
Hello everyone,
2023-07-17 19837, 2023
17:01 PM
reosarevok
Last Tuesday a very close friend of mine passed away suddenly.
2023-07-17 19840, 2023
17:01 PM
reosarevok
I’ve been grieving and dealing with the surprising amount of logistics that comes with death.
2023-07-17 19843, 2023
17:01 PM
reosarevok
As a consequence I only really worked on Monday and have been 98% AFK since.
2023-07-17 19844, 2023
17:01 PM
reosarevok
That being said, I did review GSOC projects and filled in the midterm evaluations.
2023-07-17 19846, 2023
17:01 PM
reosarevok
That’s it for me.
2023-07-17 19847, 2023
17:01 PM
reosarevok
'''
2023-07-17 19850, 2023
17:01 PM
reosarevok
hugs, monkey
2023-07-17 19807, 2023
17:02 PM
mayhem
that death has affected a lot of people here in BCN
2023-07-17 19855, 2023
17:02 PM
ShivamAwasthi
really sorry to hear that
2023-07-17 19819, 2023
17:03 PM
reosarevok
The other mail is by VishalFTW (is that vscode_?)
2023-07-17 19824, 2023
17:03 PM
mayhem
(I personally didn't really know this person, but most of my friends did)
2023-07-17 19837, 2023
17:03 PM
reosarevok
Who says:
2023-07-17 19839, 2023
17:03 PM
reosarevok
'''
2023-07-17 19844, 2023
17:03 PM
reosarevok
Hi, hope you are doing well!
2023-07-17 19848, 2023
17:03 PM
reosarevok
Due to some unforeseen circumstances I have to share my weekly details through, Please let me know if there are any issues.
2023-07-17 19850, 2023
17:03 PM
lucifer
reosarevok: its pixelpenguin
2023-07-17 19850, 2023
17:03 PM
reosarevok
2023-07-17 19853, 2023
17:03 PM
reosarevok
2023-07-17 19859, 2023
17:03 PM
reosarevok
Kind regards,
2023-07-17 19804, 2023
17:04 PM
reosarevok
'''
2023-07-17 19806, 2023
17:04 PM
reosarevok
Oh!
2023-07-17 19810, 2023
17:04 PM
reosarevok
Ok, thanks lucifer
2023-07-17 19828, 2023
17:04 PM
reosarevok
That's it for mailed reviews
2023-07-17 19834, 2023
17:04 PM
reosarevok
mayhem: wanna start us?
2023-07-17 19841, 2023
17:04 PM
reosarevok
Other people today: reosarevok, bitmap, zas, yvanzo, lucifer, akshaaatt, atj, ApeKattQuest, riksucks, kellnerd, Pratha-Fish, ShivamAwasthi, vscode, arsh, jasje
2023-07-17 19843, 2023
17:04 PM
mayhem
sure.
2023-07-17 19848, 2023
17:04 PM
yvanzo
hugs to monkey
2023-07-17 19806, 2023
17:05 PM
mayhem
I posted a blog post explaining where the MusicBrainz name came from today, since its MB's birthday.
2023-07-17 19835, 2023
17:05 PM
lucifer
monkey: oh that's sad to hear :(. 🫂
2023-07-17 19836, 2023
17:05 PM
mayhem
last week was kinda slow -- lots of visitors in town and generally hot summer weather in BCN made it difficult to concentrate most of the week.
2023-07-17 19813, 2023
17:06 PM
mayhem
but then I worked on lb-radio a bit, reviewed some PRs, accounting/emails and the usual background sort of stuff. hoping to really get back into things this week.
2023-07-17 19818, 2023
17:06 PM
mayhem
yvanzo: go!
