#metabrainz

/

      • yvanzo
        compile logs have only two warnings and it's about web-tests.
      • 2023-07-24 20536, 2023

      • bitmap
        I assume your root/static/build/common-chunks.js contains a bunch of string evals which run the scripts?
      • 2023-07-24 20551, 2023

      • yvanzo
        hmm... which string should I grep for?
      • 2023-07-24 20512, 2023

      • yvanzo
        (I can upload it but the file is 14M)
      • 2023-07-24 20508, 2023

      • bitmap
        I guess just 'eval' or 'sourceURL'
      • 2023-07-24 20552, 2023

      • bitmap
        for some source map implementations it will convert all the js files to strings and execute them with eval (I don't remember why)
      • 2023-07-24 20547, 2023

      • yvanzo
        it doesn't seem so, but I will upload it to wolf
      • 2023-07-24 20559, 2023

      • bitmap
        but, I'm not sure why ours would differ unless you are setting WEBPACK_DEVTOOL environment variable
      • 2023-07-24 20552, 2023

      • jasje
        LB down?
      • 2023-07-24 20516, 2023

      • mayhem
        nope
      • 2023-07-24 20527, 2023

      • yvanzo
        bitmap: I copied it under ~yvanzo/csp-errors on wolf
      • 2023-07-24 20555, 2023

      • yvanzo
        No, WEBPACK_DEVTOOL isn’t set either.
      • 2023-07-24 20537, 2023

      • yvanzo
      • 2023-07-24 20549, 2023

      • yvanzo
        NODE_ENV is set to test
      • 2023-07-24 20501, 2023

      • bitmap
        hmm
      • 2023-07-24 20503, 2023

      • yvanzo
        MUSICBRAINZ_CATALYST_DEBUG=1
      • 2023-07-24 20511, 2023

      • yvanzo
        MUSICBRAINZ_DEVELOPMENT_SERVER=1
      • 2023-07-24 20532, 2023

      • yvanzo
        MUSICBRAINZ_USE_PROXY=1
      • 2023-07-24 20500, 2023

      • bitmap
        ok, no source map evals, but I see `var global = new Function("return this")();` in your setInputValueForReact file, which would trigger the eval error
      • 2023-07-24 20504, 2023

      • bitmap
        I believe this is related to babel-plugin-istanbul
      • 2023-07-24 20536, 2023

      • bitmap
        so NODE_ENV=test will include that
      • 2023-07-24 20553, 2023

      • bitmap
        actually, we ran into this before, heh - https://github.com/metabrainz/musicbrainz-server/…
      • 2023-07-24 20517, 2023

      • yvanzo
        I tried setting NODE_ENV=production but it didn’t have any effect.
      • 2023-07-24 20515, 2023

      • arsh
        Hi mayhem: I was able to create a PR between the tags on my fork
      • 2023-07-24 20516, 2023

      • arsh
      • 2023-07-24 20523, 2023

      • Pratha-Fish
        hey yvanzo, sorry for bringing it up again, but here's what I've done so far:
      • 2023-07-24 20523, 2023

      • Pratha-Fish
        1. Re-deployed my musicbrainz-docker installation from scratch by following: https://github.com/metabrainz/musicbrainz-docker#…
      • 2023-07-24 20523, 2023

      • Pratha-Fish
        2. I also went ahead and published the db on 0.0.0.0:5432 by using `admin/configure add publishing-db-port` before `sudo docker-compose up -d`
      • 2023-07-24 20524, 2023

      • Pratha-Fish
        3. I created the test db by running `script/create_test_db.sh` on the `musicbrainz` container
      • 2023-07-24 20525, 2023

      • Pratha-Fish
        4. I updated the DBDefs.pm file in the musicbrainz container as follows: https://www.irccloud.com/pastebin/Pft75gO5/
      • 2023-07-24 20526, 2023

      • Pratha-Fish
        Basically, I just:
      • 2023-07-24 20527, 2023

      • Pratha-Fish
        set the host and port for the TEST db
      • 2023-07-24 20527, 2023

      • Pratha-Fish
        set `sub DB_STAGING_TESTING_FEATURES` to 1
      • 2023-07-24 20528, 2023

      • Pratha-Fish
        and set `sub USE_SET_DATABASE_HEADER`to 1.
      • 2023-07-24 20530, 2023

      • Pratha-Fish
        All the rest is the same
      • 2023-07-24 20530, 2023

      • Pratha-Fish
        4. I restarted musicbrainz-docker with `sudo docker-compose restart` (in the locally cloned repo, of course)
      • 2023-07-24 20531, 2023

      • Pratha-Fish
        =====
      • 2023-07-24 20532, 2023

      • Pratha-Fish
        5. Now, I manually insert a new user into the TEST database, and try to login with that user. With mechanize, as well as with the browser interface.
      • 2023-07-24 20533, 2023

      • Pratha-Fish
        Both of the methods are throwing some errors that I haven't been able to figure out
      • 2023-07-24 20516, 2023

      • Pratha-Fish
        Here's a copy of the error message from mechanize:
      • 2023-07-24 20523, 2023

      • Pratha-Fish
      • 2023-07-24 20521, 2023

      • mayhem
        arsh: ok, let me take a look
      • 2023-07-24 20555, 2023

      • yvanzo
        Pratha-Fish: I will look into it after the meeting. Please use the Post a text snippet feature or gist for long text.
      • 2023-07-24 20518, 2023

      • Pratha-Fish
        yvanzo: thankyou, noted :)
      • 2023-07-24 20559, 2023

      • Pratha-Fish
        bitmap: Maybe could you also look into the above issue to see if I missed any step that we had used earlier to setup our testing suite?
      • 2023-07-24 20512, 2023

      • Pratha-Fish
        Whatever time suits you of course
      • 2023-07-24 20522, 2023

      • yvanzo
        bitmap: Thanks, at least I can test the register page now by temporarily patching Server.
      • 2023-07-24 20529, 2023

      • reosarevok
        <BANG>
      • 2023-07-24 20558, 2023

      • reosarevok
        Hi everyone! It's Monday again and we have gathered to regale each others with tales of our prowess
      • 2023-07-24 20521, 2023

      • mayhem
        rawr!
      • 2023-07-24 20514, 2023

      • reosarevok
        I have no mailed reviews today, it seems
      • 2023-07-24 20528, 2023

      • reosarevok
        Is everyone's holiday over?
      • 2023-07-24 20532, 2023

      • reosarevok
        I guess we'll find out :)
      • 2023-07-24 20551, 2023

      • reosarevok
        On my list today: reosarevok, bitmap, zas, mayhem, yvanzo, monkey, lucifer, akshaaatt, atj, aerozol, ApeKattQuest, riksucks, kellnerd, Pratha-Fish, ShivamAwasthi, vscode, pixelpenguin, arsh, jasje
      • 2023-07-24 20556, 2023

      • reosarevok
        mayhem: wanna start?
      • 2023-07-24 20512, 2023

      • Pratha-Fish hops in
      • 2023-07-24 20528, 2023

      • ApeKattQuest
        🐟
      • 2023-07-24 20537, 2023

      • Pratha-Fish 🐟
      • 2023-07-24 20550, 2023

      • mayhem
        sorry
      • 2023-07-24 20503, 2023

      • mayhem
        last week I focused on lb-radio, which is now available for testing here:
      • 2023-07-24 20515, 2023

      • mayhem
      • 2023-07-24 20532, 2023

      • mayhem
        I would very much love it if people could give it a try and tell me what you think of the generated playlists.
      • 2023-07-24 20558, 2023

      • mayhem
        I also worked on PR reviews, lb content resolver, and moving recommendations along.
      • 2023-07-24 20509, 2023

      • mayhem
        which we released today -- thanks for monkey and lucifer for all the help!
      • 2023-07-24 20518, 2023

      • mayhem
      • 2023-07-24 20522, 2023

      • mayhem
        looking perty!
      • 2023-07-24 20528, 2023

      • monkey
        and aerozol for the designs !
      • 2023-07-24 20538, 2023

      • mayhem
        yes, sorry, thanks!
      • 2023-07-24 20551, 2023

      • mayhem
        we immediately found a few minor bugs that will be fixed in the coming days.
      • 2023-07-24 20519, 2023

      • mayhem
        finally her. believe it or not, this is what I set out to do 23 years ago, but realized that MusicBrainz needed to exist before I could do this.
      • 2023-07-24 20533, 2023

      • mayhem
        So 20 years later, I could finally start working on that. and today we delivered.
      • 2023-07-24 20549, 2023

      • mayhem
        loong road was long, but I'm very happy with what we've created. and loads more to come!
      • 2023-07-24 20551, 2023

      • mayhem
        monkey: go!
      • 2023-07-24 20555, 2023

      • monkey
        Hi
      • 2023-07-24 20517, 2023

      • monkey
        Last week I continued reviewing and moving the GSOC projects along
      • 2023-07-24 20541, 2023

      • monkey
        Also finished some long-opened PRs for BookBrainz and deployed to beta
      • 2023-07-24 20552, 2023

      • monkey
        And more PR reviews
      • 2023-07-24 20500, 2023

      • monkey
        That's me in a nutshell (let me out!)
      • 2023-07-24 20504, 2023

      • monkey
        reosarevok: go
      • 2023-07-24 20510, 2023

      • reosarevok
        Hi!
      • 2023-07-24 20546, 2023

      • reosarevok
        I mostly worked on style issues last week, since I felt I hadn't looked at them enough recently
      • 2023-07-24 20527, 2023

      • reosarevok
        Other than that, we had a couple long-ish meetings with the MBS team and we hopefully figured out needed improvements for the DB schema docs
      • 2023-07-24 20505, 2023

      • reosarevok
        Today I got a lot of PR reviews by yvanzo so I've been dealing with that and will probably do more of that after the meeting and tomorrow :)
      • 2023-07-24 20547, 2023

      • reosarevok
        ApeKattQuest: what about you?
      • 2023-07-24 20549, 2023

      • ApeKattQuest
        Arararara~! hi!
      • 2023-07-24 20555, 2023

      • ApeKattQuest
        Doing lots of AFK stuff on vacation. seems the whole of europe is burning up but here we are drowning in water (it's better than dying of heatstroke though.)
      • 2023-07-24 20515, 2023

      • ApeKattQuest
        Tried adding some stuff and suggestions to the comparison table doc aerozol made (ORG-52)
      • 2023-07-24 20515, 2023

      • ApeKattQuest
        that's it for me, i'll be afk and on again with instruments this week too♋
      • 2023-07-24 20516, 2023

      • BrainzBot
        ORG-52: Feature comparison table https://tickets.metabrainz.org/browse/ORG-52
      • 2023-07-24 20523, 2023

      • ApeKattQuest
        fin, go Pratha-Fish 🐟
      • 2023-07-24 20529, 2023

      • Pratha-Fish
        Hi all :)
      • 2023-07-24 20538, 2023

      • Pratha-Fish
        Last week was great!
      • 2023-07-24 20539, 2023

      • reosarevok
        Left on my list for today: bitmap, zas, yvanzo, lucifer, akshaaatt, atj, aerozol, riksucks, kellnerd, ShivamAwasthi, vscode, pixelpenguin, arsh, jasje
      • 2023-07-24 20543, 2023

      • Pratha-Fish
        Made some progress on a new feature (edit existing areas on MusicBrainz) for the MusicBrainz bot
      • 2023-07-24 20550, 2023

      • Pratha-Fish
        Started exploring and implementing new scripts to fetch areas from wikidata 👀
      • 2023-07-24 20508, 2023

      • Pratha-Fish
        Broke my testing setup YET AGAIN and spent wayy too much time fixing it 😑 (making progress thanks to yvanzo
      • 2023-07-24 20508, 2023

      • Pratha-Fish
        :))
      • 2023-07-24 20538, 2023

      • Pratha-Fish
        interestingly enough, I'm also onto some unexpected developer relations work. I'll be conducting two sessions at one of the best universities in India where I'll be guiding folks on how to make their first contributions in open source!
      • 2023-07-24 20546, 2023

      • Pratha-Fish
        (using the Musicbrainz codebase ofc ;))
      • 2023-07-24 20558, 2023

      • Pratha-Fish
        Finding some ridiculolusly easy bugs to solve live rn
      • 2023-07-24 20524, 2023

      • jasje
        you can get those in lb android
      • 2023-07-24 20526, 2023

      • ApeKattQuest
        :D
      • 2023-07-24 20533, 2023

      • Pratha-Fish
        Also, I went to the hills and almost died in a car crash, missing my last weeks meet 💀
      • 2023-07-24 20539, 2023

      • Pratha-Fish
        That's it for me :D
      • 2023-07-24 20539, 2023

      • ApeKattQuest
        oh shit
      • 2023-07-24 20545, 2023

      • Pratha-Fish
        Fin 🐟
      • 2023-07-24 20547, 2023

      • jasje
        ez survive
      • 2023-07-24 20553, 2023

      • ApeKattQuest
        jøssa
      • 2023-07-24 20554, 2023

      • Pratha-Fish
        ApeKattQuest: oh shit moment indeed
      • 2023-07-24 20559, 2023

      • Pratha-Fish
        jasje next?
      • 2023-07-24 20512, 2023

      • jasje
        hi everyone
      • 2023-07-24 20539, 2023

      • jasje
        last week i got my similar listens pr merrged
      • 2023-07-24 20514, 2023

      • jasje
        fixed listen submitter little bit and saved listens ti submit later
      • 2023-07-24 20538, 2023

      • jasje
        shrinked the code for submitter as well
      • 2023-07-24 20557, 2023

      • jasje
        continued with my gsoc project
      • 2023-07-24 20515, 2023

      • jasje
        I’ve been eyeing on making some changes to the designs as well
      • 2023-07-24 20533, 2023

      • reosarevok
        Honey, I shrunk the code for the submitter
      • 2023-07-24 20537, 2023

      • reosarevok
        (?)
      • 2023-07-24 20539, 2023

      • ApeKattQuest
        lmao
      • 2023-07-24 20546, 2023

      • ShivamAwasthi
        🤣
      • 2023-07-24 20555, 2023

      • jasje
      • 2023-07-24 20539, 2023

      • jasje
        reosarevok: well it was duplicated so I just created a component thats all
      • 2023-07-24 20545, 2023

      • jasje
        its works the same tho
      • 2023-07-24 20547, 2023

      • Pratha-Fish
        good one 😆
      • 2023-07-24 20555, 2023

      • reosarevok
        Left on my list for today: bitmap, zas, yvanzo, lucifer, akshaaatt, atj, aerozol, riksucks, kellnerd, ShivamAwasthi, vscode, pixelpenguin, arsh
      • 2023-07-24 20514, 2023

      • jasje
        bitmap?
      • 2023-07-24 20518, 2023

      • bitmap
        hey
      • 2023-07-24 20543, 2023

      • bitmap
        last week I finished deploying new postgres (standby with streaming replication from floyd), pgbouncer, and haproxy containers on jimmy and peformed some benchmarks
      • 2023-07-24 20500, 2023

      • bitmap
        current changes are in the 'ha' and 'ha-pg' branches for docker-postgres-cluster and docker-server-configs respectively
      • 2023-07-24 20530, 2023

      • bitmap
        performance appeared to be very good and within expectations, but I understand some further optimizations are needed for zfs
      • 2023-07-24 20528, 2023

      • bitmap
        the main architectural change is that pgbouncer will point to haproxy instead of postgres directly, and haproxy will detect which pg node is the primary. it should simplify switchovers a lot and reduce the amount of downtime needed
      • 2023-07-24 20511, 2023

      • bitmap
        otherwise I mainly just reviewed the database schema doc/diagram changes from yvanzo that reosarevok mentioned
      • 2023-07-24 20516, 2023

      • bitmap
        fin. go yvanzo
      • 2023-07-24 20545, 2023

      • yvanzo
        Hi!
      • 2023-07-24 20556, 2023

      • yvanzo
        And Happy International Self-Care Day.
      • 2023-07-24 20521, 2023

      • yvanzo
        Two MB dev meetings (reosarevok and bitmap mentioned) helped with finally updating the MB PostgreSQL database docs to schema 28 (2023 Q2).
      • 2023-07-24 20547, 2023

      • yvanzo
        There still are a few undocumented areas, but it’s much more complete and consistent now.
      • 2023-07-24 20504, 2023

      • yvanzo
        Implemented CORS support for LB to use wikipedia-extract.
      • 2023-07-24 20529, 2023

      • yvanzo
        Also reviewed a bunch of MBS PRs, plus some support.
      • 2023-07-24 20535, 2023

      • yvanzo
        Fin. Go zas!
      • 2023-07-24 20539, 2023

      • zas
        Hey
      • 2023-07-24 20507, 2023

      • zas
        I came back from a train trip on Wednesday, so the week was rather short
      • 2023-07-24 20533, 2023

      • zas
        We (with atj) upgraded docker on all servers
      • 2023-07-24 20548, 2023

      • zas
        (more on this after reviews)
      • 2023-07-24 20511, 2023

      • zas
        I also reviewed PRs for Picard, 2.9 should be released this week
      • 2023-07-24 20508, 2023

      • zas
        plus usual supervision, minor fixes, services restart, that's it for me. lucifer?
      • 2023-07-24 20514, 2023

      • lucifer
        hi all!
      • 2023-07-24 20525, 2023

      • reosarevok
        Left on my list for today: akshaaatt, atj, aerozol, riksucks, kellnerd, ShivamAwasthi, vscode, pixelpenguin, arsh
      • 2023-07-24 20555, 2023

      • lucifer
        last week, i worked on finishing up the tags dataset and generation of weekly playlists.
      • 2023-07-24 20507, 2023

      • lucifer
        some PR reviews and gsoc discussions.