0:54 AM
Sciencentistguy4 joined the channel
2023-08-07 21916, 2023
0:57 AM
Sciencentistguy has quit
2023-08-07 21916, 2023
0:57 AM
Sciencentistguy4 is now known as Sciencentistguy
2023-08-07 21957, 2023
1:54 AM
kepstin joined the channel
2023-08-07 21903, 2023
2:05 AM
BrainzGit
2023-08-07 21908, 2023
2:31 AM
BrainzGit
2023-08-07 21938, 2023
2:39 AM
kepstin has quit
2023-08-07 21959, 2023
2:39 AM
kepstin joined the channel
2023-08-07 21939, 2023
3:05 AM
BrainzGit
2023-08-07 21947, 2023
3:37 AM
kepstin has quit
2023-08-07 21900, 2023
3:38 AM
kepstin joined the channel
2023-08-07 21921, 2023
4:05 AM
d4rk-ph0enix joined the channel
2023-08-07 21950, 2023
4:07 AM
d4rkie__ joined the channel
2023-08-07 21952, 2023
4:07 AM
d4rkie_ has quit
2023-08-07 21944, 2023
4:09 AM
d4rk-ph0enix has quit
2023-08-07 21929, 2023
7:55 AM
Sophist-UK has quit
2023-08-07 21946, 2023
8:27 AM
reosarevok
Katana spam. That's a first.
2023-08-07 21912, 2023
9:01 AM
reosarevok
2023-08-07 21955, 2023
9:03 AM
reosarevok
(if it needs some changes I'd be more than happy to make them)
2023-08-07 21942, 2023
9:11 AM
yvanzo
O’Moin
2023-08-07 21932, 2023
9:12 AM
reosarevok
Welcome back! :) How was the break?
2023-08-07 21943, 2023
9:35 AM
yvanzo
reosarevok: Is there a release planned for today?
2023-08-07 21916, 2023
9:36 AM
reosarevok
Not really planned, but given the last beta update, we might as well :)
2023-08-07 21930, 2023
9:36 AM
reosarevok
Been in beta for over a week after all
2023-08-07 21935, 2023
9:36 AM
reosarevok
So I can release
2023-08-07 21939, 2023
9:36 AM
reosarevok
Thanks for the reminder :D
2023-08-07 21945, 2023
9:36 AM
reosarevok
(or did you want to?)
2023-08-07 21921, 2023
10:05 AM
lucifer
jasje: i'll look into the feed issues later today and try to fix those
2023-08-07 21919, 2023
10:14 AM
BrainzGit
2023-08-07 21910, 2023
10:15 AM
yvanzo
reosarevok: From looking at server logs ^ it seems worth deploying to beta asap so it's in today’s release.
2023-08-07 21914, 2023
10:23 AM
yvanzo
aerozol: In your mailed-in review last week (now in the forum), the linked ticket doesn’t seem to match what you were talking about.
2023-08-07 21947, 2023
10:26 AM
monkey
mayhem: Can I use test.LB?
2023-08-07 21953, 2023
10:26 AM
mayhem
sure.
2023-08-07 21911, 2023
10:27 AM
monkey
👍
2023-08-07 21940, 2023
10:29 AM
aerozol
yvanzo: oh, thanks! I've linked to the correct ticket in the forum thread now
2023-08-07 21922, 2023
10:31 AM
yvanzo
reosarevok: Actually this PR might not be so urgent, it’s just 2M of logs in a week, I found some other warnings with many more occurrences.
2023-08-07 21939, 2023
10:31 AM
reosarevok
yvanzo: seems entirely safe anyway, so we might as well
2023-08-07 21946, 2023
10:31 AM
reosarevok
Are any of the other ones equally trivial?
2023-08-07 21956, 2023
10:31 AM
yvanzo
not so trivial
2023-08-07 21942, 2023
10:32 AM
reosarevok
Then we can merge this one for now and then look at others for the next release maybe? :)
2023-08-07 21917, 2023
10:33 AM
yvanzo
I’m okay with not having another beta cycle (even for a short time) just for this patch.
2023-08-07 21949, 2023
10:33 AM
reosarevok
Does that mean "let's merge and put beta out"? :)
2023-08-07 21920, 2023
10:34 AM
yvanzo
No, rather “let's skip it and go straight for a prod release” :)
2023-08-07 21933, 2023
10:34 AM
yvanzo
(without this patch)
2023-08-07 21901, 2023
10:35 AM
reosarevok
Oh
2023-08-07 21907, 2023
10:35 AM
reosarevok
Ok, works too :)
2023-08-07 21913, 2023
10:35 AM
yvanzo
It isn’t as impacting as I thought when I opened this PR.
2023-08-07 21920, 2023
10:35 AM
reosarevok
Then move it to point to master and let's merge it after prod is out
2023-08-07 21925, 2023
10:35 AM
yvanzo
👍
2023-08-07 21937, 2023
10:36 AM
yvanzo
updated, thanks
2023-08-07 21903, 2023
10:45 AM
mayhem
jasje: I still get occastional now listening misses:
2023-08-07 21906, 2023
10:45 AM
mayhem
2023-08-07 21923, 2023
10:45 AM
mayhem
the listen for massive attack came in, but its now listening never did.
2023-08-07 21926, 2023
10:58 AM
mayhem
lucifer, monkey : can I use beta for a bit or do we have something running there?
2023-08-07 21940, 2023
10:58 AM
lucifer
fine by me
2023-08-07 21953, 2023
10:58 AM
monkey
Yep, it's free
2023-08-07 21959, 2023
10:58 AM
mayhem
thx
2023-08-07 21959, 2023
10:58 AM
monkey
Currently running the latest release
2023-08-07 21935, 2023
11:07 AM
yvanzo
reosarevok: For example there are some more warnings about uninitialized value (of `$self->release->gid`) in `lib/MusicBrainz/Server/Entity/Artwork.pm` and muting this warning would be trivial but I’m not sure why this isn’t initialized to start with: Is it expected or a bug?
2023-08-07 21910, 2023
11:42 AM
BrainzGit
2023-08-07 21906, 2023
12:03 PM
jasje
mayhem: the code suffers from internal concurrency issues. I got the gist of how to solve those but wanna wrap up feed asap
2023-08-07 21922, 2023
12:03 PM
jasje
also some changes are already in the pipeline
2023-08-07 21930, 2023
12:03 PM
jasje
should be out soon
2023-08-07 21936, 2023
12:53 PM
monotux has quit
2023-08-07 21952, 2023
13:17 PM
monotux joined the channel
2023-08-07 21935, 2023
13:46 PM
reosarevok
yvanzo: now back
2023-08-07 21951, 2023
13:46 PM
reosarevok
yvanzo: does it say in what part of Artwork.pm?
2023-08-07 21907, 2023
13:47 PM
reosarevok
For filename we return undef already if $self->release->gid does not exist
2023-08-07 21943, 2023
13:47 PM
reosarevok
Which suggests that's a possibility - maybe we should do the same for _ia_url_prefix and _url_prefix, or for stuff calling them
2023-08-07 21941, 2023
13:48 PM
yvanzo
lines 76 & 96
2023-08-07 21956, 2023
13:48 PM
reosarevok
Yeah, so the prefixes
2023-08-07 21922, 2023
13:49 PM
reosarevok
Well the prefixes are useless without a gid anyway
2023-08-07 21938, 2023
13:49 PM
reosarevok
So we should probably return undef in that case :)
2023-08-07 21952, 2023
13:49 PM
yvanzo
But why would that happen?
2023-08-07 21916, 2023
13:50 PM
reosarevok
If trying to load it for an edit when the release has been deleted is a guess
2023-08-07 21922, 2023
13:50 PM
reosarevok
Do you have context from the warnings?
2023-08-07 21919, 2023
13:57 PM
Maxr1998 joined the channel
2023-08-07 21928, 2023
13:58 PM
Maxr1998_ has quit
2023-08-07 21906, 2023
14:10 PM
BrainzGit
2023-08-07 21915, 2023
14:13 PM
reosarevok
Starting prod release
2023-08-07 21900, 2023
14:14 PM
monkey
Ooooh, PR number 3000 !
2023-08-07 21948, 2023
14:39 PM
reosarevok
yvanzo: anything new for docker btw?
2023-08-07 21959, 2023
14:39 PM
reosarevok
Or basic version upgrade only?
2023-08-07 21957, 2023
14:40 PM
yvanzo
Nothing from the logs at least.
2023-08-07 21908, 2023
14:41 PM
reosarevok
Ok
2023-08-07 21931, 2023
15:02 PM
bitmap
reosarevok: sorry for the delay, I'll take a look
2023-08-07 21950, 2023
15:19 PM
reosarevok
Releasing prod
2023-08-07 21915, 2023
15:51 PM
reosarevok
yvanzo: can you check the blog and docker drafts?
2023-08-07 21940, 2023
15:54 PM
yvanzo
yep
2023-08-07 21944, 2023
16:01 PM
BrainzGit
2023-08-07 21953, 2023
16:03 PM
yvanzo
reosarevok: the blog draft has probably not been saved: lots of TBD
2023-08-07 21904, 2023
16:04 PM
reosarevok
Oh no
2023-08-07 21939, 2023
16:04 PM
reosarevok
ffs, yes, it lost it all
2023-08-07 21944, 2023
16:04 PM
reosarevok
Ok, redoing
2023-08-07 21958, 2023
16:04 PM
yvanzo
I can test the musicbrainz-docker release in the meantime if you didn't already.
2023-08-07 21926, 2023
16:06 PM
reosarevok
I did not
2023-08-07 21906, 2023
16:07 PM
yvanzo
Ok, on it.
2023-08-07 21933, 2023
16:16 PM
reosarevok
yvanzo: try now (the blog)
2023-08-07 21940, 2023
16:19 PM
siinamon has quit
2023-08-07 21905, 2023
16:20 PM
siinamon joined the channel
2023-08-07 21924, 2023
16:21 PM
BrainzGit
2023-08-07 21904, 2023
16:22 PM
monkey
2023-08-07 21909, 2023
16:26 PM
reosarevok
1sweet
2023-08-07 21916, 2023
16:26 PM
reosarevok
2sweet even :D
2023-08-07 21931, 2023
16:30 PM
yvanzo
reosarevok: Made small changes
2023-08-07 21953, 2023
16:30 PM
reosarevok
Checking
2023-08-07 21955, 2023
16:30 PM
yvanzo
reosarevok, bitmap: Good news: Zero user account related template is left :)
2023-08-07 21937, 2023
16:31 PM
siinamon has quit
2023-08-07 21959, 2023
16:31 PM
siinamon joined the channel
2023-08-07 21919, 2023
16:32 PM
yvanzo
reosarevok: Tested building the Docker image and displaying the homepage.
2023-08-07 21905, 2023
16:33 PM
reosarevok
yvanzo: changes seem good, ok to publish then?
2023-08-07 21925, 2023
16:34 PM
yvanzo
reosarevok: all set :)
2023-08-07 21926, 2023
16:35 PM
BrainzGit
2023-08-07 21943, 2023
16:35 PM
reosarevok
Ok, I think all is ready
2023-08-07 21947, 2023
16:35 PM
siinamon has quit
2023-08-07 21912, 2023
16:36 PM
siinamon joined the channel
2023-08-07 21916, 2023
16:36 PM
BrainzGit
2023-08-07 21944, 2023
16:36 PM
BrainzGit
2023-08-07 21927, 2023
16:39 PM
Lotheric has quit
2023-08-07 21955, 2023
16:41 PM
yvanzo
aerozol: reminder: you can delete your branch after the pull request has been merged ^
2023-08-07 21906, 2023
16:45 PM
monkey is a bit late for the starts of the meeting. Please don't pick me first!
2023-08-07 21912, 2023
17:00 PM
reosarevok
<BANG>
2023-08-07 21937, 2023
17:01 PM
reosarevok
It's Monday again! And here we are again around the CampfireBrainz
2023-08-07 21925, 2023
17:02 PM
reosarevok
We have two mailed in reviews today:
2023-08-07 21942, 2023
17:02 PM
reosarevok
aerozol is back from holidays and says:
2023-08-07 21943, 2023
17:02 PM
reosarevok
'''
2023-08-07 21952, 2023
17:02 PM
reosarevok
Nothing much to report. Drafted LLM/AI guidelines for CB, put in a pull request to change to the stupid new 'X' favicon.
2023-08-07 21955, 2023
17:02 PM
reosarevok
Oh, quite cool, the unofficial Discord organized a group editing session on chat/video on Wednesday, which five or six editors popped into, which was fun. Organized by UltimateRiff. If it carries on successfully we could look into similar social events, or try open that one to a wider/non-discord audience.
2023-08-07 21957, 2023
17:02 PM
reosarevok
Aerozol out.
2023-08-07 21958, 2023
17:02 PM
reosarevok
'''
2023-08-07 21915, 2023
17:03 PM
reosarevok
That'll be "the site previously known as Twitter"'s favicon, fwiw
2023-08-07 21945, 2023
17:03 PM
reosarevok
Also, zas is apparently on a river somewhere, and says:
2023-08-07 21956, 2023
17:03 PM
reosarevok
'''
2023-08-07 21959, 2023
17:03 PM
reosarevok
This week, I worked on and reviewed Picard PRs, mainly to address PICARD-2697 and PICARD-1815 (along rdswift).
2023-08-07 21901, 2023
17:04 PM
BrainzBot
2023-08-07 21901, 2023
17:04 PM
BrainzBot
2023-08-07 21903, 2023
17:04 PM
reosarevok
I also fixed an issue with telegraf and buddy (office/backup server), caused by an upgrade together with the lack of proper configuration on Ansible side.
2023-08-07 21905, 2023
17:04 PM
reosarevok
Apart from that, I unblocked few users, and did usual supervision, upgrades, minor fixes. fin.
2023-08-07 21907, 2023
17:04 PM
reosarevok
'''
2023-08-07 21951, 2023
17:04 PM
reosarevok
ApeKattQuest also mentioned being away but with nothing to report, although I do know we do have some new instrument images :)
2023-08-07 21958, 2023
17:04 PM
reosarevok
My list for today: reosarevok, bitmap, mayhem, yvanzo, monkey, lucifer, akshaaatt, atj, kellnerd, Pratha-Fish, ShivamAwasthi, vscode, pixelpenguin, arsh, jasje
2023-08-07 21908, 2023
17:05 PM
reosarevok
If anyone else wants in (or if riksucks wants back) do let me know!
2023-08-07 21912, 2023
17:05 PM
yvanzo
reosarevok: nothing to report either
2023-08-07 21922, 2023
17:05 PM
reosarevok
yvanzo: ok, who should go next? :D
2023-08-07 21929, 2023
17:05 PM
yvanzo
you!
2023-08-07 21934, 2023
17:05 PM
reosarevok
!recall oh no.
2023-08-07 21934, 2023
17:05 PM
BrainzBot
2023-08-07 21937, 2023
17:05 PM
Pratha-Fish peaks into the chat
2023-08-07 21947, 2023
17:05 PM
yvanzo
Or Pratha-Fish? :)
2023-08-07 21951, 2023
17:05 PM
reosarevok
Hi! Last week I spent a lot of time looking at open style tickets