#metabrainz

/

      • Sciencentistguy4 joined the channel
      • 2023-08-07 21916, 2023

      • Sciencentistguy has quit
      • 2023-08-07 21916, 2023

      • Sciencentistguy4 is now known as Sciencentistguy
      • 2023-08-07 21957, 2023

      • kepstin joined the channel
      • 2023-08-07 21903, 2023

      • BrainzGit
        [musicbrainz-server] 14Aerozol opened pull request #2997 (03master…master): MBS-12617, MBS-12618, MBS-12627 - adding new entity icons https://github.com/metabrainz/musicbrainz-server/…
      • 2023-08-07 21908, 2023

      • BrainzGit
        [musicbrainz-server] 14Aerozol opened pull request #2998 (03master…new-icons): MBS-13215 - Update the Twitter/X logo https://github.com/metabrainz/musicbrainz-server/…
      • 2023-08-07 21938, 2023

      • kepstin has quit
      • 2023-08-07 21959, 2023

      • kepstin joined the channel
      • 2023-08-07 21939, 2023

      • BrainzGit
        [critiquebrainz] 14Aerozol opened pull request #488 (03master…guidelines): CB-458 - Link to ‘how to write a review’ guide https://github.com/metabrainz/critiquebrainz/pull…
      • 2023-08-07 21947, 2023

      • kepstin has quit
      • 2023-08-07 21900, 2023

      • kepstin joined the channel
      • 2023-08-07 21921, 2023

      • d4rk-ph0enix joined the channel
      • 2023-08-07 21950, 2023

      • d4rkie__ joined the channel
      • 2023-08-07 21952, 2023

      • d4rkie_ has quit
      • 2023-08-07 21944, 2023

      • d4rk-ph0enix has quit
      • 2023-08-07 21929, 2023

      • Sophist-UK has quit
      • 2023-08-07 21946, 2023

      • reosarevok
        Katana spam. That's a first.
      • 2023-08-07 21912, 2023

      • reosarevok
        bitmap: any chance you can take a look at https://github.com/metabrainz/musicbrainz-server/… ? It's been waiting forever and people keep asking about it :)
      • 2023-08-07 21955, 2023

      • reosarevok
        (if it needs some changes I'd be more than happy to make them)
      • 2023-08-07 21942, 2023

      • yvanzo
        O’Moin
      • 2023-08-07 21932, 2023

      • reosarevok
        Welcome back! :) How was the break?
      • 2023-08-07 21943, 2023

      • yvanzo
        reosarevok: Is there a release planned for today?
      • 2023-08-07 21916, 2023

      • reosarevok
        Not really planned, but given the last beta update, we might as well :)
      • 2023-08-07 21930, 2023

      • reosarevok
        Been in beta for over a week after all
      • 2023-08-07 21935, 2023

      • reosarevok
        So I can release
      • 2023-08-07 21939, 2023

      • reosarevok
        Thanks for the reminder :D
      • 2023-08-07 21945, 2023

      • reosarevok
        (or did you want to?)
      • 2023-08-07 21921, 2023

      • lucifer
        jasje: i'll look into the feed issues later today and try to fix those
      • 2023-08-07 21919, 2023

      • BrainzGit
        [musicbrainz-server] 14yvanzo opened pull request #2999 (03beta…fix-warning-after-MBS-12376): Fix warning after pull request #2554 https://github.com/metabrainz/musicbrainz-server/…
      • 2023-08-07 21910, 2023

      • yvanzo
        reosarevok: From looking at server logs ^ it seems worth deploying to beta asap so it's in today’s release.
      • 2023-08-07 21914, 2023

      • yvanzo
        aerozol: In your mailed-in review last week (now in the forum), the linked ticket doesn’t seem to match what you were talking about.
      • 2023-08-07 21947, 2023

      • monkey
        mayhem: Can I use test.LB?
      • 2023-08-07 21953, 2023

      • mayhem
        sure.
      • 2023-08-07 21911, 2023

      • monkey
        👍
      • 2023-08-07 21940, 2023

      • aerozol
        yvanzo: oh, thanks! I've linked to the correct ticket in the forum thread now
      • 2023-08-07 21922, 2023

      • yvanzo
        reosarevok: Actually this PR might not be so urgent, it’s just 2M of logs in a week, I found some other warnings with many more occurrences.
      • 2023-08-07 21939, 2023

      • reosarevok
        yvanzo: seems entirely safe anyway, so we might as well
      • 2023-08-07 21946, 2023

      • reosarevok
        Are any of the other ones equally trivial?
      • 2023-08-07 21956, 2023

      • yvanzo
        not so trivial
      • 2023-08-07 21942, 2023

      • reosarevok
        Then we can merge this one for now and then look at others for the next release maybe? :)
      • 2023-08-07 21917, 2023

      • yvanzo
        I’m okay with not having another beta cycle (even for a short time) just for this patch.
      • 2023-08-07 21949, 2023

      • reosarevok
        Does that mean "let's merge and put beta out"? :)
      • 2023-08-07 21920, 2023

      • yvanzo
        No, rather “let's skip it and go straight for a prod release” :)
      • 2023-08-07 21933, 2023

      • yvanzo
        (without this patch)
      • 2023-08-07 21901, 2023

      • reosarevok
        Oh
      • 2023-08-07 21907, 2023

      • reosarevok
        Ok, works too :)
      • 2023-08-07 21913, 2023

      • yvanzo
        It isn’t as impacting as I thought when I opened this PR.
      • 2023-08-07 21920, 2023

      • reosarevok
        Then move it to point to master and let's merge it after prod is out
      • 2023-08-07 21925, 2023

      • yvanzo
        👍
      • 2023-08-07 21937, 2023

      • yvanzo
        updated, thanks
      • 2023-08-07 21903, 2023

      • mayhem
        jasje: I still get occastional now listening misses:
      • 2023-08-07 21906, 2023

      • mayhem
      • 2023-08-07 21923, 2023

      • mayhem
        the listen for massive attack came in, but its now listening never did.
      • 2023-08-07 21926, 2023

      • mayhem
        lucifer, monkey : can I use beta for a bit or do we have something running there?
      • 2023-08-07 21940, 2023

      • lucifer
        fine by me
      • 2023-08-07 21953, 2023

      • monkey
        Yep, it's free
      • 2023-08-07 21959, 2023

      • mayhem
        thx
      • 2023-08-07 21959, 2023

      • monkey
        Currently running the latest release
      • 2023-08-07 21935, 2023

      • yvanzo
        reosarevok: For example there are some more warnings about uninitialized value (of `$self->release->gid`) in `lib/MusicBrainz/Server/Entity/Artwork.pm` and muting this warning would be trivial but I’m not sure why this isn’t initialized to start with: Is it expected or a bug?
      • 2023-08-07 21910, 2023

      • BrainzGit
        [bookbrainz-site] 14MonkeyDo closed pull request #827 (03master…BB-491): BB-491: Show more information in merge queue https://github.com/metabrainz/bookbrainz-site/pul…
      • 2023-08-07 21906, 2023

      • jasje
        mayhem: the code suffers from internal concurrency issues. I got the gist of how to solve those but wanna wrap up feed asap
      • 2023-08-07 21922, 2023

      • jasje
        also some changes are already in the pipeline
      • 2023-08-07 21930, 2023

      • jasje
        should be out soon
      • 2023-08-07 21936, 2023

      • monotux has quit
      • 2023-08-07 21952, 2023

      • monotux joined the channel
      • 2023-08-07 21935, 2023

      • reosarevok
        yvanzo: now back
      • 2023-08-07 21951, 2023

      • reosarevok
        yvanzo: does it say in what part of Artwork.pm?
      • 2023-08-07 21907, 2023

      • reosarevok
        For filename we return undef already if $self->release->gid does not exist
      • 2023-08-07 21943, 2023

      • reosarevok
        Which suggests that's a possibility - maybe we should do the same for _ia_url_prefix and _url_prefix, or for stuff calling them
      • 2023-08-07 21941, 2023

      • yvanzo
        lines 76 & 96
      • 2023-08-07 21956, 2023

      • reosarevok
        Yeah, so the prefixes
      • 2023-08-07 21922, 2023

      • reosarevok
        Well the prefixes are useless without a gid anyway
      • 2023-08-07 21938, 2023

      • reosarevok
        So we should probably return undef in that case :)
      • 2023-08-07 21952, 2023

      • yvanzo
        But why would that happen?
      • 2023-08-07 21916, 2023

      • reosarevok
        If trying to load it for an edit when the release has been deleted is a guess
      • 2023-08-07 21922, 2023

      • reosarevok
        Do you have context from the warnings?
      • 2023-08-07 21919, 2023

      • Maxr1998 joined the channel
      • 2023-08-07 21928, 2023

      • Maxr1998_ has quit
      • 2023-08-07 21906, 2023

      • BrainzGit
        [musicbrainz-server] 14reosarevok opened pull request #3000 (03master…MBS-13216): MBS-13216: Add VNDB to other databases whitelist and handle links https://github.com/metabrainz/musicbrainz-server/…
      • 2023-08-07 21915, 2023

      • reosarevok
        Starting prod release
      • 2023-08-07 21900, 2023

      • monkey
        Ooooh, PR number 3000 !
      • 2023-08-07 21948, 2023

      • reosarevok
        yvanzo: anything new for docker btw?
      • 2023-08-07 21959, 2023

      • reosarevok
        Or basic version upgrade only?
      • 2023-08-07 21957, 2023

      • yvanzo
        Nothing from the logs at least.
      • 2023-08-07 21908, 2023

      • reosarevok
        Ok
      • 2023-08-07 21931, 2023

      • bitmap
        reosarevok: sorry for the delay, I'll take a look
      • 2023-08-07 21950, 2023

      • reosarevok
        Releasing prod
      • 2023-08-07 21915, 2023

      • reosarevok
        yvanzo: can you check the blog and docker drafts?
      • 2023-08-07 21940, 2023

      • yvanzo
        yep
      • 2023-08-07 21944, 2023

      • BrainzGit
        [musicbrainz-server] 14yvanzo opened pull request #3001 (03master…mbs-13217): MBS-13217: Fix displaying cover art edits https://github.com/metabrainz/musicbrainz-server/…
      • 2023-08-07 21953, 2023

      • yvanzo
        reosarevok: the blog draft has probably not been saved: lots of TBD
      • 2023-08-07 21904, 2023

      • reosarevok
        Oh no
      • 2023-08-07 21939, 2023

      • reosarevok
        ffs, yes, it lost it all
      • 2023-08-07 21944, 2023

      • reosarevok
        Ok, redoing
      • 2023-08-07 21958, 2023

      • yvanzo
        I can test the musicbrainz-docker release in the meantime if you didn't already.
      • 2023-08-07 21926, 2023

      • reosarevok
        I did not
      • 2023-08-07 21906, 2023

      • yvanzo
        Ok, on it.
      • 2023-08-07 21933, 2023

      • reosarevok
        yvanzo: try now (the blog)
      • 2023-08-07 21940, 2023

      • siinamon has quit
      • 2023-08-07 21905, 2023

      • siinamon joined the channel
      • 2023-08-07 21924, 2023

      • BrainzGit
        [listenbrainz-server] 14MonkeyDo opened pull request #2534 (03master…refactor-user-feedback): Refactor user feedback logic https://github.com/metabrainz/listenbrainz-server…
      • 2023-08-07 21904, 2023

      • monkey
      • 2023-08-07 21909, 2023

      • reosarevok
        1sweet
      • 2023-08-07 21916, 2023

      • reosarevok
        2sweet even :D
      • 2023-08-07 21931, 2023

      • yvanzo
        reosarevok: Made small changes
      • 2023-08-07 21953, 2023

      • reosarevok
        Checking
      • 2023-08-07 21955, 2023

      • yvanzo
        reosarevok, bitmap: Good news: Zero user account related template is left :)
      • 2023-08-07 21937, 2023

      • siinamon has quit
      • 2023-08-07 21959, 2023

      • siinamon joined the channel
      • 2023-08-07 21919, 2023

      • yvanzo
        reosarevok: Tested building the Docker image and displaying the homepage.
      • 2023-08-07 21905, 2023

      • reosarevok
        yvanzo: changes seem good, ok to publish then?
      • 2023-08-07 21925, 2023

      • yvanzo
        reosarevok: all set :)
      • 2023-08-07 21926, 2023

      • BrainzGit
        [musicbrainz-docker] release 03v-2023-08-07 has been published by 14reosarevok: https://github.com/metabrainz/musicbrainz-docker/…
      • 2023-08-07 21943, 2023

      • reosarevok
        Ok, I think all is ready
      • 2023-08-07 21947, 2023

      • siinamon has quit
      • 2023-08-07 21912, 2023

      • siinamon joined the channel
      • 2023-08-07 21916, 2023

      • BrainzGit
        [musicbrainz-server] 14yvanzo merged pull request #2999 (03master…fix-warning-after-MBS-12376): Fix warning after pull request #2554 https://github.com/metabrainz/musicbrainz-server/…
      • 2023-08-07 21944, 2023

      • BrainzGit
        [musicbrainz-server] 14reosarevok merged pull request #2998 (03master…new-icons): MBS-13215 - Update the Twitter/X logo https://github.com/metabrainz/musicbrainz-server/…
      • 2023-08-07 21927, 2023

      • Lotheric has quit
      • 2023-08-07 21955, 2023

      • yvanzo
        aerozol: reminder: you can delete your branch after the pull request has been merged ^
      • 2023-08-07 21906, 2023

      • monkey is a bit late for the starts of the meeting. Please don't pick me first!
      • 2023-08-07 21912, 2023

      • reosarevok
        <BANG>
      • 2023-08-07 21937, 2023

      • reosarevok
        It's Monday again! And here we are again around the CampfireBrainz
      • 2023-08-07 21925, 2023

      • reosarevok
        We have two mailed in reviews today:
      • 2023-08-07 21942, 2023

      • reosarevok
        aerozol is back from holidays and says:
      • 2023-08-07 21943, 2023

      • reosarevok
        '''
      • 2023-08-07 21952, 2023

      • reosarevok
        Nothing much to report. Drafted LLM/AI guidelines for CB, put in a pull request to change to the stupid new 'X' favicon.
      • 2023-08-07 21955, 2023

      • reosarevok
        Oh, quite cool, the unofficial Discord organized a group editing session on chat/video on Wednesday, which five or six editors popped into, which was fun. Organized by UltimateRiff. If it carries on successfully we could look into similar social events, or try open that one to a wider/non-discord audience.
      • 2023-08-07 21957, 2023

      • reosarevok
        Aerozol out.
      • 2023-08-07 21958, 2023

      • reosarevok
        '''
      • 2023-08-07 21915, 2023

      • reosarevok
        That'll be "the site previously known as Twitter"'s favicon, fwiw
      • 2023-08-07 21945, 2023

      • reosarevok
        Also, zas is apparently on a river somewhere, and says:
      • 2023-08-07 21956, 2023

      • reosarevok
        '''
      • 2023-08-07 21959, 2023

      • reosarevok
        This week, I worked on and reviewed Picard PRs, mainly to address PICARD-2697 and PICARD-1815 (along rdswift).
      • 2023-08-07 21901, 2023

      • BrainzBot
        PICARD-2697: Picard doesn't restore all defaults https://tickets.metabrainz.org/browse/PICARD-2697
      • 2023-08-07 21901, 2023

      • BrainzBot
        PICARD-1815: Notification on plugin updates available https://tickets.metabrainz.org/browse/PICARD-1815
      • 2023-08-07 21903, 2023

      • reosarevok
        I also fixed an issue with telegraf and buddy (office/backup server), caused by an upgrade together with the lack of proper configuration on Ansible side.
      • 2023-08-07 21905, 2023

      • reosarevok
        Apart from that, I unblocked few users, and did usual supervision, upgrades, minor fixes. fin.
      • 2023-08-07 21907, 2023

      • reosarevok
        '''
      • 2023-08-07 21951, 2023

      • reosarevok
        ApeKattQuest also mentioned being away but with nothing to report, although I do know we do have some new instrument images :)
      • 2023-08-07 21958, 2023

      • reosarevok
        My list for today: reosarevok, bitmap, mayhem, yvanzo, monkey, lucifer, akshaaatt, atj, kellnerd, Pratha-Fish, ShivamAwasthi, vscode, pixelpenguin, arsh, jasje
      • 2023-08-07 21908, 2023

      • reosarevok
        If anyone else wants in (or if riksucks wants back) do let me know!
      • 2023-08-07 21912, 2023

      • yvanzo
        reosarevok: nothing to report either
      • 2023-08-07 21922, 2023

      • reosarevok
        yvanzo: ok, who should go next? :D
      • 2023-08-07 21929, 2023

      • yvanzo
        you!
      • 2023-08-07 21934, 2023

      • reosarevok
        !recall oh no.
      • 2023-08-07 21934, 2023

      • BrainzBot
      • 2023-08-07 21937, 2023

      • Pratha-Fish peaks into the chat
      • 2023-08-07 21947, 2023

      • yvanzo
        Or Pratha-Fish? :)
      • 2023-08-07 21951, 2023

      • reosarevok
        Hi! Last week I spent a lot of time looking at open style tickets