[listenbrainz-android] 14dependabot[bot] opened pull request #210 (03main…dependabot/gradle/io.sentry.android.gradle-3.12.0): Bump io.sentry.android.gradle from 3.11.1 to 3.12.0 https://github.com/metabrainz/listenbrainz-androi…
Hah! I was just wondering why the love/hate buttons looked broken !
2023-08-09 22138, 2023
mayhem
sorry.
2023-08-09 22148, 2023
mayhem
I doubt aerozol needs to look long.
2023-08-09 22132, 2023
monkey
No worries, I didn't need it anymore really
2023-08-09 22126, 2023
monkey
I'm going to quickly fix the mode selection thing on the LB radio PR
2023-08-09 22152, 2023
mayhem
sweet. I'll address the PR feedback after that.
2023-08-09 22122, 2023
aerozol
Thanks mayhem!
2023-08-09 22122, 2023
mayhem
monkey: Lb radio PR feedback improvements pushed.
2023-08-09 22110, 2023
monkey
mayhem: great. Just pushed some small changes myself, using a typescript enum to define the mode values a bit more safely (and generate the select options programmatically from the enum values)
2023-08-09 22130, 2023
monkey
+ default value for the select to fix the reported issue
2023-08-09 22142, 2023
aerozol
I hope the smoke detectors in the office are working
2023-08-09 22149, 2023
aerozol
Because you guys are on FIRE
2023-08-09 22100, 2023
monkey
huhu
2023-08-09 22127, 2023
monkey
I'm sure we would have found out by now if there was a working smoke detector at the office.
Ooooh, I love it. I wouldn’t mind having pages like that open to the public if we have a ‘beta’ section in explore (I think it’s in the initial mockups even)
2023-08-09 22144, 2023
mayhem
Oh, I like that idea. how do we do that? do you have that mocked up>
2023-08-09 22145, 2023
mayhem
?
2023-08-09 22145, 2023
aerozol
Doesn’t look bad at all, already
2023-08-09 22151, 2023
aerozol
Let me dig
2023-08-09 22107, 2023
mayhem
monkey was overseeing it. could perhaps use more whitespace and larger buttons.
2023-08-09 22141, 2023
monkey
It's mockep up. IIRC it was just a separator of sorts with a bit of a title
if not complicated to you, wanna take a stab at it?
2023-08-09 22127, 2023
mayhem
aerozol: what image would we use for LB radio?
2023-08-09 22104, 2023
aerozol
I was just about to offer to make a picture! I’ll get onto it. Since it’s beta maybe some kind of a wireframe look
2023-08-09 22117, 2023
mayhem
sweet.
2023-08-09 22152, 2023
aerozol
<h3>Beta</h3>
2023-08-09 22154, 2023
aerozol
yw
2023-08-09 22120, 2023
mayhem
heh.
2023-08-09 22124, 2023
monkey
aerozol: I'm thinking we can drop the dropup/dropdown indicator to the left of "Beta" and the associated feature for now. Revisit it when we have more items in there when it would make sense to want to hide them
2023-08-09 22137, 2023
aerozol
monkey: agreed
2023-08-09 22143, 2023
monkey
I'll do that bit while you work on the image :)
2023-08-09 22106, 2023
mayhem
♥️
2023-08-09 22121, 2023
mayhem goes to deal with our insurance policy
2023-08-09 22125, 2023
monkey
I'll keep playing with my CSS toys and you go adulting? Works for me !
monkey: I just realized that I was showing the playlist desc as a title. and we were not showing title at all. Adding one more state and one div. done soon.
yes, makes total sense. there is too much horizontal whitespace now.
2023-08-09 22101, 2023
monkey
building the image for beta now
2023-08-09 22143, 2023
mayhem
$no_filter_recent -- to not filter recent listens, which otherwise is the default.
2023-08-09 22103, 2023
mayhem
monkey: ^^ not great, but I am struggling to do better.
2023-08-09 22112, 2023
mayhem
and $no_filter_hate
2023-08-09 22153, 2023
monkey
How about something along the lines of `$filter:recent:false` ?
2023-08-09 22121, 2023
mayhem
yeah, better.
2023-08-09 22130, 2023
mayhem
$filter:hate:false
2023-08-09 22147, 2023
mayhem
$filter:country:spain
2023-08-09 22157, 2023
mayhem
yeah, lets do that.
2023-08-09 22142, 2023
monkey
There's a subtlety in there which is that the filters can be either inclusive or exclusive: `$filter:country:spain` keeps only `spain`-ish recordings, while `$filter:hate:true` keeps only non-hated recordings
2023-08-09 22156, 2023
monkey
But eh. I don't think we need to dig too deep.
2023-08-09 22120, 2023
mayhem
agreed. not sure that level of consistency serves anyone.
2023-08-09 22102, 2023
monkey
How to make queries take longer for no reason: `$filter:country:worldwide`
2023-08-09 22131, 2023
monkey
Actually, that would probably keep only ~ the digital releases, no?
2023-08-09 22149, 2023
monkey
Aaaaaanyway.
2023-08-09 22120, 2023
mayhem
I wonder how long until someone requests '$filter:country:worldwide - $filter:country:(north america)'
2023-08-09 22144, 2023
monkey
Yeah, I was just thinking that.
2023-08-09 22112, 2023
monkey
$filterout:country:russia
2023-08-09 22126, 2023
mayhem
yeah.
2023-08-09 22137, 2023
mayhem
ok, three leavels gives us enough control. let me implement that.
2023-08-09 22109, 2023
monkey
There's some ambiguity with stuff like `$filter:country:spain`: how is the recording associated with the country? Are we talking album release country? Artist birthplace? Artist country of residence?
2023-08-09 22109, 2023
monkey
A problem for another day
2023-08-09 22146, 2023
mayhem
thats not a parsing problem. that a data problem for lucifer. :)
