[listenbrainz-android] 14dependabot[bot] opened pull request #210 (03main…dependabot/gradle/io.sentry.android.gradle-3.12.0): Bump io.sentry.android.gradle from 3.11.1 to 3.12.0 https://github.com/metabrainz/listenbrainz-andr...
Hah! I was just wondering why the love/hate buttons looked broken !
mayhem
sorry.
I doubt aerozol needs to look long.
monkey
No worries, I didn't need it anymore really
I'm going to quickly fix the mode selection thing on the LB radio PR
mayhem
sweet. I'll address the PR feedback after that.
aerozol
Thanks mayhem!
mayhem
monkey: Lb radio PR feedback improvements pushed.
monkey
mayhem: great. Just pushed some small changes myself, using a typescript enum to define the mode values a bit more safely (and generate the select options programmatically from the enum values)
+ default value for the select to fix the reported issue
aerozol
I hope the smoke detectors in the office are working
Because you guys are on FIRE
monkey
huhu
I'm sure we would have found out by now if there was a working smoke detector at the office.
Ooooh, I love it. I wouldn’t mind having pages like that open to the public if we have a ‘beta’ section in explore (I think it’s in the initial mockups even)
mayhem
Oh, I like that idea. how do we do that? do you have that mocked up>
?
aerozol
Doesn’t look bad at all, already
Let me dig
mayhem
monkey was overseeing it. could perhaps use more whitespace and larger buttons.
monkey
It's mockep up. IIRC it was just a separator of sorts with a bit of a title
if not complicated to you, wanna take a stab at it?
aerozol: what image would we use for LB radio?
aerozol
I was just about to offer to make a picture! I’ll get onto it. Since it’s beta maybe some kind of a wireframe look
mayhem
sweet.
aerozol
<h3>Beta</h3>
yw
mayhem
heh.
monkey
aerozol: I'm thinking we can drop the dropup/dropdown indicator to the left of "Beta" and the associated feature for now. Revisit it when we have more items in there when it would make sense to want to hide them
aerozol
monkey: agreed
monkey
I'll do that bit while you work on the image :)
mayhem
♥️
mayhem goes to deal with our insurance policy
monkey
I'll keep playing with my CSS toys and you go adulting? Works for me !
monkey: I just realized that I was showing the playlist desc as a title. and we were not showing title at all. Adding one more state and one div. done soon.
yes, makes total sense. there is too much horizontal whitespace now.
monkey
building the image for beta now
mayhem
$no_filter_recent -- to not filter recent listens, which otherwise is the default.
monkey: ^^ not great, but I am struggling to do better.
and $no_filter_hate
monkey
How about something along the lines of `$filter:recent:false` ?
mayhem
yeah, better.
$filter:hate:false
$filter:country:spain
yeah, lets do that.
monkey
There's a subtlety in there which is that the filters can be either inclusive or exclusive: `$filter:country:spain` keeps only `spain`-ish recordings, while `$filter:hate:true` keeps only non-hated recordings
But eh. I don't think we need to dig too deep.
mayhem
agreed. not sure that level of consistency serves anyone.
monkey
How to make queries take longer for no reason: `$filter:country:worldwide`
Actually, that would probably keep only ~ the digital releases, no?
Aaaaaanyway.
mayhem
I wonder how long until someone requests '$filter:country:worldwide - $filter:country:(north america)'
monkey
Yeah, I was just thinking that.
$filterout:country:russia
mayhem
yeah.
ok, three leavels gives us enough control. let me implement that.
monkey
There's some ambiguity with stuff like `$filter:country:spain`: how is the recording associated with the country? Are we talking album release country? Artist birthplace? Artist country of residence?
A problem for another day
mayhem
thats not a parsing problem. that a data problem for lucifer. :)